When using several certification together, there was an issue
when we tried to modify the quantity of an orderline.
The "this" context was lost and we were unable to call the function
anymore.

In order to fix that, we bind the context when calling the function.

closes odoo/odoo#74162

Related: odoo/enterprise#19811
Signed-off-by: William André (wan) <wan@odoo.com>

Before this commit, MOs were not filtered based on selected BoM.

With this commit, We are filtering MOs to selected based on BoM.

Fixes #70215

closes odoo/odoo#74674

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

Currently, while trying to share the survey with 'one page per section'
layout, if the survey has only questions and no sections, a warning is
raised that says 'You cannot send an invitation for a survey that has
no questions'. It is misleading because in this case, what you do not
have is atleast one section with question(s).

This commit fixes the warning message for 'one page per section' type
of survey and gives clear idea to the user about what is missing.

TaskID-2611996

closes odoo/odoo#74510

X-original-commit: a48550a8
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Signed-off-by: awa-odoo <awa-odoo@users.noreply.github.com>

Suppose such a SO line:
- Unit Price: 541.26
- Qty: 38
- Discount: 2%

The line amount is computed thanks to application of the discount on the
price, then the multiplication of the result with the quantity. The
rounding eventually happens after these steps:
https://github.com/odoo/odoo/blob/254b2a0840d3e817cc6062c483b5213c10088af5/addons/sale/models/sale.py#L1013-L1024
https://github.com/odoo/odoo/blob/b76e9ef658bde0178fa1660b6ad27b880e91632a/addons/account/models/account.py#L1138


Therefore, in the above case, we have:
```
Total = round(541.26 * 0.98 * 38)
      = round(530.4348 * 38)
      = round(20156.5224)
      = 20156.5224
```

However, when confirming the SO and setting the delivered quantity, the
Untaxed Amount To Invoice is computed using the unit price with both the
discount and the rounding already applied:
```
Total = round(541.26 * 0.98) * 38
      = round(530.4348) * 38
      = 530.43 * 38
      = 20156.34
```
As a result, the amount is not the same than the first one, this is
incorrect.

OPW-2525975

closes odoo/odoo#74646

X-original-commit: a3ba7c5f
Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>

closes odoo/odoo#74618

Signed-off-by: William André (wan) <wan@odoo.com>

Steps to reproduce:

  - Install purchase and accounting apps
  - Set the database to a language that is not English
  - Create a purchase order
  - Remove purchase representative from PO (otherwise, no issue)
  - Action -> Create Vendor Bill
  - From the vendor bill, print invoice

Issue:

  The pdf is in English (country names, date labels, etc...)

Cause:

  If invoice type is `in_invoice` or `in_refund`, it will use the
  `invoice_user_id` language (object.invoice_user_id.sudo().lang).
  In the above case, there is no invoice_user_id on invoice.

Solution:

  While preparing invoice values, set invoice_user_id to
  self.env.user.id if not user_id on PO.

opw-2510134

closes odoo/odoo#74341

Signed-off-by: bon-odoo <nboulif@users.noreply.github.com>

Step to reproduce

- Purchase >> reporting
- Filters > choose a Vendor
- Filters > Effective Date Last Year
- Toggle Studio
- Add Pivot View and close
- Measures > On-Time Delivery Rate

Got a traceback, the read_group method didn't take into account
the aggregate functions.

opw-2600230

closes odoo/odoo#74118

Signed-off-by: Anh Thao PHAM <kitan191@users.noreply.github.com>

    The field is supossed to point to account.bank.statement but is pointing to account.move
    Now is working because the field is only used in button_open_statements method where the model is defined,
    but if you want to use this field to report it will get information from account.move with that ID or an error if the move do not exist

closes odoo/odoo#73642

Signed-off-by: William André (wan) <wan@odoo.com>

Issue: When preparing a work order for a product on which the bill of material had a line with duration set to 00:00, the work order expected_duration for that line was set to 60:00

Steps to reproduce :
 1) Enable Work Orders under Manufacturing Settings
 2) Create a Bill of Material for a new product "test"
 3) On the BoM Form, go to Operation, add a line
 4) Set an operation, a work center and for Duration Computation, set it to manually and 00:00 minutes and save
 5) Create a manufacturing order for that product, check the Work Orders tab of the Manufacturing order form, the duration is set to 60:00

Why is that a bug:
 Since we can set a duration of 00:00 in the Bill of Material, it means the work order can take 00:00 as expected duration, however it was set to 60.0 since 00:00 is evaluated as 0, which is considered `False` in a conditional assignment that was catching the case where the variable was `None`, which it can never be since it is a fields.Float that will be 0 in case of a `None` or `False`

opw-2603928

closes odoo/odoo#74626

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

When a purchase order is generated via the scheduler with a reordering rule, the gst_treatment is not retrieved

opw-2540090

closes odoo/odoo#74569

Signed-off-by: Achraf <abz-odoo@users.noreply.github.com>

Steps to reproduce:

  ! Chrome version >= 91.0.4472.114 (no issue on <= 90.0.4430.51)
  - Install Accounting module
  - Go to Customer Invoices and create a new one
  - Add a customer with a very long name, add product then save
  - Go back to list view
  - Ensure that the column "Customer" does not display the full
    customer name
  - Try to resize "Customer" column

Issue:

  All columns are resized.

Cause:

  Since Chrome 91.0.4472.114, `max-width` on column cause
  an issue with table.
  The issue is triggerd when a <th> width size
  exceeds the maxWidth size.
  Also, when resizing, the maxWidth of current collumn stays the same.

Solution:

  On resizing, update also, maxWidth with new width value.

opw-2585307

closes odoo/odoo#74591

X-original-commit: cc6c61d4
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: bon-odoo <nboulif@users.noreply.github.com>

Steps to reproduce the bug:
- Change the language in odoo preferences (e.g: FR)
- Go to pos app > Configuration > Point of sale
- Choose anyone > Edit > Enable “Global discounts” option
- Open new session with the same pos
- Click on “Discount”
- The button "cancel", “confirm” and "ok" are not translated

opw-2615309

closes odoo/odoo#74614

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

At the moment, it is possible to archive a journal for which some
entries are still waiting to be auto-posted in the future.
Add a constrains to avoid make sure that it is no longer possible,
since it shouldn't.

Task id #2585454

closes odoo/odoo#74536

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

The non readonly computed field with inverse on the company was raising
an access error for users that have accounting rights but not admin
rights to write on the company.

opw-2446242

closes odoo/odoo#74534

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Due to the following PR: https://github.com/odoo/odoo/pull/70092


the download icon wasn't present in the document viewer.
We had to do this to avoid crash in mobile apps (Android and iOS).

But even if there are multiple other ways to download file, some
of our users are used to use pdf js download button that was previously
hidden.

So in this commit, we restore it on desktop as we can now correctly
handle the error on Android tablets and hide this button on iOS tablets.

Note that pdfjs button is not needed on mobile as we doesnt' have
attachements preview on small screens. Another button is available
when you open the file.

Steps to reproduce:
- Go to Accounting
- Customer Invoices
- After printing it once, the download icon wasn't present in pdfjs preview

closes odoo/odoo#74606

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>

Ticket: 2578903

In the overview menu, the time of a calendar event was not formatted according to the user preferences. This PR fixes that.

closes odoo/odoo#73569

Signed-off-by: Arnaud Joset <arj-odoo@users.noreply.github.com>

Issue: When making a return for a transfer, the precision_rounding was taken from the UoM of the product given in the transfer, but the quantity was taken in the UoM of the product defined on its form

Steps to reproduce :
 1) Create a UoM "Hundreds", rounding precision 1 (has to be different than "Dozen"), Bigger than the reference Unit of Measure, ratio 100
 2) Create a test product with "Dozen" as UoM
 3) Inventory > Operations > Transfers > Create
 4) Add test product, Demand=2, Unit of Measure=Hundreds
 5) Validate
 6) Create a Return for that transfer
 7) Quantity is set to 17 Dozen instead of 16.67

 Why is that a bug:
 The quantity to return is `quantity = stock_move.product_qty` (in UoM of the product form) but the rounding is made with rounding precision `stock_move.product_uom.rounding` (in UoM of the line of the transfer) which can be different in case of manual transfer creation for example

opw-2543304

closes odoo/odoo#74576

X-original-commit: 4f962846
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

The template to render location and picking barcodes was not optimized
to print lots of barcode. This could lead to extremely long documents
with a few barcodes to print.

closes odoo/odoo#72538

Opw: 2564764
Related: odoo/enterprise#19168
Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

Steps to reproduce:

  - Install Expenses module
  - Go to Expenses (list view)
  - Select multiple expense in `To Submit` stage
  - Click on Action -> Create report

Issue:

  Report is directly in Submitted stage.

Cause:

  Submitting report on creation.

Solution:

  Do not sumbit report on creation.

opw-2586184

closes odoo/odoo#74547

Signed-off-by: bon-odoo <nboulif@users.noreply.github.com>

Hook to be overridden when we need to add some field to product and use it in variable factor from price rules.

closes odoo/odoo#74539

X-original-commit: 6ec768d0
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

Currently, the default invoice origin for the sale action_view_invoice
is being passed as a list by using the mapped method. This causes that,
when an invoice is created from this view, the origin is set to ['SOXXXXX'].

With the fix, we properly pass the origin as a string so the origin is set
as SOXXXXX, which should be the expected. Notice also that the context is
only passed when dealing with a single SO.

closes odoo/odoo#74538

X-original-commit: c45ad549
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Steps to reproduce:

  - Install "Point of sale" and "l10n_fr" modules
  - Switch to french Company
  - Go to user preference and change language to "French"
  - Create a new POS with french certification installed
  - Run the POS
  - Try to change quantity of a product

Issue:

  Impossible to encode a quantity with decimals (add a line at 0 instead)

Cause:

  The popup return value is a string.
  The value is used before coverting it to float.

Solution:

  Parse quantity value like a float before using it.

opw-2608707

closes odoo/odoo#74303

Signed-off-by: bon-odoo <nboulif@users.noreply.github.com>

Even in the interface, when we empty a string, the value
in the database is '' and not NULL.  So, we should let the user
put the field to '' again.  (as it is not required)

This will require un update, but otherwise, it just relaxes
the constraint.

closes odoo/odoo#74537

Signed-off-by: William André (wan) <wan@odoo.com>

Step to reproduce:

- Change the language to any language other than english
- Go to PoS and open a session
- Click on "Client" and select a client
- The button 'Select Customer', 'Deselect Customer' and 'Change Customer'
  are not translated.

Cause of the issue

- The term 'Change Customer' was missing in pos.pot
- Translation was not enabled in JS file

This fix complete the one "done" in commit 00e177b

opw-2596436

closes odoo/odoo#74532

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

The goal is to take into consideration that in case the TAX ID
is issued by the same member state as the vendor's,
then VAT charge is not reversed.

The VAT ID must be foreign as from the vendor's point of view.

closes odoo/odoo#73831

Task: 2596204
Signed-off-by: William André (wan) <wan@odoo.com>

Group by products margins computations to reduce SQL queries sent
to postgre server, improving overall performances.

Replace setattr for loop by product.write to reduce the number
of write queries.

closes odoo/odoo#74134

X-original-commit: 0bb81774
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
Signed-off-by: William André (wan) <wan@odoo.com>

When reconciling bank statement using manual operation (write-off), the tags generated on the journal entry have their sign reversed between manual creation (using the account and tax field in the reconciliation widget) and automated creation using a button (created from reconciliation model).

This pr adds the inversion of the tags in the case of the use of a reconciliation model

opw-2540090

closes odoo/odoo#74427

Related: odoo/enterprise#19979
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

This commit adds an option to disable horizontal scrolling in the
smoothScrollOnDrag feature options and use it when dragging and
dropping a snippet into the editor to prevent the wrapwrap from
scrolling horizontally when an element overflow the page (e.g. an
animated element).

task-2215118

closes odoo/odoo#74069

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

1. Activate 'Deliver Content by Email' in the Sales>Configuration>Settings
2. Create a mail template with Product Template for 'Applies to' and
a dynamic field (e.g. ${object.company_id.name}) in the body
3. Add this mail template on a [DEMO] product 'Automatic Email at
Invoice' field, in the Sales tab
4. Create an invoice with [DEMO], confirm it.
5. If the ID of the invoice does not exist as a product.product, you get a
traceback

The reason is that the model used for the template rendering is the
one specified on the template, but the res_id given to the composer
is the one from the invoice.

opw-2476169

closes odoo/odoo#68339

X-original-commit: 9c7d7f01
Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com>

Edit a website menu label with:

    & < > " ` '

This is what is shown after saving:

   &amp; &lt; &gt; &quot; &#x60; &#x27;

This is happening since ea4dbcd2: characters &, <, >, ", `, and ' are
now always escaped. Before that commit, only < and > where escaped and
only when an image was inside the label.

With this change, we unescape the label when we are editing a menu.

opw-2609413

closes odoo/odoo#74429

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

When combining a reordering rule, the 3-steps manufacture and
by-products option, the picking from the post-production to the stock
will not contain the residual products produced by the MO (by-products)

To reproduce the error:
1. In Settings, enable:
    - By-Products
    - Multi-Step Routes
2. Inventory > Configuration > Warehouse Management > Warehouses, edit
company's warehouse:
    - Manufacture: 3 steps
3. Create 3 products P_compo, P_finished, P_secondary
    - P_compo is consumable
    - P_finished and P_secondary are storable
    - Routes of P_finished: Manufacture
4. Create a reordering rule for P_finished:
    - Min = Max = 1
5. Create a BoM:
    - Product: P_finished
    - Type: Manufacture
    - Components: 1 x P_compo
    - By-products: 1 x P_secondary
6. Inventory > Operations > Run Scheduler
7. Open the generated MO
8. Check Availability, Produce, Mark as Done
    - Note that in the "Produce" wizard, we mention that one P_secondary
is also produced
    - Also note that in "Finished Products" tab, there are 1 x
P_finished and 1 x P_secondary
9. Open the Transfers > Select the one from Post-Prod to Stock

Error: P_secondary is missing

When creating the byproducts move
https://github.com/odoo/odoo/blob/ad62f877c174d56b90ec516cf24494d751383db9/addons/mrp/models/mrp_production.py#L587
the field `move_dest_ids` is present (is the move created after
evaluating the RR)
https://github.com/odoo/odoo/blob/ad62f877c174d56b90ec516cf24494d751383db9/addons/mrp/models/mrp_production.py#L580
so it is used, but this will cause the `_push_apply` to skip the
evaluation of the move
https://github.com/odoo/odoo/blob/f0eaa756c4947e2a595359959b34b14bfda81a07/addons/stock/models/stock_move.py#L678-L679


and `_assign_picking` will not run, as it normally do when creating the
manufacture

OPW-2581762

closes odoo/odoo#74479

X-original-commit: e2b2fe5f
Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

Usecase:
- Product A 10 units in stock
- Do a planned transfer of 7 units to customer
- Reserve
- Do an rpc or execute code to call copy on the stock.move.line

It will result with 2 sml that have 14 units reserve and 7 units
reserved on stock.quant

It's the same result if you create twice the stock.move.line without
updating the stock.quant at the same time. However in stable we
try to only use _update_reserved_quantity on stock.move or some
override in create/write method for 'done' stock.move.line in unlock
cases.

So we never use the copy in stable and define the basic behavior as
'we don't copy the reservation' could prevent some usecase where
the update on the stock.quant is forgotten after.

closes odoo/odoo#74475

X-original-commit: e5041ee1
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

Task ID: 2613031

closes odoo/odoo#74305

Signed-off-by: Josse Colpaert <jco@openerp.com>

*: web, website_livechat, website_sale_comparison

Before this commit, bottom fixed elements (e.g. the livechat button)
hid the buttons to go to the next step in website sale when these
buttons are located at the bottom of the page, on some screen sizes.

After this commit,

- A bottom fixed element is hidden if this element hides a button at
the bottom of the page.

- Bottom fixed elements are hidden if a modal is open
to prevent it to hide buttons or any important part of the modal.

task-2501400

closes odoo/odoo#69296

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

By Sunat regulations from 08/01/2021 two new types of identity documents
will be accepted: Temporary Residence Permit and Safe Passage.

Legal ref:

Website: https://cpe.sunat.gob.pe/node/88
Document with Catalog Update No. 8:
https://cpe.sunat.gob.pe/sites/default/files/inline-files/AjustesValidacionesCPEv20210727%20%28ultimo%29.xlsx



Replaces #74342

closes odoo/odoo#74403

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Because there are some restrictions with the HTTPS and trusted certificates
We forward, in some cases,  the POS and the POS RESTAURANT to a specific url.

HTTPS: /pos/ui
HTTP: /pos/web

To allow rules for webserver

We make this change when we check 'Direct Devices'
And when we use a 'Order Printer' type 'epson_epos'

closes odoo/odoo#74363

Tasks: 2597021
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

Steps to Reproduce Bug:

- Create PO
- Remove default Currency
- Add a Line

Bug:
```ValueError: Expected singleton: res.currency()```

With this Commit, we are using default currency to round amount.

closes odoo/odoo#74208

X-original-commit: d9ff2e8e
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

When generating coupons for customers, the email was sent twice due to the values
given on the email_values that is generating a TO (email_to) value (plus using the one given on the template
(recipients_ids))

opw:2574046

closes odoo/odoo#74406

X-original-commit: c99b6ab0a79cf605d78aaa2f9bb00faa192f7fcc
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Co-authored-by: simongoffin <sig@odoo.com>

closes odoo/odoo#74438

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>