Incorporate Alejandro Mellado (alejandromellado) as Vauxoo's contributor.

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#131196

X-original-commit: 73ee076b
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

closes odoo/odoo#131186

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Part-of: odoo/odoo#131186

In Switzerland, since 16.0, the QR Bill page always has the external_layout template, whatever template the user chose for his invoices. 

This was a "lesser evil" choice to allow the user to print QR-bills : BootStrap5 and wkhtmltopdf were not compatible, causing a display bug and generating incorrect QR Bills before this.  

See for an example the task-3037921.

Returned to the original behaviour, namely :

- Display the invoice header on the QR Bill ;
- Adapt said header display to the layout chosen by the user ;
- Fixed Din5008 display. 

task-3241502

closes odoo/odoo#130478

Signed-off-by: Laurent Smet (las) <las@odoo.com>

When updating taxes, creation of taxes of type 'group' does not
work correctly if either a child or the parent itself has been deleted.
Indeed the creation of _generate_tax() method suppose that both the parent
and the child needs to be created in the same batch while we can have
databases where one of those already exists and will go in the 'update'
and not 'creation' part of the script.

closes odoo/odoo#131215

X-original-commit: 8372a02f
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
Signed-off-by: Jinane Maksoud (maji) <maji@odoo.com>

Currently, the form view of the account.account has a fixed width for the
account name field which can lead to longer account names to not be readable
as they are not displayed entirely.

This PR allows users to resize the width of the name field to the length
they want without letting them exceed the maximum of the page. This makes
the field keep a shorter width for shorter account names while being able
to be longer for accounts which name is longer.

The account name field has now a width which can be adapted by the user so
he can read both sort and long account names.

task-3441547

closes odoo/odoo#130165

Signed-off-by: Laurent Smet (las) <las@odoo.com>

PURPOSE
=======

Starting from 16.0 we introduced some reports to log skills history, skills evolution.

It means that the skill model is linked to another model, preventing us to delete it.

Usually, we use the message "link to x, archive it instead", but archiving a skill will only be possible from v17 (new task)

So, we need to be able to delete a skill on v16

closes odoo/odoo#131158

Taskid: 3456843
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

An error occurs when the user attempts to delete the 'database.secret' record,
either by following these steps:
- Enable developer mode.
- Go to Settings > Technical > System Parameters.
- Select the 'database.secret' record and attempt to delete it.

Or when the user tries to update the key for the 'database.secret' record using
the following steps:
- Open the 'database.secret' record.
- Update the value of the key field.
-  Save the record.
- The server will stop running and not be accessible.

Error: ValueError: CSRF protection requires a configured database secret

sentry - 4291267997

closes odoo/odoo#131017

X-original-commit: 6b8c2481
Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>

Reproduction:
1. Install Note, create a new note
2. Start the Inspector, edit the placeholder <p> element in the
description
3. Replace the element as `<p style="color: rgb(32, 31, 30); font-family
: &quot;Segoe UI&quot;, &quot;Segoe UI Web (West European)&quot;, &quot;
Segoe UI&quot;, -apple-system, BlinkMacSystemFont, Roboto, &quot;Helveti
ca Neue&quot;, sans-serif; font-size: 15px;">dsfhislahflidsahisa</p>`
4. The saving icon appears, click it but it will always be there, e.g.
always dirty

Fix: instead of comparing the raw value of the prop value and editing
value, we parse them and compare after the parsing

opw-3341605
task-3434080

closes odoo/odoo#129173

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

closes odoo/odoo#131063

X-original-commit: 0a1d7d71
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Similar to what was done [here](https://github.com/odoo/odoo/commit/5d0111d079601c07c62717575cb22ead15c585d0

) when the credit limit feature
was introduced, a `sudo()` is also necessary in
`_load_records_create()`.

This method is called when importing contacts from a CSV file.
So the access to the commercial fields is done when synching
fields from the commercial entity to its contact and should
not block the import.

Fixes #126567

closes odoo/odoo#129587

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

Steps to reproduce this bug:

1- On a Bank type journal, set true the "Use electronic and deferred
checks" field
2- Do a new vendor payment with Bank journal and Manual payment method
3- Corresponding journal entry shows "Check False delivered"

closes odoo/odoo#129283

Signed-off-by: Habib Ayob (ayh) <ayh@odoo.com>

Bug to reproduce
----------------

- Log in as admin
- Go to the frontend page of a course
- Click on 'Add Section'
- Fill the form (name input)
- Press 'Enter' or click on save button x times
x sections with the same name will be created

Specifications
--------------

Prevent the 'Add section' form being submitted multiple times in a row.

task-3432418

closes odoo/odoo#131050

X-original-commit: a91a60b4
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>

Before this commit
Previously, there was a bug that caused an error when a zip code containing
any character was entered.

After this commit
This bug has been fixed now.

task id- 3441139

closes odoo/odoo#130886

X-original-commit: 8deeabdb
Signed-off-by: de Wouters de Bouchout Jean-Benoît (jbw) <jbw@odoo.com>
Signed-off-by: Zeel Patel (zepa) <zepa@odoo.com>

The 'onsite' payment provider shouldn't be shown to the user
if the cart/order only contains services (or if there are no onsite carriers).
The logic was there but the filtering didn't correctly update the values.

opw-3437107

closes odoo/odoo#131083

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

If a given template T has two attributes lines:
* standard attribute (instant creation): one value
* no_variant attribute (never create a variant for it): one value

It will have one automatically generated variant V, which will be automatically
selected on the sale order line if you chose the template T.

If optional product(s) are added on the template T, the configurator will
open to choose the optional products.

But in this situation, the main product was shown as "Option not available"
on the configurator.  This is wrong since there is the valid variant V that we
can use.

This is caused by a behavioral change in 16.0, we saved the variant V directly
on the sale order line, before opening the configurator.  Previously, the values
were applied to the line after the configurator was closed (if there were optional
products).

As the values were applied before the call to `_openProductConfigurator`,
the product.template.attribute.value of V (the standard one, not the no_variant)
is given to the wizard opening, disabling the automatic fallback that previously
gave the two expected ptav's (the standard AND the no_variant one), leading to
an incomplete combination, which was considered invalid.

This commit restores the previous behavior, by setting the product on the line
only if there is no optional products. If there are, everything will be
correctly managed when the configurator is closed.

opw-3355216

closes odoo/odoo#131067

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

When trying to delete a bank statement,
if there is no move with the same id,
we get an error "Record doesn't exist or
has been deleted".

The reason is we call the
account_move.check_move_sequence_chain()
method wih the id of the statement.
We avoid using account_move_service if
the model is not account_move as it make
no sense to call an account_move method
from a bank statement record.

opw-3425826

closes odoo/odoo#130914

Signed-off-by: Habib Ayob (ayh) <ayh@odoo.com>

Before this PR, when moving the snippet's position, `d-none` gets added
which should not.

With this PR, removing the `this.$target.addClass('d-none')` from
`cleanForSave` method as it was adding `d-none` unnecessarily while
moving snippets position. The fact is snippet will be hidden if the
current user has no access to the mail group. So that case will be
handled using controllers route `/group/is_member`, if this return email
of the user, snippet is visible else the user has no access to the mail
group so we remove the snippet.

task-3107451

closes odoo/odoo#130948

X-original-commit: 2a46580e
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>

When applied, this commit will restore the edition of a block when
the content has a height > 10000px.

Steps to reproduce:
1) Go to a runbot
2) Go to a blog or on the homepage
3) Enter edit mode
4) Add some text in one bloc with a total height above 10000px
5) The text will be uneditable on the top

Current behavior:
If the text is too important in one block (more than 10000px),
the text will be uneditable

Expected behavior:
The text should be accessible and editable even if the block
has too much content

opw-3393570

closes odoo/odoo#130946

X-original-commit: 493d31a9
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Versions:
---------
- 14.0+

Steps to reproduce:
-------------------
1. Settings -> Configure document layout
2. Select the Boxed layout
3. Go to Invoices -> create a new invoice and register payment
4. Click on Preview
5. The field “Amount due” is in the wrong color and barely visible

Issue:
------
The field “Amount due” is in the wrong color and barely visible in
invoice boxed layout

Cause:
------
The issue is happening because we have `<strong>`  before the text
”Amount due” and it changes the font color to gray because of the CSS definitions

Solution:
---------
We need to make the text bold in a different way, to do it we can use the bootstrap
class font-weight-bold, this way we keep it bold and do not break the colors

OPW-3374092

closes odoo/odoo#130457

X-original-commit: 0c4badb0323414eb267be877109829ac8071dabe
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Signed-off-by: Matheus Leal Viana (malv) <malv@odoo.com>

The current neutralization implementation for ir_mail_server deactivates
existing servers. This can still result in mails being sent if an SMTP
server was specified on the command-line. To prevent that from happening
a dummy SMTP server is defined that doesn't resolve to anything.

I've opted to use the "invalid" domain for this purpose:
https://www.rfc-editor.org/rfc/rfc6761#section-6.4

 .

closes odoo/odoo#130376

Signed-off-by: Merel Geens <mege@odoo.com>

Steps to reproduce:
- Activate "Analytic Accounting" in Accounting settings
- Go to Accounting / Configuration / Analytic Accounting / Analytic Accounts
- Create an Analytic Account with a very long name (i.e. +100 chars)
- Go to Expenses
- Create an Expense with the created Analytic Account in the Analytic field
The display of the labels in the form view should break because the badge is too
long and is taking all the available width.

Solution:
Limit the width of tag badges in "analytic_distribution" widget as it is done in "many2many_tags" widget.
https://github.com/odoo/odoo/blob/2f47df6663b65c4f6b6ec61f956c453e97563462/addons/web/static/src/views/fields/many2many_tags/many2many_tags_field.scss#L47-L49



opw-3322688

closes odoo/odoo#130235

Signed-off-by: John Laterre (jol) <jol@odoo.com>

When the payment method was detached from the customer, trying to pay with the
linked payment token would end up with a crash because Stripe failed to send us
the payment intent, as it could not create it. In that case, a logger error
occurs on the server which creates noise in the sentry.

Error: The creation of the payment intent failed.
Stripe gave us the following info about the problem:
'Your card has insufficient funds.'

The logger is updated to use the 'warning' level instead of the 'error' level.
This change reflects a less severe logging level for cases where the creation
of payment intent fails.

sentry-4363481906

closes odoo/odoo#130802

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

before this commit, on reading data with default dict data
type is showing error to end user, without returning the
requested data.

for eg, if a read operation is triggered on model sale.order
it wont return the requested data, instead traceback is
shown in response.

in sale.order model the tax_totals field is a computed
field, with data as format default dict which was
causing the issue.

after this commit, without any traceback the requested
data will be returned to the user.

closes odoo/odoo#129830

Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>

Steps to reproduce:
- Go to Contacts and open any contact (e.g. Contact X)
- Check its configured Account Receivable (e.g. 121000 Account Receivable)
- Configure that account and set a default Sales tax on it (e.g. Tax 15%)
- Create an invoice with Contact X as customer
- Add an invoice line for any amount (e.g. $100) and any tax
- Swith to "Journal Items" tab and display "Taxes" column
A line (with 121000 Account Receivable) has been created automatically to balance the invoice line.
This line has a tax (i.e. Tax 15%): the default one configured on the account.
There should not be a tax for a receivable account.
Another issue is that the tax is set on the aml but not tax line has been created.
- Go back to "Invoice Lines" tab
- Remove the tax on the invoice line
- Save
In "Journal Items" tab, the tax line has been created from the aml with the receivable account.
- Go back to "Invoice Lines" tab
- Add a tax on the invoice line again
- Save
- Remove the tax on the invoice line
- Save
In "Journal Items" tab, there are now 2 tax lines from the aml with the receivable account.
By repeating the previous steps, new tax lines can be created infinitely.

Solution:
To prevent the issue, the default taxes shouldn't be populated on the aml when the account
is a receivable (or payable) one and when the move type is an "invoice" type one.
As "display_type" field of "account.move.line" is set to "payment_term" when the account is
a receivable or a payable one and when "is_invoice" is True on the move, no tax will be set
in "_compute_tax_ids" computed method when "display_type" is "payment_term".

opw-3345953

closes odoo/odoo#130677

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

Release notes:
https://github.com/odoo/owl/releases



Commits:
[FIX] compiler: fix xmlns attribute not being set correctly in firefox
[FIX] compiler: fix t-call at root of template causing crashes
[REF] compiler: minor cleanup
[FIX] devtools: fix inspected path

closes odoo/odoo#131018

Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

Denmark is comprised in the EAS list but is not currently supported in
Odoo. This commit makes UBL Bis 3 available for Danish companies.

The schemeId "0184" corresponds to the "DIGSTORG" and is mandatory for
Danish Suppliers (see: rule DK-R-014,
https://docs.peppol.eu/poacc/billing/3.0/rules/ubl-peppol/DK-R-014/

).

issue-130519

closes odoo/odoo#130605

X-original-commit: e4e2a28c
Signed-off-by: Laurent Smet (las) <las@odoo.com>
Signed-off-by: Julien Van Roy (juvr) <juvr@odoo.com>

closes odoo/odoo#130644

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

closes odoo/odoo#130665

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

If the `_toRollback` property of the editor is assigned on its own line, it is
easier to identify which assignation caused/prevented a rollback when
debugging.

closes odoo/odoo#130830

X-original-commit: 263dcbaf
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

To reproduce
============
- Activate wave transfers in settings
- In Inventory, have more than 80 delivery orders to process
- select all and try to add to new wave
- Try to select all

Select all button doesn't work

Problem
=======
in the dialog, the ListController is representing only the body so it
will only listens to the events coming from the body, while the "select all"
button is rendred in the footer.

Solution
========
bind the event listner when rendering the buttons.

opw-3420368

closes odoo/odoo#130770

X-original-commit: 30ec83e8
Signed-off-by: Luca Vitali (luvi) <luvi@odoo.com>
Signed-off-by: Abdelouahab Laaroussi (abla) <abla@odoo.com>

UseDebounce to avoid executing debounced code when the component
is unmounted. This prevents crashes.

closes odoo/odoo#130624

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

In the wishlist, if a product has no stock available, the customer can request to be notified when the product is "back in stock".

If a barcode is configured on the product, the request will fail with a "Missing record" error.

Indeed, the code relied on the tracking info (google analytics data) to find the product id.  This is a mistake since the barcode is given as `item_id` in the tracking info if set (instead of the product id).

Since the product id information is already available as node data, use this mean to get the right product id directly.

Fixes #130471

closes odoo/odoo#130473

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

The salesperson is not added to the following list of invoice that is generated from a sales order.

1. Create a sales order by assigning a salesperson.
2. Confirm the order and generate the invoice.

Current Behavior:
The salesperson is not added to the message following list of invoice.

Expected Behavior:
The salesperson should be in the message following list of invoice.

OPW-3439198

closes odoo/odoo#130286

Signed-off-by: Hamza Islam (hisl) <hisl@odoo.com>

Prerequisites -->

1) Login with a user with just Inventory/User access rights
2) Product A with purchase policy set to `on ordered quantities`
3) Product category of A set to `AVCO` costing method

Steps -->

1) Create+confirm a PO with product A and create and confirm vendor bill
2) Switch to Inventory/User user
3) Try to validate picking
4) Access right error

This occurs due to the fact that `Inventory/User` does not have access to s`tock.valuation.layer` or `account.move.line`.

Solution -->

Add sudo to the lines where accesses to SVL and invoice lines are made.

opw-3357028

closes odoo/odoo#129184

Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

Steps to reproduce:

  - Install `website_appointment` module
  - Activate a second language on main website
  - Activate debug mode
  - Go to Website -> Configuration -> Online Appointments
  - Share multiple appointment and copy the link
  - Open the link in a new tab
  - Switch to second language
  - Open editor and click on `Translate` button

Issue:

  Traceback is raised.

Cause:

  When sharing multiple appointment and opening the shared link, we are
  redirected on the page to select the right appointment and we have the
  key `filter_appointment_type_ids` (with the IDs of the appointments)
  with the value already encoded.
  e.g: `[1, 3]` => `%5B1%2C+3%5D`.

  When translating a page by redirecting to the same URL (but encoded)
  with param `edit_translations` set to 1, the URL is re-encoded and
  therefore the value of the key `filter_appointment_type_ids` is double
  'encoded' and broken/not possible to parse.
  e.g: `%5B1%2C+3%5D` => `%255B1%252C%2B3%255D`.

Solution:

  Don't re-encode the updated URL; `goToWebsite` is expecting a non
  encoded path and is in charge of the re-encoding it.

opw-3409757

closes odoo/odoo#130175

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Remove tax demo data:
- They have the same tax name which breaks a uniqueness constraint, and
cause error at migration.
- It doesn't make sense to have taxes demo data
Also remove assignation of those taxes on other aml demo data.

closes odoo/odoo#130801

X-original-commit: 8904e338
Signed-off-by: Laurent Smet (las) <las@odoo.com>
Signed-off-by: Claire Bretton (clbr) <clbr@odoo.com>

Creates a sale order, then validates the delivery.
Modify the sale order lines qty via import.
We expect a new delivery instead we have a UserError

The purpose of the userError is to avoid editing
reserved quantity directly in the picking. But in
SO/PO case it's handle by the system and quantities
are correctly reserved so the UserError should not
happens.

A better fix exists in saas-16.2 where the create
method of stock.move.line is now responsible for
reservation

opw-3336131

closes odoo/odoo#129795

X-original-commit: a53614e507b7f42d757794761959cc49ec78f435
Signed-off-by: Tiffany Chang <tic@odoo.com>

Current behavior:
When your connection is slow and you try to create a cash move, and you
click multiple times on the confirm button. The cash move is created
multiple times.
This happens because the function is not locked while the asynchronous
call is not finished. To fix this we added a custom hook to lock the
function while the asynchronous call is not finished.

Steps to reproduce:
-Open the POS
-Press F12 and in the network tab of the developper tools, set the
 connection to slow 3G
-Open the cash move popup, enter an amount and click on confirm multiple
 times.
-Close the session, and check the cash moves created.

opw-3431775

closes odoo/odoo#130735

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>