Considering the field declaration:
https://github.com/odoo/odoo/blob/fe5deb4ee4c8e07aed2f2cff6210271bfaa61476/addons/point_of_sale/models/pos_order.py#L1121


`discount` is a rate, not an amount. Therefore, suppose a discount of
10%, when opening a POS-generated SO, the discount shouldn't be "$10".

OPW-2629493

closes odoo/odoo#75907

X-original-commit: 666955cb
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>

Currently, when we try to shorten the links from content with help of
`_convert_links_text` method, it throws traceback if the body(content)
we pass is `False`(might happen when we directly pass a model field of
textual type but the field doesn't have a value yet). It's because
the `re` expects the content to be string / bytestring.

This commit fixes the issue by adding a check in this method, which
will simply return `False` if there's no body.

Task-2628586

closes odoo/odoo#75920

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

To reproduce performance problem one can use following scenario:

* Use Enterprise v13
* go to Accounting / Assets, select the chair and click on "Set To Running"
* Click "Modify Deprecation" and enter the following values:
Reason: x
Number of Deprecations: 1000 Months
Deprecation Amount: 1000
Account Asset Counterpart: 101000 Current Assets
* click on "Modify"

---

opw-2621292

closes odoo/odoo#75919

Signed-off-by: William André (wan) <wan@odoo.com>

Rounding in purchase order is 'UP' which is causing issue when doing
receipt in a different uom than the purchase. Rounding should be
'HALF-UP'

Added test in purchase and sales to ensure this issue is detected in the
 future.

closes odoo/odoo#75792

Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

This should avoid disrupting layouts.

closes odoo/odoo#75957

X-original-commit: baca6bd7
Signed-off-by: Olivier Dony (odo) <odo@openerp.com>

In the method _get_vat(), used to inform AFIP about the vat taxes of an
invoice, we were assuming that in the journal items of the invoices
there is always one line per tax group, but if the user enables the
option "Include in Analytic Cost" of the tax, then it could create more
than one line per tax so it will return an error if you try to validate
the invoice in AFIP or upload the vat book.

closes odoo/odoo#75802

Signed-off-by: Josse Colpaert <jco@openerp.com>

We fix 2 related UoM issues:

1. Fix quant inconsistency from changing the UoM of Done
   stock.move.lines

Steps to reproduce:
- Enable "Storage Locations" setting
- Create a new "Storable Product" and create a receipt for 1 unit of it
- Validate the 1 unit receieved
- Open "Detailed Operations" of the move and change the stock.move.line
  UoM to dozen.

Expected result: 13 on hand
Actual result: 1 on hand

To fix this:
- prevent users from editing the UoM after the picking is
  done (i.e. unless adding a new stock.move.line and not saving).
- update the write on done logic so stock.move.line UoM changes are
  considering and will update the quant correctly (in case of RPC or
  direct write).

2. Prevent changing UoM of Done stock.move to prevent inconsistent field
values within stock.move and confusion for users

Steps to reproduce:
- Complete a picking (incoming is easiest to see) with a new product
  (i.e. 0 qty) having 1 unit done.
- Unlock picking and add a new stock.move with 1 unit done and save.
- Edit the just added stock.move's UoM from Units to Dozen.
- Check the quantity on hand / Done qty of stock.move after leaving and
  returning to form.

Expected result: 13 On Hand
Actual Result: 2 On Hand and the "Done" qty in the picking is 0.0083
  (i.e. 1/12 of a dozen)

To fix this:
- prevent users from editing the UoM after the picking is done (unless
  adding a new stock.move and not saving)
- if a Done stock.move UoM is uodated, a UserError occurs because there
  is no straightforward way to ensure the quant is updated correctly
  since is handled within the move.line (i.e. has no visibility to its
  move's uom change => changing only UoM and not qty done will result in
  no quant update)

closes odoo/odoo#75823

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

When a sale.order containing a slide.channel registration product is confirmed
by a person that does not have rights on slide.channel (typically a salesman),
the system will throw an error.

This commit forces the addition of members by using a sudo on the
"_action_add_members" method.

We assume that when confirming a sale.order, we want to add the members and
enable their access to the course even if the person confirming the sale.order
does not have e-learning privileges.

OPW-2580128

closes odoo/odoo#75824

Signed-off-by: Achraf <abz-odoo@users.noreply.github.com>

This commit is related to 01fa18b, which introduced an issue :
the test flow needed a mrp.bom instance, which is not a dependency of
stock_dropshipping. This commit move the test to
mrp_subcontracting_dropshipping whiwh depends of mrp.

closes odoo/odoo#75845

Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

Without this, the warning isn't very actionable.

closes odoo/odoo#74428

Signed-off-by: Olivier Dony (odo) <odo@openerp.com>

*: website_slides

A function allowing to convert a SVG to a PNG has been added as an
utility function in website.utils and is used for the upload of document
in website_slides. This function add support for a specific case which
was not supported by the previous conversion function used for the
document upload in website_slides: SVG without width and height
attributes on Firefox.

Note: this should be simplified in master, the fix here is done the most
stable way possible.

Related to task-2602521

closes odoo/odoo#75741

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>

Before this commit, when loading a view containing a searchbar on a
tablet, the device's keyboard is appearing once the searchbar's field is
autofocused.

Thanks to the backport of the mobile OS detection (see PR
odoo/odoo#75455 ), we are now able to properly target mobile OS
(independent of the screen's resolution) instead of only small screens.

closes odoo/odoo#75781

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>

The `letterRendering` option from the html2canvas broke the receipt's characters of some localizations/languages such as the arabic one.

With this commit, we can simply override the `htmlToImgLetterRendering()` method from the `PosModel` when needed.

closes odoo/odoo#75777

Related: odoo/enterprise#20520
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

Bug
===
The arguments model and res_id were declared on the method but never
used. This method was supposed to be callable from the model and not
from the records with those 2 parameters.

Make this possible.

Task-2599676

closes odoo/odoo#75497

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

The `update_db_index` method is called even if the field has no index
(the check on `index` field attribute is here on purpose).

Before 13f02a60 was applied, the call of `sql.drop_index` was taking
care of the index existence if a `IF EXISTS` SQL statement, so even if
the field had no index it wasn't causing any issue.

With 13f02a60 applied, the log 'Keep unexpected index' is spam even if
the field has actually no index at all in the database.

This commit ensures to check the existence of the index before logging.

closes odoo/odoo#75748

X-original-commit: 57f078b6
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

This revision has a similar goal than the previous revision
62c5b8d9
but this times, it's a kit/phantom bom which is nested in another
kit/phantom bom, and their computation is asked in the same time.

```
2021-08-20 11:29:54,835 1689 ERROR db_22687 odoo.upgrade.stock.tests.test_on_hand_quantity: FAIL: TestOnHandQuantityUnchanged.test_check
Traceback (most recent call last):
  File "/tmp/tmpv3ujv2vr/migrations/testing.py", line 208, in test_check
    self.check(value)
  File "/tmp/tmpv3ujv2vr/migrations/stock/tests/test_on_hand_quantity.py", line 20, in check
    self.assertEqual(before_results, self.convert_check(after_results), self.message)
AssertionError: Lists differ: [[551[14585 chars] [8988, '137'], [8989, '137'], [8990, '20'], [[1793 chars]91']] != [[551[14585 chars] [8989, '137'], [8990, '20'], [8991, '126'], [[1778 chars]91']]

First differing element 1007:
[8988, '137']
[8989, '137'
```

```
SELECT b.id, b.type,  p.id as kit_product_id, b.product_tmpl_id as kit_product_tmpl_id, pt.name as
kit_product_name FROM mrp_bom b JOIN product_template pt ON pt.id = b.product_tmpl_id JOIN product_product p ON p.pr
oduct_tmpl_id = pt.id WHERE p.id = 8988;
-[ RECORD 1 ]-------+-----------------
id                  | 2208
type                | phantom
kit_product_id      | 8988
kit_product_tmpl_id | 9049
kit_product_name    | KIT Poulie AR G4
```

```
SELECT b.id, p.id as kit_product_id, b.product_tmpl_id as kit_product_tmpl_id, pt.name as kit_product_name, l.product_id as component_product_id, component_t.name as component_name FROM mrp_bom_line l JOIN mrp_bom b ON l.bom_id = b.id JOIN product_product p ON p.product_tmpl_id = b.product_tmpl_id JOIN product_template pt ON pt.id = b.product_tmpl_id JOIN product_product component ON component.id = l.product_id JOIN product_template component_t ON component_t.id = component.product_tmpl_id WHERE l.product_id = 8988;
-[ RECORD 1 ]--------+---------------------
id                   | 2213
kit_product_id       | 8761
kit_product_tmpl_id  | 8879
kit_product_name     | VEL BP KIT direction
component_product_id | 8988
component_name       | KIT Poulie AR G4
```

upg-22687

closes odoo/odoo#75654

Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>

After 0411dda6
the associated test fail in certain time frame due to the datetime check

closes odoo/odoo#75695

X-original-commit: 55fac5d3
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

[FIX] hr_holidays: Set domain correctly according to company_ids from Leave Allocations: multi company global rule

closes odoo/odoo#75397

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

This commit fixes a behavior when we send a batch of mailings
with no recipients.
When there is no recipients passed down, each mailing should
use it's own recipients and not the recipients of the first mailing.

closes odoo/odoo#75391

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Only purchaseable products are not searchable in the lines of debit notes
and credit notes if this account moves are created from their tree view with
the CREATE button. This changes make that this behavieour were also if we
create this account moves from the buttons in the invoices "ADD CREDIT NOTE"
and "ADD DEBIT NOTE".

closes odoo/odoo#75402

Task: https://www.odoo.com/my/task/2543493


Signed-off-by: Florian Gilbert <FlorianGilbert@users.noreply.github.com>

- The `move_type` property is undefined, and we miss the `in_invoice` branch condition.

Fixes #75549

closes odoo/odoo#75551

Signed-off-by: Florian Gilbert <FlorianGilbert@users.noreply.github.com>

A stock move with 0 qty in initial demand is considered as 'ready'. But
those stock moves should be excluded of the picking state computation to
not false the readiness of the picking, especially if the delivery
policy is set to 'direct'.

opw-2611018

closes odoo/odoo#75564

X-original-commit: 92e266e6
Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>
Signed-off-by: Achraf <abz-odoo@users.noreply.github.com>

When creating a new partner on the fly at lead convert time we should created
a customer-oriented partner. This is done through the use of a specific
``res_partner_search_mode`` context key allowing to handle creation of a
partner flagged as "customer".

closes odoo/odoo#74593

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

This commit backports the mobile OS detection support, and specifically
Android & iOS one to allow more specific targeting of edge cases (i.e.
disabling native date picker in the mobile iOS app only).

opw-2613810

closes odoo/odoo#75536

X-original-commit: be9effaae8fe9dee2166abe7f79a73a119b78a92
Related: odoo/enterprise#20434
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
Signed-off-by: Pierre Paridans <pparidans@users.noreply.github.com>

It was preventing custom reports from being printed

opw-2625480

closes odoo/odoo#75499

Signed-off-by: Florian Gilbert <FlorianGilbert@users.noreply.github.com>

Before this commit editing a link that was saved with the style "Outline
+ Rounded" did reset the style to as different value.

After this commit "Outline + Rounded" is not lost when re-editing the
link.

task-2629461

closes odoo/odoo#75398

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

New optional 'ttl' parameter for the authorize function. It will allow to specify how much time the credits will be reserved.

closes odoo/odoo#75442

X-original-commit: 2dfa8fd0
Signed-off-by: Florian Daloze (fda) <fda@odoo.com>
Signed-off-by: Starkhurst <Starkhurst@users.noreply.github.com>

closes odoo/odoo#75311

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

- Create a sale order that generates picking and confirm it.
- Validate the picking  when the local DATE and the GMT DATE
are different (i.e. GMT-4, between local 20:00:00 and 23:59:59)

Effective Date will be different in the SO and the picking

opw-2559308

closes odoo/odoo#75367

X-original-commit: 0411dda6
Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com>

When called with a `srt` as readgroup parameter we get a traceback.
Example:
`read_group([('partner_id', 'in', self.ids)], 'partner_id', 'partner_id')`
TB:
```
 Traceback (most recent call last):
   File "/home/odoo/src/odoo/14.0/odoo/tools/safe_eval.py", line 330, in safe_eval
    return unsafe_eval(c, globals_dict, locals_dict)
   File "", line 2, in <module>
   File "/home/odoo/src/odoo/14.0/odoo/addons/base/models/ir_attachment.py", line 420, in read_group
    if any('(' in field for field in fields + groupby):
 TypeError: can only concatenate list (not "str") to list
 ```

 Observed on the upgrade request 22627.

closes odoo/odoo#75410

X-original-commit: 8e7990dd5c069f7b0dba9f3d27f620f0fcad5441
Signed-off-by: Christophe Simonis <chs@odoo.com>

The current code uses cached data to retrieve the tax_line which is usually near the end of lines (often the second to last line).
This only works if there are fewer lines than the limit, but otherwise the line is not found and a traceback appears.

In case there are 50 invoice_line_ids for example, there will be 52 line_ids (invoice_line_ids + 2 lines including one containing the tax),
the base limit of the list subview is 40, the tax_line will not be in the cached data.

The following fix automatically loads the last page to always access the tax line.

The last page is loaded only if the tax_line is not already in the cache

opw-2566580

closes odoo/odoo#75356

Signed-off-by: Achraf <abz-odoo@users.noreply.github.com>

Step to follow

- Trigger the Print > Invoices action
- An error is displayed but the PDF is still attached

Cause of the issue

> The PDF is generated before the error

Solution

> Show an error earlier

opw-2625480

closes odoo/odoo#75329

Signed-off-by: Florian Gilbert <FlorianGilbert@users.noreply.github.com>

When an index has name 'tablename_fieldname_index', this index is
dropped if the field has index=False.  This lead to dropping a
user-created index or dropping/recreating the index when index=True is
set in a dependent module.  Some info is logged instead.

closes odoo/odoo#66700

closes odoo/odoo#75339

X-original-commit: 13f02a60
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Signed-off-by: Ivan Yelizariev // IEL <yelizariev@users.noreply.github.com>

With this commit, it will check if the tax name is given by external method and take that name if any.

For example,
vals = {'rate': 5.2, 'name': 'Odoo New Tax'}
tax_template = self.env['account.tax'].search(domain, limit=1)
new_tax = tax_template.copy(default=vals)

Current Behavior:
new_tax.name => 'Odoo New Tax (Copy)'

Instead of 'Odoo New tax'

closes odoo/odoo#75323

X-original-commit: 7ba56a2d
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

When searching for partners to fill the move, the refactoring done in
``find_partner`` for extracting the partner misses the case where no
record is found, as Form expects a recordset as entry, not an empty
list.

Note that on previous version, this error doesn't happen, as the
assignation was done only if the partner was found:

https://github.com/odoo/odoo/blob/e935cf9a/addons/account_facturx/models/account_invoice.py#L118



TT31272

closes odoo/odoo#74679

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

Before this commit when user quick create a certification,
then it will create record in survey but not with certification
equals to True. Due to which it will be excluded from domain and
we will not able to find it in survey_id in elearning.

With this commit we pass certification equals to true and scoring_type
equals to scoring_without_answers in context of survey_id. So now,
it will be not excluded in domain('certificate', '=', True) in elearning.

Task Id: 2621296

closes odoo/odoo#75295

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>