Before this commit: if one of the orders is corrupted, it will print an empty report.

The solution is to print corrupted orders in the report.

opw-2867770

closes odoo/odoo#95455

X-original-commit: 0fe806e8
Signed-off-by: Masereel Pierre <pim@odoo.com>

closes odoo/odoo#95388

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Adding a @depend decorator on product_id in the stock_move_line model can trigger a search on stock.move.line.product_id
When the number of StockMoveLine reach a million, a simple `SELECT id FROM stock_move_line WHERE product_id = XXX` can take 200ms.
When a transfer contains a few hundred StockMoveLine (ex: when dealing with serial numbers), the process of validating it will take a few minutes.
Indexing product_id will change the process time back to a few seconds.

OPW-2893131

closes odoo/odoo#95467

X-original-commit: ed4839d4
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: DavidFesquet <dafr@odoo.com>

Previously, the test runner would evaluate an expression to check if the
browser test that is about to be run is ready, but before the test is
ready, this expression may be invalid as the variables used in the
expression may not be defined yet, causing a ReferenceError to be thrown
by Chrome.

In Chrome >=102, errors that are thrown when writing code in the console
or by using Runtime.evaluate over CDP are thrown in the context of the
current tab, which means that they trip registered error handlers in
that tab. In Odoo, this means that we show error dialogs with the
traceback.

In the tour manager, when we are looking for an element  to trigger, we
only look for that element inside dialogs if there are any dialogs open
(unless the in_dialog option is false on that specific step). This means
that if an error dialog is open, most tours will fail (which is actually
what we want).

In order to avoid opening a bunch of error dialogs while waiting for the
tour to be ready, we simply wrap the ready expression in a try catch so
that it doesn't throw an error, and simply returns a undefined until the
tour is ready instead of throwing a ReferenceError.

closes odoo/odoo#95419

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

Steps to reproduce the bug:
- Create a storable product “P1”
    - Tracking: by serial number
    - BOM:
        - Component: C1

- Create a storable product “P2”
    - BOM:
        - Component: P1

- Create a MO to produce one unit of P1:
    - serial number: SN1
    - Confirm and mark as done

- Unbuild the manufactured product
- Manufacture the same product using the same serial number again

- Create a new MO to produce one unit of “P2”:
    - Component P1 → select SN1
    - Try to confirm and validate the MO

Problem:
Get User Error: The serial number “SN1” used for component “P1”
has already been consumed

We do a search in the `stock.move.line` to find if the SN has already
been used in a previous MO, but there is no specific condition to get
only those used in an MO so the unbuild order is in the same condition
and therefore the SN is considered as it has already been used
opw-2883450

closes odoo/odoo#94997

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

The default order of the picking moves generated from a purchase order should be the same order as the purchase order lines.

Steps to reproduce:
- Create a purchase order with several purchase lines.
- Change the order of the purchase lines.
- Confirm the purchase order.
  => The moves of the picking don't maintain same order as set before.

closes odoo/odoo#94354

X-original-commit: cb44c011
Signed-off-by: William Henrotin (whe) <whe@odoo.com>

When accessing the job positions page, country is detected automatically
to filter only those jobs whose country match current one + the ones
available in any country. However, when job positions have no specific
country, they're being excluded due to the usage of an old API
(expecting relational fields as `None` when they're empty), so only
positions with country are being taken into account.

This commit fixes the above by expecting the correct value (an empty
recordset) when an address is not set.

closes odoo/odoo#95394

X-original-commit: 65a28512
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Use the dutch fields 'l10n_nl_oin' and 'l10n_nl_kvk' after checking
for their presence. Otherwise, we could get traceback like:
'AttributeError: 'res.partner' object has no attribute 'l10n_nl_oin''

In addition, _render already returns a byte object, we should not encode it
again when generating the PDFA.

closes odoo/odoo#95298

Signed-off-by: Josse Colpaert <jco@odoo.com>

the amount of payment cannot be negative.
the negative amount is manage by payment_type.

closes odoo/odoo#94450

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

With this commit, users can no longer have headers that have the sidebar
template and the over the content option at the same time.

Steps to reproduce the problem:
 - Edit a website
 - Edit the navbar
 - Set Header Position to Over the Content
 - Change the navbar template to Sidebar

The navbar is not displayed properly and there is a margin on the left
that should not be there.

task-2877421

closes odoo/odoo#93054

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

This commits provides a solution to the traceback appearing when
removing a popup under certain conditions.

Steps to reproduce the bug:
- Drag and drop a popup snippet
- Drag and drop 2 or more text-image in the popup
- Delete the popup
=> traceback

task-2824253

closes odoo/odoo#92482

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Complement of this commit 7d7c53ed
because added records were missed during fw-port.

opw-2862296
opw-2877133

closes odoo/odoo#95284

Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

By trying to avoid concurrency issues while assigning the sequence [1],
we are locking too many operations even when not in the process of
assigning a new number.
* when computing `highest_name`, we don't need to lock as this is mostly
  an information on the form that can possibly change anyway while the
  form view is open (without any lock anymore)
* when computing the accounting date, we don't need to lock, the only
  information we want is the format of the sequence (yearly, monthly, no
  reset), which is not likely to change on a same journal.
* when changing the `journal_id`, it is only a helper for encoding, if
  there is a concurrency error it will be shown during the post anyways.
  Also same argument as for `highest_name`

[1] https://github.com/odoo/odoo/commit/ba6ee0b75d66d6f22a592b1b6a7c5158461bec41



closes odoo/odoo#94852

Related: odoo/enterprise#28957
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

Steps to follow:

  - Go to a crm.lead
  - Schedule an activity
  - Click on edit
  - Click on mark as done in the popup
  - Move the lead to a new stage
  -> A missing record error is displayed for the activity

Cause of the issue:

  Once the activity has been mark as done (deleted),
  The crm.lead record is not updated. The old activity is then
  passed to the server where an error is thrown

Solution:

  Update the main view after editing an activity

opw-2878984

closes odoo/odoo#94877

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Fixes to:  https://github.com/odoo/odoo/pull/94406
backported from its fw-port:  https://github.com/odoo/odoo/pull/95176



1) The test for reverse charge should only consider tags for
its country (Italy)
2) The report template shouldn't change its structure, even
if one field is not shown.
3) (enterprise) Mexican invoice template should target the note by
name and not by t-if condition

closes odoo/odoo#95244

Related: odoo/enterprise#29088
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

Before this commit: syncing with google led to sending emails to
attendees of existing future events on Odoo.

Steps to reproduce the first issue:

	- Install 'google_calendar' module
	- Integrate with Google Calendar in setting
	- Add an event to the Odoo calendar for future date
	- Add one external attendee to the event
	- Sync with Google

	Invitation emails would be sent to the attendees of the events.

Solution

	It's possible to not send emails to the attendees in api calls. So
the solution is to not send emails to the attendees for the syncing
time.

opw-2819046

closes odoo/odoo#92953

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Reproduction:
1. Install recruitment
2. Create a new job position with an extra-long title
3. Save and the title of this record is exceed the kanban card

Reason: CSS style doesn’t take account of long title

Fix:  Backported the overflow changes in V15 and added o_text_overflow
to the title of the job's kanban view, so the title does not exceed the
border of the kanban card

opw-2849601

overflow change in V15: https://github.com/odoo/odoo/commit/a0ebb4609848a65f9b6a14a94030ad3144a95038



closes odoo/odoo#95255

X-original-commit: da6b5e17
Signed-off-by: Liu Jinjiu (jili) <jili@odoo.com>

Before this commit:

Attachments are not properly supported in livechat, so there is no point in
allowing attachments to be uploaded via drag and drop.

After this commit:

Disable attachment upload via drag and drop in livechat channels.

Task-2824502

closes odoo/odoo#92124

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Upon save, uploaded images are saved because they are tagged with the
`o_modified_image_to_save` class.
Because of this is an image is uploaded then replaced by an icon, upon
save it does not make sense to obtain the actual source of the image
that is not on the page anymore.

After this commit upon replacing an image by an icon, the
`o_modified_image_to_save` is removed so that summernote does not try to
adapt its source upon save.

task-2829971

closes odoo/odoo#89010

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

When replacing an image by a pictogram, the classes of the previous media
are copied to the new icon's `<span>`. This potentially includes the
`w-100` class which prevents the alignment from behaving correctly.

This commit removes the `w-100` class if it exists - in addition to
removing the inline `width` attribute which was done before.

Steps to reproduce:
- Drop a "Media List" block
- Replace first image by pictogram.
- Align icon to the right.
=> Icon was displayed aligned to the left.

task-2829971 (was task-2729177)

Part-of: odoo/odoo#89010

Now the way of access to an action is using the method `_for_xml_id` of
the model `ir.actions.actions` and not reading the action itself because
they need the access of the group "Administration/Settings" which not
all the users have it, so we were having an error with users that have
the permissions to see MRP Picking Types but they didn't have the group
mentioned above.

closes odoo/odoo#95156

Signed-off-by: Tiffany Chang <tic@odoo.com>

Steps to reproduce the bug:
- Enable “Expiration date” in inventory settings
- Create a Storable product “P1”
    - Tracking: by serial number
    - Enable the expiration date option
    - Update the quantity:
        - Create a new Lot “SN1”:
            - select today's date as the alert date

- Go to inventory > reporting > Inventory Report
- Try to filter by “Expiration Alerts”

Problem:
The product P1 is not selected, because the filter checks the removal
date instead of the alert date

Solution:
The filter should check if the alert date is less than or equal
to today's date to display products or not, as it is for lots:
https://github.com/odoo/odoo/blob/14.0/addons/product_expiry/views/production_lot_views.xml#L30-L39



opw-2889737

closes odoo/odoo#94654

Signed-off-by: Christophe Simonis <chs@odoo.com>

Sometime Paypal took 3 or 4 days for some payment verification due to
weekend. This raises the retry limit days for 4 days instead of 2 to
solve the issue

closes odoo/odoo#95166

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

Issues
------
Purchase Dashboard gives wong value for PO in RFQ and RFQ sent when
user's language is not English

Current behavior before PR:
---------------------------
1. Create some RFQ and RFQ Sent to see its statistic in dashboard
2. Swith user language to another one that is other than English
3. Statistic in the dashboard is wrong now

Solution
--------
Passing translated RFQ and RFQ Sent into the dashboard query in stead of
passing pure text without translation.

closes odoo/odoo#88635

Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

From July 2022, External Reverse Charge (for Import/Export)
has to be sent through the SdI to the Agenzia delle entrate.
Exports will be 0% VAT
    (Reverse charged to the buyer)
Imports will have a -100%/+100% VAT tax
    (We are the buyers, and in charge of VAT)

See specification in the Task description.
Task: https://www.odoo.com/web#id=2823646&model=project.task



opw-2823646

closes odoo/odoo#94406

Related: odoo/enterprise#28798
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

Leftovers of previous fixes of this issue.

closes odoo/odoo#95123

X-original-commit: fec84116
Signed-off-by: Christophe Simonis <chs@odoo.com>

Improvement of the current fixes:
https://github.com/odoo/odoo/commit/ac3cf2ed59c1dd5a6c91da201a0d4093212b26ae
https://github.com/odoo/odoo/commit/feb4e839dc4e35ab16527e5e264b5cc1c0a76c8e



- A tax line is linked to a tax repartition line. If you suppose a tax with 2 repartition lines then, removing one tax line should recompute the tax line.
- There are multiple taxes configuration leading to a tax line with a zero amount. For example, python tax, fixed tax with quantity = 0, a tax with a tiny amount...etc

closes odoo/odoo#95094

X-original-commit: 11e74861
Signed-off-by: William André (wan) <wan@odoo.com>

Reproduction:
1. Install Expense in V15
2. Go to Expense->Configuration->Expense Products
3. Create a new product, after selecting a vendor tax, click save, the
selected vendor tax is erased and is not saved.

Reason: When creating a new expense product in the normal flow, it still
falls in the condition thus the vendor tax is not updated for the first
time.

Fix: This issue is fixed in the V15 and onwards. The new code just needs
to be backforwarded to V13 and V14.

opw-2852894

Related fix in V15: https://github.com/odoo-dev/odoo/commit/0937ed8d18e4b9ebcaeba6508bd6ffdf1d8e58b7#diff-b294a9786d016b2eda726753fbf75bf749227c2f102d154aa094b2c635334e7e



closes odoo/odoo#95086

X-original-commit: e90005a6
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: Liu Jinjiu (jili) <jili@odoo.com>

When sending an invoice to the SII edi, the field TipoDesglose is
required. In case we have a foreign customer outside of Spain, we are
filtering the taxes information based on the tax scope (services or
goods). In case the tax scope is not filled in, TipoDesglose is not
provided and this will cause the request to fail, with no clear reason
for the user. We should add an UserError message to make it clear enough
so the user can fix it himself.

closes odoo/odoo#94688

Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

The total value of the invoice can be reported in the edi using the
field <ImportoTotaleDocumento>. This commit uses the amount_total of the
invoice to occupy this field.

Adapt the l10n_it_edi_sdicoop tests to include this field in the
expected xml.

closes odoo/odoo#94553

Task-id: 2894623
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

[FIX] account_edi_ubl_cii: Prevent error when zip is not set (since https://github.com/odoo/odoo/commit/b467c2c6536d291ac9b4d426f964fb1d9e309e3f

).

TT36147

closes odoo/odoo#94333

Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

(To be commited with  [#94024](https://github.com/odoo/odoo/pull/94024)

)

Duplicating an email sent from Odoo would raise an error because some required fields could not be set.
Setting those fields on duplication does not make sense, duplication is to be disabled on e-mails.

As this applies to some messages and no use-case could be found for the duplication of messages or notifications,
both also had duplication disabled.

Task-2857244

closes odoo/odoo#94026

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Actually we send request to check if the terminal is available when we poll
the status of a payment.

We remove it and need check the availablity before we start the session

closes odoo/odoo#94859

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

If we use the auto-complete feature to add PO's lines to an bill or we select multiple PO's then use
'create bill' button, the generated invoice line will copy the sequence line from the PO's line. This
can lead to situation where we will have all the first lines of each PO then all the second, etc, ending
with a mix of all PO's in the bill.

Example:
Purchase order 1
- seq 10 line A
- seq 11 line B
- seq 12 line C

Purchase order 2
- seq 10 line A'
- seq 11 line B'
- seq 12 line C'

Invoice created from those PO's
- seq 10 PO1:line A
- seq 10 PO2:line A'
- seq 11 PO1:line B
- seq 11 PO2:line B'
- seq 12 PO1:line C
- seq 12 PO2:line C'

After this PR this PR the lines from the same PO's will be contiguous like:

Invoice created from those PO 1 and 2
- seq 10 PO1:line A
- seq 11 PO1:line B
- seq 12 PO1:line C
- seq 13 PO2:line A'
- seq 14 PO2:line B'
- seq 15 PO2:line C'

opw-2749682

closes odoo/odoo#93673

Signed-off-by: Steve Van Essche <svs@odoo.com>

In April 2022 efaktur standard has been updated to version 3.2
Transaction code 05 has been introduced
https://atpetsi.or.id/kode-transaksi-05-pada-faktur-pajak-digunakan-untuk-ppn-ini



opw-2830864

closes odoo/odoo#95008

X-original-commit: f65d2b69
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Grazioso Andrea (agr) <agr@odoo.com>

Cause:

  The tests fails because the expected price is not the right one.
  It is because that when installing the l10n module, it changed
  the current company currency (if no localisation set) but not the
  pricelist.

Solution:

  For the tests, change pricelist currency of the main website
  with company currency.

opw-2899730

closes odoo/odoo#94983

Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>

Only users with admin rights are able to confirm and send an invoice to
the SII

Steps to reproduce:
1. Install l10n_es_edi_sii module
2. Switch to company 'ES Company'
3. Go to Settings > Invoicing > Spain Localization > Registro de Libros
   connection SII and select 'Hacienda Foral de Gipuzkoa'
4. Go to Invoicing > Configuration > Accounting > Journals and open
   'Customer Invoices'. In the 'Advanced Settings' tab, enable EDI
   functionality 'SII IVA Llevanza de libros registro (ES)'
5. Go to Invoicing > Configuration > Spain > Certificate (ES) and import
   the certificate (file named sello_entidad_act.p12 in
   l10n_es_edi_sii/demo/certificates/) with password "IZDesa2021"
6. Connect as demo in 'ES Company'
7. Create an invoice with any customer and product and confirm it
8. Click on 'Send now', an access error is raised

Solution:
Call `_decode_certificate` with sudo to allow any user to send invoices
to the SII

opw-2767288

closes odoo/odoo#94835

Signed-off-by: Guillaume Merlin (megu) <megu@odoo.com>

Current behavior:
When creating a backorder for a MO the smart buttons showing
the MO counts had the wrong value

Steps to reproduce:
- Have a product that has MTO and Manufacture in his routes
- Create a quotation for 5 of this product
- Validate the order and click the manufacturing smart button
- Set the quantity to 3 and validate
- Create backorder
- Go back to the sale order, the manufacturing count is still 1
  but should be 2

Solution:
Backport of saas-15.2: b3fffea6

opw-2877348

closes odoo/odoo#94091

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Overriding method has_group() in some extension of model 'res.users' is
not possible because of code invoking model.has_group.clear_cache().

As clear_cache() is no longer invoked on ormcached methods, we can
simply replace the code by a global cache invalidation.  In this case,
it is not even necessary, since method call_cache_clearing_methods()
does it already.

closes odoo/odoo#94907

Signed-off-by: Raphael Collet <rco@odoo.com>