MAke sure to always set the expiration date of a coupon.

opw-2151284

closes odoo/odoo#41448

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

OPW 2151580
There is a needed font for the swiss IRS report: OCR-B. This commit
ensures it is used.

closes odoo/odoo#41428

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

If you reconcile for example a bank statement of 200,00€ with a
customer invoice of 300,00€, you get a pen icon next to the 300,00€
and if you click on it you have an editing cell with:

200.00

But if you validate this, this will be parse in the current language
number formatting so if you have . as thousands separator, this number
will become 20000 which is not expected (higher than original invoice).

With this changeset, we display the number in the current lang format.

note: with this fix, number of decimals can be different than 2

opw-2150396
closes #41410

closes odoo/odoo#41431

X-original-commit: 0fa0acca963075176bd8195ec66581653940ca7f
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

When creating vendor bills, it was considering this two numbers as different but actually are the same invoice number

* 01234-00000001
+ 1234-00000001

To avoid this we remove the zero to the left always if the pos number > 4.

closes odoo/odoo#41196

Signed-off-by: Josse Colpaert <jco@openerp.com>

closes odoo/odoo#41391

Related: odoo/enterprise#7058
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

When the adapation without jQuery promise was done for 12.3 (in
bfed5742) the hack for always saving a pad URL was added in
the deferrence of the start method.

This caused that in the following conditions:

- pad URL is set
- form is in edit mode
- a change in the form change the readonly status of the pad

=> we would have a mutex lock (of the form change) waiting for the pad
that is being rerendered to finish its start but that can only be done
once the mutex is unlocked (because setValue of the pad is protected by
the same mutex) => so we have deadlock and interface does not allow to
save or do any other change.

This happened for example if we had a project.project A without
collaborative pad, project.project B with collaborative pad, and if we
moved a task from project B to project A then back to project B.

With this change, we get back to the behavior before bfed5742 of not
waiting for the fake "setValue" in `start` of Pad.

Without the change, added test fails with:
    Expected 1 assertions, but 0 were run

because interface is deadlocked so write does not happen.

opw-2150827
closes #41346

closes odoo/odoo#41363

X-original-commit: cc73abb218e17756b21824a192f4461eb8537c0e
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

When the box is in "access point" it calls the function 'get_wifi_essid'
at every ping => ~ 3 seconds.
So after a few moments the network card blocks and turns off.
Now we redirect the user to the '/steps' route that only executes the function once.

closes odoo/odoo#41397

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

We must delete the folder "MOUNT_POINT" before the "zerofree"

closes odoo/odoo#41388

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

When printing an invoice, the order of the lines not always match the
order in the interface.

It occurs because `account.move.line` contains a `sequence` field which
is taken into account in the UI but not used in the report. Note that
commit 0a5955bf explicitly removed from the `_order`.

opw-2145878
opw-2147922

closes odoo/odoo#41380

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

In some cases, Stripe will return the result of a transaction with
a faulty HTTP Status (e.g. 4XX statuses) - not because the request
was malformed, but because the payment failed. It is a bit unfortunate
that Stripe would not differentiate between payment status and request
validity, but that's the state of things.

This commit ensures that such a response will be logged correctly, by
making the call to `raise_for_status` conditionnal on the response object's
status code and internal structure, forwarding the response's json to the
validation flow if the status is in the 4XX range and a `code` key is
found in the response, as described in https://stripe.com/docs/error-codes



While testing this fix, it became apparent that some error message
processing in the frontend was not correctly handled as well - instead
of purely rejecting the promise, a failed payment should still send its
payload to the backend, to allow the server to put the transaction in
the correct state according to the response.

closes odoo/odoo#41377

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

Before this commit, trying to put a transaction in a state
where it was already in was causing an error.

For example: Putting a transaction in'Done' when it was
already in'Done' caused an error
'Only draft/authorized transaction can be posted.'

Now, we just log a note that the transaction is
already in the good state and pass over.

Before this commit, when navigating from test environment (e.g.
page reload), it crashed with following error:

`TypeError: Cannot convert undefined or null to object`

This error comes from mocked bus services in tests: even when they
have been destroyed, they handle the window event 'unload'. They
no longer have a parented parent, so `this.call()` returns
`undefined`, hence the crash.

This commit prevents mocked bus services to listen on window 'unload'
event. Tests must always simulate this window event by explicitly
calling the handler.

closes odoo/odoo#41374

X-original-commit: fd08d04f
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

- Create a Reconciliation Model and set 'Journals', e.g. Bank
- Create a payment in the Bank journal
- Open the Payment Matching

The model created is not available.

In the case of the Payment Matching, `state.st_line.journal_id` is
`undefined`, so it is always filtered out.

Since the filtering should only apply on the Bank Statement Matching, we
do not filter out them in Payment Matching.

opw-2149154

closes odoo/odoo#41338

X-original-commit: 74a26acb
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

- Create a batch picking with all available products
- Click on 'Done'
- On the 'Immediate Transfer' wizard, choose 'Cancel'

The picking is set to done anyway.

This is because we set the picking as done whatever the action on the
wizard.

If there is a wizard, we don't set the batch as done. This avoids
unwanted change of status, but requires the user to click twice on the
'Done' button.

opw-2147944

closes odoo/odoo#41366

X-original-commit: 0f9f3ded
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

The state field does not contain any information whether an invoice was paid or not. This info is stored in the invoice_payment_state field. This change fixes the field used in the customer-facing template to display the payment status of the invoice.

closes odoo/odoo#41354

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Description:
- Add readonly attribute to partner view for l10n_cl_sii_taxpayer_type field for children res.partner records.
- Fix the tax payer type label to prevent usage of "label for.."
- Optimize document type order to put most used on top of file and in selection of document types during invoicing process

closes odoo/odoo#40877

Signed-off-by: Josse Colpaert <jco@openerp.com>

opw-2125858

closes odoo/odoo#41362

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Fix error like "TypeError: {4} is not JSON serializable" when
serializing the session object (e.g. for external storage)

closes odoo/odoo#41341

X-original-commit: e91e38fa
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

If a module add a state field on another table used by this report, 
PostgreSQL will report a:

```psycopg2.ProgrammingError: column reference "state" is ambiguous```

closes odoo/odoo#41325

Signed-off-by: Christophe Simonis <chs@odoo.com>

tax grouping key from base and tax line that will be used as a key to group taxes together
so both functions must have the same dictionary key. (you can check comment here https://github.com/odoo/odoo/blob/13.0/addons/account/models/account_move.py#L412

)

here we have three key (product_id,product_uom_id,quantity) in _get_tax_grouping_key_from_base_line
and only one key (product_id) in _get_tax_grouping_key_from_tax_line

so we get wrong tax calculation

now we remove that extra key(product_uom_id, quantity) because we don't need group by these key values.

closes odoo/odoo#40558

Signed-off-by: Josse Colpaert <jco@openerp.com>

task-2121584

closes odoo/odoo#40110

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Open Bank reconciliation, deactivate some record (-), go to "Manual
Operations" tab, add Analytic Tags using the "Search More" functionality.
Resulting tag will be blank and impossible to delete.

This is because:
1) The field shown is the display name, which is missing.
2) When selecting analytic tag(s) this way an array of
results is returned but it is not handled correclty by the view.
When selecting the analytic tag from the drop down menu a single value
'{id: , display_name: }' is returned.

opw-2146833

closes odoo/odoo#41300

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

The method `unlink` checks whether any of the records to delete is used
as the default value of a company-dependent field.  The query simply
blows up when deleting several millions of records.  The fix consists in
performing the check in batches.

closes odoo/odoo#41293

X-original-commit: 39d5440e
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

closes odoo/odoo#41298

Related: odoo/enterprise#7018
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

The `text` attribute is not translatable, so we support the `title`
attribute which is.

Fixes #38568
opw-2148416

closes odoo/odoo#41274

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

Using studio odoo doesn't let user drop notebook in a group since it
generates issues with the notebook. (See https://github.com/odoo/enterprise/commit/ea5ccd548bb6781e5ccdf76cf11255c6fd6aa3cb

 )

For better understanding, a note for 'notebook' tag is added by this commit.

task -  2060330

closes odoo/odoo#41241

X-original-commit: a2d331af0df859fd29e84bfa30a9086c3d2e0fa8
Related: odoo/enterprise#7004
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Usually in a form view, a notebook is not placed within group/s.

Also, using studio we don't let user drop notebook in a group since it
generates issues with the notebook.(See https://github.com/odoo/enterprise/commit/ea5ccd548bb6781e5ccdf76cf11255c6fd6aa3cb)

This commit fixes the issue by moving notebook out of the group and making
the 'payment.icon' form view structure consistent(and properly
editable with studio).

task - 2060330

X-original-commit: c4efe0173478be8b6a643d5fefef4244384ea6c2

If we have eg. a report with a page break (eg. `Print On New Page`
enabled on a financial report section) the encoding is broken.

The reason is that lxml.html fragments_fromstring function accepts text
string (OK in unicode) or bytestring => the encoding will be guessed (by
chardet library) if guess_charset argument is set to true.

So since we do not pass guess_charset option, the encoding is not
recognized.

In this changeset, we give a text string to the fragments_fromstring
function since it seems that all our input should be in UTF-8.

note: lxml.html itself uses html5lib.HTMLParser parseFragment that takes
a charset argument, but there is no interface through
fragments_fromstring to specify the charset.

opw-2146715
closes #41255

closes odoo/odoo#41277

X-original-commit: 1d3d517a
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

opw-2148101

closes odoo/odoo#41258

X-original-commit: 9eb28754
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

The only good solution is to set `show_reserved` to `True` to avoid any
kind of weirdness...

This reverts commit eed3171f.

closes odoo/odoo#41276

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

When computing the price of a product through a pricelist item, if the
item was based on anotherp pricelist, the dates and uom weren't given to
the subsequent method call.

As the majority of the calls to those pricelist methods put all their
arguments in the context, it wasn't noticed until now.

Functional example:
Pricelist A:
Rule A1 : 10% discount on Pricelist B, from day 3 to day 6.

Pricelist B:
Rule B1: 5% discount on Sales price, from day 3 to day 6,
Rule B2: 10% discount, from day 7 to day 9.

If today was day 8, the call to pricelist(A)._compute_price_rule(day=5)
would use rules A1 and B2, but should have used rules A1 and B1.

closes odoo/odoo#41254

X-original-commit: bba7a6b2
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

closes odoo/odoo#40822

X-original-commit: 44fc66e00f56a5cc564682799eb4483225958a7a
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

[FIX] account: when writing the country of a tax report line, also update the country of its tags, to keep consistency

X-original-commit: 11bf6d8d5a01759be2d3e943a96213730c4c5528

closes odoo/odoo#41252

X-original-commit: f17d389c
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Co-authored-by: Denis Ledoux <dle@odoo.com>
Co-authored-by: Raphael Collet <rco@odoo.com>

If we do a payment with:
- a currency different than the journal
- the journal currency the same as company currency

=> it fails, because of the constraint on account.move.line:

> The amount expressed in the secondary currency must be positive when
> account is debited and negative when account is credited.

with code:

```
CHECK(currency_id IS NULL OR company_currency_id IS NULL OR
((currency_id != company_currency_id) AND {conditions on balance}))
```

This happens because in this use case, a NON-NULL currency_id means that
the currency is different than the company currency, this was not taken
into account when creating a liquidity line.

opw-2150267
closes #41244

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Task 2046921

closes odoo/odoo#41103

X-original-commit: 60a1aea9b4267f6538ce7160d363e3d8bb38ce7b
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Do not remove the country set on the company when the state is removed.

closes odoo/odoo#41217

X-original-commit: dfa2a3b7
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Set a default company since it is mandatory and hidden in mono-company
mode.

opw-2129187

closes odoo/odoo#41214

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Issue

    - Swiss company
    - Install Accounting & Studio
    - Journals > Customers Invoice
        - Communication standard: Switzerland
    - Journals > Bank
        - Swizz account with CHF ISR subscription number
    - Studio > Reports > ISR

    Traceback

Cause

    If the statement of the `l10n_ch_isr_optical_line` compute
    method is False, the value will be `None`.

    In the view, we do a foreach on the value which is `None` and
    it crashes.

Solution

    Set an empty string as default value for the
    `l10n_ch_isr_optical_line` field

OPW-2129122

closes odoo/odoo#41213

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>