Typo error detected on `/mrp/wizard/mrp_immediate_production_views.xml`.
It doesn't cause any issue on module installation or updates, but
it's probably gonna cause issue on view inheritance.

If you can confirm this is unintended typo I will edit commit msg.
I also detected this on version 15.0 and 16.0.

closes odoo/odoo#134788

X-original-commit: 80e8222f
Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Steps to reproduce:

  - Install `account` module
  - Activate another language (e.g. French)
  - Create a partner with the new activated language
  - Create an invoice for this partner and sent it by mail

Issue:

  Some words in the external layout of the email are not translated;
  button and title

Cause:

  The language of the partner is not taken into account (except for the
  model name in the button) when creating the external layout of the
  mail.

Solution:

  Call send_mail with the partner language in the context.

opw-3301607

closes odoo/odoo#133744

Signed-off-by: William André (wan) <wan@odoo.com>

If a bank account is added through the onboarding step and the user creates one instead of linking it,
the dashboard is not reloaded to show the completion of the step and the new account.
To make sure that the view is reloaded to show new data,
the easiest fix would be to return a reload action in `validate`.

task-3431961

closes odoo/odoo#133057

Related: odoo/enterprise#46250
Signed-off-by: William André (wan) <wan@odoo.com>

Have a form view with a date or datetime field with onchange.
Change its value to trigger the onchange. If the onchange fails,
we want to revert the value to the original one. Before this commit
it didn't work, because the datepicker blocked the update when the
props were the same, which was the case in this situation.

Task~3498849

closes odoo/odoo#134792

Signed-off-by: Francois Georis (fge) <fge@odoo.com>

In a form view, have a field with an onchange that returns an
error. Before this commit, the error was displayed but the
faulty value that triggered the onchange (and thus the error)
was still displayed in the UI (even though in the model, the
previous value was still set).

This commit enforces an update of the UI when an error occurs,
such that the previous, valid, value is displayed again.

For instance:
Go to a customer invoice, open the Actions menu, click on
"generate a payment link", in the dialog, set an high amount.

Task~3498849

Part-of: odoo/odoo#134792

Steps to Reproduce the Bug:

- Create a storable product "P1" with 2 Bills of Materials:
   - BoM 1:
     - Component: C1
   - BoM 2:
     - Component: C2

- Create a MO:
   - Select BoM 1.
   - Save.
   - Select BoM 2 without saving. Result: The component C1 is deleted
   and replaced by the component of BoM 2.
   - Select BoM 1.

Problem:
The component of BoM 2 is not cleared. Because we check if the new BoM
is different from the original one, but since we didn't save the change
when selecting BoM 2, the `move_raw_ids` are not cleared.

Solution:
Clear the `move_raw_ids` if any move with `bom_line` is not linked to
the current BoM.

OPW-3473387

closes odoo/odoo#134718

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

BUG:
show +NAN on kanban view

FIX:
show +6 on kanban view

closes odoo/odoo#134623

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Task-2674716

Closes #78392

Signed-off-by: Christophe Matthieu (chm) <chm@odoo.com>

closes odoo/odoo#27664

Signed-off-by: Pierre Masereel (pim) <pim@odoo.com>

Description of the issue/feature this PR addresses:

when logged in user name is too long then it take whole header to display it
name.
In project module, if milestone name is long then name is overflowing.
Current behavior before PR:

whole header is occupied when username is long.
milestone name is overflowing when name is too long.
Desired behavior after PR is merged:

when username is long it would show with '...' format.
when milestone name is long it would show with '...' format.
Fix:

some property is added in oe_topbar_name class to display the username in short
and '...' format.
add some bootstrap class so that long name should be formatted in '...' .
task-3217427

closes odoo/odoo#133670

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Signed-off-by: Ravi Bhingradiya (ravb) <ravb@odoo.com>

When a user tries to import the CSV file with a different separator at that
time, the values in mapper and rows_to_import are not correctly mapped. So
the traceback will be generated.

Steps to reproduce:
1. Click on import in the bank statement.
2. Select any CSV file for the bank statement line or can download and import
this file https://drive.google.com/file/d/1lnScw4RN6T01pOkyNON8vvb3FQOPiy1O/view?usp=drive_link


3. Select any separator other than a comma.
4. Click on the test or Import button.
5. Error will occur.

Error: IndexError: list index out of range.

To solve this issue, a row's length is checked with the
number of fields.

sentry-4021250095

closes odoo/odoo#134502

X-original-commit: 62253417
Signed-off-by: Achraf Ben Azzouz (abz) <abz@odoo.com>
Signed-off-by: Saurabh Choraria (sauc) <sauc@odoo.com>

This reverts commit e458a4c1 from
pull-request #129567, see #134791

closes odoo/odoo#134952

Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>

When getting the available quantity of a product, it is possible to
specify the warehouse and/or the location in the context. However,
it does not correctly work. For instance, if we provide the stock
location ID (8) and the warehouse ID (1): we first use the view
location of the warehouse, and we then get the intersection between
this view location and the provided locations: nothing. In such case,
we should keep the stock location. Few other examples are given in
the test.

OPW-3450169

closes odoo/odoo#134823

X-original-commit: 8b53464d
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Adrien Widart (awt) <awt@odoo.com>
Co-authored-by: Simon Schmid <simon.schmid@braintec.com>

Commit [1] introduced a stronger regex to detect urls. Unfortunately,
it did so using a negative lookbehind, which is is only supported on
very recent version of Safari iOS.

This commit is an attempt at reproducing the same behavior, albeit
with a more complicated regex, unfortunately.

[1]: https://github.com/odoo/odoo/commit/a42a19e484d63cebeaed10b75ac20e507ff85d56



closes odoo/odoo#134821

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Bug
===
When we enrich a partner we don't have access to, it will try to read
it, but because of the ACL if will crash. To fix that issue, we don't
return the partner if we can't access it and we show an error message
in the UI instead of letting it crash.

Task-3344536

closes odoo/odoo#134875

X-original-commit: a0290a9d
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

During this pr (https://github.com/odoo/odoo/pull/121413

), we have made a few
css changes on the din5008 format, some of them needed to be revert because they
 broke the layout.

closes odoo/odoo#134833

Task: 3495712
X-original-commit: c120d138
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>

There is code to block the UOM changing if there are done moves.

Because it searches in non-sudo mode, it does NOT currently
stop you changing the UOM if the product has moves in a different
company.

closes odoo/odoo#134807

X-original-commit: 42674464
Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>

Implemented support for the BACS payment scheme as per the latest
technical specifications, enabling the processing of BACS Direct Credits
and Direct Debits. Included the mandatory requirement of a Service User
Number (SUN) for businesses conducting transactions via BACS.

closes odoo/odoo#128069

Task-id: 3326945
Related: odoo/enterprise#43923
Signed-off-by: Quentin De Paoli <qdp@odoo.com>

- Added ondelete='cascade' to account_payment_method_line's
field definition.
- Fixes the foreign key constraint failure during module uninstallation
by automatically deleting dependent records.

task-3326945

Part-of: odoo/odoo#128069

Steps to reproduce:
- Enable multistep routes (3 steps delivery)
- Create a new storable product (0 on hand quantity)
- Confirm an SO with that product

Bug:
forecast button is correctly red on the SO line but it's green on the
stock pickings

Fix:
button should be green if it's possible to reserve quantity red otherwise

opw-3440627

closes odoo/odoo#134841

X-original-commit: 0312c1bdc371e5a841b8d9e620c9fd7a49782b15
Signed-off-by: Quentin Wolfs (quwo) <quwo@odoo.com>
Signed-off-by: Walid Hanniche (waha) <waha@odoo.com>

Before this commit, the push to talk key combination was wrongly
detected. Indeed, it was dependent on which key was pressed first.

Steps to reproduce:
- Register "ctrl + alt" as the push to talk key
- Press control then alt, push to talk does not work
- Press alt then control, push to talk works
- If you unpress the alt key, the push to talk will stop as expected
- If you unpress the control key, the push to talk will keep going

This commit fixes the issue.

closes odoo/odoo#134728

X-original-commit: 224c23d9c28421e93ee317eebe9e7da25c6c5872
Signed-off-by: Thanh Son Dodeur (tso) <tso@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Currently, when a journal is created during import, we just use the journal name as the code.
However, that gets truncated to 5 characters on create, which can conflict with existing journals.
The import should be as flexible as possible, as it's better to let users import and fix things
after the import rather than debug the import file.
- If there is a journal with a shortcode that matches the truncated name of the new journal,
  just use the existing journal (enterprise PR)
- If the shortcode conflict arises within the imported file
  (so the journals don't exist before the import), keep track of the codes in `vals_list`.
  The `get_next_bank_cash_default_code` is modified to avoid duplicating code.

See also odoo/enterprise#46101

closes odoo/odoo#132715

Signed-off-by: Laurent Smet (las) <las@odoo.com>

after using the token to link a database to an iot box, the odoo service
 is not restarted and therefore no box is visible in the database.
Now we apply the odoo_restart() function regardless of the platform used

closes odoo/odoo#134829

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

Steps to reproduce:

- Install Loyalty module
- Go to Website and buy a gift card
- Checkout and pay the order

Issue:

  Only 'Order Confirmation' email is sent directly to the customer,
  gift card email is queued and sent later.

Cause:

  `send_email` method is called with `force_send=False` by default,
  which queues the email to be sent later.

Solution:

  Add optional parameter `send_force` (default to `False`) to
  `_send_creation_communication` method and call it with
  `send_force=True` when confirming a sale order.

opw-3324386

closes odoo/odoo#133427

Signed-off-by: Nasreddin Boulif (bon) <bon@odoo.com>

Add IEPS taxes and tax groups. Make sure the IEPS taxes are
`include_base_amount` and have a lower sequence than the IVA taxes.

Unify the names of the taxes and their labels on invoice.

Resequence the taxes to group them by nature.

task-3100679

closes odoo/odoo#134595

X-original-commit: 734e18eb
Related: odoo/enterprise#47121
Signed-off-by: Laurent Smet (las) <las@odoo.com>
Signed-off-by: Julien Van Roy (juvr) <juvr@odoo.com>

Have a form view with a view button. Make some changes in the form
s.t. the create/write rpc will return an error. Before this commit,
the "oh snap" dialog was displayed, providing 2 choices to the
user: stay here (basically, close the error dialog and do nothing
else) or discard (discard changes, and continue the flow). In this
case, the flow is to do the "call_button" as we clicked on a view
button. It means that if the user clicked on discard, we still
call the method/action, even though the record was invalid (and
maybe not even existing if it was a new record). This can cause
other issues afterwards.

The "oh snap" dialog was designed for navigation flows (e.g. menu,
breadcrumbs...), when the user tries to leave the form view. It
doesn't fit very well with flows involving the current record that
couldn't been saved.

This commit thus prevents the "oh snap" dialog from being displayed
if the save preceeding a call_button fails. The error returned by
the save is simply displayed in a basic dialog that can only be
closed.

opw~3395109

closes odoo/odoo#134783

Signed-off-by: Géry Debongnie <ged@odoo.com>

The website menu is cached for each page, but there is no difference
between the cache of a logged user or of a public user. If you have a
page restricted to logged in users in the menu, this can sometimes lead
to:
(1) the link appearing in the menu even though the visitor is logged out
(because the cache was done when logged in), and
(2) the link not appearing even though the visitor is connected (because
the cache was done when logged out).

While (1) only leads to a 403 error if one clicks on the menu link, (2)
is more annoying as it hides a page that should be shown.

This commit therefore also caches the website menu depending on the
visitor being logged in or not.

Note that the same bug occurs for pages restricted to a specific group.
In these cases however, there is no technical solution as of now. It
should be considered as a limitation.
In such cases, workarounds are possible:
- Going on the "My account" page (by clicking on the username) will
always show the page.
- One could add a snippet on the homepage with a link to the restricted
page, and conditionally display the snippet only for users of that group

Steps to reproduce the bug:
1) Connect as admin, create a new page, open its properties and set its
visibility to 'Signed in', then publish it.
2) Logout, connect as portal
3) Logout, connect as admin
4) Unpublish and republish the page
5) Logout, reconnect as portal
6) Go to the homepage: the new page doesn't appear in the menu
7) Go to 'Contact us': the page reappears in the menu

opw-3445032

closes odoo/odoo#134688

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Linked pr https://github.com/odoo/odoo/pull/133484
Comparison price was not converted to currency pricelist, now it's done.

Problem https://github.com/odoo/odoo/pull/133484#issuecomment-1705317420



closes odoo/odoo#134278

Signed-off-by: Achraf Ben Azzouz (abz) <abz@odoo.com>

Steps to reproduce:
- Create Storable Product "Super Test" with Cost of $1.
- Create Storable Product "Pack of Super Test" with Cost of $10.
- Create a Kit BoM that produces 1 "Pack of Super Test" from 10 "Super Test".
- Ensure product category on both products is set to Automated FIFO Inventory Valuation.
- Create a PO for 20 "Pack of Super Test" and confirm.
- Process the Delivery and look at inventory valuation.
- See that "Super Test" has moved quantity at 200 with Unit Value of 10 each (taken from kit product!).

Bug:
cost isn't split on the qty of the bom line

Fix:
take product quantities of the bom into consideration

opw-3453703

closes odoo/odoo#132186

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Steps to reproduce:
- In Manufacturing, create a the following BoM
  - Product: P1
  - Components:
    - 2 x P2
    - 2 x P2
- Set the quantity in stock for P2 to 2
- Open the Overview from the BoM

Issue:
The 'Ready to Produce' column will indicate 1, as it checks line by line
how much product there is in stock compared to what is required for this
line.
To avoid this, we just need to sum the quantities required by products.

closes odoo/odoo#134714

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Issue:
Displaying the data on the dashboard accounting can take up to 1 minute

Analysis:
The spreadsheet_fetch_debit_credit function needs a domain in order to compute the formulas. The domain being set in `_build_spreadsheet_formula_domain` use a like search for account_account.code on account_move_line which is a big table. Thus it does not scale well. There is also a unnecessary complexity on adding an "OR expression" on each one of the account_id code searched for.

Solution:
It can be optimized by searching for the full exhaustive (like in SQL) codes in account.accoun since it has way less records and thus more scalable. And then use an exact condition (=) which is faster than a like search. Also adding more readable while adding the balance_domain and pnl domain only once in the whole query.

Benchmark:

| Before PR | After PR |
|:----------:|:---------:|
| 8s 51 ms | 42 ms code search + 42 ms full query |

Related ticket:
opw-3328144

Version affected:
16.0 and above

closes odoo/odoo#134514

Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>

Because why not?

We often need to re-render the user interface from python, but limited to call a browser reload (redirect to current URL).
With this simple client action tag `soft_reload` - we can quickly reload the UI, without a hard refresh.

An example use case: refresh the kanban when an onboarding step is done via a dialog. See `validate` in 'account.setup.bank.manual.config'

closes odoo/odoo#133643

Signed-off-by: Francois Georis (fge) <fge@odoo.com>

To reproduce the issue:
1. In Settings, enable:
   - Multi-Routes
2. Unarchive the route MTO
3. Create three storable product P1, P2, P3:
   - P2:
     - With route MTO
4. Create and confirm a MO:
   - Product: P1
   - Components:
     - 1 x P2
     - 1 x P3
     - 1 x P3
5. Set the produced/consumed quantities:
   - For P2, set 1.5
6. Mark the MO as done

Error: an error message is displayed: "Record does not exist or has
been deleted."

In `SM._action_done`, we create some extra moves:
https://github.com/odoo/odoo/blob/e029abe649573350e633999e42ab040c57b8fe4e/addons/stock/models/stock_move.py#L1705-L1710
Because of the exceed quantity on the first components line, we
create a new SM (qty 0.5). There is a difference between both SM:
the `procure_method` (MTO for the initial SM, MTS for the new one).
Because of that difference, when confirming the new SM, we don't
provide any `merge_into` (the `else` block):
https://github.com/odoo/odoo/blob/e029abe649573350e633999e42ab040c57b8fe4e/addons/stock/models/stock_move.py#L1684-L1690
Confirming the new SM leads to the `_merge_moves` method. In this
method, because we didn't provide any `merge_into`, we first try to
get some candidates:
https://github.com/odoo/odoo/blob/e029abe649573350e633999e42ab040c57b8fe4e/addons/stock/models/stock_move.py#L866-L868
And at that point, we will provide with all components SMs:
https://github.com/odoo/odoo/blob/e029abe649573350e633999e42ab040c57b8fe4e/addons/mrp/models/stock_move.py#L494-L497


So, we will also provide the two SM of C02. Therefore, the method
will merge these SMs and unlink the second one. Then, back to the
extra moves creation in `SM._action_done`, the for loop will iterate
on the deleted record, hence the error.

OPW-3454899

closes odoo/odoo#134674

X-original-commit: 587a2996
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Adrien Widart (awt) <awt@odoo.com>

Before this commit:
Packages were computed using a for loop, skipping any picking without
any packages.

After this commit:
Packages are computed using a read_group, speeding up the computed
method for large pickings with hundreds of stock move lines.

opw-3461706

closes odoo/odoo#134581

X-original-commit: 8dcad6e4
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Signed-off-by: Walravens Mathieu (wama) <wama@odoo.com>

before this commit, POS order can add a reward from loyalty programs
which have already reached maximum usage by add the loyalty rule's code
and refresh the browser. It will clear 'total_order_count' in browser
cache.
step to remake:
1. create a promo code loyalty program with maximum usage
2. create orders (pos order or sale order) with this promo code and paid
them until the program reaching the limit usage.
3. create new POS order and add the promo code -> no reward line in POS
order, then refresh browser, it will add new reward line into order

after this commit, 'total_order_count' allways be fetching from database
so it is being clear no longer.

closes odoo/odoo#134077

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

To reproduce the issue:
1. In Settings, enable:
   - Storage Locations
   - Package
2. Create a product P
   - Type: Storable
   - Tracked by SN
3. Process a receipt with 1 x P, serial S
4. Return P in a package
5. Process a new receipt with 1 x P, still S as SN

Error: An error is displayed "The serial number has already been
assigned [...]". This is incorrect, the user should be able to
receive that SN.

After step 3, there exists a quant Q1: -1 x P at Supplier Location
with S. Then, after step 4, a new quant Q2 is created: 1 x P at
Supplier Location with S and the package. Because the field
`package_id` is not the same on Q1 and Q2, both quants are not merged.

As a result, step 5, we will update Q1 and have -2 x P at Supplier
Location with S. This will trigger the constraint, hence the error
message.

OPW-3390615

closes odoo/odoo#134727

X-original-commit: 3a501855e65b6e82004d67beeecffe7286cc682b
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Adrien Widart (awt) <awt@odoo.com>

Before this commit, simple user could not use the novatim API since https://github.com/odoo/odoo/commit/160e8bfbf72a3e5d7cc8d8cbe7bc4f310f298baa



closes odoo/odoo#134735

Taskid: 3497580
X-original-commit: 43763618
Signed-off-by: Arnaud Joset (arj) <arj@odoo.com>

Steps to reproduce:

1. add a paragraph
2. add a blockquote
=> the cursor will jump in the paragraph
This commit fixes a bug detected when inserting a blockquote. The cursor
jumps to nearby paragraph on insert, and other issues.

The cause of the bug is tied to the fact that we rely on a complex behavior
when inserting paragraph related elements (within the insert command).
The way to make blockquote behave like the other paragraph related
elements is simply to add it to the list as done in this commit.

Task-3383441

closes odoo/odoo#134633

X-original-commit: 8195beac
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

This commit introduces improvements to the order synchronization
mechanism. The changes ensure better error handling and provide a more
reliable and informative synchronization process.

Key Changes:

1. Enhance `_flush_orders` Method
    - The `_flush_orders` method now has additional error handling to
    detect RPC errors during synchronization of multiple orders. If an
    RPC error is detected and multiple orders are being synced, the
    method will attempt to send each order to the server individually.

2. Introduce `_flush_orders_retry` Method
    - This method sends orders to the server one by one and keeps track
    of the synchronization status (successful, RPC error, or other
    errors).
    - It sets the synchronization status to `'connected'`, `'error'`,
    or `'disconnected'` based on the outcome of individual order
    synchronization attempts.

3. Improve Error Handling
    - Enhanced error handling mechanisms to differentiate between
    various types of errors.
    - Synchronization status reflects the type of error encountered.

opw-3389388

closes odoo/odoo#134333

X-original-commit: 57074c34e90cdbf1db5b06fc8ccd6ae2318191fc
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Pedram Bi Ria (pebr) <pebr@odoo.com>