One of the selector didn't work due to a space before the classes and
prevented the fix from working. This fixes it in my tests.

closes odoo/odoo#108107

Signed-off-by: Louis Baudoux (lba) <lba@odoo.com>

When a kit template has several variants, the on hand quantity can be
incorrect.

To reproduce the issue:
1. Create two products P_compo, P_kit:
    - P_kit:
        - Storable
        - Variants:
            - Color (White, Black)
    - P_compo:
        - Storable
2. Update the on hand quantity of P_compo: 10
3. Create two BoMs:
    - BoM01:
        - Product: P_kit
        - Variant: Black
        - Type: Kit
        - Components: 1 x P_compo
    - BoM02:
        - Product: P_kit
        - Variant: White
        - Type: Kit
        - Components: 2 x P_compo
4. Open the form view of the template P_kit

Error: it displays "15 units on hand", which is impossible (there are
only 10 P_compo available)

Since it is difficult to determine the expected value, a decision has
been made: hide these smart buttons if a template has more than one
variant and if at least one of the variants is a kit.

OPW-2645299
OPW-2678400
OPW-3076502

closes odoo/odoo#104481

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Fix the PR https://github.com/odoo/odoo/pull/107553



closes odoo/odoo#108141

Signed-off-by: John Laterre (jol) <jol@odoo.com>

To Reproduce
============

- enable QR code on Accounting settings
- with a vendor who has a bank account create an invoice from him/her
- print or preview the credit note

The Problem
===========

the qr code method field will not be filled with SEPA, and a QR code will not be added to the PDF or preview.
This qr reflects the vendor's bank account, so the user could scan it and send the money.
This feature was removed by PR #104496 because it was also printed in the refunds to the customers, which was odd, but as a side effect it is also removed from vendor bills.

Solution
========
The QR should not be hidden in vendor bills and purchase receipts, ( also in vendor refund it can be helpful for the vendor, but there isn't any complain about it now )
A better solution would be displaying the QR code in the form view if it is not the company's bank account (it is the partner's bank account), but it should be done in master, it is too much of change for stable versions.

Ticket No: 3071310

Closes: #108098
Signed-off-by: William André (wan) <wan@odoo.com>

Prior to this commit, adding an anchor using auto-complete would not
properly prefix the url with the URL of the current page.

Steps to reproduce:
- Create a page (e.g. /test), add blocks and create an anchor (e.g.
- Save the page
- Click on "Edit Menu" in "Pages"
- Add a new menu entry
- Type '#' in the URL field and select the anchor
- Save

=> The menu entry is wrongly set as it does not contain the original
page's URL inside the `href` attribute. This means that clicking on the
menu from any other place will not properly redirect to the anchor on
the /test page

On top of that, editing a menu entry that was previously linked to a
page would change the URL of the page with an anchor, making it
impossible to access the page anymore until you change the URL back in
the page manager.

Steps to reproduce:
- Create a new page (e.g. test)
- Add a new menu entry that has this page as its URL
- Save the new menu entry (close the dialogs)
- Re-open the Menu dialog and edit the newly created menu entry
- In the URL field, replace it with the page + an anchor
 (e.g. /test#anchor)
- Save
=> The page's URL is now /test#anchor and is no longer accessible

The is due to the `save` method of the `website.menu` model not
containing code to properly manage adding an anchor to the menu.

This commit fixes that.

opw-3067750

closes odoo/odoo#106882

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

before this commit:
users without read permission of ir.module.category cannot search
res.groups by names. An access error will be raised.

after this commit:
all users with read permission of res.groups can search res.groups
by names

Backport of odoo/odoo#97877 with small fix for bool case

closes odoo/odoo#108155

Luxembourg added new fields and modified some rules for VAT reports: monthly, simplified, and annual.
- Add new fields
- Adjust formulas

task-2993792

closes odoo/odoo#104833

Related: odoo/enterprise#33558
Signed-off-by: William André (wan) <wan@odoo.com>

The URLs in notes created from the systray were not transformed into links.
This solves the problem.

Task-3052952

closes odoo/odoo#105990

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

As the previous commit explained, there is sometimes a gap between two
shapes due to some browser rounding errors, especially when using
browser zoom. However, there are also some things we can do in our
shapes themselves to decrease this problem.

This commit fixes two pairs of shapes which were easily fixed by
reviewing the rounding of one path and making the viewBox a square
(making a viewBox a square is known to solve issues). However:
- The first pair is not entirely fixed, the error is just reduced.
- The second pair is fixed... but the shapes actually do not join very
  well (somehow the linear gradients do not seem to join properly)...
  but still better than a white line between the two.

Reminder: several commits had attempted to fix this before ([1], [2],
[3], [4]) (and this commit's parent). But that wasn't enough to stop it
happening. Some shapes still need to be fixed although that will likely
be done in future versions.

[1]: https://github.com/odoo/odoo/commit/c0f62593a4da37e8404dddc0a5762879a5ebbf7f
[2]: https://github.com/odoo/odoo/commit/ac82407b259eab929486bf0a333a48bc507efa60
[3]: https://github.com/odoo/odoo/commit/42b3ad10e0b32b7fc72f801e2c67d6baf938c566
[4]: https://github.com/odoo/odoo/commit/e386f318f5cff50901dba3db8a2587911ba02a6e



task-2824607
opw-3069213
opw-3057533

closes odoo/odoo#107492

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

This commit mitigates an issue with shape elements sometimes having tiny
spacing on their top or bottom edge.

This issue is mainly on Chrome when the user has changed the page zoom.
When the page is zoomed the elements can have a width value with a
decimal part. Because of it, the size of the SVG background images are
not correctly rounded compared to their container and therefore leaves a
visible space.

Steps to reproduce the bug:

- On Chrome, add several shapes on a website page.
- Change the zoom of the page and change the window width.
- At some points, the gap will appear.

The least bad solution we found to fix this is to ensure that the width
of the shape elements is always as close to an integer as possible.

Reminder: several commits had attempted to fix this before ([1], [2],
[3], [4]). But that wasn't enough to stop it happening. Some shapes
still need to be fixed although that will likely be done in future
versions.

[1]: https://github.com/odoo/odoo/commit/c0f62593a4da37e8404dddc0a5762879a5ebbf7f
[2]: https://github.com/odoo/odoo/commit/ac82407b259eab929486bf0a333a48bc507efa60
[3]: https://github.com/odoo/odoo/commit/42b3ad10e0b32b7fc72f801e2c67d6baf938c566
[4]: https://github.com/odoo/odoo/commit/e386f318f5cff50901dba3db8a2587911ba02a6e

task-2824607
opw-3069213
opw-3057533

Part-of: odoo/odoo#107492

Steps to reproduce the bugs:
- In edit mode, choose the "contact" header template.
- Drag and drop a table of content snippet on the page.
- Save the page.
- Click on the table of content links.
- Bug => the links are not activated correctly.

The reason of the bug was that the scrollspy offset (calculated against
the header height) was not updating when the header height changed.

We did make a new call to scrollspy at the right time but that had no
effect because we first had to destroy the existing scrollSpy to be able
to make a new call that works.

opw-2951315

closes odoo/odoo#104092

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Before this commit, some tag would not display correctly in the tag list of eLearning

This commit fixes this behavior

closes odoo/odoo#108041

Related: odoo/enterprise#35003
Signed-off-by: Vranckx Florian (flvr) <flvr@odoo.com>

closes odoo/odoo#107866

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

closes odoo/odoo#107572

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

The motivation of this commit is to get a correct pathname on an
ir_logging when a test fail .

The main issue comes from subtest since an exception inside a subtest
will have only a partial traceback, not containing the line triggering
the error in the test method.

This can also affect debugging since a part of the stack is missing.

See pull request for more informations

Part-of: odoo/odoo#107572

Step to reproduce:
- Create an invoice with a product
- confirm it
- go to the product and change the uom

Issue:
Traceback

Cause:
https://github.com/odoo/odoo/blob/51ead4b2d52e0faec2065b475dac7f376328c425/addons/uom/models/uom_uom.py#L155-L159



Solution:
Prevent the user to change the uom of a product if this one is used in an invoice

opw-3039419

closes odoo/odoo#107553

Signed-off-by: John Laterre (jol) <jol@odoo.com>

closes odoo/odoo#106377

Signed-off-by: Julien Castiaux <juc@odoo.com>

Before this commit, it was possible to resize a column so that it
overflows the right border of the row.

Steps to reproduce the bug:
  1. In website edit mode, drop a `media list` snippet in the page.
  2. Select a column.
  3. Resize the column by dragging its left side to the right to make it
  smaller.
  4. Drag its right side to make it bigger and go until the edge of the
  editor => The column overflows and ends outside of the content zone.

This commit prevents the column from overflowing when it has an offset.

task-2837361

closes odoo/odoo#96993

Signed-off-by: Bojabza Soukéina (sobo) <sobo@odoo.com>

Commit [1] introduced the shape system. This system was able to chain
shapes depending on the shape of the previous sibling element.

Unfortunately, if the shape selected on the sibling was the last shape
available, clicking on the toggle shape button would result in nothing
happening.

This commit fixes that by defaulting to the first shape if no possible
shapes are given by the sibling.

[1]: https://github.com/odoo/odoo/commit/b84e0af742c51b88b4c108ebec2d0c7fff4b7483



opw-3082292

closes odoo/odoo#107951

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

When chaining multiple moves (like in a multi-step delivery), if
products are reserved on the previous moves of the chain, the products
won't appear as "Reserved" in the forecast report, leading to
inconsistencies between reservation done in stock and the one showed in
the report.

Steps to reproduce :
- Enable multi-step deliveries for this warehouse
- Put enough quantity in stock for a single product
- Create a Sale Order, validate it and the validate the firsts pickings
(i.e. pick/pack transfers)
- Create another Sale Order, validate it. Check that the quantity is
reserved in the first picking (i.e. pick transfer)
- Go to the forecast report, only the first SO will me marked as
"Reserved from Stock", even if both are.

opw-3074572

closes odoo/odoo#107939

Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

- Select the "Sidebar" header template
- Position it to the left (it's left by default)
- Select a website layout != 'full', like 'framed'

In edit mode, the menu will be floating in the middle of the screen.

Probably a bad adaption in commit [1] which refactored the code to move
the edition panel from left to right.
The rule was initially working fine for the left panel since [2].

Note that one might think that the rule should have been kept and
adapted to add the same behavior when the menu is positioned right but
this case was actually handled with [3].

[1]: https://github.com/odoo/odoo/commit/2abe8517063b2696cc89e9a453dcc3921fb3b8c7
[2]: https://github.com/odoo/odoo/commit/b30e47d81c1f71a66b1b6aa6846b52e080c25643
[3]: https://github.com/odoo/odoo/commit/f693c71b8c1b03367e00ec8f0f7854a239a9f097



closes odoo/odoo#107596

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>

This is a rare case where method _read() raises a MissingError instead
of just ignoring it.

The issue is triggered by several conditions on a model M:
 - at least one ir.rule on M with a domain using a column field on M;
 - one deleted record Y which is in the prefetch set of a record X;
 - one reads a non-column field on record X.

Fix method _read() to manage that case.  It adds an extra call to
exists() in that case, but adds no overhead in the general case.

closes odoo/odoo#107883

Signed-off-by: Rémy Voet <ryv@odoo.com>

Steps to reproduce the bug:
- Add a "Table of Content" on the website.
- Try to save a "Block" of the table.
- 14.0: you get an error message.
- 15.0: it keeps loading forever.
- 16.0: you get a white page.

Users should not have the possibility to save part of a snippet. The
goal of this commit is to ensure that the save option applies on a
snippet. If it is the case, the user has the possibility to save it. If
not, the user does not have the opportunity to save it.

opw-3056913

closes odoo/odoo#107012

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

The currency field shows as a badly aligned "in USD".
This PR adds a proper handling of the combinations
of accounting and multi_currency groups.

Original PR in v15: https://github.com/odoo/odoo/pull/104013



closes odoo/odoo#104814

Signed-off-by: Nicolas Viseur (vin) <vin@odoo.com>

closes odoo/odoo#105375

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Before this Commit, dates was not formatted based on user's language.

With this commit, we use format_date to correctly format dates.

closes odoo/odoo#107709

Related: odoo/enterprise#34894
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Steps to reproduce:

1- install any payment acquirer (e.g. stripe)
2- configure the payment acquirer and link it to a journal
3- try to delete the journal
4- the journal can be deleted which will create an internal server
error when this payment acquirer is used

Bug:

There is no restriction on deleting `account.journal` linked to
payment acquirers

Fix:

add a restriction that forces the user to remove the journal from the
payment acquirers first

OPW-3089006

closes odoo/odoo#107842

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Currently _compute_bulk_weight and _compute_weight are
going through each picking in self and each stock_move_line
in picking.move_line_ids to compute the pickings' weight.

This can be slow when there are lots of move_lines by pickings
as the field cache will be filled by the move_lines records
and uom._compute_quantity will be called once by move_line.

This is especially true for pickings with SN-tracked products.
For SN tracked products there will be one move_line by product_qty
(so a picking with 1 SN tracked product with a qty of 100 will have
 100 move_lines). In this case doing a read_group yields the highest
speedup.

Following the same reasoning a search_count is done in _compute_packages
before retrieving package.move_line_ids.
When package.move_line_ids.result_package_id is empty doing a count
is much faster as it avoids calling _in_cache_without for the package
move_line_ids. The search_count overhead is negligeable in the other
case so adding it leads to an overall speedup on average.

opw-3017013

closes odoo/odoo#107558

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

When checking if a line in traceability report is unfoldable,
`_get_move_lines` is a costly operation and should be executed last when
all other conditions are satisfied.

closes odoo/odoo#107677

Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

Computing the recurrences of a task repeating every X months until a
certain date generates too much dates

Steps to reproduce:
1. Install Project
2. Go to Settings > Project > Tasks Management and enable Recurring
   Tasks
3. Open any project in the Project app and create a new task then edit
   it
4. Enable the Recurrent field of the task
5. In the Recurrence tab, edit:
   - Repeat Every: 6 Months
   - Until: End Date: one year from now
6. The recurrence message says there are 11 tasks but there should only
   be 2

Solution:
Generate the recurrences until the `repeat_until` date is reached if the
`repeat_type` is 'until', otherwise generate as much recurrences as the
count
Also relax the constraint on the `repeat_day` and `repeat_until` to not
raise an error if `repeat_until` is the last day of the month

Problem:
The recurrence of a task with `repeat_unit` month and `repeat_interval`
different than 1 with a `repeat_type` until creates too much tasks,
exceeding the `repeat_until`

opw-3076593

closes odoo/odoo#106596

Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>

Steps to reproduce:
-install l10n_sa_invoice module
-switch to a company in Saudi Arabia (SA company)
-create and print an invoice with a product that has arabic translation

Bug:
When adding a product and the Arabic translation.
If we add an internal reference it is added to the template,
Odoo directly concatenates this with the product name.
The result is the product name being duplicated.

Fix:
display line name and add the translation if it's different

opw-2829934

closes odoo/odoo#100325

Signed-off-by: Josse Colpaert <jco@odoo.com>

The journal id from a purchase order was not
taken into account when creating the bill

Override _prepare_invoice method and add
the journal_id to the vals.

opw-3080805

closes odoo/odoo#106793

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

Follow-up reports were previously not handled by the commit fixing
invoices. This commit aims to fix that.

closes odoo/odoo#107540

Signed-off-by: Florian Daloze (fda) <fda@odoo.com>

Field `has_partner_email` depends on `partners_domain` field, which uses domain
widget. The domain widget may generate broken value.
This commit fixes it by checking that value in the onchange method.

STEPS:

1) go to coupon programs
2) click generate coupon
3) select <Number of Selected Customers>
4) click on domain field, and click the arrow back (nothing is in the domain)
5) if you click on the scrollbar, error appears (the same for any other click
that triggers onchange)

Alternative solution could be fixing the domain widget. But this looks as an
overkill for v14 for few reasons. First, the js client was heavily updated in v15+.
Second, the problem is quite specific for this module and v16 has not such usage
examples in standard modules.

opw-3062969

closes odoo/odoo#107325

Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>

Without this change, upgrades would generate the `pos_config_main`
record even in dbs with otherwise-well-organized structure.

Also, it might cause issues[^1] hard to solve otherwise.

[^1]: https://upgrade.odoo.com/web#active_id=421039&cids=1&id=421039&menu_id=107&model=upgrade.request&view_type=form



closes odoo/odoo#107718

X-original-commit: 1fc4b241
Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

Commit [1] improved the "sanitation" of this field for special
character. For instance, when copy pasting the following terms:

|      Input      |      Before      |       After     |
|-----------------|------------------|-----------------|
| fée d'été à 40€ |    f-e-d-t-40-   |  fee-dete-a-40  |
| Nội dung có Dấu |  n-i-dung-c-d-u  | noi-dung-co-dau |

But it actually came with a bad behavior which was not noticed: it
prevents to type `-` at the end of the input, which sounds good but is
not.
Indeed, when typing `a-word`, you will type `a` then try to type `-`
which won't work as considering a (forbidden) trailing slash, even if
you actually want to type something after.

This commit allows trailing slashes again, it's not a big deal and one
can remove it if he wants to.

[1]: https://github.com/odoo/odoo/commit/bb43d4dbb5745be84f0f9462e768989e50607bea



opw-3075419

closes odoo/odoo#107610

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

This commit enables the switch between the different tabs of a custom
tabs even in the editor mode.

Steps to reproduce the bug:
- Drag & drop a tabs snippet on the website.
- Save it ("save the block to use it elsewhere") as a custom block.
- When the editor mode is "on", it is impossible to switch between the
different tabs of the custom tabs.

The goal of this commit is to differentiate the ID's of the tab panes
located on the website and the ones of the corresponding custom model
located on the edit bar. In the case of the tabs snippet, it is
important in order to link the anchors of the tabs to their correct
tab pane. Indeed, before this commit, two tab panes (the one on the
website and the custom model on the edit bar) had the same ID's. The
anchors of the tabs on the website were linked to the tab pane located
on the edit bar.

opw-2988215

closes odoo/odoo#103635

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

update the module name of l10n_ma. Morocco is the real country name and currently upon searching with country name, app is not listed.

closes odoo/odoo#107598

Signed-off-by: John Laterre (jol) <jol@odoo.com>

For some reason, safari on mac is not showing the sidebar menu content
at all. It remains a white div without content.

Seems like a bad implementation of that browser for this case, or at
least an implementation which is not shared by all other browsers.

Note that removing `z-index`, `position:absolute` or `overflow` css
property from the `wrapwrap` will make the menu appear.
!!! Also note that having a non scrollable page (not enough content),
like an empty homepage, will make the menu appear too. !!!

As this issue is quite critical:
- All mac/safari users are not seeing your website menu..
- And the admin don't event know it most of the time (as not on mac)
And since:
- It's been going for months without someone finding a proper fix
- It's hard to investigate as devs generally don't have mac to
  investigate and have to use browserstack which is really bad for such
  work
This commit is a fix attempt using `calc` which is probably not ideal.

Step to reproduce:
- Select the sidebar header template
- Visit the website on safari
-> The menu will be invisible, like if the navbar was empty

opw-2984536
opw-2896939

closes odoo/odoo#107010

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>