Skip to content
Snippets Groups Projects
  1. Jan 28, 2016
    • Martin Trigaux's avatar
      [FIX] inter_company_rules: no warehouse defined on sale order · 366d5840
      Martin Trigaux authored
      With:
      
      Two companies 'Company A' & 'Company B'
      Sequences for SO & PO for each company
      so_from_po set to True on 'Compny B'
      When:
      
      Company A created a PO with Company B as supplier, and validated it,
      An error is raised "Configure correct warehouse for company(Company B)..."
      The field warehouse_id is required on the SO, so force the user to set one in
      the configuration of the company
      366d5840
  2. Jan 27, 2016
  3. Jan 26, 2016
  4. Jan 25, 2016
    • Denis Ledoux's avatar
      [FIX] stock_account: stock valuation at date total · ab245fca
      Denis Ledoux authored
      When performing a stock valuation at date,
      the stock valuation total wasn't equal
      to the sum of each line of the report.
      
      This is because the domain forcing the
      date wasn't passed to the `search` call
      when no group by was applied.
      
      Indeed, when calling
      `read_group` with a group by, the lines in the results
      contains the domain used for each line, but when
      there is no group by applied, this is not the case, the domain
      is not included in the line dict returned by `read_group`.
      
      In such a case, therefore, we must use the domain that was passed to
      the `read_group` call.
      
      opw-667761
      ab245fca
    • David Monjoie's avatar
      [FIX] mass_mailing: added missing models in form view · 11fe2d5b
      David Monjoie authored
      Backport of fda5021e that I
      erroneously did in 9.0, thinking it was reported on 9.0.
      11fe2d5b
    • Denis Ledoux's avatar
      [FIX] survey: matrix results after row deletion · 7ad309e0
      Denis Ledoux authored
      In a survey question of type `matrix`,
      nothing prevents to remove a row from the matrix,
      even if there are already answers for this line.
      
      If the case happens, the row is deleted, but
      not the answers. The answers are therefore orphan.
      The answers should probably be deleted when the
      row is removed from the survey, but this is a risky
      change, and, even, users might want to keep track
      of the answers given even if the line doesn't exist
      anymore in the survey.
      
      Therefore, we just handle the case when displaying
      the survey results,
      we ignore matrix answers for which the row no longer
      exists.
      
      opw-666393
      7ad309e0
  5. Jan 24, 2016
  6. Jan 22, 2016
  7. Jan 21, 2016
  8. Jan 20, 2016
    • Denis Ledoux's avatar
      [FIX] stock: state change tracking · d349584f
      Denis Ledoux authored
      The `stock.picking`.`state` field is set
      to track the change of values
      (`track_visibility='onchange'`)
      
      It's supposed to write the state changes
      within the picking thread.
      
      It does not work properly for function fields,
      as the onchange tracking is designed to work
      only with direct user changes, direct
      `write` operations on the record, while,
      here, the state value changes according to the
      picking moves changes, for instance.
      
      To solve this, the tracking changes have to be
      hooked within the `create` & `write` methods
      of the model on which this function depends on.
      
      Therefore, from now, when changes are
      performed in the moves, on the fields that
      could lead to the picking state change, we
      force the tracking of the picking state.
      
      In addition, we had the `mail_notrack` key
      in the context when creating back orders,
      to avoid displaying the back and forths
      in the state
      e.g. when transferring 9 units on 10, the
      changes were displayed as below:
      Draft -> Waiting availability
      Waiting Availability -> Ready to Transfer
      Ready to Transfer -> Draft
      Draft -> Partially available
      Partially Available -> Waiting availability
      Waiting Availability -> Transferred
      
      opw-666317
      d349584f
    • Nicolas Martinelli's avatar
      [FIX] purchase: currency of PO · 0b8e48dd
      Nicolas Martinelli authored
      When a PO is created automatically from a procurement, the currency is
      the currency of the connected user, which might be different from the
      currency of the pricelist.
      
      The fix set the currency to the currency of the pricelist.
      
      opw-665573
      0b8e48dd
  9. Jan 19, 2016
    • Goffin Simon's avatar
      [FIX] base: by default a company is not a customer · c0571d40
      Goffin Simon authored
      When creating a company, a new partner is created with his field
      'customer' = True. But by default a company doesn't have to be
      a customer.
      
      opw:667130
      c0571d40
    • Denis Ledoux's avatar
      [FIX] mass_mailing: statistics associated to deleted recipients · b7d98583
      Denis Ledoux authored
      When deleting the resource associated to a mail statistic,
      e.g. deleting the lead associated to a statistic,
      the statistic could not longer be opened.
      
      opw-656738
      b7d98583
    • Nicolas Lempereur's avatar
      [FIX] google_drive: use new spreadsheet id · 6f28b701
      Nicolas Lempereur authored
      When doing a copy of a google drive spreadsheet (in google_drive.py's
      copy_doc method, using the following google API call
      https://developers.google.com/drive/v2/reference/files/copy). Google
      server return an error if we used the old spreadsheet KeyId.
      
      The new FileId is available in the AlternateLink and this commit updates
      it.
      
      similar-to: 00c2a998
      
      opw-647222
      6f28b701
    • Goffin Simon's avatar
      [FIX] purchase: taxes_id in PO line · eefc76fd
      Goffin Simon authored
      When a PO line is created from procurement, the supplier taxes set
      on the PO line must be visible in the company set on the procurement.
      
      opw:666875
      eefc76fd
    • Joren Van Onder's avatar
      [FIX] point_of_sale: stop body rubberbanding on IOS devices · 434fa814
      Joren Van Onder authored
      Apple devices have a patented feature called rubberbanding that allows
      the user to scroll past the end (or beginning) of a document. Browsers
      on IOS have this same feature.
      
      This is not an issue most of the time. But sometimes the rubberbanding
      happens to the entire document.body of the POS, which is not
      ideal. Rubberbanding is already disabled partially by
      Chrome.disable_rubberbanding(). But it is not perfect. The most
      important issue that remained is what happens when a scrollable element
      is either at it's top or bottom and the user *initiates* a scroll past
      its beginning or end. So scrolling an element all the way to the top and
      then continuing to scroll did not trigger the problem. If however the
      element was already at the top and you would initiate a scroll up the
      scroll would fall through to the document instead and the entire POS
      would scroll.
      
      What aggrevates the issue from a UI point of view is that as long as the
      rubberbanding animation is not finished, any subsequent scrolls will
      target the entire document as well. Normal treatment of scrolling
      resumes only when the animation has finished and the document is in the
      center of the screen again.
      
      Stopping this behavior is not trivial. The only know solutions are all
      built around stopping touchmove events, which we already did.
      
      This patch makes it so that we also stop all touchmove events that
      trigger the unwanted behavior described above. It ensures that we stop
      touchmove events that would scroll an element above it's top or below
      it's bottom. To do this we have to manually determine whether or not the
      element is scrolled all the way to the top or bottom and we have to
      manually determine the direction the user is swiping.
      434fa814
  10. Jan 18, 2016
  11. Jan 17, 2016
  12. Jan 15, 2016
    • Denis Ledoux's avatar
      [FIX] purchase: origin concatenation · 9f7200a2
      Denis Ledoux authored
      This is related to revision 44eeb387
      
      The origin concatenation was not working
      when `procurement.origin` was `False`
      
      opw-666933
      9f7200a2
    • Denis Ledoux's avatar
      [FIX] website_event_sale: pay the displayed price · f9ee454d
      Denis Ledoux authored
      The price displayed on the event page is the
      `event.ticket`.`price_reduce` field,
      which is basically the ticket price(`event.ticket`.`price`)
      minus the possible discount applied by the pricelist
      
      Nevertheless, the price asked when ordering the ticket,
      in the cart/checkout, was the `ticket.price`,
      without the possible discount from the pricelist, therefore.
      
      The price asked for the ticket was therefore different than the price displayed.
      
      To reproduce:
       1. Settings > Sales > Use pricelist
       2. Sales > Configuration > Pricelist > Public Pricelist > Apply a 20% discount (-0.2)
       3. Go to /event, -> Conference on Business Applications
       4. Order 1 of each
       5. Notice that the price asked is 800€ and 1200€ instead of 1000€ and 1500€ respectively
       6. Hit Order now -> Notice that the price in the cart are the price without the discount
      
      opw-665540
      f9ee454d
    • Raphael Collet's avatar
    • Josse Colpaert's avatar
      [IMP] stock: avoid deletion of quants by user · 4bd64dc9
      Josse Colpaert authored
      Quants should never be changed or deleted by a user.
      We make it not possible anymore in the views.
      And also in the code we avoid to unlink without
      passing a specific key in the context.
      (as we still need to be able to delete quants in case of
      negative quants reconciliation)
      4bd64dc9
    • Joren Van Onder's avatar
      [FIX] pos_restaurant: stop ghost clicks on iOS · 870c0ca5
      Joren Van Onder authored
      On iOS (at least version 8.3 and up), both Chrome (at least 47 and up)
      and Safari emit ghost clicks [1] that added the product normally
      rendered under the table widget to the order. So when selecting a table
      without any orders you would end up with the table selected, and the
      product under the table in the order after just tapping the table.
      
      The issue is that on the table selection screen we listen to touchend
      events. On the product selection screen we listen to click
      events. Mobile browsers will usually emit both, first the touchend
      event, then a small delay, and then the click event. The small delay is
      platform dependent. Also, depending on a bunch of circumstances,
      browsers adjust this delay time (see [1] for more info).
      
      On Android this never caused issues because there the click is fired
      pretty fast after the touchend and more importantly, the click event
      still has the table widget as it's target. We don't listen to click on
      the table widget so it gets correctly ignored.
      
      On iOS there is a longer delay, and the click event is emitted with
      whatever target is currently under the coordinates of the click.
      
      In order to stop this from happening we'll just bind to click when not
      editing. When we are editing the floor layout we'll do what we did
      before.
      
      We also bind to dragend because on touch devices it is sometimes not
      easy to click, especially on small elements. You have to touch and
      release the screen without moving your finger. Because the table
      selection screen hides overflow there are no downsides to doing this,
      and it makes selecting a table much easier and less likely to fail due
      to accidental dragging.
      
      Calling preventDefault on the touchend event is another option but did
      not work on Android running Firefox 43.
      
      [1] http://ariatemplates.com/blog/2014/05/ghost-clicks-in-mobile-browsers/
      870c0ca5
    • Nicolas Lempereur's avatar
      [FIX] board: don't add default filter on dashboards · 759f98e6
      Nicolas Lempereur authored
      When displaying a dashboard, if a custom default filter was set on a
      view it would be concatenated to a given dashboard filter.
      
      Since it is never wanted and dashboard are embodied by fixed saved
      filters, thus not needing custom filter, this fix simply disable them
      when viewing the dashboards.
      
      closes #10477
      
      opw-660140
      759f98e6
  13. Jan 14, 2016
Loading