Before this commit, following these steps:
- Go to /blog
- Enable the customize option 'Top banner - Name / Latest Post'
- Disable the customize option 'Full-Width Cover'
- Search for the word 'helicopter' in the blog post search bar

Two problems are then visible:
1) The top banner is always visible with a blog post that does not match
the search. This top banner should not be visible (like for tag and date
searches).
2) There is an alert message 'No results for "helicopter".' while the
blog post 'Maui helicopter tours' matches the search.

This commit corrects both errors.

task-3058239

Part-of: odoo/odoo#105462

Add missing term "Shipping Adress"

opw-3198115

closes odoo/odoo#113958

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

Before this commit: if a different `web.base.url` is set with
`web.base.url.freeze`, during the first synchronization of Google
calendar it will show a mismatch URL error. The problem is that we
send the `redirect_uri` based on the `web.base.url` in the
`_get_authorize_uri` function.

The solution is to use the request root URL instead.

opw-3175539

closes odoo/odoo#113902

Signed-off-by: Arnaud Joset <arj@odoo.com>

Before this commit: it was possible to create an event for another user as
its organizer. But even if that user has a synchronized Google calendar, it
will be sent by the current user token, and it causes several issues.

The solution is to use the event's organizer token if it exists.

opw-3076595

closes odoo/odoo#110858

Signed-off-by: Pedram Bi Ria (pebr) <pebr@odoo.com>

In some cases, Odoo's move state is unaligned to that on the
IAP Proxy Server, because the ACK message from Odoo to IAP
deletes all attachments from the EDI transactions on the IAP
without regard if they are with type "Send" or "Receive".

We fix both cases by making Odoo just look at the state and not
to the attachment when it's not needed, and it's only needed when
there is a rejection of the document being sent.

We reserve for the future a change to the ACK to only delete the
attachments by transmission type (Send/Receive) so that they don't
interfere.

Error case 1:
- Odoo client sends an invoice to the IAP Proxy
- The IAP proxy will send it to the SdI
- If everything goes well, the SdI will send a notification back
- The IAP proxy sees the notification and saves it
- The Odoo of the client downloads the notification and sends an ack
- The IAP proxy sees the ack and deletes the attachment
- (ERR!) The client resets to draft, modifies and re-confirms
- The state of his invoice is set again To Send
- Odoo tries to re-send the invoice with the same Id Transaction
- The notification for that Id Transaction is already on the IAP proxy
- Odoo client asks for changes, but just sees the old notification
- (-->) The old notif. has no attachment, so Odoo thinks there's no news
- The move in Odoo stays in the To Send state forever

Error case 2:
- Odoo client sends a Tax Integration for a Vendor Bill (reverse charge)
- The IAP proxy will send it to the SdI
- If everything goes well, the SdI will send the same Vendor Bill back
  as the client's CodiceDestinatario is actually the recipient in the XML
- The IAP proxy sees the file, the Id Transaction is the same
  for both the received and the sent documents
- The SdI sends a notification because the tax integration is OK
- The IAP proxy saves the notification, there are now two EDI
  transactions with the same Id Transaction.
- Odoo checks for new documents
- IAP proxy sends the document to Odoo
- Odoo sends an ACK for that
- (ERR!) the IAP proxy sees the ACK and clears the attachment
  from BOTH the records for sent and received document
- Odoo checks for documents updates and gets the record without
  the attachment
- (-->) The notification has no attachment, so Odoo thinks there's no news
- The move in Odoo stays in the To Send state forever

Ticket link: https://www.odoo.com/web#id=3194378&model=project.task


opw-3194378

closes odoo/odoo#113666

Signed-off-by: Josse Colpaert <jco@odoo.com>

Before this commit, when moving inner content inside a carousel slide
(with the 'move' button), the carousel was jumping to the first slide.

Steps to reproduce the bug:

- In website edit mode, drag and drop a Carousel snippet onto the page.
- Move to the second slide.
- Click on the column to activate its overlay.
- Click and hold the "drag and drop" button of the column to start
dragging it.
- Release the mouse button.
- Bug: the carousel jumps to the first slide.

task-3006831

closes odoo/odoo#103086

Signed-off-by: Benoit Socias (bso) <bso@odoo.com>

To reproduce the issue:
1. Add French as a language to your profile
2. Install [CRM], [Resellers] on Apps
3. On [Settings]>[Website]
- set the language to French then SAVE
4. Go to [CRM]
- click [Configuration]>[Partner Level]
- click Gold
- click [Go to Website] at the top right corner
- adjective and subject order is not natural for French speakers

Desired behavior: Remove the word 'Partner' (show level only)

Impacted versions: 14.0 up to master

opw-3160102

closes odoo/odoo#113395

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

1. Install [Studio], [Accounting] on Apps
2. Enter [Accounting]
- Click the Studio icon second to left on the top right corner
- [Edit Menu]
- [NEW MENU]
- Fill in e.g.`Test`, select [Existing Model], Model: Payment Methods
- Click the icon on the right, check it is `account.payment.method`
- [SAVE & CLOSE]
- [CONFIRM]
- [CLOSE]
3. Click on `Test` menu created next to [Configuration]
- [NEW]
- Type in all info, click to Save
- Error is thrown

Desired: block users from creating a `payment.method` by all means

Impacted versions: 14-master

opw-3148453

closes odoo/odoo#113787

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

Before this change, when the recipient_single_description field was empty (the field is then false), the field box was still displayed before the number. Since the field is not editable there is just a blank space.

This PR hides the field when it is empty to avoid having the empty space.

closes odoo/odoo#105436

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Add missing translations to .pot

opw-3198115

closes odoo/odoo#113831

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

This commit addresses a bug in jQuery Draggable where the 'stop' event
did not trigger a 'mouseup' event outside of the dragged element window
if it was inside an iframe. This issue only occurred in Chrome (Firefox
was not affected).

In mass_mailing, this issue occurred in the email editor when the mouse
was released in the area above the editor. This error also affected the
Sign module, where elements can be dropped into a PDF, and where the
'stop' event of the dragging did not trigger outside of the iframe.

Steps to reproduce the bug in mass_mailing:

- Open the Email Marketing app.
- Create a new mailing.
- Choose the second available email template.
- Click and hold the "drag and drop" button of the first snippet (Your
logo) to start dragging it.
- While dragging the snippet, move the mouse outside of the email editor
iframe.
- Release the mouse button.
- Bug: the drop zones are still present in the DOM, and it is possible
to save the template with them.

opw-3164969

closes odoo/odoo#112979

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

PR: odoo/odoo#113475 replaced the computation of allowed_mo_ids with a
`pass` since this field was no longer needed anymore but could not be
removed in a stable version. This breaks the unbuild flow since this
value must be assigned and throws a ValueError without it, therefore
we now default allowed_mo_ids = False to avoid this error. (i.e. cannot
open any existing unbuild records + cannot validate new unbuilds)

closes odoo/odoo#113824

Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

An IndexError `list index out of range`  trace back that occurs in stock/
stock_move : _onchange_move_line_ids was caught by sentry.
because split_lines list is empty when user enter blank entry  in value.

So hear we check the split_lines is empty or not.

sentry - 3942491608

closes odoo/odoo#113353

Signed-off-by: Adrien Widart <awt@odoo.com>

Followup of odoo/odoo#110592

- Incorrect 0% soportado fp mapping
- Homogenize new tax names for import and intracommunity
- Incorrect tags for services import. And it should be both supported
  and subjected.

forward port of 3915e68a

closes odoo/odoo#113654

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

Before this commit, it was possible to drop a snippet in a non-editable
area (e.g. dynamic snippets).

Steps to reproduce the bug:

- Drop a "Dynamic Products" snippet in a page.
- Drop a "Columns" snippet in the same page.
- Moves a column from the "Columns" snippet into the "Dynamic Products"
snippet thanks to the "drag and drop" button.
- Bugs => It works when it shouldn't.

task-3054763

closes odoo/odoo#109156

Signed-off-by: Arthur Detroux (ard) <ard@odoo.com>

Closes odoo/odoo#83176

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

closes odoo/odoo#113690

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Making a dynamic domain with a  field is a bad idea
when the domain doesn't filter out the most of records. It can create a
performance issue, if the  contains too many ids, then
a lot of data will be exchanged to/from the server for each onchange which
slows down all the form views.

This commit is different from the original commit that we are backporting,
which was already present in the master branch https://github.com/odoo/odoo/commit/6f30f7959e15cf9b9a1fe8dd47e5f8c2c2e443c4
However, the changes made in the original commit would cause issues in
Stable versions due to a Python change that breaks the existing XML view.
Therefore, it's not feasible to apply the changes as they are
and it was decided to keep _compute_allowed_mo_ids.

task-2558097
backport-of: https://github.com/odoo/odoo/pull/71870/commits/6f30f7959e15cf9b9a1fe8dd47e5f8c2c2e443c4



opw-3133757

closes odoo/odoo#113475

Signed-off-by: Tiffany Chang <tic@odoo.com>

If there's a l10n_it_edi_transaction id on the move, then the move
has been sent to the SdI and it has received no rejection yet.
So we avoid showing the Reset To Draft button in that case.

Task link: https://www.odoo.com/web#id=3191726&model=project.task


Task-3191726

closes odoo/odoo#113085

Signed-off-by: Josse Colpaert <jco@odoo.com>

If one of the theme was not migrated to the new tx api, still support
the previous notation.
Happened on the design-theme repository

Backport of a8355ba3

closes odoo/odoo#113635

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

closes odoo/odoo#113559

Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

KeyError "sequence_code" occurs when creating a stock picking type. This is
because there is not a key "sequence_code" in vals.

This commit added the condition to ensure "sequence_code" key
is available in vals.

sentry-3828105626

closes odoo/odoo#112607

Signed-off-by: Adrien Widart <awt@odoo.com>

Creating a new partner with no company selected should raise the
same VAT partner warning if there is any other partner **in any**
company with the same VAT.

closes odoo/odoo#104367

Signed-off-by: William André (wan) <wan@odoo.com>

Before this commit: if "Automatic Receipt Printing" is enabled in a PoS
restaurant, and a printer is configured, an error will raise if the user clicks
on "New Order" before the end of the printing process.

To reproduce the issue, I added a sleep at the beginning of the
`_printReceipt` of `AbstractReceiptScreen`, and clicked on "New Order"
immediately after validating the order.

The solution is to keep the `currentOrder` in a variable before printing.

opw-3096677

closes odoo/odoo#111041

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

The `format_float` function is calling `float_repr`, which should not be
used for rounding operation (see its docstring). Instead, we should use
the `float_round` function.

opw-3171987

closes odoo/odoo#113216

Signed-off-by: Nicolas Viseur (vin) <vin@odoo.com>

Courtesy of Marianna (cima)

closes odoo/odoo#113524

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

The line was supposed to mention the remaining surplus,
not the total difference between input and output tax.

closes odoo/odoo#113523

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

Finland is comprised in the EAS list but is not currently supported in
Odoo. This commit makes UBL Bis 3 available for Finnish companies.

opw-3178684

closes odoo/odoo#113410

Signed-off-by: Nicolas Viseur (vin) <vin@odoo.com>

Current behaviour:
When trying the resend a snailmail that had a format error, by
adding a cover we get an error that a record we trying to access is
deleted.

Expected behaviour:
We shouldn't delete the letter that we are trying to resend.

Steps to reproduce:
- Install Invoicing
- Add an IAP account with some credits
- Create a contact with a reallllyyyy long address, to overfill the
  fields.
- Create an invoice for that customer, try to print/send a snailmail
- It should fail without a message, then scroll down to the red
  paperplane, add the cover and update resend, you get an error
  about the missing record.

Reason for the problem:
This legacy code, so maybe in the past it used to work a bit
differently. When trying to resend the letter, we are unlinking it's
attachment (reasons for that are unknown to me), which is linked
with a `Many2One` with letter with a cascading delete, so we end up
deleting the `snailmail_letter` that we are iterating over, then
when trying to write, it throws the error.

Fix:
Remove the link between the attachment and the letter before the deletion
of the `attachment_id`, so the letter is not being deleted.

Affected versions:
- 14.0
- 15.0
- saas-15.2
- 16.0
- saas-16.1
- master

opw-3111774

closes odoo/odoo#113005

Signed-off-by: Piryns Victor (pivi) <pivi@odoo.com>

backport of 46040d11

closes odoo/odoo#112841

Signed-off-by: Rémy Voet <ryv@odoo.com>

Steps to reproduce:
- Create a new journal Bank
- In Sequence, find the 'New Bank Check" and edit it so the sequence can be 10 number digits long
- Create a Vendor Payments with the the New Banck and Check as a method
- Click on Print a check
- Set any number > 2147483647 and validate

Issue:
Traceback

Cause:
The query SQL make a check to verifiy that the number is correct ('025'::integer == '25'::integer but '025'!='25)
But using INTEGER limits the number up to 2147483647 (https://www.postgresql.org/docs/current/datatype-numeric.html

)

Solution:
Use BIGINT whose limit is 9223372036854775807

opw-3140973

closes odoo/odoo#112832

Signed-off-by: John Laterre (jol) <jol@odoo.com>

To reproduce the issue:

- Website > Edit mode > Click on header
- Change the shadow color of the header to a suggested gray > it only
  works with normal colors but not grays.
- Change the header to "Header full" (it has no shadow by default)
- Add a shadow > It works
- Change the shadow color to a gray > it is reverted to no shadow.

To explain what happens exactly, let's suppose we want to set the gray
color from the custom property "--900":

When this color selected on colorpicker, the `customizeWebsiteVariable`
method will update assets to set a new user value:

`'menu-box-shadow': var(--900) ...`

But when the SCSS is compiled, the property name (here "--900") is
computed as a number which generates a wrong CSS value: `var(900) ...`

The goal of this commit is to prevent this behaviour by protecting
colorpicker variable names so they cannot be used for any further math.

task-3069518

closes odoo/odoo#105916

Signed-off-by: Arthur Detroux (ard) <ard@odoo.com>

In DB with lot of product.template with this domain [('barcode','!=','truc')] it is possible to get a MemoryError.

closes odoo/odoo#113254

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

There is only one legitimate usage of `_patch_method` (base_automation)
and none of `_revert_method`. The other uses are in tests and they are
all wrong: if the test crashes between the `_patch_method` and the
`_revert_method`, the method will not be reverted.

For the only proper usage of `_patch_method`, move the code to this
place. Correct tests using `_patch_method`/`_revert_method` by calling
the `patch` method of `BaseCase`.

Also, remove the `api.returns` from the `create` method of `BaseModel`
as it is useless and confusing. In fact, we never use it because we
have a special treatment at the RPC level for the `create` method
(see `_call_kw_model_create`).

closes odoo/odoo#110370

closes odoo/odoo#113171

Signed-off-by: Raphael Collet <rco@odoo.com>

- l10n_it_edi_sdicoop: EDI receiving cron error handling fix
If we cannot receive invoices or bills from the IAP proxy we also can't
iterate over them

- l10n_it_edi: Check edi_format before trying to remove signature
The edi_format must be checked before trying to remove the eventual
PKCS#7 signature from the file, otherwise we're uselessly going to try
and remove the signature for every edi_format check (facturX etc.)

- l10n_it_edi: .p7m files can wrongly be missing the signature
In the case that the .p7m extension is put by mistake, try to use the
content of the file as it is before discarding it.

Task link: https://www.odoo.com/web#id=3189457&model=project.task


Task-3189457

closes odoo/odoo#112845

Signed-off-by: Josse Colpaert <jco@odoo.com>

To reproduce the issue:
1. In Settings:
   - Days to Purchase: 10
2. Create two products P01, P02:
   - Storable
   - With the same seller
     - Delivery Lead Time: 1.0
3. On replenishment page, create a new line:
   - Product: P01
   - Min Qty: 1.0
4. Order once
   - a RfQ is created and the order deadline is in ten days
5. Time travel to the next day
6. Repeat steps 3-4 with P02

Error: a second RfQ has been generated. However, as the first one is
still in draft state, the POL of P02 should be added to that first RfQ

When processing the orderpoint of P02, at some point, we try to find
an existing RfQ with its order deadline equal to `today + 10 days`.
Since we are the next day (step 5), the order deadline of the first
RfQ is `today + 9 days`, so we don't find it.

OPW-3047931

closes odoo/odoo#112687

Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

In Switzerland, an ISR payment file was to be added to an invoice.

This file has since been replaced with the QR Bill: https://www.pikon.com/en/blog/everything-you-need-to-know-about-the-swiss-qr-bill/



Removed the buttons allowing for the printing of ISR files, while keeping the variables and functions linked to it to follow stable policy.

Those options will be permanently removed from 16.2.

task-3040400

closes odoo/odoo#110660

Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

Before this commit, no check was made on conditional questions to see if their
condition was valid when taking a survey.

With this commit, if the survey is not in "random mode" (in which case,
conditions do not apply), there is a check to see that a conditional question
has a valid condition. If not, it is not used in the survey.

Task-3083488

closes odoo/odoo#110236

Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>

Steps to reproduce:

- Install mrp_workorder
- Edit product Table > Inventory tab > Tracking: No Tracking
- Manufacturing Orders > Create order for Table > Quantity = 3
- Confirm > Work orders tab > Open Tablet View
- Change the number of units to produce in the top from 3 to 2.
- Pause > Continue

Issue:
The quantity to produce is reset to the original amount.

Solution:
Do not reset the qty_producing when it is already set.

opw-3032052

closes odoo/odoo#113046

Signed-off-by: Tiffany Chang <tic@odoo.com>