- Jan 11, 2019
-
-
Géry Debongnie authored
Before this commit, the web client had a naive strategy to handle lost connections: it tried to poll the server every 2 seconds until a rpc succeeds. This works quite well from the perspective of the user, but may be a problem from the perspective of the server. If a server is down for a longish period, then each users active tabs will then perform a request every 2 seconds. This means that the server will be progressively hammered by many requests, which will clutter the logs, and make it more difficult to gracefully recover. With this commit, we simply exponentially increase the delay each time, and add a little jitter to give a better distribution. closes odoo/odoo#30136
-
- Jan 14, 2019
-
-
Christophe Simonis authored
The field `reference_type` has been removed with b5bb5bd4 Adapt newly forward-ported test to not use this field.
-
- Jan 11, 2019
-
-
Christophe Simonis authored
-
Christophe Simonis authored
Followup of 3b85900f Courtesy of Swapnesh Shah (@sswapnesh)
-
Pierre Rousseau authored
The field ignored is set in javascript on company object to filter the ones we want to show. As it is not an odoo field, it triggers a traceback when the trigger_up 'field_changed' is called. OPW-1921568 closes odoo/odoo#30153
-
Yannick Tivisse authored
Purpose ======= Since 9c5f930f, the double holiday is computed from the wage with holidays. When we compute the employer costs, we should take the original wage, not the adapted one, to keep fix employer costs, whatever the amount of days the employee takes. closes odoo/odoo#30149
-
Jorge Pinna Puissant authored
opw-1918789 Before this commit, the addresses (invoicing and shipping) in the SO wasn't displayed in the same way in the portal and in the report. Now, the addresses are displayed in the same way in both the portal and the report. closes odoo/odoo#30093
-
Nicolas Lempereur authored
Following 4a3fd02a on the portal when displaying an invoice we may get a report_type variable (with value 'html' or 'pdf') on the portal. This was used to not display the page number when checking the report, but when the report is printed in the backend this report_type was unset so the page number was mistakenly removed too. With this changeset, the report alway know if he is pdf, html or text and only print the page number if it is of type pdf. opw-1924729 closes #30095
-
Romain Derie authored
Since panel collapse became card collapse while migrating from BS3 to BS4 with commit 59237ea8, it is impossible to open the card content. Indeed, there was already data-parent attribut pointing to inexisting DOM element. This was not an issue in BS3 but BS4 is not working with it. closes odoo/odoo#30142
-
- Jan 10, 2019
-
-
Christophe Simonis authored
Since 5efec7cc, ProjectPlan widget expect actual html.
-
Christophe Simonis authored
-
Christophe Simonis authored
-
Christophe Simonis authored
-
Christophe Simonis authored
-
Christophe Simonis authored
SQL improve the speed of the implied group VS the orm version. closes odoo/odoo#30108
-
Christophe Simonis authored
-
Christophe Simonis authored
-
Nans Lefebvre authored
During uninstallation of a module, recompute operations may be triggered. The prefetch might thus try to read a column that has already been deleted. Install CRM, create an opportunity then schedule a meeting (itself a calendar event linked to the opportunity). Note that the CRM module adds an opportunity_id field on events. When you try to uninstall the module, the bug is triggered. The calendar model contains a res_model field, which is related to res_model_id. Its recompute triggers the prefetching of the opportunity_id field, which has already been removed. opw 1917354 closes odoo/odoo#29979
-
- Jan 11, 2019
-
-
Alexandre Kühn authored
Before this commit, the process of positioning chat windows could fail if one of the tabs had discuss open. When a chat window was hidden and become visible, the algorithm was not updating the state of the chat window to "visible" when discuss was open. As a result, it was always trying to make it visible, resulting in an infinite loop and raising the following error message: `Uncaught RangeError: Maximum call stack size exceeded` This commit ensures it works even when discuss is open. opw-1919327 closes odoo/odoo#30137
-
Jorge Pinna Puissant authored
opw-1921686 The failed mail notification group all the records of the same model that failed to send an email. Before this commit, the failed mail notification displayed as title the name of the last record that failed to send an email. Now, the notification displays as title the model name. closes odoo/odoo#30134
-
- Jan 10, 2019
-
-
Martin Trigaux authored
This commit adds a test to test the scenario fixed in the parent commit. Creating a new test module is necessary as the bug is only revealed when the current module is different than the model._original_module (cf c9837ac5) Before that commit, was failing only the second search of test_ir_model_data_inherits_depends. Add other test to avoid regression of the bugs corrected at 574f4c3d and c9837ac5 closes odoo/odoo#30116
-
Martin Trigaux authored
On a field created through a _inherits, the fields on the child model did not benefit from the parent _modules information. If two models are created in module base class Partner(models.Model): _name = 'res.partner' class User(models.Model): _inherits = {'res.partner': 'partner_id'} partner_id = fields.Many2one('res.partner') and a second module auth_signup adds a field on the parent model class ResPartner(models.Model): _inherit = 'res.partner' signup_token = fields.Char() Both res.users and res.partner should have an ir.model.data create base_setup.field_res_partner__signup_token was correctly created but base_setup.field_res_users__signup_token was not created The reason is was, in the call to _reflect_model, since 574f4c3d, the creation of ir.model.data is based on the field._modules However, the field res.partner.signup_token did not propagate its _modules value to the related field res.users.signup_token With this patch, both ir.model.data are created. This allow a proper uninstallation of fields as well as translation.
-
- Jan 11, 2019
-
-
Christophe Simonis authored
Avoid matching terms that will be discarded when synchronising translations. opw-1921639 opw-1923669 opw-1921933 opw-1921509 opw-1919989 opw-1917321 opw-1916782 opw-1915683 opw-1900821 opw-1891187 closes odoo/odoo#30114
-
- Jan 09, 2019
-
-
Lucas Perais (lpe) authored
the search method should return a Deferred as explicit in MediaDialog OPW 1919549 closes odoo/odoo#30077
-
- Jan 08, 2019
-
-
Christophe Simonis authored
The prefetch hell patch [1] generate one more query. [1] a07a076c
-
Jorge Pinna Puissant authored
opw-1916965 Before this commit, the price printed in the product label was the list_price (catalog price) it didn't take into account the extra price of the variants. Now, the price printed is the lst_price (catalog value + extra). closes odoo/odoo#30039
-
- Jan 10, 2019
-
-
Aurélien Warnon authored
Task #1923443 Purpose ======= When adding a like/dislike to a slide, the like/dislike counter was not properly updated. partly closes #29901 closes odoo/odoo#30027
-
Aurélien Warnon authored
Task #1923443 Purpose ======= Probably due to the migration to bootstrap 4, the active tab panel in the 'slide_detail_view' was not displayed on page loading (and only when switching back and forth in the tabs). partly closes #29901
-
Lucas Perais (lpe) authored
Make an expense report containing 2 expenses one of them has tax exigible on payment Validate the whole thing and make a payment Before this commit, the journal entries were wrong this was because: - there were 2 move lines in the payable account Each of them wanting to reconcile with the payment, and each of them trying to create an cash basis entry - the amounts were incorrect too, as the matched percentage was computed on move lines that were not in a payable/receivable, but in taxes accounts OPW 1912247 closes odoo/odoo#29878
-
- Jan 11, 2019
-
-
Pierre Masereel authored
PAYPAL ------ The paypal tests are not working working for two reasons: - we check that there is no date in pending state on payment transaction, but since the refactoring in this commit: https://github.com/odoo/odoo/commit/01216345e28374b554bfe95df82d607c591271cf the date is always set before the validation of transaction. - Since the changes on dates, the datetime field doesn't return a string anymore and the comparison fails. So we convert the datetime to string for the comparison. BUCKAROO -------- The buckaroo tests were not working for multiple reasons. STRIPE ------ The payment stripe tests were not working because: - The reference set in transactions were not the same as the ones givent to the payment provider. - we were checking for a script tag in form that has been removed in commit https://github.com/odoo/odoo/commit/7c639be4aadce20bf6662ab347470fadf9afd99f AUTHORIZE --------- This test cannot be tested on runbot due to its server to server way of working closes odoo/odoo#30105
-
- Jan 10, 2019
-
-
Pierre Masereel authored
The field partner id is not a required field in payment transaction, and we try to read its value in the dictionnary given to the create function, so if a transaction is created without the partner_id, it will raise a KeyError. So to fix it, we only complete the pratner values on the payment transaction if a partner_id is given.
-
Jorge Pinna Puissant authored
opw-1922531 Before this commit, the product's description for customers was not translated in the invoice. Now, the product's description for customers is translated in the invoice. closes odoo/odoo#30107
-
qsm-odoo authored
In the 'banner' snippet, there is a column using a white jumbotron component. Those comes with a default background color so when using the website builder to remove the white background, it did not go away; it was replaced with the default background color (some gray). This commit sets the default background color of jumbotron components to 'transparent'. task-1889341 closes odoo/odoo#30099
-
Jairo Llopis authored
closes odoo/odoo#28628
-
Quentin De Paoli authored
utils.round_precision() is expecting a float as precision (0.01) whereas utils.round_decimals() is expecting the number of digits to consider after the coma (2). The previous code was totally wrong in that regard, which led to reconciliation wrongly considered as total in foreign currency, as long as the amount_currency difference was lower than the currency precision digits. closes odoo/odoo#30091
-
- Jan 09, 2019
-
-
Sébastien Theys authored
* website_theme_install This commit will add MODULE_UNINSTALL_FLAG to the cleanup methods of themes and modules. This is necessary to also unlink inherited views of those we try to unlink. Before this commit, an error would be raised when trying to delete a view that still had other inherited views (either created manually by the user, or with just bad luck in the order of which the views are deleted). PR: #29753
-
Sébastien Theys authored
If a module has a view that has been copied (copy on write, web editor, customize show, manual copy, ...), currently the copied view will not be deleted if the module of the original view is removed. If the copy is not used anymore, it is not a problem (but still polluting the database), but if the copy is still used (ex. it is an inherit of a view still in use), then it will crash if that copy references other data (views, fields, ...) that were in the module that is now removed. Eg. The view `website_sale_comparison.product_add_to_compare` is inheriting `website_sale.product` and calls `website_sale_comparison.add_to_compare`. If the view `website_sale_comparison.product_add_to_compare` is copied (when using the web editor on the product page -> copy on write is making a copy of the `product` view and all its tree), then the product page on website will crash when the module `website_sale_comparison` is removed because `product_add_to_compare` will call the deleted view `add_to_compare`. The solution is to also remove copied views when removing a module. Instead of just using the xml id, we should look for the `key` starting with the module name currently removed, because copied views don't have an external id. task-1920005 PR: #29753
-
Sébastien Theys authored
`ref` could raise even if raise_if_not_found was False on `viewref`, now we prevent that, and rely only on the exception on `viewref`. Also, when not set to raise, the method could return None instead of a recorset. PR: #29753
-
Sébastien Theys authored
PR: #29753
-
Sébastien Theys authored
This comment is not true, we originally wanted to code it this way but we changed our mind and forgot to remove the comment. PR: #29753
-