opw-2294930

The tax amount not included in price should be computed in the remaining
balance, even if not included in price.

closes odoo/odoo#54356

X-original-commit: 6a6aefdfac472421b9cf6de043682a6cdc131d85
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

The fact that led_status.sh was still running when performing the
`git reset --hard` made it impossible to remount the filesystem in RO
mode, due to a `mount point is busy` error.

Instead of starting the led_status_sh script from rc.local, we make it
a service so it can be easily restarted when an update is performed.

closes odoo/odoo#54353

X-original-commit: 2ad99d3b
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
Signed-off-by: Antoine Prieëls <aprieels@users.noreply.github.com>

The label of some buttons is updated on-the-fly, and the code which
does that was actually altering the structure of the button widgets
instead of just the labels' text. This code should be made more robust
in master.

closes odoo/odoo#54324

X-original-commit: 5eb25c482eeaf68e30fd9f5b2fbe889f9b53c954
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

In Sales, in Payment Link generation wizard, when entering manually the total of the quotation
as Amount, it can happen that the Validation Error asking to set an Amount smaller than the total
is triggered.

opw-2287794

closes odoo/odoo#54309

X-original-commit: a7034b75
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

The custom 'to consume' widget wrap the classic float widget into a
<span> tag to add a non editable part to display. The issue this commit
fix is the following: the float widget element is this.$el in
_renderEdit. Appending it to a new element make it loose its link to the
DOM. The custom widget is totally blank.
This commit clone this.$el before surrounding it by the new span

Task : 2278147

closes odoo/odoo#54042

X-original-commit: 01bb1fce77cce3d54cd969e643b7c720673f2b22
Related: odoo/upgrade#1451
Related: odoo/enterprise#11645
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

This commit bring together sanity check functions called during
production order validation in a separated method. Other modules will
override it to add other sanity checks.

Task : 2278147

X-original-commit: e11f8da6674e9a21ab61d0aa67ef1797752273e2

If the consumption wizard is triggered in a workorder (via 'Mark As Done
And Close MO'). We would like the confirm button redirect to the
workorder list view afterwards.

Task : 2278147

X-original-commit: 55e2a4d16d3a56b8f509d2d67a344c53d62474b6

The Table (MTO) production hasn't its finished moves created in the demo
data. This lead to the impossiblity to mark as done the production
order.

Task : 2278147

X-original-commit: d6e20db6f6b372707a67ec63d71a1c2737511765

Duplicate a BoM with operations and some BoM line consume in specific
operation. The operations are well duplicated but the 'consume in
operation' field still point to the original BoM's operations.

This commit search for the operation to replace based on the name and
the workcenter_id.

Task : 2278147

X-original-commit: 4c6d445dfd561a236b1b171ccbcc2ff2b6236640

Consuming all the components for only a part of the finished product
will ask the manufacturing user to create a backorder. Confirm it will
fail as there are no component left to consume to produce the
remaining quantity of finished product. This commit only confirm
backorders that still have some quantities to consume.

Task : 2278147

X-original-commit: 51c9281d715e27143955c7b9b51f60b22e672f52

This commit makes some changes in the production order views
as well as in the workorders one. This commits make sure there
is now only one form view left for the mrp.workorder model.

This commit take part of the MRP refactoring
(69c48add)

Task : 2278147

X-original-commit: 8b389ab3601cf5ed9328b7ce55ee91d54aa70150

Issue

	- Accounting > General ledger
	- Have 2-3 lines in the table
	  I added filters to have them
	- Toggle optional columns: (...) on the right

	There is an y scroll but you can't scroll
	more than half of the scrollbar.

Cause

	The cause is that the dropdown height is greater
	than the table height.

Solution

	Use data-display: static this way the element doesn't
	scroll with parent scroll and scrolling is working
	as expected on the dropdown

OPW-2291531

closes odoo/odoo#54320

X-original-commit: 9afd7b7e
Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>

Commit [1] merged a debug console.log. This commit removes it.

[1]: https://github.com/odoo/odoo/commit/6df67a28c2f113572acd4a3db19ab6b1bd37e7da

Part of https://github.com/odoo/odoo/pull/54311



closes odoo/odoo#54311

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Commit [1] introduced at least 2 linter errors, which this commit is
fixing.

[1]: https://github.com/odoo/odoo/commit/6df67a28c2f113572acd4a3db19ab6b1bd37e7da

Part of https://github.com/odoo/odoo/pull/54311

The linter would miss / fail to warn on injection of *local variables*
in some cases.

Try to improve it to be stricter and more reliable, after discussion
with odo, sql which is "correctly" dynamic should use psycopg2's sql
package in order to bypass the linter (bonus: it should also properly
escape & quote identifiers).

closes odoo/odoo#53938

Related: odoo/enterprise#11718
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

*: web, web_editor

Instead of three lists + one map to define font information and user
choices saved as the index of the related fonts in those lists, the
fonts are now stored in an unique map <font-name> -> <data> and the
user choices are saved as the font name. This allow to have a visually
better definition of the fonts and allows to reorder fonts in the UI
without losing user customization (and actually simplify some code).

Unfortunately any user font customization < 14.0 will be lost, but this
is a small price to pay (users can still rechoose the same font in the
editor UI where they will go anyway to discover all the new shiny
features we are introducing there).

Part of https://github.com/odoo/odoo/pull/54065


task-2291398

closes odoo/odoo#54065

Related: odoo/design-themes#269
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

*: website

Make sure strings are printed quoted and null values are not printed.

Part of https://github.com/odoo/odoo/pull/54065
task-2291398

This is a huge mistery. But this particular `align-items: baseline`
rule, introduced by [1], yields a red runbot ~20% of the time.

As it is not stricly necessary in current master (but necessary if the
font changes which will be the case in the upcoming days), this commit
simply removes the rule temporarily.

[1]: https://github.com/odoo/odoo/commit/94b59b1972e1a18e18dfcd6c2ded495391380b9a

Part of https://github.com/odoo/odoo/pull/54274



closes odoo/odoo#54274

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

A mockRPC was catching the route to transparent.png file which has been
relocated with [1]. This commit solves that unadapted mockRPC and makes
it easier to grep.

[1]: https://github.com/odoo/odoo/commit/94b59b1972e1a18e18dfcd6c2ded495391380b9a

Part of https://github.com/odoo/odoo/pull/54274

- Seta a value for the `ir.config_parameter` `mail.catchall.domain`
- Enroll user A to a course
- Add new content to the course
- Publish it
  => an email is sent to the users enrolled
- Reply to the email

The reply is considered as a review of the course.

It is not intended that users reply to such email; they are 'one-way'
notifications.

A solution is to be able to set the `reply_to` field on the mail
template. This way, it's possible to set it to a `noreply` value.

opw-2290521

closes odoo/odoo#54281

X-original-commit: 7ffc300e7c857bf743d7ab25631f9ee02419dea1
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

In an app using rating (e.g. eLearning), get 3 ratings:
- A 5-star review
- A 3-star review
- A 0-star review

The average is 2.5 stars, while it should be 4 stars.

This happens because the 0-star review is taken into account in the
average computation, while it shouldn't. Indeed, zero star means no
review.

We apply the same login than:
https://github.com/odoo/odoo/blob/0028a602bea6a48aaa2747127ec075394732b324/addons/rating/models/rating_mixin.py#L205



opw-2290617

closes odoo/odoo#54279

X-original-commit: 4f7981f8
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

There are orm models that don't have _rec_name defined. The orm doesn't
allow creation of record via name_create if _rec_name is not defined in
the model. This commit considers this fact, such that if name_create
returns false, we don't proceed on displaying the non-existing record.

Note: _rec_name defaults to 'name' if not specified so only few models
don't have _rec_name.

closes odoo/odoo#54270

Task-id: 2285036
X-original-commit: 676c2b8e4fdf7347d44bc5afb7ca51d39338a527
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Some demo messages have a grey background because they have the subtype_id set to
NULL.
The subtype should be `mail.mt_comment`, like other messages inside the general channel.

task-2278438

closes odoo/odoo#54261

X-original-commit: 9be1079cc62699d119b9c2acc6282bd72f71f9af
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Changing the driver on a car shouldn't change the
fleet.vehicle.log.services associated. We should keep the driver
assigned to the car at the time the service was done.

closes odoo/odoo#54264

Taskid: 2208080
X-original-commit: 5422bb8d6e3db5d6932570116af74ea634c40a51
Signed-off-by: Paul Morelle <madprog@users.noreply.github.com>

When creating a new service on vehicle, the first vehicle was always
selected by default due to a wrong default value. Same thing for the
contract.

Taskid: 2289808
X-original-commit: 9ec3875249748929c4a8e0c8a16e7b729ab9f2d9

The license plate was not shown on the view due to a wrong t-if value.

Taskid: 2289808
X-original-commit: 474322a7f5ee346b4d57b07818fd79801b93f574

Adjacent buttons are not displayed in a single column. When the
table overflows, we try to squeeze largest columns to make it fit
into its container (in this case, text may be clipped and an
ellipsis is displayed). Button columns didn't get away from this.

As a consequence, now that a cell may contain several buttons,
some of them may be clipped and replaced by the ellipsis, which
isn't what we want for buttons.

This commit removes the button columns from the list of columns
to squeeze, so we let the browser reduce them as much as it can,
and we keep them as they are.

Task 2282470

closes odoo/odoo#54258

X-original-commit: e00960daa3ed3d1fd3a7572b2acedd3d2fb0448e
Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Edit in backend now redirect to related apps, and no more in website Apps

closes odoo/odoo#54208

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Add the possibility to call services from posmodel. At the moment,
this is needed to call the `iot_longpolling` service from `DeviceProxy`.

closes odoo/odoo#54229

Related: odoo/enterprise#11708
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

Go to invoice list view.
Select several invoices, click on 'Send and print', switch template to a
different one (possibly a duplicate of the default).
Send

On each selected record there will be a pair of attachment:
- one belonging the the record (ok)
- one duplicate from the first record selected (not ok)
This occur because when switching template the default composition
mode for the wizard is 'comment' (single send), which causes the wizard
to compute and store the attachment of the first record it found.
Later, this get assigned to the list of attachment to send so it
duplicated (and sent) in all other records

opw-2291274

closes odoo/odoo#54255

X-original-commit: 0028a602
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

with this commit ce0700ce401523267b5a8bd5665a368cfea24912
we lose the compatibility with olders version of Odoo

So we keep the vesion of IoT box in the same place
for olders version of Odoo

closes odoo/odoo#54242

X-original-commit: 0215ff3fd7a353c4f191a1cb93fdce6d0db78fa0
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

Before this commit:
In helpdesk_timesheet, we have a compute_task_id with super.
But in hr_timesheet, task_id is not a compute field, so this
compute has no effect.

After this commit:
Task_id is changed to compute stored field.

taskId 2285926

closes odoo/odoo#54117

Related: odoo/enterprise#11682
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Update mail alias layout, makes email address
clickable (mailto) and fix a couple of typos.

Task ID 2287394

closes odoo/odoo#53960

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Prior to this commit, the autoscroll on drag feature was accessible and only
used in the web_editor application.

After this commit, the autoscroll on drag feature will be available in the
web application and has been refactored in order to allow its usage
in other application (as for the sign application).

task-2280965

closes odoo/odoo#54072

Related: odoo/enterprise#11656
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

* Make Connect button primary if the Reconcile button is not shown
primary)
* Rollback the change "Create Manually" > "New Invoice"

closes odoo/odoo#54250

X-original-commit: e50b378520aa7d9674ee3dca169365eeb1ecac85
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
Signed-off-by: wan <william-andre@users.noreply.github.com>

task-2171877
task-2282377
task-2282382

closes odoo/odoo#54249

X-original-commit: acf8eb3e2e49c1ade638ff1f2fed4969f9944053
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

- Follow button is now correctly aligned in document app chatter overlay
- Topbar does not move up anymore on select Send Message or Log note

task-2287136

closes odoo/odoo#54247

X-original-commit: 6f05705158a7a197945e6720f5ac231ce6932686
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Issue

	- Install eCommerce
	- Modify a product image with one which
	  has more than 1024px width/height to
	  enable zoom (I used: https://bit.ly/2VETQZS

)
	- Go on the website preview & hover the image

	Depending on the screen size, a part of the
	flyout is hidden because of overflow-x
	if you want to see it, you should scroll
	right width right arrow key.

Cause

	The flyout has 100% width and is put
	right (position absolute, left: 100%)

Solution

	To avoid this error on all screen size,
	the solution is to compute the max-width
	of the flyout depending on the available
	space on the right.

OPW-2283648

closes odoo/odoo#54222

X-original-commit: c89b4c25
Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>

Issue

	- Runbot 13.0
	- Website > Contact Form
	- Double click on send button

	Link dialog opened, ok

	- Discard
	- Double click on send button
	- Click link button

	Traceback

Cause

	The next double click doesn't work
	because in rte.js RTEWidget._onMousedown
	we remove the target's contenteditable
	attribute and it's never added back.

	This is because we break if the element
	is not editable.

	The traceback is a side effect,
	since we can't select the button
	anymore, our selection is incorrect
	and getLinkInfo use range.create()
	try to use it.

Solution

	Break only if the target is not
	a '<a>' & non-editable element

OPW-2268595

closes odoo/odoo#54221

X-original-commit: 460bc102
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>

1. set a Sales team and add an alias
2. create a contact (customer) with an email and grant them portal
access (under the action)
3. Odoo creates a portal user
4. use the email of the contact to send an email to the alias set under
the sales team

An opportunity is created but the sales person assign to that
opportunity is the customer.

This will revert user if the user has no access to crm.lead

opw-2288442

closes odoo/odoo#54217

X-original-commit: a3fdff3d
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>