Follow-up on https://github.com/odoo/odoo/commit/22f02af6bf002324ebafc38d4eefeda60063247a


Use the correct reference for the file.

closes odoo/odoo#44919

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Followup on 5ce8f1e3
Before this commit, There would be traceback on Launching Plan with `Responsible` set to `other` and No `Responsible Person` defined on activity due to Extra argument.

In this commit, We remove that extra Argument.

closes odoo/odoo#44965

X-original-commit: 009e5526
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Purpose
=======

Whenever a visitor start a livechat session but finally close the session
without sending any messages, the livechat session is empty and stay in DB.
Livechat session counter counts all the sessions (with and without message)
but when opening the sessions tree view, the view is filtered by default on
session with messages. There is no reason to see the empty sessions as it
does not give any information (except "the visitor hesitated to start
livechat and finally did not" which is quite useless info)

The goal is to keep only sessions with messages.

When the visitor is closing the livechat window, if the session is empty,
the session should be deleted. But what happens if a visitor start a livechat
session, send no message and just leave the website without closing the
livechat window ? --> empty live chat session will remains in database.

The ir_autovacuum already handle the deletion of empty sessions to main a
clean DB.

Specifications
==============

- Apply 'with messages' domain on session count in the livechat channel view
- Apply 'with messages' domain on session count in the lead view
- Apply 'with messages' domain on livechat session view
- Remove With message filter
- Remove Without message filter

- If send message on a deleted session :
    just tell the visitor that operator is not available anymore
    AND delete livechat session cookie (as he waited 1 day to send a message)

Empty sessions becomes invisible : not possible for users to see empty session
(in count or in views) and cron is cleaning empty sessions every day.

This commit also adapts visitor session count and view accordingly.

Task ID: 2146962
PR #41065

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

The filter for Purchase orders in the Purchase report did not filter out Sent RFQ,
despite the fact that they were not really ordered yet.

opw:2158248

closes odoo/odoo#44892

X-original-commit: 201cfb46
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

When grouping records in kanban view, if a quick create widget was
already opened, clicking on the "+" to launch another quick creation
would crash.

Fixes https://github.com/odoo/odoo/issues/44680



closes odoo/odoo#44949

X-original-commit: b482df17058e6f2117b616e6b152a7f2c90dc121
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

This parameter declared on mailing and project classes is not used anymore.
Let us remove it to clean model definitions.

closes odoo/odoo#39401

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

The typical command to launch odoo in the install documentation is usable as it is after following the complete instructions.
There is two changes done here:
- Remove the ../my_modules from the command, as it is a directory not used in the page at all.
- Remove the db-filter option not mandatory since the 11.0 version and add a '-d' argument. This will create the db instead of showing the database selector to the reader.

closes odoo/odoo#44899

X-original-commit: 6a5d43da
Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>

* = website_crm, website_hr_recruitment, website_sale

Changing label position on existing field was replacing the label with
the default one.

Redirection message was not updating the overlay

Going from show message to redirect without hidding the mesage made the
form d-none

When a select field's label's position was changed the select was not
editable anymore.

Some other miscellaneous fixes

task-2191409

closes odoo/odoo#44911

X-original-commit: 3cf87cc1cb179598cecb736728378e330d3b2e22
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Make sure `force_company` context key is set on the SO in all cases.
Indeed, when the context key is not properly set, an incorrect fiscal
position can be retrieved in:

https://github.com/odoo/odoo/blob/cc557f1e4de88466d0d159c5edf1a606a0c0bc6f/addons/account/models/partner.py#L99-L100



This is for example the case when we go through the route
`/shop/confirm_order`.

opw-2186682

closes odoo/odoo#44451

closes odoo/odoo#44933

Original-signed-off-by: Toufik Benjaa (tbe) <tbe@odoo.com>
X-original-commit: 5691e733e2d860baa012140fc35d3f39ddf747c8
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

[FIX] l10n_eu_service: wizard: don't copy tags when creating the service tax for the selected EU country

This restores the behavior for 12.0; we don't want those amount within the national tax report.

closes odoo/odoo#44894

X-original-commit: bd21046f9259f0c755deeba8a1d207da6578e957
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

This route was public by mistake, probably introduced to test during
ddf32f4f but no reason to make it public, public user has not the write
access on models anyway.

Courtesy of Swapnesh Shah

closes odoo/odoo#44915

X-original-commit: 66ac96b2
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

- Go to Settings > Technical > Resource > Working Times
- Have a Resource Calendar RC with Average hour per day != 8.00
- Have an Employee E with Working Hours == RC
- Leaves > Configuration > Leave Types
- Have a Leave Type LT with Take Leaves in Hours
- Leaves > Managers > All > Allocations
- Create an Allocation A with Employee E and Leave Type LT
- Enter any number in Duration

The number of hours entered changes as we leave the field.

Being totally honest, what happens here is not clear at all, but using
the corresponding `resource_id.calendar_id` field seems to fix the
problem.

opw-2191795

closes odoo/odoo#44903

X-original-commit: e239b354
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

If some filter domains use M2O to models current user cannot access,
using sudo() permit to filter even when user cannot access linked
models.

for the accuracy of the fix, add a unit test which reproduce the exact
reported bug.

closes odoo/odoo#44923

X-original-commit: 30e2153539643491fad889811a54a8e580fa9c58
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

    When you have su == True in your env and you call _name_search
    the _name_search was switching back to su = False
    when you call with_user with the same user or with None

    To reproduce the issue, take a model where a user has
    no access.control.list allowing to read the model
    call name_search with sudo.

X-original-commit: 8755269f9877e039663adaec8500b530b6d67c68

X-original-commit: ba1d04ac8a23a2f3cfad7f332dab96f7e460eb53

Issue

	- Install Website
	- Go on your website
	- Add text block with image
	- Change ONLY the image's alt and/or the image's title text
	- Save dialog
	- Save page

	Not saved

Cause

	The element doesn't become dirty after changes in alt dialog.

Solution

	Trigger content_changed to make the element become dirty.

OPW-2189909

closes odoo/odoo#44885

X-original-commit: 4f171207
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

closes odoo/odoo#44877

X-original-commit: 4c5aea41
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

Make sure `is_website` is an existing field of the model at creation.

opw-2192139

closes odoo/odoo#44870

X-original-commit: 5daf25f2
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

closes odoo/odoo#44869

X-original-commit: c8c311b8
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

X-original-commit: efa3a148

[IMP] account: Improve fixes https://github.com/odoo/odoo/commit/ab1ae1a854eab4a38aa2866bfc9d8ca9aa4013be

Explanation about flushing in action_switch_invoice_into_refund_credit_note:
Because the 'type' is set before 'amount_total', 'amount_total' is recomputed with the
wrong type and then make the condition badly evaluated.
For some reason, the field wasn't badly recomputed before:
https://github.com/odoo/odoo/commit/020e2a5e85036976b309b439582d70b5b775e54f



closes odoo/odoo#44868

X-original-commit: a82e62d1925ebfd4f49360fdc5f3a8d28de5a0d9
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

- install e-commerce;
- In the website settings, orders followup, set a salesperson;
- By something as a public user;
- Pay the order.

Before this commit:
- 2 emails where create to assign the salesperson to the SO, but these
    emails didn't have a from and the salesperson didn't receive the
    emails.
- 1 email was also create to assign the salesperson to the contact, this
    mail is not necessary.

Now, only one email that assigns the salesperson to the SO is sent,
with a correct from address.

opw-2189683

closes odoo/odoo#44861

X-original-commit: 7c08eb158858b9573d3d84a0b54df0bfca754105
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

Before this commit, no recompulation were performed at the end of the
tracking procedure.  This is because the main flush() occurred before
the tracking of values.  The absence of flushing is problematic in the
case where the tracking is used to create/update records.

closes odoo/odoo#44851

X-original-commit: c60da49a1d81fa73b60135185d5b706eec771475
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

* website_form

Some technical explanations:

The method became async because the `setTarget` call which was in there
became `async` since it performed an UI update. As this method being
async is a problem with some snippets, it is best to keep it synchronous
for now. For this, the UI update in `setTarget` is removed and becomes
the responsibility of the caller. Nothing relied on it except one code,
which is solved by calling `onFocus` before the UI update which occurs
on focus, as it is already the case in master.

closes odoo/odoo#44850

X-original-commit: 53bba0660237abbcadc9675fd89ec94a2a31e130
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Normally, the number of column option adjusts the width of each column
after changing their number so that they always fit in one row. In
previous versions, the sequence of the code was correct thanks to
jQuery's deferreds executing their then callbacks synchronously if the
promise was already resolved. However, native Promise objects always
put their then callbacks in the microtask queue, and this was resulting
in the column width classes being recalculated before their number had
actually changed.

This commit fixes that by calculating the width of the columns based on
how many columns there will be after addition/removal. It also
introduces a new field on the option that is used to update the UI so
that it displays the correct number.

closes odoo/odoo#44849

X-original-commit: 58804d6ea375629b07748bc442eaccc401c56d1b
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

- Activate 'Round Globally'
- Create a 21 % tax included in price
- Create a product costing 21.5
- Add the product in a pos order, make the payment

The `price_subtotal` is saved as `17.768595`, while it should be
`17.77`.

When these amounts are added in [1] (coming from [2]), it can lead to an
inconsistency in the final computation, preventing the closing because
of an unbalanced journal entry.

Actually, the total and the subtotal must always be rounded following
the currency precision, as done in [3] and [4].

It was probably not causing an issue before 13.0 since the creation of
the journal entry from the POS was different.

[1] https://github.com/odoo/odoo/blob/b22935caa3df824bc56a0828da9bee921bca5a5b/addons/point_of_sale/models/pos_session.py#L381
[2] https://github.com/odoo/odoo/blob/b22935caa3df824bc56a0828da9bee921bca5a5b/addons/point_of_sale/models/pos_session.py#L557
[3] https://github.com/odoo/odoo/blob/b22935caa3df824bc56a0828da9bee921bca5a5b/addons/account/models/account.py#L1654
[4] https://github.com/odoo/odoo/blob/b22935caa3df824bc56a0828da9bee921bca5a5b/addons/account/models/account.py#L1740



opw-2181486

closes odoo/odoo#44834

X-original-commit: 0896afdc
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

We only want journal entries with an actual sequence to be used as
reference, otherwise we can't deduce the reset periodicity of the
journal.

closes odoo/odoo#44833

X-original-commit: a57a0edae27a93aadf8fe8c95ae45ab91ec9aa31
Signed-off-by: wan <william-andre@users.noreply.github.com>

On product categories, the `total_route_ids` field is shown without
label. This is confusing for end users since the same route seems to
appear twice.

opw-2173783

closes odoo/odoo#44821

X-original-commit: 91bc6464
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Before this commit, when printing in safari a receipt that contains
products with long names, parts of the name were overlapped. This occurs
because, in safari, the library that transforms the html into text
mismanages the spaces.
This is a well known problem, see : niklasvh/html2canvas#1654

Now, the name is printed correctly in safari, same behaviour than the
others browsers.

opw-2169656

closes odoo/odoo#44819

X-original-commit: 263131f4
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

We chose the vendors by searching random res.partner but sometimes
partners of another company are returned, making the _check_company
mechanism raise an error.

closes odoo/odoo#44815

X-original-commit: 1cfcf21efa888720f9c34b337532251db6fd0089
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

in anglo saxon accounting
- receipt products through an rfq
- when creating the vendor bill of the rfq, directly add a landed costs
  product
- post the vendor bill then create the landed cost, validate the landed
  cost
- the aml of the LC is not reconciled with the aml of the vendor bill
  for the lc product because the "You are trying to reconcile some
  entries that are already reconciled." error.

We fix this by filtering out the already reconciled aml.
Not that the flow is behaving as expected if the landed cost is created
in another vendor bill, such as the tests were doing. We thus add
another test.

opw-2184988

X-original-commit: 1e78527ac5295563e9610ad9ddd98834998285f3

- Create a default value for 'Source Location' or 'Scrap Location'
- Create a Scrap Order

the default value is not taken into account since it is overridden by
`_onchange_company_id`.

We avoid changing the location in case the company matches.

opw-2189578

closes odoo/odoo#44812

X-original-commit: 5c544adb
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

- Create the following tax:
  Tax Computation: Percentage of Price Tax Included
  Amount: 100 %
  Included in price
- Create an invoice, add a product with this tax
- Save

A ZeroDivision error is raised.

opw-2186998

closes odoo/odoo#44810

X-original-commit: 0b11474a
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

1) Go to purchasing, and in the search area type "8888"
2) Click on the little arrow next to "Search Product for: 8888"
3) Select "[FURN_8888] Office Lamp"
4) Choose Purchase Order PO00009 which has FURN_8888 on the second line:
5) Choose Action > Duplicate

The 1st line end up with the searched product, not the original product.
This happens because the search add the context key
'default_product_id'. By chance the product.product model has a
'product_id' field which may happen to be not filled.
This cause the model api to look for a default value in the context and the
first line of the order get overridden.

Removing the specific key from the env solve the issue

opw-2188429

closes odoo/odoo#44802

X-original-commit: ed6ac9c6
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

closes odoo/odoo#44800

Co-authored-with: Xavier Dollé <xdo@odoo.com>
X-original-commit: bc2bb5e0
Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>

Before, the buttons to save, cancel or update quiz in eLearning frontend
as well as icons weren't displayed correctly.

Now, all elements are displayed correctly on mobile or on computer, more
responsive and better displayed.

Task 2153990
PR #42846

closes odoo/odoo#43328

X-original-commit: 4d986beb7192c34c133d8d5d02ff62bd159f202a
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Highlight the 'Validate Inventory' button only if there is at least one
inventory line.

opw-2187225

closes odoo/odoo#44793

X-original-commit: 95da1ac1
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Have a company with Croatian address but no street2 set.
Create and invoice, print it. On the report the street2 will appear
blank (Empty line).

Correcting the formatting of the address fix the issue

opw-2182621

closes odoo/odoo#44789

X-original-commit: 5f4cc31a
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Nothing prevents to delete a bank statement linked to an open pos session,
which leads to a KeyError when validating and posting entries at closure.

closes odoo/odoo#44787

X-original-commit: 7416340e
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Steps to reproduce the bug:

- Create a journal entry
- Create a line L1 with an account A and a partner P
- Create a second line L2 with an account A and a partner P
- Create a third line by clicking on 'Add line'

Bug:

The account A and partner P was not suggested as in saas-12.3

opw:2188921,2152827

closes odoo/odoo#44784

X-original-commit: 31890c4e
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>