This PR adds the 'posted' filter by default on the journal items list
view, when coming from an account's form view.

opw-2896728

closes odoo/odoo#98183

Signed-off-by: Grazioso Andrea (agr) <agr@odoo.com>

If datetimepickers were used too soon after page loading, they would use
the wrong format and UI options as the code in charge of initializing
those options was not fully lazy loaded yet.

With this patch, we prevent the tempusdominus lib to consider pickers
that are in a body that is marked by the lazyloader during the lazy
loading of JS files. We could potentially not add the lib attribute
(data-toggle="datetimepicker") on those elements and let the business
code initializing the pickers add it but that would not have been a
stable fix and it may be better this way as this works generically.

opw-2944720

closes odoo/odoo#98529

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Add Jose Moreno Hanshing

closes odoo/odoo#98329

Signed-off-by: Josse Colpaert <jco@odoo.com>

Backport of https://github.com/odoo/enterprise/commit/0a8aa0d48b17d2d428941b3bd11aca5d0a3422e9



Don't show the stock input/output accounts
in the reconciliation widget.

Steps to reproduce:

- A product category PC, costing method AVCO,
  automated valuation and custom stock input(STI)/output(STO)
  account (reconcile = True)
- A Journal Entry with the STI
  Move line :
  | Account | Debit | Credit |
  |---------|-------|--------|
  |   STI   |  0.0  |  50.0  |
  | XXXXXXX |  50.0 |   0.0  |

- Create a bank statement with amount corresponding with
  the journal entry then reconcile
-> Line for custom stock input STI account shows up in misc tab
   on reconciliation widget

Fetch all accounts relative to stock accounts properties, then
filter them in the domain.

opw-2792862

closes odoo/odoo#96131

Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

Reproduction:
1. Create a dynamic attribute "dyn_att" with a couple of values
2. Create a product template "dyn_prod" with those attribute values
3. Create an order for "dyn_prod", this will trigger creating a variant
4. Make sure to check Variant Grid Entry in Sales Settings
5. Open variant form view of dyn_prod and edit it to allow duplication
6. Duplicating it leads to an error

Reason: copying the variant is not possible and disabled here:
https://github.com/odoo/odoo/pull/38303

 For future convenience, maybe
it’s better to give a temporal working solution. The function
_create_first_product_variant is used in the product module but only
defined in its child module website_sale

Fix: copy the product template, create and return its first possible
variant. Added test for dynamic variant copy. change the definition
place of _create_first_product_variant to module product

opw-2790543

closes odoo/odoo#88075

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Exporting data incorrectly formats the float values of group headers

Steps to reproduce:
1. Install Planning
2. Open Planning and trigger the list view
3. Remove the default filter and add a group_by on employees
4. Export the data
5. The file produced doesn't have the same format for Allocated Hours in
   the group headers and in the line details

Solution:
Create formats for float and monetary values using the user's
preferences in decimal separator and decimal precision. For monetary
format, we use the biggest decimal precision used in the company
currencies.

opw-2864273

closes odoo/odoo#94534

Signed-off-by: Julien Castiaux <juc@odoo.com>

Searching by attributes works via a separate form. It has a copy of other search
parameters (`category`, `search`), but not `order`.

STEPS

1) enable View "Products Attribute's Filters" in eCommerce
2) enable View "Show Sort by" in eCommerce
3) Set sorting to specific value
4) Change Product Filters Attribute values
5) as you can see, the sorting set in Pt3 is lost....

opw-2956280

closes odoo/odoo#98553

Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>

Steps to reproduce:

  - Install `website_event` module
  - Go to Events and edit `Design Fair Los Angeles` event
  - Edit the title and make it very long then save
  - Go to the Website then click on Events in the menu
  - Click on Customize and disable `Layout - Columns` to have
    a list view.

Issue:

  The cover is hidden on edited event.

Cause:

  It's a know issue:
  https://stackoverflow.com/questions/36247140/why-dont-flex-items-shrink-past-content-size



Solution:

  Set min-width: 0 to the div arround the title if screen size bigger
  then `sm`.

opw-2882533

closes odoo/odoo#95992

Signed-off-by: Nasreddin Boulif (bon) <bon@odoo.com>

Facebook no longer supports the option to see the profile pictures of
friends who have liked the page. So this commit removes the option
(which was no longer useful). See [same issue at WordPress].

[same issue at WordPress]: https://wordpress.org/support/topic/facebook-likebox-disappearance-of-the-faces-of-friends-who-like-the-page/



task-2950329

closes odoo/odoo#98177

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Steps to reproduce the issue:

- Notes app > Kanban view > Create a bunch of notes using
the + icon in the kanban view
- (optional) Modify the default order of the notes
- Add a new note using the quick add feature
- Don't modify the order of the notes and refresh the page
- The new note will be sent to the bottom of the note list
(off-screen if the list is long enough)

This happens because new notes have their sequence set to NULL, which
places them at the end of the list after ordering by sequence.

This commit sets the default sequence of a new note to 0, so that it
is placed at the top of the list and adds an additional sort on
'id desc' to consider the case where all notes have the same sequence.

opw-2924615

closes odoo/odoo#97023

Signed-off-by: stcc-odoo <stcc@odoo.com>

The model had name_get, but not _name_search, which leads to difference between
what user sees and what he get as search results.

This patch doesn't fix the issue completly, but adds more search results on
searching just by account move (e.g. invoice) name.

STEPS:

* open menu Analytic Items (account.analytic.line)
* make custom filter *Journal items contains "INV/"* (
`[["move_id","ilike","INV"]]` )

BEFORE: no items found even if you see such analytic items

---

opw-2691495

closes odoo/odoo#87156

Signed-off-by: William André (wan) <wan@odoo.com>

/my/account controller blocks name/vat/company_name updating if there are issued invoices.

However Before this commit, user can change name via /shop/address page

STEPS

1/ install sales, eCommerce,inventory,Accounting
2/ create a sales order from the portal page, validate and create an invoice from SO and post it
3/ Try to change the name from the Portal > Account
Result - not possible = correct
4/ Place a new SO by the same portal user and edit the name on the address before proceeding to checkout

[1]: https://github.com/odoo/odoo/blob/1f49528a4b198e8912beb33be921d2855c694e2e/addons/account/controllers/portal.py#L111-L113



opw-2848251

closes odoo/odoo#97686

Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>

Consider this case:
Template A has 2 variants: KIT and NOKIT
KIT has a total cost of 100, NOKIT costs 50
When selling NOKIT, the current code will select the bom of KIT
to calculate the price_unit of NOKIT, which means that when
reconciling the aml of the invoice (amount = 100) with the aml of
the cogs move (amount = 50), it will be partial due to the difference
in amount. This alse messes with the balance sheet report.

This fix ensures that only boms directly related to the product
or for the generic template are selected.

opw-2918080

closes odoo/odoo#97453

Signed-off-by: Steve Van Essche <svs@odoo.com>

So that the link works...

Task-2954531

closes odoo/odoo#98155

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

This commit attempts to fix an undeterministic error during one of
`website_sale_wishlist` tests.
Due to a race condition it may happen that the button to add to the
wishlist would be re enabled while it should be disabled (if the product
is already in the wishlist) causing the tour to fail.

closes odoo/odoo#98143

Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>

When sending a mass mail through the composer, if the field ``reply_to`` had to
fall back to being ``email_from``, reply_to would take the value of the template
syntax instead of the rendered value.

This is notably the case when mass-mailing invoices through the accounting app.
Resulting in reply_to fields such as: '{{user.email}}'

On some mail clients (including mailhog), this could also result in template
syntax being shown as part of the subject or sender field.

This commit fixes that by correctly taking the rendered value of 'email_from'

Task-2816845

closes odoo/odoo#95227

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

When sending a mass mail through the composer, if the field ``reply_to`` had to
fall back to being ``email_from``, reply_to would take the value of the template
syntax instead of the rendered value.

This is notably the case when mass-mailing invoices through the accounting app.
Resulting in reply_to fields such as: '{{user.email}}'

On some mail clients (including mailhog), this could also result in template
syntax being shown as part of the subject or sender field.

Task-2816845

Part-of: odoo/odoo#95227

For the product categories, the default income and expense accounts
should only contain the income/expense accounts.
Such that the dropdown menu in the product view only lists the possible
income or expense accounts.

task-2835541

closes odoo/odoo#90358

Signed-off-by: Laurent Smet <las@odoo.com>

Steps to reproduce:

  - Install l10n_ar module (or any l10n_* module that depends on
    l10n_latam_invoice_document)
  - Go to Accounting -> Vendors -> Bills
  - Click on Upload and select a bill file
  - Open draft bill
  - Click on `Send For Digitalization`

Issue:

  Digitalization don't start and a warning message is diplayed saying
  that some required fields are invalid.

Cause:

  When clicking on the button to digitalize the invoice, we try
  to save the form first before executing the action.
  By doing so, if some fields are required and empty, a warning message
  will be displayed.

  In this case, the issue is with the fields `Document Type` and
  `Document Number`.

Solution:

  Set `Document Type` and `Document Number` to not required if there is
  no partner_id set on the bill.

opw-2797444

closes odoo/odoo#96004

Signed-off-by: Josse Colpaert <jco@odoo.com>

When the country events snippet displayed events specific to a country
(geoip properly installed + upcoming confirmed events in that country),
a flag of the country was displayed but it was way too big.

Difficult to say when the bug was created, at least from 12.0. In 15.1,
that snippet has been refactored anyway and is now entirely different to
make it more attractive.

opw-2904427

closes odoo/odoo#97905

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Before this commit, we had an error following those steps:

1. Install website app.
2. Customize the first website default theme settings (like the
   font-size of the header logo).
3. Uninstall the website app.
4. Reinstall the website app.
5. Try step (2) again => It does not work.

This is due to custom SCSS attachments which were not properly removed
after we uninstalled the app. The problem was actually already solved
at some point with [1] but was later broken by [2] which prevented to
properly call the `unlink` method for the only remaining website.

[1]: https://github.com/odoo/odoo/commit/2f361bec36dff09181b96d140d62c477cdf013a1
[2]: https://github.com/odoo/odoo/commit/93a2e85ae7b11f9a390f40f74e6d78e1ec876fc3

Fixes https://github.com/odoo/odoo/issues/44240


opw-2947919

closes odoo/odoo#97852

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Steps to reproduce:

  - Switch language to french
  - Refresh the page
  - Create a new payment
  - Select a partner
  - Enter an amount of 100000,00
  - Save the record
  -> The following field is incorrect: amount

Cause of the issue:

 Since https://github.com/odoo/odoo/pull/97425

 ,
 `parseMonetary` wrongly assumed that a currency was always passed in
 the parameters

opw-2937403

closes odoo/odoo#97788

Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

closes odoo/odoo#97774

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

When sending SMS on several records in comment mode (aka: post sms message
in batch) the body is sent as it is. This does not happen frequently as
default usage is either

  * comment on a single record -> body is rendered by onchange / compute;
  * mass SMS on several records -> body is rendered for all records then
    sent to all recipients;

Using comment mode in mass is not common, and is mainly achieved through
handcrafted actions. However this can be fixed by correctly rendering the
body before posting on all records.

Use addition of records instead of OR to keep ordering of created
messages when using SMS composer.

Spotted during Task-2613245 (Server actions mail update / cleaning)

closes odoo/odoo#97734

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Purpose is to enable dynamic rendering in mass comment mode. This highlights
an issue, as currently when using the comment mode on several records body
is not rendered, just sent as it is. This means raw dynamic code could be
sent.

Also cleanup some invalid setup (not enough records for mass) that skipped
some tests.

Spotted during Task-2613245 (Server actions mail update / cleaning)

Part-of: odoo/odoo#97734

If you delete a tag, but still have some link to this one, you arrive on
a 404 /blog/tag/.
We decide to redirect to the blog post without tag instead.
What is probably the expected behaviour for most customers.

closes odoo/odoo#97223

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Steps to reproduce:

1- ping a user on any record
2- open the link in the email without being logged in
3- you are redirected to the login page
4- after login, you will be in discuss module

Bug:

the function `_redirect_to_messaging` is called instead of constructing
the proper redirect based on the model

Fix:
like:
https://github.com/odoo/odoo/blob/15.0/addons/mail/controllers/mail.py#L100-L110

back-port of
https://github.com/odoo/odoo/commit/0b9d49f33713fc2d5a76f25523f2d4bb5ddb3b44



OPW-2885735

closes odoo/odoo#94652

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

*: microsoft_outlook, website_twitter

Steps to reproduce:
- install the google_gmail, microsoft_outlook and website_twitter
modules
- go to Settings > General settings > Discuss > External email servers
- for the twitter module go to Settings > Website > Features > Twitter
roller
- the client secret fields are visible

This commit changes the fields types into 'password'.

opw-2936506

closes odoo/odoo#97306

Signed-off-by: Anh Thao PHAM <pta@odoo.com>

closes odoo/odoo#97362

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Steps to reproduce:
- Create a quotation
- Add a product that is invoiced on "ordered quantities" and set the
  quantity to a negative number.
- Leave 'delivered' to 0
- Confirm the quotation
- Create the Invoice and validate it.
- Go to the SO list view (Orders > Orders)

You should see that the Invoice Status of the order you just created is
'Upselling Opportunity', which is not correct.

Why this is happening:

Here's an explanation on the 'Upselling Opportunity' state (found in
the code):
" upselling: this is possible only for a product invoiced on ordered
quantities for which *we delivered more than expected.* "

In our case, the invoice line's state is set to 'upselling'
because we have a negative ordered quantity and a zero delivered
quantity (i.e. we delivered more than expected)

opw-2895218

closes odoo/odoo#97015

Signed-off-by: Nshimiyimana Serge Séna (sesn) <sesn@odoo.com>

closes odoo/odoo#97520

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Steps to reproduce:

1. Go to Inventory-->Settings-->Check option to "Display Lots & Serial
Numbers on Invoices"
2. Go to Rental App
3. Create a new Rental Order for a product that is tracked by Serial
Number. Pop up shows up. Also something to note here, though not
necessarily related to this ticket, but you cannot select available
serial number from this pop-up. It doesn't let you choose anything
even when there are multiple serial number available/in stock.
4. Confirm the order.
5. Validate the Pickup and set the Serial Number in the popup.
6. Create the invoice.
7. Confirm the invoice.
8. Print "Invoices without payment"

Bug:

in https://github.com/odoo/odoo/commit/7a030f616f7e04b3994fc718840d265b1dd21068



the filter functions were removed. They had the effect
of making sure that the sml is either a delivery or a return
by filtering on `sml.location_id.usage` and
`sml.location_dest_id.usage`

Fix:
check if the product is a delivery or a return by
making sure that either of `sml.location_id.usage` and
`sml.location_dest_id.usage` is `customer`

OPW-2936505

closes odoo/odoo#97449

Signed-off-by: Adrien Widart <awt@odoo.com>

Steps to reproduce:

  - Switch odoo language to french
  - Create a client bill for Azure Interior of $1 000 000
  - Confirm it
  - Go to the accounting dashboard
  - On the bank, click on reconcile
  - Select Azure interior
  - Click on the correct bill
  - Switch to Manual operations
  -> $1 000 000 is not a correct monetary field

Cause of the issue:

  Recently in https://github.com/odoo/odoo/pull/94126

 , `formatMonetary`
  switched from joining the currency and symbol from ` ` to a non
  breaking space, NBSP.
  To parse monetary values, the behavior was to split around NBSP to
  get the symbol on one side and the value on the other which is then
  passed to `parseFloat`.

  For the following examples, NBSP is replaced with an underscore.
  So `$_1000` becomes `$, 1000`
  But some languages such as french uses the same char as thousands
  separator.

  In that case, `$_1_000` becomes `$, 1, 000` and then the parse fails.

opw-2937403

closes odoo/odoo#97425

Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

This old file is indented with tabs instead of spaces.
This is a problem because the file is using as template to
write new localization.

closes odoo/odoo#97412

Signed-off-by: Josse Colpaert <jco@odoo.com>

Before this commit, importing an .OFX file from BNP failed because the account number format is not the same.

This is a problem on BNP's side but it is blocking for our clients and needs to be fixed.

This commit fixes this by checking that the account number corresponds to a specific part of the IBAN (for France only).

Task id 2860720

closes odoo/odoo#97413

Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

Sometimes, no picking type match the domain, but picking_type_id is a required field.

closes odoo/odoo#97230

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

backport of  #85323

closes odoo/odoo#96201

Signed-off-by: Vranckx Florian (flvr) <flvr@odoo.com>
Co-authored-by: auon-odoo <auon@odoo.com>