Before this commit: the `product.display_name` field could contain
line breaks, which prevented it from being matched correctly by
regular expressions. This commit fixes the issue by modifying the
`_product_search_string()` function to remove line breaks.

opw-3239830

closes odoo/odoo#116692

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

Steps to reproduce:
- In inventory/replenishement
- edit a line (eg: prefered route) then click on reorder
- the edits are discarded

Fix:
the line is saved only when it gets unselected or manually saved
it more intuitive to also do it when a button is clicked on the line

opw-3125732

closes odoo/odoo#116065

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Some databases encounter an error when they try to upgrade when
they have more than one tax with the same name that violate
the tax name unique constraint (name, company_id, type_tax_use, tax_scope).
This will adapt the update of taxes script to handle this situation
by renaming such taxes to [old] taxname, [old1] taxname, etc.

opw-3178128

closes odoo/odoo#114292

Signed-off-by: Quentin De Paoli <qdp@odoo.com>

When updating taxes we send a message to accounting advisors if
we duplicated tax(es) in the process so he can check if the
original tax is still relevant. This message was wrongly sent
multiple times per advisor when there was more than one advisor.

Task: 3178775
Part-of: odoo/odoo#114292

Adds more tests to the update of taxes.

Task: 3178775
Part-of: odoo/odoo#114292

Rework tests of the taxes update and fix PEP8 docstring rule violations.

Part-of: odoo/odoo#114292

_create_or_update_picking() is a time-consuming method.
On some Purchase, all the purchase.order.line may be written with 'product_qty' in 'values', even though it did not change.

OPW-2978569

closes odoo/odoo#114546

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

closes odoo/odoo#117287

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Current behaviour:
When creating a timesheet, if in the vals passed the AAL doesn't
have a company (possible since it's not required), then the `uom`
of the timesheet is False, which doesn't make sense.

Expected behaviour:
The timesheet `uom` should fallback on the uom of the company
of the project.

Steps to reproduce:
- Install hr_timesheet, Accounting
- Activate the AAL in the settings
- Create a project with an AAL
- Remove the company on the AAL of the project
- In that project create a task and log some timesheet.
- `uom` field should be empty

Reason for the problem:
When setting the `product_uom_id` in the vals when creating/writing
a timesheet, we just take the `project_time_mode_id` on the company
linked to the AAL. The problem is that the company on an AAL is not
a required field, so it can be `False`, leading the setting the val
for `product_uom_id` to `False`.

Fix:
In case the AAL has no company, we get the `uom` from the company
linked to the project.

Affected versions:
- 14.0
- 15.0
- saas-15.2
- 16.0
- saas-16.1
- saas-16.2
- master

opw-3245671

closes odoo/odoo#117012

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

Problem:
When doing a write on an empty recordset from coupon programs,
a traceback error about tuple index out of range is thrown.

When doing a write on multiple records, it's not guaranteed to have the
same (discount_line_product_id, reward_id) pair per record.
Thus, it's not correct to use the reward_id of the first record and
apply it to all records.

Solution:
Pass in self as a condition to check whether self is empty or not.
The method should just return res if self is empty.

For each coupon program in self, update its discount_line_product_id to
its respective reward_id.display_name

Steps to Reproduce in Runbot14:
1. Install Sales & Coupons
2. Enable Coupons & Programs in Settings
3. Create a server action to do a write on an empty recordset
ex. env['coupon.program'].write({'discount_fixed_amount': 0})
4. Create a server action to do a write on multiple records

opw-2658794

closes odoo/odoo#116096

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Incorporate Rodrigo Serrano (Rodrigosu_Vauxoo) as Vauxoo's contributor.
I confirm I have signed the CLA and read the PR guidelines at:
www.odoo.com/submit-pr

closes odoo/odoo#117087

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

When importing an electronic invoice, we only want to create the partner
when the vat and the name were retrieved.

closes odoo/odoo#114900

Signed-off-by: Laurent Smet <las@odoo.com>

The color that was used for portal chatter published dates was the muted
color that we use at some places in the backend. The portal screens
being frontend screens, it of course did not work with all website color
schemes.

This simply uses the `$text-muted` color to fix the issue. This probably
needs refactoring in master to avoid those extra CSS rules that could
simply be gone with proper bootstrap XML structures.

opw-3146164

closes odoo/odoo#116968

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

The trigger that downloads FatturaPA used the `_trigger` function only available in Odoo 15.
This means that if we manually re-trigger, each iteration will have less time before timeout and will eventually do.
So, we revert the change in Odoo 14.

Reversal of odoo#116373
https://github.com/odoo/odoo/pull/116373



closes odoo/odoo#116731

Signed-off-by: Josse Colpaert <jco@odoo.com>

Before this commit, in the website profile frontend, if we filter the users
using 'This week' or 'This month' filters we always get a '+' displayed before
the karma gain.

If user gained negative karma, lets say -500, currently it displays as follows
--> +-500 , instead of -500.

After this commit, if the gained karma during the period is it will show
-500 instead of +-500.

closes odoo/odoo#114506

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Steps to reproduce:

- Install Sales, Inventory
- Sales > Create quotation > Fill data > Other Info tab >
Customer Reference = *insert very long string here* > Confirm
- Click on delivery stat button > Print > Delivery Slip

Issue:

The customer reference overlaps with the other information in the same row.
In the resulting XML there are two nested divs with `class="row"`.

Solution:

Remove the row div in the derived xml.

opw-3121097

closes odoo/odoo#116681

Signed-off-by: Tiffany Chang <tic@odoo.com>

Currently in the survey:
- If we have a conditional question and the question selection mode is
  random and we select the question layout as one page with all questions
  or one page per section, the conditional question is not visible. This
  happens because the  random mode condition is ignored.
- If we have a conditional question and the question selection mode is random
  and we select the question layout as one page per section, the traceback is
  generated when we start the survey. This is because it is trying to get value
  from the "selected_answer", which does not exist in random mode.

Expected behaviour is If the question selection mode is random, the conditional
questions are considered normal and visible and do not generate a trace back if
the question layout is one page per section.

This commit fixes the above issue by adding a condition that treats
the conditional question as a normal question when the question
selection mode is random.

task-3142209

closes odoo/odoo#111171

Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>

When creating an invoice from e-commerce, the invoice is not sent by mail but the user must be able to see it from the portal.

closes odoo/odoo#116867

Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

Before this commit:
Assuming we have a "Shipping Labels Printer" set on an operation type.
Assuming we also have a delivery carrier which send Label through the chatter of this picking type (like DHL or BPost).
If we have several sessions connected with the same user (author of the chatter message), for examples, on different devices.
Each session will send the same IoT request to print the label (as the code rely on the bus).

In consequences, the same label will be printed multiple times

After this commit:
The label is print only once

Associated enterprise PR: https://github.com/odoo/enterprise/pull/36904



opw-3081423

closes odoo/odoo#112355

Related: odoo/enterprise#36904
Signed-off-by: Sens Loan (lse) <lse@odoo.com>

There can be multiple causes that could prevent a sales order gets
confirmed when we push the *Confirm* button. This can be common when
extension modules come to play.

The simplest way to reproduce it (no extra modules needed) would be to
make an automated action on sale.order with a criteria that could avoid
the confirmation throwing a UserError.

The coupon email would be sent anyway as we can't rollback a mail
sending once it's gone away but it wouldn't be valid as the process
stopped after it.

So we want to prevent sending that mail if the sale.order can't be
confirmed.

TT42124

closes odoo/odoo#116817

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

before this commit, for the company_id field
the user groups given was base.main_company,
such a group is not existing in the system

after this commit, the group will be changed
to base.group_multi_company from base.main_company

closes odoo/odoo#116793

Related: odoo/enterprise#38871
Signed-off-by: Tiffany Chang <tic@odoo.com>

before this commit, on duplicating a contact tag
will duplicate the assigned partners also.

suppose if we have a partner A with tag B assigned,
and then we duplicate tag B and create new tag C,
the newly created tag is automatically getting
assigned to partner A.

after this commit, the copy is set to False for
partner_ids field in tag and then the partners
wont be copied on duplicating a tag

closes odoo/odoo#116632

Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>

Before this commit, no default date filter was set on the report.
For older databases, it results in a systematic heavy query.

opw-3134913

closes odoo/odoo#115113

Signed-off-by: nda-odoo <nda@odoo.com>

before this commit, there is typo in unit of measure

after this commit, the typo will be corrected and
unity of measure will be updated to unit of measure

closes odoo/odoo#116630

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Rewords and fix the typos in the mailing.mailing model notes.

Task-3240405

closes odoo/odoo#116162

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

*: google_recaptcha, web_editor, website_blog, website_forum,
   website_sale_comparison, website_slides, website_twitter

This commit fixes improperly escaped query parameters across javascripts
of website-related modules.

See https://github.com/odoo/enterprise/pull/31711



closes odoo/odoo#100868

Related: odoo/enterprise#31711
Signed-off-by: Bojabza Soukéina (sobo) <sobo@odoo.com>

Create a customer with Country Philippines and no vat
Try to save
Traceback

Fixup of f0e9a3ce

closes odoo/odoo#116646

Signed-off-by: Josse Colpaert <jco@odoo.com>

Invalid taxes could lead to invalid results from the
`_prepare_edi_tax_details` fonction. For instance: a tax without tax
repartition lines will be disregarded, which in turns leads to an
invalid xml being generated.

opw-3175701

closes odoo/odoo#116359

Signed-off-by: Nicolas Viseur (vin) <vin@odoo.com>

Steps to reproduce:
Launch a contract which has an end date
scheduled for the next day for an employee
and manually activate the "HR Contract: update state" cron.

Issue:
Running contracts are closed one day in advance.

Solution:
Correct the condition which selects contracts to close.

opw-3217616

closes odoo/odoo#116346

Signed-off-by: Kevin Baptiste <kba@odoo.com>

Step to reproduce:

1. create a product
2. duplicate it and change its translation (but DO NOT change the product name)
3. create a transfer for that new product without a contact
4. print delivery slip

Bug:
the db's product name is used instead of the translated name
(i.e. "original product name (copy)")

FIX:
when partner id is not set in picking, then default to the user's language

opw-3141202

closes odoo/odoo#116392

Signed-off-by: Tiffany Chang <tic@odoo.com>

In case we retrieve the maximum number of documents the IAP server
can send, we retrigger the cron to receive more documents, until
we get them all.

Parameter `recipient_codice_fiscale` wasn't used at all, download is
related to the proxy user which is determined by authentication on the
IAP proxy.

See odoo/iap-apps#583

closes odoo/odoo#116373

Signed-off-by: Josse Colpaert <jco@odoo.com>

Create an misc journal entry with 1000 as debit and a tax.
The tax line is linked to a refund tax repartition line.

Open the manual reconciliation widget and do the same.
The tax line is linked to an invoice tax repartition line.

When dealing with tax grids, the resulting tags set on the journal items are not the same.
This is because the given price_unit is not following the sign of the debit/credit column.
Indeed, a positive amount means you are adding something on the credit column.

opw-3236208

closes odoo/odoo#116387

Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

HTTPS certificate IoT issues can be complicated to troubleshoot
as the information are not visible/given.
This PR aim to share this information on the IoT box homepage.
As there is a lot of possible causes for a given problem,
a code is used that will be explained/detailed in Odoo's
IoT documentation:
https://github.com/odoo/documentation/pull/3818



OPW-3227004

closes odoo/odoo#114993

Signed-off-by: Loan (LSE) <lse@odoo.com>
Signed-off-by: Sens Loan (lse) <lse@odoo.com>

Register a ph contact with vat 123-456-789-012
Validation Error will raise

Currently we use check the PH vat against regexp \d{3}-\d{3}-\d{3}-\d{5}
This seems to be not correct according to the official documentation
https://serp-p.pids.gov.ph/publication/public/view?slug=taxpayer-identification-number-tin-its-development-and-importance-in-tax-administration



"""
12 digit number (E.g. 123 456 789 002), of which the first digit
identifies type of taxpayer (0 for corporations, 1-9 for individuals
and other businesses), second to eighth digits are sequential numbers
between 0 and 9, ninth digit is a check number, last three digits are
000 for individuals and head office of businesses and 001-999 for
branches of businesses, if any
"""

The TIN should be a 9 digit code + 3 for the branch code

opw-3141793

closes odoo/odoo#111519

Signed-off-by: Josse Colpaert <jco@odoo.com>

Insteadeither is added without space, adding spacing between the words.

Insteadeither  --> Instead either

closes odoo/odoo#115319

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Steps to reproduce:
- have a damaged pdf (such as in the ticket)
- Create Bill B and attach it to it
- in the list view of bills select multiple bills
- Print - Original Bills
-> Error => Ok
- Select only the Bill B
- Print - Original Bills

Issue:
You cannot print only one invoice

Cause:
Since https://github.com/odoo/odoo/commit/266a8e2a8abf936d5fbd45752ddf492d92e6a397


we are checking if the PDF's are readable before trying to merge them.
But in this case, since there is only one PDF, we don't want to
merge it

Solution:
Skip the readable_pdf check for only one pdf

opw-3142646

closes odoo/odoo#114576

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Odoo 14 uses BS v4.3.1
but `col-sm-offset-3` is a is BS class version 3 causing
a error in the message alignment because the offset in BS
4 is `offset-sm-3`

closes odoo/odoo#116142

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

Before this commit, the compute method was not returning the value for the
field karma_flag field, and thus it was returning compute method failed to
assign value error.

After this commit, the compute method will return correctly set the value
for karma_flag field from the forum.

closes odoo/odoo#116141

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

This commit fixes several bugs with the navbar and the header templates:

- The "right" alignment options didn't work with most headers. This was
due to a missing CSS rule.

- The "right/left" alignment option was reversed with the "vertical"
header template.

- The navbar collapse style was broken with the "Hamburger Full" header
template.

- This commit hides the alignment options in cases where they have no
effect ("Hamburger Full" or "Magazine" header template + not
"off-canvas"). It also changes the options label to "Mobile Alignment"
when the alignment only impacts the mobile view (since this commit =>
[1], the "alignment" option no longer only impacts the mobile view,
depending on the templates, it can also impact the "desktop" view).

- The text section of the "Magazine" header template had no background
color (It was transparent after scrolling the page).

- The "off-canvas" navbar was not positioned correctly with several
header templates (e.g. "Boxed" header template).

[1]: https://github.com/odoo/odoo/commit/2a1aa808e939eeaa3caec6a1a82e19f023f1d010



opw-2951315

closes odoo/odoo#106764

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>