- Mar 01, 2018
-
-
Quentin De Paoli authored
Make sure that all propositions/created data will be linked to the company of the processed statement line. + adapted QUnit tests Closes PR #23070. Co-authored-by:
Miquel Raïch (Eficent) <miquel.raich@eficent.com>
-
Stefan Rijnhart authored
When updating the cost on products with realtime valuation, the journal entries do not have their product_id set, whcih make it difficult to track/filter on them. Closes #18492 Closes #22281 Task 60955
-
Nicolas Martinelli authored
The decimal precision 'Account' has been removed in v9, and therefore it should not be used anymore. opw-1819517
-
- Feb 28, 2018
-
-
Martin Trigaux authored
This reverts commit 861e21c6. Failing test While the purpose seems fine, it needs more work
-
Miquel Raïch authored
demo products shouldn't have company if they will be used by other companies Was the company of the administrator Closes #21220
-
Thibault Delavallée authored
No purpose, no explanation, incorrect commit message, no review from technical and functional team, no task, separate features mixed in same commit, incorrect code. As /dev/null and its related POs manage timesheet applicationplease ask us for guidance and review before committing that kind of commits. Many thanks.
-
Thibault Delavallée authored
No purpose, incorrect commit message, incorrect tag, no review from functional team, no task. As /dev/null and its related POs manage timesheet applicationplease ask us for guidance and review before committing that kind of commits. Many thanks.
-
Kishan Gajjar authored
[ADD] hr_timesheet: Added employee_id field to form view so that default values passed in context can be set and send to server when save record
-
Kishan Gajjar authored
- set employee_id if there is default_employee_id in context
-
Christophe Matthieu authored
The method removeSrcAttribute is critical, because each changes trigger this one. this method must be optimized to the maximum to be the fastest. Before this fix, removeSrcAttribute method search the image and iframe for all body nodes instead of search only in the inserted nodes, and the method are very slow.
-
Christophe Matthieu authored
create range method slow down all the web client because the handler who use this method it's in the module (not in the widget method) and called for each click and keyup. We need only this handler for the iframe or the website, used by the rte.
-
Vandan Shah authored
UI improvement: If there is no stage then there will be no button(no status bar) but there will be stages but task or note etc.. will not be in any stage then there will be 'undefined' so by click on that ('undefined') user can move to any stages. To avoid this behavior we add a default stage in note.
-
Vandan Shah authored
-
Simon Lejeune authored
`child_of` used to return inactive records, it doesn't anymore
-
Raphael Collet authored
This replaces the former modified preorder tree traversal (MPTT) with the fields `parent_left`/`parent_right`. Each record is associated to a string `parent_path`, that represents the path from its root node to itself. The path is made of the node ids suffixed with a slash: a node | id | parent_path / \ a | 42 | 42/ ... b b | 63 | 42/63/ / \ c | 84 | 42/63/84/ c d d | 85 | 42/63/85/ This field provides an efficient implementation for parent_of/child_of queries: the nodes in the subtree of record are the ones where `parent_path` starts with the `parent_path` of record. It is also more efficient to maintain than the MPTT fields, and less sensitive to concurrent updates, because the value of `parent_path` does not depend on sibling nodes.
-
Raphael Collet authored
Simplify the implementation of parent_left/parent_right by removing this optimization.
-
Raphael Collet authored
-
mreficent authored
Was PR #23259. Courtesy of Miquel Raïch (Eficent)
-
- Feb 27, 2018
-
-
David Arnold authored
Some call signatures have not been aligned with the taxes/product/partner signature introduced by the tax cloud module and necesary by some localization modules Closes #23334 Fixes #23333
-
Florent de Labarre authored
Closes #23300
-
Christophe Matthieu authored
Simplification of the search method of the lines lines (for the propositions) of the two requests in one. The sql query returns the two matching lines without filtering after the request because we inject the rules of access rules directly into it. This is an optimization in terms of clarity and speed. In addition to the fix because the previous browse does not use access rules.
-
Christophe Matthieu authored
-
Yannick Vaucher authored
-
Christophe Matthieu authored
Contains widget reconciliation methods. This refactoring does not modify the feature, some errors have been notified in the code but not modified.
-
Fabien Pinckaers authored
-
Suraj Shukla authored
The following tweaks have been applied on mobile devices: - remove left and right arrow in control panel - enable swipe navigation (instead of left/right arrows) - replace 'Today' button by a calendar icon - remove static text 'Attendees:' in events - shorten header content in week mode to prevent them from overlapping - ensure that the calendar fits in the screen Also introduce a mobile test suite for the calendar view. Task #31449
-
Aaron Bohy authored
-
Christophe Monniez authored
The web test suite is increasing, so the test duration increases too. 6 minutes is not enough on some runbot instances.
-
- Feb 26, 2018
-
-
Quentin De Paoli authored
[IMP] account, account_bank_statement_import: create res.partner.bank only when statement lines get processed Previously, bank accounts were created at the line creation, even if the partner was unknown. That was a very weird behavior since - that use case of a res.partner.bank belonging to no one is meaningless - the default partner was actually set to the current'user company, which was even more wrong. This has been already improved by https://github.com/odoo/odoo/commit/7b322d08de2b5343cdf6935a7ae4a12f1fd61958 but that first patch ignored the use case of res.partner.bank created thr$
-
Thibault Delavallée authored
Currently the rating value coming from the rating application is stored on the message it belongs to. However storing it is not necessary as there is no direct search using it. Having a computed field is sufficient for all use cases we currently have in Odoo. Removing the store allow to gain queries. Indeed the field is not computed anymore after each message creation meaning we save queries by not having to check existing ratings. It allows to gain a lot of computation as mail.message is a critical model. On the whole community runbot when installing all modules this leads to a gain of more than 14K queries on 585K which means 2.4% of performances increase. Considering the code size of this optimization this is quite an interesting result. Looking at test_mail performance tests we gain several queries (2/3) for each new message which is coherent with the model change. Finally it allows to lessen the performance difference between tests done with test mail only and tests done with other modules already installed. This is especially simple mail thread-enable records. Related to task ID 51523. #Closes #23294. Done with blessing of @jem-odoo .
-
XavierDo authored
Also rename product.uom.categ into uom.category to give it a decent name.
-
XavierDo authored
Moves UoM models, test and data to a new addon in order to be able to use uom without product. A simple example is be to be able to use UoM for timesheets. This commit only move code, and adapt xml ids without chaging any feature or functionnal behavior. Note: 'product' module now depends on new 'uom' module.
-
Thibault Delavallée authored
Purpose of this merge is to clean a bit various methods and remove some dead code. All those commits come from other work-in-progress branches in mail aiming at improving performances and reducing code size. We can already merge some light cleaning in order to lessen diff and ease understanding of real feature-based branches. It contains * some renaming in notification methods to match the _notify prefix used in most of them; * removal of some dead code coming from old implementations of chatter; * removal of unnecessary context switch in email sending process; * small cleaning of notification group methods in various addons; It allows to gain some queries in various test_mail performance test as stated in the test_performance file update. When notification emails are sent 4 queries are gained with this merge. On the whole community runbot the impact is small (about 1K queries) probably because most of email sending part is skipped on runbot. This merge is related to the task Id 59039. #Closes #23089.
-
Thibault Delavallée authored
Overrides of _notify_get_groups are used to add some buttons in notification emails and control the display of "Access document" button. This commit cleans some overrides : * accounting: portal users that are not the customer have no access to the invoice and should not have the access button; * project: remove unnecessary override on project model and consider portal users have access to the document through customer portal; * sale: portal users that are not the customer have no access to the sale order and should not have the access button; * website_blog: display access button to everyone only if the post is published; otherwise keep standard behavior; * website_forum: display access button to everyone only if the post has not been closed or deactivated; otherwise keep standard behavior; * website_slides: display access button to everyone only if the slides has been published; otherwise keep standard behavior;
-
Thibault Delavallée authored
Send methods of mail.mail model are set private and simplified. Those methods have been written when a lot of overrides were necessary to generate notification emails. Since then the flow has changed but methods have not been updated completely. This commit therefore simplified a bit the call chain and parameters. This commit is purely technical and does not hold any functional change. Purpose is to clean code in order to prepare future changes in mail application.
-
Thibault Delavallée authored
This commit renames some internal mail.thread methods linked to the notification process. This is the next commit of a series aiming at improving code readability and method finding through prefixes. See notably cae1c397, cdfe479e and fc1348dd. This commit does not change any functional feature. It does only rename notification-related methods, using the _notify prefix to ensure they are private and to mark they are part of the notification process.
-
Thibault Delavallée authored
Commit 0d3d0e95 added a key in context when sending emails to know the target model name. It was used at that time to forge for footer of notification emails. Since that time notification emails have evolved a lot. The code based on that context key has been removed. Context key has been transformed into a context switch. However it is not used anymore and can be removed. It allows to clean a bit the code and save a context switch. This commit is purely technical and does not hold any functional change. Purpose is to clean code in order to prepare future changes in mail application. This commit allows to gain some queries in mail sending process, meaning removing context switch is interesting. One query is gained when using the send process. Complex performance test involving several message post gain 3 queries each.
-
Thibault Delavallée authored
1d57a091 added a two-steps parent fetch when posting a message on a discussion thread. At the time this commit was done responsible were notified of the first thread message. It was helpful to notify them of the original email that created the thread instead of the "document created" generic message. Indeed for documents like leads or issues having the original email containing the customer question is interesting when being notified. This is why this commit was done. However since quite a long time responsible notifications have changed. They now receive an email notification telling they have been assigned on a document. This commit is not necessary anymore and we therefore remove it in order to clean a bit the message_post process. This commit globally reverts 1d57a091. Please note that @beledouxdenis agreed after a long thinking. This commit has a slight impact on mail performance tests, allowing to save one query in some more complex test case.
-
Thibault Delavallée authored
Purpose of this commit is to simplify a bit message_post API. It has a content_subtype parameter allowing to receive plaintext content. It is then automatically converted into html. This commit removes the parameter and consider the content is always html. Code calling message_post should handle the conversion. In Odoo the only use was in the chat_post controller that now perform the plaintext to html conversion before calling message_post. This commit is purely technical and does not hold any functional change. Purpose is to clean code in order to prepare future changes in mail application.
-
Thibault Delavallée authored
Posting on users is not supported anymore. It was implemented in a time we thought having a twitter-like behavior in Odoo was a good idea. Posting on users was redirected on its related partner in mail. It was redirected on its related employee in hr. It does not make sense anymore as employee are records with limited access and partners used for other purpose than discussing notably in accounting. Now that we have chat channels it makes no sense to have this kind of behavior still implemented. Let us remove it. No functional change should occur with this commit.
-