Skip to content
Snippets Groups Projects
  1. Jul 06, 2020
  2. Jul 03, 2020
  3. Jul 04, 2020
  4. Jul 03, 2020
    • oco-odoo's avatar
      [FIX] account: cash basis taxes: Make cash basis taxes work with the new tax report in any case. · 718f2aed
      oco-odoo authored
      Before that, since https://github.com/odoo/odoo/commit/71ee252dc43fd0e2b86ba8079c31915544e528eb , negative invoice lines were not supported by thoses taxes. Nor were miscellaneous entries. To make them work, we change the way tags are assigned to cash basis taxes : instead of copying them from the invoice, sign included, we now change their sign when appropriate, so that the resulting cash basis move can be treated like any regular miscellaneous operation by the tax report (so, always applying a factor of 1 to its lines' balance).
      
      Doing that also allows us to re-simplify the code used in the tax report and tax audit computation to manage cash basis entries, and makes the cash basis entry more standard. This is also a usability improvement: now the user does not have to search for the original invoice to understand how the CABA entries are going to impact the report: it's always managed like a misc. operation, so he can just trust the signs of the tags.
      
      v13 version of https://github.com/odoo/odoo/pull/53085
      
      
      
      closes odoo/odoo#54058
      
      X-original-commit: 20850301f5025ffd1a05e0594f6d26d2a61759ef
      Related: odoo/enterprise#11652
      Signed-off-by: default avatarLaurent Smet <smetl@users.noreply.github.com>
      Signed-off-by: default avataroco-odoo <oco-odoo@users.noreply.github.com>
      718f2aed
    • Laurent Smet's avatar
      [FIX] account_facturx: Fix facturx xml with discount, group of taxes and multi-currency · 187dc351
      Laurent Smet authored
      
      - Fix discount indicator with 100.0% discount.
      - Fix reported tax amount with group of taxes.
      - Fix reported tax_base_amount with foreign currency.
      - Fix invoice summary according the facturx xsd.
      
      closes odoo/odoo#54080
      
      X-original-commit: e97333f6d80eaa5807467a863a9c8f5850e1d644
      Related: odoo/enterprise#11657
      Signed-off-by: default avatarQuentin De Paoli (qdp) <qdp@openerp.com>
      Signed-off-by: default avatarLaurent Smet <smetl@users.noreply.github.com>
      187dc351
    • Laurent Smet's avatar
      [IMP] account: Allow mocking a datetime in mocked_today · aa7dd77a
      Laurent Smet authored
      X-original-commit: a9a1d8e5348010eca7de15199faae1f2469d96ff
      aa7dd77a
    • Laurent Smet's avatar
      [IMP] account: Add a new setupclass to test the result of e-invoice xml · ddf9f0f4
      Laurent Smet authored
      X-original-commit: 955db1203599516bdbefeedee37de6b8ad69bf12
      ddf9f0f4
    • Odoo's Mergebot's avatar
      [FW][FIX] web: unsafe access to config property & extract lib's input setter · 8117907b
      Odoo's Mergebot authored
      
      During TempusDominus autobinding to fields matching its default classes
      (like `.datetimepicker-input` used by our DatePicker widget) and no
      config was previously provided to the library (like when we disable it
      on mobile), an unsafe access to the config's `_options` property results
      into an error as the config is `undefined`.
      
      This PR fixes it by first checking for config existence before
      attempting to access its property.
      
      It also extracts the DatePicker widget's input setter to allow
      overriding it and preventing from calling the `datetimepicker` lib when
      not initialized (like on mobile).
      
      opw-2242880
      
      closes odoo/odoo#54068
      
      Forward-port-of: odoo/odoo#54039
      Forward-port-of: odoo/odoo#54005
      Related: odoo/enterprise#11654
      Signed-off-by: default avatarAdrien Dieudonné (adr) <adr@odoo.com>
      Signed-off-by: default avatarPierre Paridans <pparidans@users.noreply.github.com>
      8117907b
    • Martin Trigaux's avatar
      [FIX] hr_attendance: format hour according to locale · 88786d61
      Martin Trigaux authored
      
      The time to display the check in/check out time was hardcoded to
      HH:mm:ss while other locales may use different formats.
      Use the appropriate time utils to retrieve the right format that uses
      the time format from the res.lang record.
      
      Fixes odoo/odoo#50527
      
      closes odoo/odoo#54079
      
      X-original-commit: 47707e1b
      Signed-off-by: default avatarMartin Trigaux (mat) <mat@odoo.com>
      88786d61
    • Pierre Paridans's avatar
      [FIX] web: TempusDominus unsafe access to config · c9ba9dc9
      Pierre Paridans authored
      During TempusDominus autobinding to fields matching its default classes
      (like `.datetimepicker-input` used by our DatePicker widget) and no
      config was previously provided to the library (like when we disable it
      on mobile), an unsafe access to the config's `_options` property results
      into an error as the config is `undefined`.
      
      This commit fixes it by first checking for config existence before
      attempting to access its property.
      
      Note: as this is a fix inside a library, a comment is added to make
      clear. Also similar fixes where already done in the same file.
      
      opw-2242880
      
      X-original-commit: fe1f7c3e361bbd249b4025a464c546f478b6e989
      c9ba9dc9
    • Pierre Paridans's avatar
      [FIX] web: extract date picker's input setter · eba83edd
      Pierre Paridans authored
      This commit extracts the DatePicker widget's input setter to allow
      overriding it and preventing from calling the `datetimepicker` lib when
      not initialized (like on mobile).
      
      Note: this change will be used on enterprise.
      
      opw-2242880
      
      X-original-commit: c0413868a8728500c52b7e1dd9a0035f90b654fd
      eba83edd
    • Julien Mougenot's avatar
      [FIX] web: Support widgets in search view · ff6263dd
      Julien Mougenot authored
      
      Since the refactor of the control panel, support of "widgets" attributes
      in the search view archs has been inadvertently dropped.
      
      Now, they are once again supported.
      
      Task 2061795
      
      closes odoo/odoo#54066
      
      X-original-commit: f33b0bc7a93e60bd0ed00b40d7459225ec0b749a
      Signed-off-by: default avatarAaron Bohy (aab) <aab@odoo.com>
      Signed-off-by: default avatarJulien Mougenot (jum) <jum@odoo.com>
      ff6263dd
    • Antoine Prieels's avatar
      [FIX] hw_drivers, pos: Move IoTBox version file · 6c97a9eb
      Antoine Prieels authored
      
      We move the IoT Box version file from /home/pi to /var/odoo
      so its not overriden after an auto-flash of the IoT Box.
      
      closes odoo/odoo#54063
      
      X-original-commit: ce0700ce401523267b5a8bd5665a368cfea24912
      Signed-off-by: default avatarQuentin Lejeune (qle) <qle@odoo.com>
      6c97a9eb
    • Nasreddin (bon)'s avatar
      [FIX] stock: Display translated picking description in delivery slip · cc0713dc
      Nasreddin (bon) authored
      
      Issue
      
      	- Install English and French languages
      	- Create a customer contact and assign french as his language
      	- Create a product with correct names in both languages.
      	  For example 'French product name' and 'English product name' for easy reference.
      	- Create an inventory transfer with the french customer as contact
      	- Add the product that you created
      	- Print > Delivery Slip
      
      	The report will show in the lines:
      	"""
      	French product name
      	English product name
      	"""
      
      Cause
      
      	Getting product description without checking partner language.
      
      Solution
      
      	If partner is set, get product description with partner language in context.
      
      opw-2280490
      
      closes odoo/odoo#54061
      
      X-original-commit: cebe2cf57e68e2d1d54cd442aff6ba7d9554d043
      Signed-off-by: default avatarNicolas Martinelli (nim) <nim@odoo.com>
      Signed-off-by: default avatarbon-odoo <nboulif@users.noreply.github.com>
      cc0713dc
    • Odoo's Mergebot's avatar
      [IMP] delivery, product_expiry, stock: improve delivery slip · 9d7f3be8
      Odoo's Mergebot authored
      
      Improve delivery slip with following features:
      
      1. Group Kit components on the delivery slip
      - Split kit components by kit "sections"
      
      2. Print one line per product whatever the tracking
      - Combine duplicate product move lines when "Display Lots & Serial Numbers on Delivery Slips" is not activated or no lots/serial numbers are assigned in the picking
      
      3. Group packages on the delivery slip
      - Split products up by package "sections"
      - Print package info such as "weight"
      
      4. Expiration Dates
      - Give option to print lot/serial number expiration dates on delivery slip
      
      Task: 2008609
      
      Description of the issue/feature this PR addresses:
      
      Current behavior before PR:
      
      Desired behavior after PR is merged:
      
      --
      I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
      
      closes odoo/odoo#49832
      
      Signed-off-by: default avatarArnold Moyaux <amoyaux@users.noreply.github.com>
      9d7f3be8
    • Jorge Pinna Puissant's avatar
      [FIX] hr: activity type responsible on hr plans · 600bfa11
      Jorge Pinna Puissant authored
      
      fine-tuning of bf8a9af1
      
      - Employees > Configuration > Activity Planning > Plans and ensure the
        activities have different responsible;
      - Create a new Employee, assign a Manager (a different user then the one
        connected, you can assign Marc Demo for example);
      - Click launch plan.
      
      Before this commit, the activity type responsible is ignored and the
      responsible for all activities is the connected user.
      
      Now, the responsible for the activities are assigned taking into account
      the activity type configuration.
      
      opw-2265631
      
      closes odoo/odoo#54054
      
      X-original-commit: 0f4ec369
      Signed-off-by: default avatarJorge Pinna Puissant (jpp) <jpp@odoo.com>
      600bfa11
    • Yannick Vaucher's avatar
      [FIX] l10n_ch - Swiss QR layout cleaning · 3230ae64
      Yannick Vaucher authored
      
      This intend to enforce specifications and improve readability
      
      Layout changes:
      
      * [FIX] Amount section must be placed under the QR code
      * [FIX] Don't display empty additional information
      * [FIX] Rename slip sections and labels
      * [IMP] Rework of the layout
      
          Group content like adresse by removing line spacing
          Reduce character size to follow Swiss Implementation Guidelines QR-bill v2.1
          Reduce left margin to avoid overlap of spaced ISR reference on the Receipt
      
      * [FIX] Missing street on Receipt
      * [FIX] Add thousand separators
      
          Official specs asks for:
          - thousand separators as blank. (using a non breaking to avoid spliting the amount)
          - decimal separators as a full stop
      
          > If  the  amount  isincluded  in  the  Swiss  QR  Code,  then  it  must  be  printed  after  the currency code. A blank (space) should be used as the thousands separator and a full stop «.»as  the  decimal  separator.  The  amount  must  always  include  two  decimal places (e.g. CHF 1 590.00).
      
      QR-Code:
      
      * [IMP] Align QR code upper and improve accuracy of size
      
          Add an option on reportlab to print QR Code without surounding blank space
          this is required to compute with accuracy the width of 46mm x 46mm defined
          in the specs.
      
      * [FIX] Street and street2 issues
      
          Removes an extra space between street values when only one is given.
          Test the right partner street, only the company street was checked.
      
      QRR generation
      
      * [FIX] make it possible to generate QRR
      
          It must be possible to generate QRR without ISR subscription number.
      
      Content removed as not present in the specs version 2.1:
      
      * [RM] procedure section
      * [RM] due date
      
      Translations:
      
      * [IMP] Add translations of the QR-bill in DE, FR and IT
      * [FIX] QR-bill lang is now based on customer lang
      
      Tests:
      
      * [IMP] Add unit tests for Swiss reality check for the QR-bill
      
      closes odoo/odoo#54053
      
      X-original-commit: 4f4edd0594b29252a5d44281cc773230c09521e9
      Signed-off-by: default avataroco-odoo <oco-odoo@users.noreply.github.com>
      3230ae64
    • Tiffany Chang (tic)'s avatar
      [IMP] product_expiry: Position product Expiration Dates better · 0aa0984f
      Tiffany Chang (tic) authored
      This commit makes it so the 'expiry_and_lots' settings in the product
      form appear underneath the corresponding checkbox that makes them
      visible. Previously it was appearing in the column before the checkbox
      and moving other form fields in a non-intuitive way.
      0aa0984f
    • Tiffany Chang (tic)'s avatar
      [IMP] sale,sale_stock: use "attributes" instead of "replace" position · a952829c
      Tiffany Chang (tic) authored
      Minor update to task 2041853 specification 10: hide "Expected date" if
      delivery took place. Replace the position="replace" with the more
      long term maintainable position="attributes".
      
      Updates Task: 2041853
      a952829c
    • Tiffany Chang (tic)'s avatar
      [IMP] delivery, mrp, stock: group delivery slips by kit · a60527bd
      Tiffany Chang (tic) authored
      This commit extends the delivery slip so that products added as a kit
      component to a stock.picking are grouped together by kit (or non-kit)
      when at least 1 kit exists. Kit grouping occurs for products from a kit
      without a package assigned. Non-kit section appears only when no
      packages are assigned.
      
      Implementation notes:
      - Sub-kits (i.e. kits within kits) of kits are purposely not included
      - Duplicate product names with different BOMs will be merged into one
        since there is no straightforward way to distinguish them within
        current db structure
      - There are some cases where this doesn't work as expected and may lead
        to components being grouped together under the same kit even if they
        are from different kits (e.g. kit1 has bolts and so does kit2 => on
        slip bolts will only show under kit1 section). Two cases where this
        happens is when kits are added before 'Operation Type' is specified
        and 'Operation Type = Manufacturing'
      
      This completes subsection 1 of overall Improve delivery slip task.
      
      Task: 2039720
      a60527bd
    • Tiffany Chang (tic)'s avatar
      [IMP] product_expiry: Add delivery slip expiration dates · 5ebf1f5d
      Tiffany Chang (tic) authored
      This commit adds the option to have lot/serial number expiration
      dates be included in a delivery report (via settings). This is only
      applicable for stock.picking where 'State=Done', when 1 or more
      lot/serial numbers are used, and 1 or more lot/serial number expiration
      dates exist.
      
      This completes subsection 4 of overall Improve delivery slip task.
      
      Task: 2039720
      5ebf1f5d
    • Tiffany Chang (tic)'s avatar
      [IMP] delivery, stock: group delivery slip packages · d20467bb
      Tiffany Chang (tic) authored
      This commit makes it so if a delivery slip contains 1 or more packages
      then move lines will be split by package (and non-package) groups with a
      "section line" between them. This only applies to when a stock.picking
      is 'State=Done'.
      
      In order to accomodate complexity of splitting by package + grouping by
      product unless printing serial numbers/lots + template inheritance,
      reoccurring parts of the template are split into their own templates and
      called. Relevant inheritance has been updated to match.
      
      Additionally, picking.shipping_weight calculation has been updated so if
      a pack.weight = 0 then calculation will default to the calculated
      product weight. This prevents inconsistency between the "Total Weight"
      at the top of the Delivery Slip and the package sections' displayed
      weights. To distinguish which value is being used, package sections that
      use the total product weight rather than the pack.weight have
      "(estimated)" after it.
      
      This completes subsection 3 of overall Improve delivery slip task.
      
      Task: 2039720
      d20467bb
    • Tiffany Chang (tic)'s avatar
      [IMP] stock, delivery: aggregate delivery slip product lines · 0accbd6e
      Tiffany Chang (tic) authored
      This commit makes it so move_lines with the same product+description+uom
      are grouped together ONLY WHEN serial numbers/lots are not to be
      printed. This is the case when the setting "Display Lots & Serial
      Numbers on Delivery Slips" is not active or when there are no
      lots/serial numbers assigned in the picking. This is only applicable for
      stock.pickings that are 'state=Done'.
      
      In order to implement this, some clean up of lots/serial numbers printing
      was also done.
      
      This completes subsection 2 of overall Improve Delivery Slip task.
      Task: 2008609
      0accbd6e
    • Ravi Singh's avatar
      [FIX] web_editor: leftover rename video type in media dialog. · 28ed951d
      Ravi Singh authored
      this fixes is related to this PR https://github.com/odoo/odoo/pull/41561 where
      are broken the behaviour of options for media dialog.
      In this commit, we have changed classes names to fix the broken behavior of
      options in the video tab of media dialog.
      
      task-2154812
      Closes https://github.com/odoo/odoo/pull/52135
      
      
      
      closes odoo/odoo#54041
      
      X-original-commit: fafbd7525c481dfed6a3df2a5cd15fbd01ab4d31
      Signed-off-by: default avatarJérémy Kersten (jke) <jke@openerp.com>
      28ed951d
    • Jigar Vaghela's avatar
      [FIX] stock_account/sale_stock: correctly valuate the product in below use case · 12b4a24b
      Jigar Vaghela authored
      
      Below is the case of product with automated valuation:
      - You bought 8 units @ 10$.
      - Then you deliver 10 units of the product.
      - You assumed the missing 2 should go out at a value of 10$
        but you are not sure yet as it hasn't been bought in Odoo yet.
      - Afterwards, you buy missing 2 units of the same product at 12$.
      
      In this case the product has been undervalued when delivered without stock,
      the vacuum entry is the following one (this entry already takes place):
      
      Account                         | Debit   | Credit
      ===================================================
      Stock Valuation                 | 0.00     | 4.00
      Stock Interim (Delivered)       | 4.00     | 0.00
      
      So, on delivering product with different price,
      We should create additional journal items like:
      Account                         | Debit    | Credit
      ===================================================
      Stock Interim (Delivered)       | 0.00     | 4.00
      Expenses Revaluation            | 4.00     | 0.00
      
      closes odoo/odoo#52396
      
      Task: 2224025
      Closes: #52396
      Signed-off-by: default avatarSimon Lejeune (sle) <sle@openerp.com>
      12b4a24b
    • Mathieu Duckerts-Antoine's avatar
      [FIX] web: correctly reload categories · c9977001
      Mathieu Duckerts-Antoine authored
      
      In the search panel, the categories, i.e. fields select="one",
      with attributes expand="0", and enable_counters="0" (defaults) were not
      correctly updated when the domain outside of the search panel was
      updated. This is no longer the case.
      
      closes odoo/odoo#54040
      
      X-original-commit: 99e9cac63f5034c1ba2154779fe82170dd656236
      Related: odoo/enterprise#11642
      Signed-off-by: default avatarAaron Bohy (aab) <aab@odoo.com>
      c9977001
    • Mathieu Duckerts-Antoine's avatar
      [FIX] web: reload search panel before view model · 9aa3297b
      Mathieu Duckerts-Antoine authored
      Problem:
      
      Go to the application apps, select accounting in the search panel,
      then filter on lunch in the search bar: the category all is displayed
      as selected in the search panel (accounting is no more a valid value
      since expand="0") but the application lunch does not appear in the
      kanban view.
      
      Root cause:
      
      The kanban model is reloaded with the old domain using accounting
      without waiting the search panel to be reloaded but it is only known
      after the search panel has been reloaded that the accounting value is no
      more valid and that all should be selected instead of accounting, thus
      that the domain used by the kanban model should be updated.
      
      Solution:
      
      The solution to the problem is simple: first reload the search panel,
      then reload the view model with the updated domain.
      
      X-original-commit: 8589babcd0f2c15433fe1eb06d0d745e80d01c22
      9aa3297b
  5. Jul 02, 2020
  6. Jul 03, 2020
  7. Jul 02, 2020
Loading