opw-3266332

closes odoo/odoo#121445

Signed-off-by: William André (wan) <wan@odoo.com>

To reproduce:
1. Create a Sales Order for a product whose product category is set to
   FIFO and automated. Use route "dropship".
2. Confirm the PO created.
3. Deliver the products (DS transfer)
5. Return, for example, 1 unit of product
6. Return the return

This is a continuation of commit f9a1c1d7bb8234eb96c48dddae9930a419bfb696
If the origin of the move is a dropshipped_returned, then the error describe in the mentioned commit will still happen.

opw-3283436

closes odoo/odoo#126685

Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

Syntax Error generates when the user gives invalid python code in 'account_tax'
module and uses that tax while creating invoice.

Steps to produce:
 * Install 'account_tax_python' module
 * Go to configuration/taxes and create a new tax.
 * Select Tax Computation as 'python code' and give some special characters to
   python code field and save it.
 * Now create an invoice, add a  product and add the above created tax in taxes.
 * At this moment traceback raises.

By applying these changes will resolve this issue.

closes odoo/odoo#122290

Sentry: 4060222060
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

## Bug

Let's say you make an expense in a foreign currency on date A. Then
you include this expense in an expense report. You set the report's
accounting date to B and post the journal entries. The system will
calculate the expense amounts based on the exchange rate on Date B.
But really, it should be using the exchange rate from Date A, the day
when the expense was made.

## Steps to reproduce

* Enable multicurrency and make sure that you have different exchange
  rates configured for two different dates, which we'll refer to as
  Date A and Date B.
* Create an expense with a foreign currency and set the expense date to
  Date A.
* Save and click `Create Report`
* Submit to manager, and approve the report
* Navigate to the 'Other Info' tab and set the report's accounting date
  to Date B.
* Save and post the journal entries

Now, review the generated journal entries. You might notice that the
expense values have been calculated using the exchange rate from Date B,
rather than Date A.

opw-3119959

closes odoo/odoo#120932

Signed-off-by: Laurent Smet (las) <las@odoo.com>

When having lock date for non advisor
set before all user lock date, reconiling
lines between the two lock dates leads
to a wrong calculation of the cash basis
move, even for user with advisor rights.

Steps:

- With a company having cash basis activated
- Set a period_lock_date to a specific date
- Set a fiscalyear_lock_date one month later
  than period_lock_date
- With user having Advisor rights, create
  an invoice between the two lock dates
- Register a payment in the same period
-> Cash Basis move is created with date == today,
   it should be the date of the payment.

opw-3245409

closes odoo/odoo#126316

Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

Before this commit:
The channel name used to overflow in the channel suggestion section.

After this commit:
The name will not overflow in the channnel suggestion section.

Task id: 3366608

closes odoo/odoo#126359

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

When updating taxes, children_tax_ids were not correctly set on
the parent tax.
This is a backport of multiples fixes applied in 15.0 and above:
- https://github.com/odoo/odoo/commit/60d5881368aa83307cf3d99a17df379d2b15417a
- https://github.com/odoo/odoo/commit/3f6fc7084789d73d128c59ced4ab1021ccb79b1e
- https://github.com/odoo/odoo/commit/a239c193208b87b88b24a1d7e0b50481e08b4b17
- https://github.com/odoo/odoo/commit/2fd0d2bbaac383949012e9340172c6062f0883e1



closes odoo/odoo#126360

Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

The error will occur when a user try to print POS inalterability check report
for pos orders when accounting is not unalterable for that company.
steps to produce:

1. install l10n_fr_pos_cert the  module
2. switch to company other than FR company
3. pos > reporting > POS inalterability check .

when the company's country is not in unalterable country :
https://github.com/odoo/odoo/blob/3b88958f5a07edf86d2fc9c8080ee46d16b872ef/addons/l10n_fr/models/res_company.py#L14-L24

1. so,`_check_pos_hash_integrity()` gets Nonetype which will lead to above
traceback, when trying to update the data dictionary.
2. Also, `_check_hash_pos_integrity()` is not defined in our standard code so ,
this commit optimize the `_get_report_values` method.
see : https://github.com/odoo/odoo/blob/3b88958f5a07edf86d2fc9c8080ee46d16b872ef/addons/l10n_fr_pos_cert/report/pos_hash_integrity.py#LL11C1-L22



sentry-4243853702

closes odoo/odoo#124664

Signed-off-by: Achraf Ben Azzouz (abz) <abz@odoo.com>

[FIX] account : fixes wrong domain of invoice and bill, uses 'in' operator to match move_type against a tuple instead of '=' operator.

closes odoo/odoo#122207

Signed-off-by: William André (wan) <wan@odoo.com>

Part-of: odoo/odoo#122207

Before this PR, when moving the snippet's position, `d-none` gets added
which should not.
With this PR, the `cleanForSave` method is removed as it applied that
`d-none` and the logic is added to the `destroy` method of the public
widget (on page load, we make the snippet visible when discussion group
info is processed and so it is logical to hide it again in `destroy`).

task-3107451

closes odoo/odoo#108790

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Before this commit:
 If the barcode nomenclature uses the or `|` symbol.
 The part after it would be used as a "contains" instead of a
 "start with".
 e.g: `123|456`
 would be transformed in the JS code to `^123|456` instead of:
 `^123|^456`
 As such, you would have error "can't find product with barcode" if
 you set such a rule and a product barcode contains the second part.
 For e.g: the barcode `44445666` would match, but should not!

After this commit:
 Force the second (and following if any) part to start with.

Note: in practice it is pretty rare to have `|` in the pattern, but
it is the case for a default rule in version 16, see:
https://github.com/odoo/odoo/blob/5ac58ebf983c1c02019253c0430fde3502e13e7c/addons/pos_loyalty/data/default_barcode_patterns.xml#L10


In this case, if a regular product have `044` in its product barcode,
the PoS will tell that there is no corresponding coupon instead of
adding the product.
But the issue itself still apply in version 14 in case of custom rules

opw-3356951

closes odoo/odoo#125390

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

Before this commit, if you reset your microsoft callendar account and
set to remove events from Odoo, it won't remove them. The problem is
that the ('ms_universal_event_id', '!=', False) condition is not
implemented, and it can't remove the existing events.

opw-3382445

closes odoo/odoo#126097

Signed-off-by: Arnaud Joset (arj) <arj@odoo.com>

In Website, since the `#wrapwrap` element is being scrolled on the
pages, we added a function called `compensateScrollbar` (added by this
commit [1]) that adds space on the right side equal to the width of the
scrollbar when a modal is open or to adjust the position of the fixed
header when a page is scrolled.

However, this `compensateScrollbar` function did not handle RTL pages
correctly, where the scrollbar is on the left instead of the right. As a
result, on RTL language pages, this space was added on the wrong side.

This commit fixes the issue by placing the space on the left instead on
RTL pages.

Steps to reproduce the bug:
- Select Arabic as the primary language for a website.
- In edit mode, drag and drop a popup onto a page.
- Bug: When the popup is open, space is added on the right to compensate
for the scrollbar, but it should be on the left instead.

[1]: https://github.com/odoo/odoo/commit/ebd0c90a146145079061e79c2d4c37fa182a2975



task-3102275

closes odoo/odoo#126506

Signed-off-by: Benoit Socias (bso) <bso@odoo.com>

Steps to Produce:-
- Install `Advanced Events`
- Go to ` website` then `Configuration`
- Open `setting`
- Then change favicon and Select svg type file and click on save
- Traceback is here

Cause :-
- The traceback occurs when an SVG image is passed to the ImageProcess method.
 In this scenario, the method sets the image as false, and then attempts to
access its size, resulting in the traceback

Fix :-
- The issue has been resolved by implementing a condition check for the image
before accessing its properties. This ensures that the image is valid before
trying to retrieve its size, preventing the traceback from occurring.

sentry-4199175498

closes odoo/odoo#122300

Signed-off-by: Achraf Ben Azzouz (abz) <abz@odoo.com>

A TypeError is thrown when an AST node is passed to `literal_eval`
because a string is expected and the object has no len().

Check the type of the expression and make sure it's a string before
calling len() on it.

closes odoo/odoo#126520

Signed-off-by: Vranckx Florian (flvr) <flvr@odoo.com>

Before this commit, in other numbering systems than "latn", the time
pickers did not allow to select hours/minutes/seconds. This was because
the lib (TempusDominus) would use `parseInt` internally to retrieve the
selected value, which was not a latin number in other numbering systems.

This commit changes 2 things directly in the lib file:

- allow the internal `getMoment` function to accept a second 'format'
parameter;

- use that same `getMoment` function to parse the text of the selected
value, effectively using moment to both parse and format the values
displayed in the picker and ensuring consistency.

OPW-3258034

closes odoo/odoo#125234

Signed-off-by: Bruno Boi (boi) <boi@odoo.com>

The return tax should only be used through its parent tax,
we don't want it to be accessible directly on bills or invoices.

opw-3347425 (2nd issue)

closes odoo/odoo#124781

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

closes odoo/odoo#126038

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

When a user tries to access the URL directly, at that time the value of
dictionary `kw` is not available. The error will be generated.

Error : KeyError: 'state'

This commit will prevent the traceback.

sentry-3947033806

closes odoo/odoo#124450

Signed-off-by: Achraf Ben Azzouz (abz) <abz@odoo.com>

Revision odoo/odoo@cabb9e7e573b86cd523980588360d8514090d370 introduced a
regression: This is no longer possible to import a data module
using `<field file="..."/>` in their data file.

This revision targets to restore the feature as expected.
The unit tests added covers the feature, so that regression
no longer happens in the future.

It introduces a new concept of temporary directory `file_open`
can read from.
e.g.
```py
with odoo.tools.file_open_temporary_directory(self.env) as module_dir:
   with zipfile.ZipFile('foo.zip', "r") as z:
      z.extract('foo/__manifest__.py', module_dir)
   with odoo.tools.file_open('foo/__manifest__.py', env=self.env) as f:
      manifest = f.read()
```

Note that `file_open` will be allowed to read from that temporary
directory only if `env` is passed to `file_open`,
and if the `env` is part of the same transaction/request than the `env`
passed to `file_open_temporary_directory`.

This is to avoid having users, whether from other databases,
or even the same database,
trying to access these directories not belonging to them.
e.g. If an admin uploads sensitive data in this temporary directory,
no one than him must be allowed to read from these files, not even
another user from his database.

closes odoo/odoo#126278

closes odoo/odoo#126337

Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>

When parsing an email containing an xml attachment, the `email` python
module will decode the base64 attachment using the charset or ascii if
the charset is missing.

In some cases, the payload is in UTF-8 but the charset is omitted. This
results in replacement characters for the non ASCII characters.

The solution is to force the charset to UTF-8, since it is a superset of
ASCII that should not be a problem.

NB1: Omitting the charset for text/xml is not recommended. See the RFC
(section 6.4): https://www.ietf.org/rfc/rfc2376.txt



opw-3144519

closes odoo/odoo#125628

Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>

Steps to reproduce:
- Install the lux localization
- Configure Peppol for a customer: Select a customer > tab accounting > under "electronic invoicing":
format: Peppol BIS Billing 3.0
Peppol e-address: 0130 - Directorates of the European Commission
Peppol Endpont: testendpoint

- Create an invoice for the peppol customer
- Add a section or a note in the Invoice
- Confirm the Invoice

Issue:
Raise user error:  Odoo requires a tax for EACH LINE, instead of each product

Solution:
Exclude the section/note line

opw-3354757

closes odoo/odoo#124806

Signed-off-by: Laurent Smet (las) <las@odoo.com>

Currently, it's not possible to check the 'Peppol Bis 3' option on the
journals of Italian companies, since Italy is not present in our mapping
`COUNTRY_EAS`.

The EAS for Italian companies may be the codice fiscal (code: 0210) or
the VAT number (code: 0211). See
https://peppol.agid.gov.it/en/news/expiration-validity-codes/



Use the VAT number by default, and add it in our mapping such that the
option now appears for Italian companies.

opw-3346572

closes odoo/odoo#126168

Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

JSONDecoderError occurs when users enters invalid JSON format data in
'Default Value' field inside 'User-defined Defaults' and wherever this field is
being accessed to get default value this traceback will be generated.

Steps to reproduce:
1) Install 'Contacts' module.
2) Open 'Settings' > 'Technical' > 'User-defined Defaults'.
3) Click on record 'Language' > 'EDIT' button > in 'Default Value' field enter
   any improper JSON format data (e.g 'Maa' : FI ) .
4) Now, open 'Contacts' module > click on 'CREATE' button and traceback would be
   generated.

By applying this, it will check for proper JSON format.

Sentry-4169062951

closes odoo/odoo#124051

Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>

closes odoo/odoo#105495

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

When a user creates a link that is tracked, an interface with graphs is
presented to him so that he can track the performance of his tracked
link. Unfortunately, these graphs did not work when the site was in a
foreign language. This was due to the fact that the code had not been
designed to handle this. This commit fixes the code so that it works in
all languages.

Note that the data is received via RPC and the python code format the
dates for the current language of the website. So we had to do a little
hack to make it work properly.

Steps to reproduce the issue:
- Install website_links module
- Go to the website app
- Click on Promote > Link Tracker
- Create a tracked link
- Visit the link
- Install Arabic (Syria) for your website
- Check the stats of your link in Arabic

=> There is a traceback and the data is not displayed.

task-3289167

closes odoo/odoo#119375

Signed-off-by: Outagant Mehdi (mou) <mou@odoo.com>

This commit ensures that the unsplash beacon calls home when an unsplash
image appears on a page.

To achieve this it patches the RPC call when the test URL contains the
test name as parameter. The patch cancels the actual beacon call to
avoid polluting data during the test, but marks the image as having had
its beacon message sent. The test then simply checks if this marker
appears on the image.

task-3360109

closes odoo/odoo#125028

Signed-off-by: Outagant Mehdi (mou) <mou@odoo.com>

In the start_sync method, the logger is updated to use the 'warning' level
instead of the 'error' level. This change reflects a less severe logging level
for cases where sending a partner to sync fails.

The changes have been made to reduce the noise level in the sentry.

sentry-3955309841

closes odoo/odoo#123827

Signed-off-by: Louis Baudoux (lba) <lba@odoo.com>