Skip to content
Snippets Groups Projects
  1. Jun 29, 2023
  2. Jun 28, 2023
    • can-odoo's avatar
      [FIX] website_mail_channel: stop discussion block disappearing on move · 9b39c52e
      can-odoo authored
      
      Before this PR, when moving the snippet's position, `d-none` gets added
      which should not.
      With this PR, the `cleanForSave` method is removed as it applied that
      `d-none` and the logic is added to the `destroy` method of the public
      widget (on page load, we make the snippet visible when discussion group
      info is processed and so it is logical to hide it again in `destroy`).
      
      task-3107451
      
      closes odoo/odoo#108790
      
      Signed-off-by: default avatarQuentin Smetz (qsm) <qsm@odoo.com>
      9b39c52e
    • Loan (LSE)'s avatar
      [FIX] barcodes: handle `^` with `|` barcode rule patterns · 2f7ad488
      Loan (LSE) authored
      Before this commit:
       If the barcode nomenclature uses the or `|` symbol.
       The part after it would be used as a "contains" instead of a
       "start with".
       e.g: `123|456`
       would be transformed in the JS code to `^123|456` instead of:
       `^123|^456`
       As such, you would have error "can't find product with barcode" if
       you set such a rule and a product barcode contains the second part.
       For e.g: the barcode `44445666` would match, but should not!
      
      After this commit:
       Force the second (and following if any) part to start with.
      
      Note: in practice it is pretty rare to have `|` in the pattern, but
      it is the case for a default rule in version 16, see:
      https://github.com/odoo/odoo/blob/5ac58ebf983c1c02019253c0430fde3502e13e7c/addons/pos_loyalty/data/default_barcode_patterns.xml#L10
      
      
      In this case, if a regular product have `044` in its product barcode,
      the PoS will tell that there is no corresponding coupon instead of
      adding the product.
      But the issue itself still apply in version 14 in case of custom rules
      
      opw-3356951
      
      closes odoo/odoo#125390
      
      Signed-off-by: default avatarJoseph Caburnay (jcb) <jcb@odoo.com>
      2f7ad488
    • pedrambiria's avatar
      [FIX] microsoft_calendar: delete events correctly when reseting account · c4d8530c
      pedrambiria authored
      
      Before this commit, if you reset your microsoft callendar account and
      set to remove events from Odoo, it won't remove them. The problem is
      that the ('ms_universal_event_id', '!=', False) condition is not
      implemented, and it can't remove the existing events.
      
      opw-3382445
      
      closes odoo/odoo#126097
      
      Signed-off-by: default avatarArnaud Joset (arj) <arj@odoo.com>
      c4d8530c
    • Benjamin Vray's avatar
      [FIX] web: fix the scrollbar compensation for rtl pages · 9e126f7f
      Benjamin Vray authored
      In Website, since the `#wrapwrap` element is being scrolled on the
      pages, we added a function called `compensateScrollbar` (added by this
      commit [1]) that adds space on the right side equal to the width of the
      scrollbar when a modal is open or to adjust the position of the fixed
      header when a page is scrolled.
      
      However, this `compensateScrollbar` function did not handle RTL pages
      correctly, where the scrollbar is on the left instead of the right. As a
      result, on RTL language pages, this space was added on the wrong side.
      
      This commit fixes the issue by placing the space on the left instead on
      RTL pages.
      
      Steps to reproduce the bug:
      - Select Arabic as the primary language for a website.
      - In edit mode, drag and drop a popup onto a page.
      - Bug: When the popup is open, space is added on the right to compensate
      for the scrollbar, but it should be on the left instead.
      
      [1]: https://github.com/odoo/odoo/commit/ebd0c90a146145079061e79c2d4c37fa182a2975
      
      
      
      task-3102275
      
      closes odoo/odoo#126506
      
      Signed-off-by: default avatarBenoit Socias (bso) <bso@odoo.com>
      9e126f7f
    • Adesh Jolhe's avatar
      [FIX] website_event_track: resolve issue with setting SVG as favicon · 1dd4236a
      Adesh Jolhe authored
      
      Steps to Produce:-
      - Install `Advanced Events`
      - Go to ` website` then `Configuration`
      - Open `setting`
      - Then change favicon and Select svg type file and click on save
      - Traceback is here
      
      Cause :-
      - The traceback occurs when an SVG image is passed to the ImageProcess method.
       In this scenario, the method sets the image as false, and then attempts to
      access its size, resulting in the traceback
      
      Fix :-
      - The issue has been resolved by implementing a condition check for the image
      before accessing its properties. This ensures that the image is valid before
      trying to retrieve its size, preventing the traceback from occurring.
      
      sentry-4199175498
      
      closes odoo/odoo#122300
      
      Signed-off-by: default avatarAchraf Ben Azzouz (abz) <abz@odoo.com>
      1dd4236a
  3. Jun 27, 2023
    • Alex (roal)'s avatar
      [FIX] tools: fix TypeError in literal_eval · 8fd136a3
      Alex (roal) authored
      
      A TypeError is thrown when an AST node is passed to `literal_eval`
      because a string is expected and the object has no len().
      
      Check the type of the expression and make sure it's a string before
      calling len() on it.
      
      closes odoo/odoo#126520
      
      Signed-off-by: default avatarVranckx Florian (flvr) <flvr@odoo.com>
      8fd136a3
    • Julien Mougenot's avatar
      [FIX] web: Allow TempusDominus to parse its own values · 3072cb56
      Julien Mougenot authored
      
      Before this commit, in other numbering systems than "latn", the time
      pickers did not allow to select hours/minutes/seconds. This was because
      the lib (TempusDominus) would use `parseInt` internally to retrieve the
      selected value, which was not a latin number in other numbering systems.
      
      This commit changes 2 things directly in the lib file:
      
      - allow the internal `getMoment` function to accept a second 'format'
      parameter;
      
      - use that same `getMoment` function to parse the text of the selected
      value, effectively using moment to both parse and format the values
      displayed in the picker and ensuring consistency.
      
      OPW-3258034
      
      closes odoo/odoo#125234
      
      Signed-off-by: default avatarBruno Boi (boi) <boi@odoo.com>
      3072cb56
    • Claire Bretton (clbr)'s avatar
      [FIX] l10n_ch: Fix return tax type · 7b07df87
      Claire Bretton (clbr) authored
      
      The return tax should only be used through its parent tax,
      we don't want it to be accessible directly on bills or invoices.
      
      opw-3347425 (2nd issue)
      
      closes odoo/odoo#124781
      
      Signed-off-by: default avatarBrice Bartoletti (bib) <bib@odoo.com>
      7b07df87
  4. Jun 26, 2023
  5. Jun 25, 2023
  6. Jun 24, 2023
    • Denis Ledoux's avatar
      [FIX] base_import_module: restore `<field file="...">` feature · 2a3ef939
      Denis Ledoux authored
      
      Revision odoo/odoo@cabb9e7e573b86cd523980588360d8514090d370 introduced a
      regression: This is no longer possible to import a data module
      using `<field file="..."/>` in their data file.
      
      This revision targets to restore the feature as expected.
      The unit tests added covers the feature, so that regression
      no longer happens in the future.
      
      It introduces a new concept of temporary directory `file_open`
      can read from.
      e.g.
      ```py
      with odoo.tools.file_open_temporary_directory(self.env) as module_dir:
         with zipfile.ZipFile('foo.zip', "r") as z:
            z.extract('foo/__manifest__.py', module_dir)
         with odoo.tools.file_open('foo/__manifest__.py', env=self.env) as f:
            manifest = f.read()
      ```
      
      Note that `file_open` will be allowed to read from that temporary
      directory only if `env` is passed to `file_open`,
      and if the `env` is part of the same transaction/request than the `env`
      passed to `file_open_temporary_directory`.
      
      This is to avoid having users, whether from other databases,
      or even the same database,
      trying to access these directories not belonging to them.
      e.g. If an admin uploads sensitive data in this temporary directory,
      no one than him must be allowed to read from these files, not even
      another user from his database.
      
      closes odoo/odoo#126278
      
      closes odoo/odoo#126337
      
      Signed-off-by: default avatarDenis Ledoux (dle) <dle@odoo.com>
      2a3ef939
  7. Jun 23, 2023
    • Julien Van Roy's avatar
      [FIX] mail: UTF-8 text/xml attachment and omitted charset · b2aa5883
      Julien Van Roy authored
      When parsing an email containing an xml attachment, the `email` python
      module will decode the base64 attachment using the charset or ascii if
      the charset is missing.
      
      In some cases, the payload is in UTF-8 but the charset is omitted. This
      results in replacement characters for the non ASCII characters.
      
      The solution is to force the charset to UTF-8, since it is a superset of
      ASCII that should not be a problem.
      
      NB1: Omitting the charset for text/xml is not recommended. See the RFC
      (section 6.4): https://www.ietf.org/rfc/rfc2376.txt
      
      
      
      opw-3144519
      
      closes odoo/odoo#125628
      
      Signed-off-by: default avatarJulien Castiaux (juc) <juc@odoo.com>
      b2aa5883
    • Yolann Sabaux's avatar
      [FIX] account_edi_ubl_cii: exclude note-section · fb716296
      Yolann Sabaux authored
      
      Steps to reproduce:
      - Install the lux localization
      - Configure Peppol for a customer: Select a customer > tab accounting > under "electronic invoicing":
      format: Peppol BIS Billing 3.0
      Peppol e-address: 0130 - Directorates of the European Commission
      Peppol Endpont: testendpoint
      
      - Create an invoice for the peppol customer
      - Add a section or a note in the Invoice
      - Confirm the Invoice
      
      Issue:
      Raise user error:  Odoo requires a tax for EACH LINE, instead of each product
      
      Solution:
      Exclude the section/note line
      
      opw-3354757
      
      closes odoo/odoo#124806
      
      Signed-off-by: default avatarLaurent Smet (las) <las@odoo.com>
      fb716296
    • Julien Van Roy's avatar
      [FIX] account_edi_ubl_cii: add italian EAS code for peppol Bis 3 · 030b55b2
      Julien Van Roy authored
      Currently, it's not possible to check the 'Peppol Bis 3' option on the
      journals of Italian companies, since Italy is not present in our mapping
      `COUNTRY_EAS`.
      
      The EAS for Italian companies may be the codice fiscal (code: 0210) or
      the VAT number (code: 0211). See
      https://peppol.agid.gov.it/en/news/expiration-validity-codes/
      
      
      
      Use the VAT number by default, and add it in our mapping such that the
      option now appears for Italian companies.
      
      opw-3346572
      
      closes odoo/odoo#126168
      
      Signed-off-by: default avatarFlorian Gilbert (flg) <flg@odoo.com>
      030b55b2
    • Mohit Beniwal's avatar
      [FIX] base: prevent json decoder error for default values · 0e6e322d
      Mohit Beniwal authored
      
      JSONDecoderError occurs when users enters invalid JSON format data in
      'Default Value' field inside 'User-defined Defaults' and wherever this field is
      being accessed to get default value this traceback will be generated.
      
      Steps to reproduce:
      1) Install 'Contacts' module.
      2) Open 'Settings' > 'Technical' > 'User-defined Defaults'.
      3) Click on record 'Language' > 'EDIT' button > in 'Default Value' field enter
         any improper JSON format data (e.g 'Maa' : FI ) .
      4) Now, open 'Contacts' module > click on 'CREATE' button and traceback would be
         generated.
      
      By applying this, it will check for proper JSON format.
      
      Sentry-4169062951
      
      closes odoo/odoo#124051
      
      Signed-off-by: default avatarRémy Voet (ryv) <ryv@odoo.com>
      0e6e322d
    • Enric Tobella's avatar
      [FIX] maintenance: Allow to see your created maintenances requests · df1badee
      Enric Tobella authored
      
      closes odoo/odoo#105495
      
      Signed-off-by: default avatarWilliam Henrotin (whe) <whe@odoo.com>
      df1badee
    • Guillaume (gdi)'s avatar
      [FIX] website_links: support foreign language for links graphs · e690da6e
      Guillaume (gdi) authored
      
      When a user creates a link that is tracked, an interface with graphs is
      presented to him so that he can track the performance of his tracked
      link. Unfortunately, these graphs did not work when the site was in a
      foreign language. This was due to the fact that the code had not been
      designed to handle this. This commit fixes the code so that it works in
      all languages.
      
      Note that the data is received via RPC and the python code format the
      dates for the current language of the website. So we had to do a little
      hack to make it work properly.
      
      Steps to reproduce the issue:
      - Install website_links module
      - Go to the website app
      - Click on Promote > Link Tracker
      - Create a tracked link
      - Visit the link
      - Install Arabic (Syria) for your website
      - Check the stats of your link in Arabic
      
      => There is a traceback and the data is not displayed.
      
      task-3289167
      
      closes odoo/odoo#119375
      
      Signed-off-by: default avatarOutagant Mehdi (mou) <mou@odoo.com>
      e690da6e
  8. Jun 22, 2023
    • Benoit Socias's avatar
      [IMP] website: test unsplash beacon · a5abc766
      Benoit Socias authored
      
      This commit ensures that the unsplash beacon calls home when an unsplash
      image appears on a page.
      
      To achieve this it patches the RPC call when the test URL contains the
      test name as parameter. The patch cancels the actual beacon call to
      avoid polluting data during the test, but marks the image as having had
      its beacon message sent. The test then simply checks if this marker
      appears on the image.
      
      task-3360109
      
      closes odoo/odoo#125028
      
      Signed-off-by: default avatarOutagant Mehdi (mou) <mou@odoo.com>
      a5abc766
    • Saurabh Choraria's avatar
      [FIX] partner_autocomplete: update log when sending partner to sync fails · c1b608c2
      Saurabh Choraria authored
      
      In the start_sync method, the logger is updated to use the 'warning' level
      instead of the 'error' level. This change reflects a less severe logging level
      for cases where sending a partner to sync fails.
      
      The changes have been made to reduce the noise level in the sentry.
      
      sentry-3955309841
      
      closes odoo/odoo#123827
      
      Signed-off-by: default avatarLouis Baudoux (lba) <lba@odoo.com>
      c1b608c2
  9. Jun 21, 2023
  10. Jun 20, 2023
  11. Jun 19, 2023
    • Romain Derie's avatar
      [IMP] website: make website_nightly build work before 16.4 · 231a7d63
      Romain Derie authored
      We have introduced a new tag `website_nightly` which is linked to a
      custom build on the nightly.
      It has been introduced with this commit [1].
      
      The goal is to extract the `external` tagged tests linked to the website
      app to another special build linked to the website team.
      Otherwise, we would not see when the test fail, as the `external` build
      of the nightly is always red and we don't check why all the time.
      
      Encapsulating this in a new build and linking to our team means that
      whenever the test fail in a nightly, we will be visually warned on the
      runbot homepage by a red warning, see screenshot on the PR of this
      commit.
      
      Sadly, before 16.4, as there is not yet `website_nightly` tours, the
      build is considered failed, showing the error.
      Another solution would have been to somehow disable this tour on Odoo
      versions < 16.4 but it we opted for this solution as:
      - It's simpler, no need to add yet another custom stuff in runbot
      - It will work out of the box should be introduce such a test in those
        versions: we won't need to ask runbot to activate the test in another
        version, should we even think about it..
      
      [1]: https://github.com/odoo/odoo/commit/a0d0afb20594aa103eb1d0476d53012b9821e861
      
      
      
      closes odoo/odoo#125662
      
      Signed-off-by: default avatarXavier Dollé (xdo) <xdo@odoo.com>
      231a7d63
    • mega-odoo's avatar
      [FIX] web_editor: prevent error when edit the float, monetary section in website · b895175c
      mega-odoo authored
      
      'replace() argument 1 must be str, not bool' is generated if the user edit a
      float or monetary section in the website view.
      
      Steps to Reproduce
      
      - Make debugger mode ON.
      - Go to Settings > Translations > Languages.
      - Remove the value of the 'Thousands Separator' field from the current user
      language.
      - Install the 'eCommerce' module.
      - Go to the website.
      - Go to the shop menu, and click any product from the product list.
      - Click on the Edit button and try to edit any float or
      monetary section like a product price (eg. change a product price from 750 to
      70) and click on the Save button.
      
      And traceback will be generated.
      
      Applying this commit will resolve this issue.
      
      sentry-4148693017
      
      closes odoo/odoo#124245
      
      Signed-off-by: default avatarDavid Monjoie (dmo) <dmo@odoo.com>
      b895175c
  12. Jun 18, 2023
  13. Jun 16, 2023
  14. Jun 15, 2023
    • Julien Van Roy's avatar
      [FIX] account_edi_ubl_cii: no xml declaration with the send & print · d89f5cb2
      Julien Van Roy authored
      
      Issue: the xml declaration "<?xml version='1.0' encoding='UTF-8'?>" is
      lost when opening the send & print wizard with existing xml attachments.
      
      Explanation: When opening the send and print wizard, the PDF are
      generated and postprocessed by `_postprocess_pdf_report`. In the
      `_postprocess_pdf_report` override in `account_edi_ubl_cii`, the xml
      attachments are parsed through `tree = etree.fromstring(xml)`, then the
      base64 PDF is inserted, and the etree is converted to a bytes through
      `etree.tostring(cleanup_xml_node(tree))` and the resulting bytes is
      written back on the attachment, but the xml declaration disappeared.
      
      Solution: include the arguments `xml_declaration=True, encoding='UTF-8'`
      in the `tostring` function when converting the etree to a bytes.
      
      opw-3144519
      
      closes odoo/odoo#125223
      
      Signed-off-by: default avatarLaurent Smet <las@odoo.com>
      d89f5cb2
    • Arthur Detroux (ard)'s avatar
      [FIX] web: mitigate navigation error on iOS/iPadOS devices · 19e484b6
      Arthur Detroux (ard) authored
      
      Ever since iOS 16.4, going back and forth through a website with the
      cache enabled, creates an error in the console which Odoo tries to
      handle but fails to do so. Therefor a generic CORS error message
      appears.
      
      There is unfortunately no proper way to fix this bug on our end so
      instead, this commit tries to mitigate the error by returning early and
      not showing the traceback dialog.
      
      I (ARD) have submitted a feedback through Apple's Feedback Assistant app
      and will subsequently remove this commit when Apple releases an update
      that fixes this.
      
      opw-3281727
      
      closes odoo/odoo#124828
      
      Signed-off-by: default avatarRomain Derie (rde) <rde@odoo.com>
      19e484b6
    • Arthur Detroux (ard)'s avatar
      [FIX] website: Fix footer Slide Hover glitching on Safari · a6307448
      Arthur Detroux (ard) authored
      
      Prior to this commit, when using the "Slide Hover" reveal effect on the
      footer, Safari would glitch it scrolls and could result in unreadable
      content.
      
      This commit fixes this by a weird hack that seems to work. Adding an
      element with a background-image and a background-attachment set to
      fixed seems to resolve the issue.
      
      task-3302302
      
      closes odoo/odoo#122029
      
      Signed-off-by: default avatarDieleman Guillaume (gdi) <gdi@odoo.com>
      a6307448
    • Antoine Dupuis (andu)'s avatar
      [FIX] l10n_it_edi: Generate correct XML for negative invoice lines · 17f336e4
      Antoine Dupuis (andu) authored
      
      When creating an invoice with a positive line and a negative line, with
      different taxes, the DatiRiepilogo node for the tax of the negative
      line contained positive amounts when they should be negative.
      
      This is because we were applying `abs()` too naively in the XML template
      and in the code of _l10n_it_edi_prepare_fatturapa_tax_details.
      
      This bugfix commit changes the logic to no longer use abs().
      
      We also include a test to check that the XML is correctly generated for
      credit notes.
      
      Back-port of #121933
      
      opw-3316300
      
      closes odoo/odoo#122928
      
      Signed-off-by: default avatarJosse Colpaert <jco@odoo.com>
      17f336e4
Loading