duration_percent field is a stored integer.
In postgresql, integer are 4 Bytes long, which create a range of -2147483648 to +2147483647.
With a small duration_expected, and a big duration, we can easily break these limits.

OPW-3253333

closes odoo/odoo#117590

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Incorporate Andy Quijada (ajqn9094) as Vauxoo's contributor.

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#117550

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

This will prevent a "Title underline too short" warning
at module install.

closes odoo/odoo#117614

Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

The method `price_compute` on `product.product` model was wrongly
using the product `company_id` field as `company` for the currency
conversion call.

Indeed, products do not always have a company (they can be shared
across companies) and when they don't, `_convert` will fail, raising
an AssertionError as it expects a valid company record.

This commit makes sure the method will work as expected even for
products shared between companies, and harmonizes both `price_compute`
methods (on `product.product` & `product.template` models) by using
the given company (or the company of the environment) for the conversion
as we want the returned price to be computed for the given company,
not for the product company anyway.

closes odoo/odoo#117435

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Part-of: odoo/odoo#117435

Based on change from PR odoo@df74fb6, the rule stated on the document attached has been reverted. It should be using the customer's tax address rather than the delivery address'. One of Indonesian customers are getting a warning letter from the government regarding this.

3230742

closes odoo/odoo#116140

Signed-off-by: Grazioso Andrea (agr) <agr@odoo.com>

Steps to reproduce the bug:
- Go to the warehouse settings:
    - enable “3 steps for manufacturing”
- Create a storable product “P1” with 2 BoM
- Create an orderpoint:
    - Preferred route: Manufacturing
    - Product: “P1”
    - BoM: select the second BoM
    - To order: 1

- Click on the “Order once” button

Problem:
The manufacturing order is created with the first BoM instead of the
second.

As we are in 3 steps, the “run_pull” function is triggered first, with
values prepared from the orderpoint so the bom is well set:
https://github.com/odoo/odoo/blob/16.0/addons/stock/models/stock_orderpoint.py#L515-L523

Then the “run_manufacture” function is triggered but with vals prepared
from the move, not from the orderpoint, so we lose the BoM information
that the user has selected:
https://github.com/odoo/odoo/blob/16.0/addons/stock/models/stock_move.py#L1334-L1340



opw-3217945

closes odoo/odoo#116685

Signed-off-by: Tiffany Chang <tic@odoo.com>

The list of attendees to contact for an event is wrong.

Steps to reproduce the error:
1-In the event app , have a canceled attendee
2-Send an Email to attendees
bug : the email will be sent to canceled attendees as well

The problem was originated from the domain given by the inherited
class, there was no condition on the state of the attendees.

opw-3240100

closes odoo/odoo#117499

Signed-off-by: Adrien Widart <awt@odoo.com>

Incorporate Rolando Duarte (rolandojduartem) as Vauxoo's contributor.

I confirm I have signed the CLA and read the PR guidelines at:
www.odoo.com/submit-pr

closes odoo/odoo#117545

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Since [1] when a `/` was added as default text when no option is
selected in dropdown options, the selected font name is not displayed
anymore inside font options because they both rely on specifying a
`content` on the `::before` pseudo-element inside the `we-toggler`.
Because the empty value text also includes a `:empty` inside its
selector, that rule wins over the font name.

This commit makes the font name rule `!important` so that it gets
applied instead of the empty selection rule.

[1]: https://github.com/odoo/odoo/commit/dc6ff20386567abbabcb2d35388a3dc8995cab28



task-3256509

closes odoo/odoo#117448

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Since [1] the font family parameter was encoded twice when adding a new
google font. This causes an issue for fonts that contain spaces in their
name.

This commit removes that additional encoding and highlights the fact
that it already is an encoded parameter.

Steps to reproduce:
- Go to the Options tab while editing a website page.
- Open the Font Family dropdown.
- Select "Add a Google Font".
- In the "Google Font address" enter
`https://fonts.google.com/specimen/Open+Sans`.
- Click on "Save & Reload".

=> Field was highlighted as being wrong.

[1]: https://github.com/odoo/odoo/commit/d8cff9a37ba51c64628085b48d071ecb24e70f07

task-3256509

Part-of: odoo/odoo#117448

- Create an account of type current asset
- Add him a Sales Tax and a Purchase Tax
- Create invoice
- Add a line
- Remove the taxes from this line
- Change the account to the one you created

=> A purchase tax is applied to the line.
It should not happen, so we prevent it.

closes odoo/odoo#115196

Signed-off-by: Quentin De Paoli <qdp@odoo.com>

As we have a team dedicated to work on analysing tracebacks
with sentry, and to takedown all tracebacks occuring on the saas,
we do an effort to avoid unecessary warnings and tracebacks
for both sentry and the runbot.

closes odoo/odoo#112101

Signed-off-by: Rémy Voet <ryv@odoo.com>

Incorporate Isaac López (isaako34) as Vauxoo's contributor.

closes odoo/odoo#117428

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Before this commit: if the user wanted to generate a
POS Inalterability Check statement, an IndexError was raised.
This commit raises a more understandable error.

opw-3237383

closes odoo/odoo#116386

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

Before this commit: the `product.display_name` field could contain
line breaks, which prevented it from being matched correctly by
regular expressions. This commit fixes the issue by modifying the
`_product_search_string()` function to remove line breaks.

opw-3239830

closes odoo/odoo#116692

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

Steps to reproduce:
- In inventory/replenishement
- edit a line (eg: prefered route) then click on reorder
- the edits are discarded

Fix:
the line is saved only when it gets unselected or manually saved
it more intuitive to also do it when a button is clicked on the line

opw-3125732

closes odoo/odoo#116065

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Some databases encounter an error when they try to upgrade when
they have more than one tax with the same name that violate
the tax name unique constraint (name, company_id, type_tax_use, tax_scope).
This will adapt the update of taxes script to handle this situation
by renaming such taxes to [old] taxname, [old1] taxname, etc.

opw-3178128

closes odoo/odoo#114292

Signed-off-by: Quentin De Paoli <qdp@odoo.com>

When updating taxes we send a message to accounting advisors if
we duplicated tax(es) in the process so he can check if the
original tax is still relevant. This message was wrongly sent
multiple times per advisor when there was more than one advisor.

Task: 3178775
Part-of: odoo/odoo#114292

Adds more tests to the update of taxes.

Task: 3178775
Part-of: odoo/odoo#114292

Rework tests of the taxes update and fix PEP8 docstring rule violations.

Part-of: odoo/odoo#114292

_create_or_update_picking() is a time-consuming method.
On some Purchase, all the purchase.order.line may be written with 'product_qty' in 'values', even though it did not change.

OPW-2978569

closes odoo/odoo#114546

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

closes odoo/odoo#117287

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Current behaviour:
When creating a timesheet, if in the vals passed the AAL doesn't
have a company (possible since it's not required), then the `uom`
of the timesheet is False, which doesn't make sense.

Expected behaviour:
The timesheet `uom` should fallback on the uom of the company
of the project.

Steps to reproduce:
- Install hr_timesheet, Accounting
- Activate the AAL in the settings
- Create a project with an AAL
- Remove the company on the AAL of the project
- In that project create a task and log some timesheet.
- `uom` field should be empty

Reason for the problem:
When setting the `product_uom_id` in the vals when creating/writing
a timesheet, we just take the `project_time_mode_id` on the company
linked to the AAL. The problem is that the company on an AAL is not
a required field, so it can be `False`, leading the setting the val
for `product_uom_id` to `False`.

Fix:
In case the AAL has no company, we get the `uom` from the company
linked to the project.

Affected versions:
- 14.0
- 15.0
- saas-15.2
- 16.0
- saas-16.1
- saas-16.2
- master

opw-3245671

closes odoo/odoo#117012

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

Problem:
When doing a write on an empty recordset from coupon programs,
a traceback error about tuple index out of range is thrown.

When doing a write on multiple records, it's not guaranteed to have the
same (discount_line_product_id, reward_id) pair per record.
Thus, it's not correct to use the reward_id of the first record and
apply it to all records.

Solution:
Pass in self as a condition to check whether self is empty or not.
The method should just return res if self is empty.

For each coupon program in self, update its discount_line_product_id to
its respective reward_id.display_name

Steps to Reproduce in Runbot14:
1. Install Sales & Coupons
2. Enable Coupons & Programs in Settings
3. Create a server action to do a write on an empty recordset
ex. env['coupon.program'].write({'discount_fixed_amount': 0})
4. Create a server action to do a write on multiple records

opw-2658794

closes odoo/odoo#116096

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Incorporate Rodrigo Serrano (Rodrigosu_Vauxoo) as Vauxoo's contributor.
I confirm I have signed the CLA and read the PR guidelines at:
www.odoo.com/submit-pr

closes odoo/odoo#117087

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

When importing an electronic invoice, we only want to create the partner
when the vat and the name were retrieved.

closes odoo/odoo#114900

Signed-off-by: Laurent Smet <las@odoo.com>

The color that was used for portal chatter published dates was the muted
color that we use at some places in the backend. The portal screens
being frontend screens, it of course did not work with all website color
schemes.

This simply uses the `$text-muted` color to fix the issue. This probably
needs refactoring in master to avoid those extra CSS rules that could
simply be gone with proper bootstrap XML structures.

opw-3146164

closes odoo/odoo#116968

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

The trigger that downloads FatturaPA used the `_trigger` function only available in Odoo 15.
This means that if we manually re-trigger, each iteration will have less time before timeout and will eventually do.
So, we revert the change in Odoo 14.

Reversal of odoo#116373
https://github.com/odoo/odoo/pull/116373



closes odoo/odoo#116731

Signed-off-by: Josse Colpaert <jco@odoo.com>

Before this commit, in the website profile frontend, if we filter the users
using 'This week' or 'This month' filters we always get a '+' displayed before
the karma gain.

If user gained negative karma, lets say -500, currently it displays as follows
--> +-500 , instead of -500.

After this commit, if the gained karma during the period is it will show
-500 instead of +-500.

closes odoo/odoo#114506

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Steps to reproduce:

- Install Sales, Inventory
- Sales > Create quotation > Fill data > Other Info tab >
Customer Reference = *insert very long string here* > Confirm
- Click on delivery stat button > Print > Delivery Slip

Issue:

The customer reference overlaps with the other information in the same row.
In the resulting XML there are two nested divs with `class="row"`.

Solution:

Remove the row div in the derived xml.

opw-3121097

closes odoo/odoo#116681

Signed-off-by: Tiffany Chang <tic@odoo.com>

Currently in the survey:
- If we have a conditional question and the question selection mode is
  random and we select the question layout as one page with all questions
  or one page per section, the conditional question is not visible. This
  happens because the  random mode condition is ignored.
- If we have a conditional question and the question selection mode is random
  and we select the question layout as one page per section, the traceback is
  generated when we start the survey. This is because it is trying to get value
  from the "selected_answer", which does not exist in random mode.

Expected behaviour is If the question selection mode is random, the conditional
questions are considered normal and visible and do not generate a trace back if
the question layout is one page per section.

This commit fixes the above issue by adding a condition that treats
the conditional question as a normal question when the question
selection mode is random.

task-3142209

closes odoo/odoo#111171

Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>

When creating an invoice from e-commerce, the invoice is not sent by mail but the user must be able to see it from the portal.

closes odoo/odoo#116867

Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

Before this commit:
Assuming we have a "Shipping Labels Printer" set on an operation type.
Assuming we also have a delivery carrier which send Label through the chatter of this picking type (like DHL or BPost).
If we have several sessions connected with the same user (author of the chatter message), for examples, on different devices.
Each session will send the same IoT request to print the label (as the code rely on the bus).

In consequences, the same label will be printed multiple times

After this commit:
The label is print only once

Associated enterprise PR: https://github.com/odoo/enterprise/pull/36904



opw-3081423

closes odoo/odoo#112355

Related: odoo/enterprise#36904
Signed-off-by: Sens Loan (lse) <lse@odoo.com>

There can be multiple causes that could prevent a sales order gets
confirmed when we push the *Confirm* button. This can be common when
extension modules come to play.

The simplest way to reproduce it (no extra modules needed) would be to
make an automated action on sale.order with a criteria that could avoid
the confirmation throwing a UserError.

The coupon email would be sent anyway as we can't rollback a mail
sending once it's gone away but it wouldn't be valid as the process
stopped after it.

So we want to prevent sending that mail if the sale.order can't be
confirmed.

TT42124

closes odoo/odoo#116817

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

before this commit, for the company_id field
the user groups given was base.main_company,
such a group is not existing in the system

after this commit, the group will be changed
to base.group_multi_company from base.main_company

closes odoo/odoo#116793

Related: odoo/enterprise#38871
Signed-off-by: Tiffany Chang <tic@odoo.com>

before this commit, on duplicating a contact tag
will duplicate the assigned partners also.

suppose if we have a partner A with tag B assigned,
and then we duplicate tag B and create new tag C,
the newly created tag is automatically getting
assigned to partner A.

after this commit, the copy is set to False for
partner_ids field in tag and then the partners
wont be copied on duplicating a tag

closes odoo/odoo#116632

Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>

Before this commit, no default date filter was set on the report.
For older databases, it results in a systematic heavy query.

opw-3134913

closes odoo/odoo#115113

Signed-off-by: nda-odoo <nda@odoo.com>

before this commit, there is typo in unit of measure

after this commit, the typo will be corrected and
unity of measure will be updated to unit of measure

closes odoo/odoo#116630

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Rewords and fix the typos in the mailing.mailing model notes.

Task-3240405

closes odoo/odoo#116162

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>