as we cannot do the test in product_matrix, add the purchase equivalent
in purchase_product_matrix to also test the matrix in this case.

two compute field have same method but one is store and other one is non store
so we split compute method for both fields(l10n_ch_isr_number,l10n_ch_isr_number_spaced)

closes odoo/odoo#39689

Signed-off-by: Josse Colpaert <jco@openerp.com>

The use of an emulator (qemu) for the IoT Box build posed compatibility and performance issues.
So we have the Raspbian filesystem to install and configure packages.

closes odoo/odoo#40839

Task: 2145445
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

The paypal payment flow was crashing because no transaction was found
when the client wasn't connected.

closes odoo/odoo#39408

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

- Handle the notifications in Odoo
- On any object, e.g. a SO, user A a note and ping user B
- As user B, go to Discuss and reply to the note

The reply is sent a regular message.

Actually, everything is available to reply with the right message type
in:

https://github.com/odoo/odoo/blob/bae8ab7d93143e082e1d1a9cbe20a350c2d34d07/addons/mail/static/src/js/discuss.js#L1327



It is simply unset.

opw-2088619

closes odoo/odoo#40941

X-original-commit: 84c8221c60e3483aa637abad057253424236af83
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

closes odoo/odoo#40913

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Reproduce the issue

    - Install CRM & sale_crm
    - Create an opportunity
    - Create a quotation from the opportunity

    The name of the draft is the opportunity's name instead of "New"

    - Add a "Storage Box" to the quotation, for instance
    - Confirm the quotation
    - Check the delivery note

    The name of the delivery note is the opportunity's name instead of
    WH/OUT/...

Cause

    This issue is caused by 4c9c249c. It seems that we pass an extra
    default_name in the context.

This commit removes the extra default_name from the context.

OPW-2122928

closes odoo/odoo#40671

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

In most use case, when we edit the website we have a situation such as:

```
<div id="wrap" branding-attributes="...">
    <section class="mycontent">hi!</section>
</div>
```

When we modify a part, we replace all child nodes of the branded
element.

But if we had more complex content such as:

```
<div id="wrap">
    <section class="mycontent" branding-attributes="...">ho!</section>
    <t t-call-assets="web.assets_common" t-js="false" t-css="false"/>
</div>
```

we have a t-call inside the div#wrap, so branding is distributed to
child that could have attribute modified (eg. changing background).

Then if `<section/>` node is saved, the possibly modified attributes
are lost.

Without the change, the added test fails with:

 '<div class="nice">hoi</div>' not found in '...<div>hoi</div>...' :
 saved element attributes are saved excluding branding ones

opw-2122947
closes #40345

closes odoo/odoo#40828

X-original-commit: 71b20a24
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

As the group_account_invoice doesn't have the access rights to unlink the
account.partial.reconcile/account.full.reconcile, there was impossible for
the user to undo a reconciliation.

closes odoo/odoo#40890

X-original-commit: c7d51acf07f7d6c417921b68fcc89cfae9657888
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

In case of a picking type where stock move lines are not shown, clicking
on 'Put in Pack' without 'Done' quantitites set shows a confusing error
message.

closes odoo/odoo#40920

Related: odoo/enterprise#6901
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

- Activate product packing
- Create a PO for a stockable product, validate
- In the barcode interface, go to the created picking
- Set the product quantity
- Click on 'Put in Pack'

An error is raised: 'All the products currently reserved in the picking
are already in a pack...'

In the regular interface, the procedure is to create the move lines
manually, therefore setting a quantity done. However, this is not
possible in the barcode, and `move_line_nosuggest_ids` is always empty.

We introduce a special use case to bypass this in the case of the
barcode view.

opw-2127637

opw 2144639

closes odoo/odoo#40874

Signed-off-by: Nans Lefebvre (len) <len@odoo.com>

fixes #38014

closes odoo/odoo#40838

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

The current 'Newly Hired' filter is incorrect in several ways:
- the compute method doesn't assign the value correctly
- the search method mixes `hr.applicant` IDs with `hr.employee` IDs

Moreover, it relies on the fact that the job position is closed. Some
positions might always be opened, so the result is inaccurate.

We make the simpler assumption that the newly hired people are employees
created less than 90 days ago.

opw-2125861

closes odoo/odoo#40889

X-original-commit: ee928babbe433285883f1e878d83392d7199a37d
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

When clicking on stat button "Meetings" on a partner, just highlight the
partner meetings as is done for similar stat button instead of having
a domain that hides other event (so when creating meeting, we can take
into account other existing meetings).

A similar change with same reasoning has been done for "Meetings" stat
button of hr.applicant records.

opw-2131494
closes #40812

closes odoo/odoo#40891

X-original-commit: 957e7eb7
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

closes odoo/odoo#40898

X-original-commit: 1b2df29e
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Before this commit, the export of translations was incorrect for code
and model translations:

For code translations, the field 'name' was used for the matching
while the _() method explicitly use None in the _get_source call to
only use the field 'src' for the search.

For model translations, the field 'res_id' was not used when searching
for a translation.
For instance, if a ir.model.fields did not have translated label,
exporting the translations was using the translations of the first
field having the same source.
While this could be convient during the import (to be discussed),
doing so in an export of translation is clearly an unexpected
side-effect.

closes odoo/odoo#40879

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Those cases are already checked in models._check_company() but not considered
when defining the default domain on `check_company=True` fields.

* Consider res_users relational field
	Companies allowed for user = user.company_ids
* Consider company-dependent fields
	Companies allowed = self.env.company

closes odoo/odoo#40724

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

closes odoo/odoo#40754

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

A second edition is being written but not published yet

closes odoo/odoo#40405

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Backport of CLA from master (af98694e) to 13.0 for odoo/odoo#40405

- Create a vendor bill for partner A with reference 'AAAAA'
- Create another vendor bill for partner A with the same reference:
=> Constraint is triggered.
- Create another vendor bill without partner with the same reference.
- Edit the vendor bill and set a partner:
=> Constraint not triggered.

closes odoo/odoo#40849

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

closes odoo/odoo#40864

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

im_livechat main controller was referring to website.visitor but this module is
not depending on website. The usage of website visitor's name should have been
done in website_livechat module.

This commit fix this issue.

Task ID: 2116715
PR #40732

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

The slide.slide "_compute_slides_statistics" method is missing the 'slide_ids.sequence' trigger.
It should be specified for cases when one of the slide_ids changes category (determined by the
sequence).

This can cause some CacheMiss and seem related to nondeterministic errors on the runbot.

PR #40705
Task#2123711
Runbot build error ID 247

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

before this commit:
when creating a product from frontend and editing the product and
delete image, it doesn't get any url thus generating the traceback.

after this commit: if url is not defined then return None from
ir.qweb.field.image field converter

task-2063293

closes odoo/odoo#40626

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

This commit applies the following ACLs rules:

C : nobody can create visitor (except of course the automated flow)
R : everyone that should access to this model
U : website_designer can update (even if only few fields are editable),
    mainly useful for language (+ system obviously)
    + livechat users as they are the guys who directly speaks with the visitors
D : system + website_designer can delete, mainly useful to clean if necessary

Remove the no_create from all visitor views as nobody can create.

This fixes the 'can create' that should not be done by any users (even admin)
except the system.

Task ID: 2092502
PR #40439

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Before this commit, the computation of kpi for last week, last 30 days and
previous period comparison was wrong due to cache. Indeed as first value
was in cache, other values were taken directly from cache itself instead
of recomputing each value based on start_date and end_date of the computation
timeframe.

As digest fields are computed fields used a bit off-side, let us manually
invalidate the cache before computing a kpi so that it correctly computes
the timeframe values.

Task ID 1883428

closes odoo/odoo#40834

Closes: #40834
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Steps to reproduce the bug:
- Let's consider a fiscal position FP with automatic detection for customer in your country
- Let's consider two taxes T1 and T2 where T1 is mapped by T2 in FP
- Let's consider a product P with T1 as customer taxe
- Let's consider a customer C in your country with no fiscal position
- Create a repair order for C
- Add P as an add line

Bug:

T1 was set as customer taxe for P instead of T2.
When manually creating an invoice for C with P, FP is automatically
detected and T2 is set.

With this fix, the automatic detection of FP is applied on repair order.

opw:2120595

closes odoo/odoo#40511

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

- Group the SO list view by Analytic Account
- Go to a SO
- Click on the stat button 'Timesheets'

Traceback because the field `analytic_account_id` is not on Timesheets.

opw-2124539

closes odoo/odoo#40518

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Accounting > Configuration > Journal > Create
Under Journal Entry Tab Fill name, type "Bank", short code
Under Advanced Settings tab set Post at "bank reconciliation"
Save

Go to Accounting > Customer Invoices > Create
Add Customer, and SO line with label and price, remove Tax Line.
Post and Register payment on the created journal.

Go to Accounting > <Created Journal> > Create
Add reference, label, partner as in soline, amount as in so line.
Save and Reconcile.

There will be no entry to reconcile with. This is because the domain
used by the reconciliation widget does not take into account the
possibility to have a draft move_id, so the line which can be reconciled
because the line is automatically posted on reconciliation is filtered

Rearranging the domain to take into account this possibility

closes odoo/odoo#40786

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

When you create a pos order, it is possible that the request timeout or
the client loose the connection with the server, that will lead to not
have the server_id of the order sent to the server. So when the client
will try to synchronize the order again, it'll not send the server_id to
the server, and the server will create a new order which is a duplicate
of the one created when the client lost the connection.

To avoid this duplication, we are using the pos_reference to find if
there is an existing order like in 12.0 to avoid duplication.

closes odoo/odoo#40600

Task-id: 2127656
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

After the rainbowMan issue was fixed here: e5bc2e7, steps were consumed
on 'click' events. This caused an issue with the drag and drop event
(which breaks tour, because it is expecting a click event). If the user
dragged an element, thetip was not getting consumed as no click event
was triggered.

closes odoo/odoo#40810

X-original-commit: 3f458fe06e6a629edc72428eab749068c2eba1ba
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Co-authored-by: Aaron Bohy <aab@odoo.com>
Co-authored-by: Priyanka Kakadiya <pka@odoo.com>

Archived users are inactive, so we shouldn't be able to ping them.

Task-2046885

closes odoo/odoo#40809

X-original-commit: 8169e34a
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

In the pivot view of report.pos.order that is a view mainly over
pos.order, the "Count" measure is a little rubish giving more or less
the number of different products in the grouped order lines.

With this changeset, we have the field "Order" as measure that allow us
to know the number of orders a grouping is corresponding to.

opw-2127275
closes #40723

closes odoo/odoo#40797

X-original-commit: 431114d4
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>