task-3429069

closes odoo/odoo#128731

Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>

Issue:
------
When adding a file to an employee's work permit ("Private Information tab"),
the file name is the "value" of the file.
This is not meaningful for the user who will download the file.

Solution:
---------
Use the `filename` attribute to determine the field of `hr.employee`
to be used to get the file name.
As the original file name doesn't exist in an existing field,
we can use a "generic" file name with a non-stored computed field.

opw-3458842

closes odoo/odoo#133569

Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>

*_ = hr_holidays

Step:
  - Install contract app
  - Create user with payroll manger access and None Employees
  - Login with new user and create contract
  - Click on employee field and click on Search More
Issue:
    When the user does not have access to the employee app and the search dialog accesses the
 employee during search more, so the traceback come.

Fix:
    If the user does not have access to the Employee application, public employee will be
  used in the search more dialog.

Why needed string insead of props.string:
   When we pass related modal in option then undefined appears in m2m search dialog instead
   of field label.

task-3366443

closes odoo/odoo#130050

Related: odoo/enterprise#44774
Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>

Both a07c6c55 and 41eaff0f were merged at the same time
without conflict

closes odoo/odoo#132221

Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>

closes odoo/odoo#131285

X-original-commit: 5db1538af8c3381ab7c9006e11db0844d8d365c1
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

before this commit, on writing user_id to hr.employee
on multiple record in raisng single ton error.

after this commit, no error wont be raised on the
same.

closes odoo/odoo#130019

X-original-commit: d4614015
Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>
Signed-off-by: Kevin Baptiste <kba@odoo.com>

1) If the contract is running when the employee is archived, we move the contract in the
   expired stage and we set the date of the archive wizard to the
   contract's end date.

2) If the contract has expired when the employee is archived, do not change the date.

task-3373275

closes odoo/odoo#126627

Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>

task-3373010

closes odoo/odoo#125207

Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>

if you are a multi company user and you are employee
in another company than the current one you will
end up not be able to use your department as a filter
even if the department is defined for multiple companies

closes odoo/odoo#129289

Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>

This commit fixes a really old grammar error in the help message of the
message_needaction_counter field.

Before this commit: “Number of messages which requires an action”
After: “Number of messages requiring action”

The subject of “require” is “messages”, which is third-person plural, so
it can't take the -s suffix.

closes odoo/odoo#128929

Related: odoo/enterprise#44299
Signed-off-by: Louis Wicket (wil) <wil@odoo.com>

Issue 1
=======
When an employee is archived and the user clicks on the 'Launch Plan' button
from that employee, it will throw an IndexError saying the tuple index is out
of range.

Steps to produce:
- Open any Employee > Action > Archive > Apply.
- Open archived employee(s) from the Filters > Archived.
- From list view or form view, Click on the 'Launch Plan' button.
- Error: IndexError: tuple index out of range.

Fixed this issue using the current company if the employee and their company
are not found.

Issue 2
=======
When a user clicks on the 'Launch Plan' button from that employee, It will
throw an IndexError saying the tuple index is out of range.

Steps to produce:
- Open any Employee.
- Make the 'name' field unrequired (Studio or Edit form view).
- Now create a new employee - before clicking on the Save button click on the
'Launch Plan' button.
- Discard Changes > Error will produce.

Fixed this issue using the check before using the employee record.

sentry-4259555464

closes odoo/odoo#125704

Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>

In case we use multi company and a user does not have an employee
in every company which is quite normal (mostly you are employed with
exactly one company), the calendar is skipping the provision of the
unusual days like public holidays or the working schedule.

To be able to access and see the calendar in such a case we fallback
to the company calendar and fixed a domain for the public holiday
retrieval whereas the public holidays are not assigned to an employee
but the company or the companies chosen to be displayed.

closes odoo/odoo#126289

Signed-off-by: Kevin Baptiste <kba@odoo.com>

*: account, event_booth, gamification, hr, project,
   website_event_track, website_hr_recruitment, website_slides

HTML fields that appear in the front-end can be modified using the
website editor. Some of them are sanitized in a way that breaks the
behavior of snippets that can be dropped within them.

This commit adapts the sanitization of those HTML fields so that the
snippets behave as expected.

opw-3267589

closes odoo/odoo#125650

X-original-commit: 477cd32c7924ce79e8f29cf567fbbc625f24534f
Related: odoo/enterprise#42802
Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Issue:
------
The "Launch Plan" button appears for an archived employee.
It causes a traceback.

Solution:
---------
Do not display the button for an archived employee.

opw-3366815

closes odoo/odoo#125896

X-original-commit: 6536a88b
Signed-off-by: Kevin Baptiste <kba@odoo.com>

Plans with no company defined were not showing in the list when
launching a plan on an employee.

task-3366394

closes odoo/odoo#124853

Signed-off-by: Kevin Baptiste <kba@odoo.com>

Current behaviour:
In mobile view, if an user that doesn't have any rights over
"Employees", clicking on any of the Many2One `employee_id` (for ex:
when adding a timesheet on a task and clicking on the employee field),
for either the dropdown, or to the form view with the `external` button,
we get a stacktrace.

Expected behaviour:
We shouldn't be met with a stacktrace, if we don't have rights, we
should be redirected to the corresponding view for the `hr.employee.
public` model.

Steps to reproduce:
- Install Timesheets
- Set Marc Demo's Employee's right to `none/empty`, login as Marc
- In mobile view, go to Project > a task > open the timesheet sheet
- Click on Add or any of the present timesheets
- Click on employee field, either on it (redirect to the mobile
  kanban view of all employees) or to the right edge of it (redirect
  to the form view for the currently selected employee).
- Instead of being redirected, you are met with a stacktrace.

Reason for the problem:
Since the migration to Owl, there is an implicit consistency
expected between what is the requested model for said view, and the
model we get back from the server for said view. In general (for
example when in desktop view), usually we pass by an override of
`get_formview_action` which changes the model we are loading
front-end side depending on the access to the employee model. If
access, we load `hr.employee`, if no access, `hr.employee.public`.
But for mobile, we don't pass by an action, we just load a dialog,
and the `resModel` used for the dialog is based on the `relation` of
the `Many2OneField`, which is `hr.employee`. In that case when
`get_views` is being called, we receive a view with the model key
being `hr.employee.public`, which is inconsistent with what the
front-end requested (which is `hr.employee`) and we have a
stacktrace in owl.

Fix:
Override the `relation` property to the correct model in the
corresponding widget set on the template of the field, based on
available group. This relation is used to set the `resModel` when
opening the dialog.

Affected versions:
- 16.0
- saas-16.1
- saas-16.2
- saas-16.3
- master

opw-3269817

closes odoo/odoo#123217

Signed-off-by: Kevin Baptiste <kba@odoo.com>

This task aims to rework the wizard that creates a salary configurator and pre-fills the applicant's name, phone and email
task - 3171707

closes odoo/odoo#118213

Related: odoo/enterprise#38202
Signed-off-by: Kevin Baptiste <kba@odoo.com>

Steps to reproduce:
-------------------
- create two employees (A and B);
- create a user;
- add the user in Related User of employee A;
- remove the user;
- add the user in Related User of employee B;
- change the Work Email of the employee B.

Issue:
------
The Work Email of the employee A is also updated.

Cause:
------
When we add a `user_id` to an employee,
we update the `work_contact_id` field.
Fields `mobile_phone` and `work_email` are inverse fields.
When we modify them, the `_inverse_work_contact_details`
method is called.
We update the `work_contact_id` linked to the employee.

When we delete an employee's `user_id`,
we don't update the `work_contact_id`.
Therefore, when we update an employee's `work_contact_id`,
we call the `_compute_work_contact_details` method
method for all employees who have the same `work_contact_id`.

The result is that we modify the `mobile_phone` and `ẁork_email`
fields for all employees linked to the `work_contact_id`.

Solution:
---------
Differentiate the case where the `user_id` is `False` (>< `None`)
when it is modified and does not contain
a value to "synchronise" the `work_contact_id`.

opw-3338188

closes odoo/odoo#123830

Signed-off-by: Kevin Baptiste <kba@odoo.com>

[FIX] hr: remove the `quick create` on the many2one_avatar_employee and many2many_avatar_employee widget

 In this commit we have removed quick create option from many2one_avatar_employee and many2many_avatar_employee
 widget. because of There are too many faulty employees records coming from a
 quick Enter press on a list. 

Example:
    According to my attention when we do quick create then partner is not created.

task-3343117

closes odoo/odoo#123006

Signed-off-by: Kevin Baptiste <kba@odoo.com>

[FIX] hr : Hide field department in launch plan wizard if multiple employees from different departments are selected

task - 3279067

closes odoo/odoo#119948

Signed-off-by: Kevin Baptiste <kba@odoo.com>

The fix introduced in odoo/odoo#114903 created another issue: changing
the work email would change the private email also, breaking the
seperation of the contacts for the employee.

The initial behavior was correct:
 - a res.partner for the work details (email, phone, etc.)
 - a res.partner (of type private) for the personal details of the
employee.

task-3284664

closes odoo/odoo#119460

Signed-off-by: Kevin Baptiste <kba@odoo.com>

[FIX] web, hr(_recruitment) : Fix the phone field widget text breaking in multiple lines This PR Fixes the phone widget in the hr views and adds back the possibility to SMS to mobile and phone task - 3242157

closes odoo/odoo#116168

Signed-off-by: Kevin Baptiste <kba@odoo.com>

closes odoo/odoo#122042

Related: odoo/enterprise#41329
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>