- fix condition to correctly display company logo placeholder
- use avatar_grey on the "Contacts & Addresses" as white on white is not visible
- use `cover` to avoid excessive zoom on mobile

closes #38001

closes odoo/odoo#38319

X-original-commit: 1210cb70
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

closes odoo/odoo#38317

X-original-commit: b50bccb2
Signed-off-by: Christophe Simonis <chs@odoo.com>

X-original-commit: 46a3ac19

The parent was expected to return a dict, but it can also return None in some
cases. When that happens, the overrides were crashing because it is impossible
to assign a key/val to None.

Note that using `if` conditions like this also prevents from writing on the dict
if it is existing but empty, but due to the definition of the parent, if there
is a dict, it will not be empty.

closes odoo/odoo#38316

X-original-commit: 3525fad3
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

When a background video was used in a mega menu, it was only working in
edit mode. Indeed, the background video size is computed on page load
(and on window resize) but as the video is inside a hidden dropdown
menu in this case, the size cannot be properly computed.

This commit fixes the issue by recomputing the video size on dropdown
menu opening.

task-2080590

closes odoo/odoo#38314

X-original-commit: 66ec1c19
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

closes odoo/odoo#38327

X-original-commit: da9e377b
Signed-off-by: Christophe Simonis <chs@odoo.com>

Prior to this commit, un-checking 'Deduct down payments' on the invoice wizard had no effect: down payments were still deducted from the final (regular) invoice.

task-2081012

closes odoo/odoo#38326

X-original-commit: 4ef49caf
Signed-off-by: Antoine Vandevenne (anv) <AntoineVDV@users.noreply.github.com>

* web_editor

The purpose is to force our dropdown style in our UI so that themes do
not break it anymore (same way all the other elements are forced (cards,
headings, etc)).

task-2059538

closes odoo/odoo#38321

X-original-commit: 4ef0eac5
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>

Create a Project with tasks, archive it, delete it.

The project is deleted, but this should not happen:
tasks are present, but they are hidden because when the project is
archived all its tasks are archived too (active flag is set to false).
On project unlinking only active tasks are checked, thus allowing the
deletion. Using a context flag to avoid filtering the non active tasks.

opw-2080515

closes odoo/odoo#38320

X-original-commit: 71a79f26
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Install both Sale Management and Invoicing. Create an invoice without
any line, save it and cancel the entry. Print the canceled invoice,
traceback.

The python's `max` function requires an non-empty iterable to retrieve
the maximum element. For line less invoices, the value must be None.

closes #38175

closes odoo/odoo#38336

X-original-commit: d0402f9c
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

The replenish action shouldn't be accessible through the action dropdown
(it makes no sense to replenish consumables or services).
It is already accessible on the product/template form when applicable.

Closes https://github.com/odoo/odoo/issues/38238



closes odoo/odoo#38332

X-original-commit: 52d7008d
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

On a customer invoice, click on 'Print ISR' => Error

This is because of computed fields not set.

opw-2081567

closes odoo/odoo#38325

X-original-commit: ed6dd797
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Commit 5a9e1af6 has the unfortunate side-effect of crashing early
if for any reason the content cannot be decoded.
However, simply ignoring that the content cannot be decoded is no better idea:
some functions pipe the result to decoding functions that crash the same.
The resulting traceback pollutes the log with uninformative message such as:
binascii.Error: Incorrect padding 5 0.002 0.016

In case the content cannot be decoded (data corruption, or simply missing file)
we return a clean 404 instead, which is morally almost equivalent,
and is clean even from functions that depend on binary_content.

opw 2072586

closes odoo/odoo#38318

X-original-commit: a68f7e6e
Signed-off-by: Nans Lefebvre (len) <len@odoo.com>

closes odoo/odoo#38296

X-original-commit: 3b4a0e81
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

Allows the quick create on m2o in list views

Before this commit, when entering a new value in a many2one in a list and
exiting the cell through a click, the quick-create modal appeared for the
duration of the mousedown.

Now, the modal remains and allow to edit the new many2one value

Task 2076380

closes odoo/odoo#38289

X-original-commit: c00f84eb
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

`l10n_it_edi` inherits `fetchmail.server` model and extends its form view,
however it does not have `fetchmail` in its transitive dependencies.

closes odoo/odoo#35744

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

The wrong order was used in the row_number call, which lead to ids
changing when writing on `is_favorite`

closes odoo/odoo#38278

X-original-commit: 28ebe6d4
Signed-off-by: Romain Libert (rli) <rli@odoo.com>

X-original-commit: fcf03eaf

When on Firefox, with sale_product_matrix and sale_quotation_builder installed,
clicking anywhere on the matrix (after opening it) raises a traceback.

It is due to the fact that isBody tries to access anchorNode.nodeName, which
is unexpectedly unaccessible as anchorNode is {Reserved}.

Due to the absence of clear documentation of the possible reasons of this problem,
it was decided to reuse the existing fallback on 'return null', which avoids the
traceback.

closes odoo/odoo#38277

X-original-commit: 70c484e7
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Have a lead with a partner on it, convert it to opportunity
in the conversion wizard, tick "don't link to customer"

Before this commit, the opportunity has been linked to the
lead's partner

After this commit, the opportunity is not linked to any partner

OPW 2077692

closes odoo/odoo#38262

X-original-commit: f1d270e4
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>

We don't want the browser to fill inputs in the backend.
Most of the time this is useless but sometimes it is
even problematic. For example, focusing an input in a
modal can trigger autofill not only in the modal but
also in the whole page. If there is an input outside
the modal and it is recognized by the browser as a
candidate to fill, bad things occur.

For that reason, we set the attribute autocomplete to
"none" by default for input elements.
Note that "off" does not work all the time because
the browsers sometimes decide to ignore it.

Task ID: 2076730

closes odoo/odoo#38039

Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>

This introduces a new constraint to the `ir.model.data` model, to
disallow external IDs containing spaces. Those cases may cause issues
and should be avoided.

For more information about why an external ID containing spaces is a bad
idea, see:
- https://github.com/odoo/odoo/commit/3c568aec0b46
- https://github.com/odoo/odoo/issues/25408



closes odoo/odoo#38139

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

https://packages.debian.org/buster/python-pil


As of today, python-pillow is at 5.4 in the latest debian release

This allows to deprecate the older versions progessively

Newer versions have new features like the exif_transpose method in 6.0
as discussed at #37448

closes odoo/odoo#38245

X-original-commit: 4ad7a99d
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Oversight of previous forward-port.

.. and first menu is a container with # as url.

There is a particular case where the / url would loop endlessly.

1. Unpublished the homepage /
2. Edit the menu so the first menu is a container. There is a hint telling you
   a container menu should have its URL set to `#` as a good practice.
3. This will lead to endless loop for public user as the code will check if the
   homepage can be accessed. Since it is unpublished, it will then fallback on
   the first menu which is not '/' and redirect to it.
   Sadly, the code was not expecting `#` to be handled as `/`.

opw-2081969

closes odoo/odoo#38234

X-original-commit: cff11bdb
Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Before this commit and since beaa30a3 it was not possible to download a
digital product.

The `search_read()` would return move line which does not have any `product_id`
which will later crash when accessing `product_id` in the for loop.

Search_read result would be:
[{'id': 20, 'product_id': (38, 'eBook: Office Renovation for Dummies')},
 {'id': 21, 'product_id': False},
 {'id': 22, 'product_id': False},
 {'id': 23, 'product_id': False}]

task-2063307

closes odoo/odoo#38225

X-original-commit: b045be2814cee96c9723f0c9d07462e07cab4773
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Before this commit, we hide the 'relative warning' when you don't start
you url with the current location. Now we show it only when you start
your url with the current location.

Before this commit, when you create a new link, the warning was shown
until you type a first char in the input to trigger the input change.

+ some small design theme (label font weight, muted color, ...)

closes odoo/odoo#38224

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

"There is no <plural>" is not correct
cf https://english.stackexchange.com/a/26634



closes odoo/odoo#38205

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Starting with Python 3, queries sent by psyocopg2 are stored as `bytes()` objects.

Logging those raw makes them appear unformatted, harder to read than in v10 or lower Odoo versions (i.e. `\n` instead of a raw newline character).

Decoding the query into unicode makes it easier to read in the logs.

closes odoo/odoo#38074

X-original-commit: 329accde
Signed-off-by: Christophe Simonis <chs@odoo.com>

Since commit 07631a51, category has been updated, but not the filter of this action

task-2081177

closes odoo/odoo#38223

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

When is created a refund from a invoice, the payment term its cleans,
but not the date due.

In the next case:
1. Create an invoice with date 05/26/2019, with payment term "30 days".
2. Create an invoice refund for invoice in 1, with the same date.

In this case, the payment term in the refund is empty, but the date_due
is the same that in the invoice.

With this change, the date due in the refund is the same that invoice
date.

closes odoo/odoo#38212

X-original-commit: 6828454dc3726d85e4d29b9399d6e8ddd1aaac21
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

before this commit: mrp work center kanban card has UI glitch in
kanban card, work center stage was overlapping kanban card right
div

after this commit: overlapping issue of work center stage will
not occur, issue was occuring due to absolute position given on
work center stage div, added margin bottom of 16px on kanban
card right div

task-2060181

closes odoo/odoo#38210

X-original-commit: 7143e570
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Currently when inviting someone on a document all recipients are considered
as standard customers. It means access buttons are not displayed and
addon specific behavior not really triggered.

This commit makes use of ``_get_recipient_data`` tool method allowing
to categorize recipients in groups and display buttons and action links
like other post on documents.

Task ID 1967234

closes odoo/odoo#38111

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

This reverts commit 08108486.
+ Fix the url that add a useless ending / and so a useless redirection.

There are no problem of mixed content or anything else, if you configure nginx
and launch your server in proxy-mode as specified into the documentation.

closes odoo/odoo#38196

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

One2many fields can use it actually

closes odoo/odoo#38193

X-original-commit: 76556603
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Every records should have a value assigned, avoid CacheMiss errors

Closes odoo/odoo#37957

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Done at #37957

In case you have a controller website=True without website installed, the
request.redirect() use url_for which one uses request.website_routing on the
request, without that it has been set by the website dispatcher.

closes odoo/odoo#38191

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Use case to reproduce:
- Create a SO and confirm it
- Add a new line with a consumable/storable product

-> The delivery order contains the new lines but with the double of
required quantity.

Due to commit cb618e9a that try to lauch procurement in bacth.
Howerver The create from sale.order.line was not removed and the
_action_launch_procurement were launched twice (in sale.order write +
sale.order.line create).

The fix could remove the create function from sale.order.line but
the drawback is that everytime a sale.order.line is created/edited then
it should pass through the sale.order 'write' method.
That would create a lot of issue in the future compare to the small gain
of performance for a correction.

Task-2077129

closes odoo/odoo#38187

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>