closes odoo/odoo#88301

Signed-off-by: Josse Colpaert <jco@odoo.com>

closes odoo/odoo#88292

Signed-off-by: William André (wan) <wan@odoo.com>

Install FR accounting and have a FR company setup with VAT
Create a bill with bill date different from accounting date
Export FEC under Accounting>Reporting>FEC

For the created bill the accounting date will be used, while it should
be taken first the bill date

opw-2680288

closes odoo/odoo#88281

X-original-commit: 2b1fc6a9
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
Signed-off-by: Grazioso Andrea (agr) <agr@odoo.com>

If applied, this commit will fix the following bug by using the correct
total based on whether the price is tax inc. or exc.

Steps to reproduce:
- Install sale
- Create a tax with "included in price" set on it
- Create a promotion program with any value higher than
  [100/(1+VAT/100)]% discount on total order
- Create a SO and add product with the created tax
- Add promotion program

Result:
- The discount applied is capped at [100/(1+VAT/100)]%
  Eg, for a 35% included tax, the max discount will be 74.07%,
  regardless if the discount % is higher like 90%.
Expected result:
- The correct discount should be applied

Bug:
The ```price_subtotal``` is used to calculate the order total amount
whether the price is tax inc. or tax exc.

Fix:
Use ```price_total``` when the price is tax inc.

opw-2765883

closes odoo/odoo#88066

X-original-commit: a99b4438
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Co-authored-by: Andrea Grazioso (agr-odoo) <agr@odoo.com>

This garbage adds no value and blocks some deployments. See https://github.com/Tecnativa/doodba/issues/485

.

@moduon MT-295

closes odoo/odoo#85823

Signed-off-by: Thibault Francois <tfr@odoo.com>

Steps :
Install modules hr_holidays and google_calendar;
Log into Odoo with two different users, one manager and one employee (subordinated): f.e. Admin e Demo;
Set Google Client ID and Google Secret with a OAuth2.0;
Check if in Odoo's Calendar the Synched with Google tag compares on the right (with manager);
From employee user, go to Time Off -> My Time Off -> My Time Off Requests and Create with a date;
From manager user, go to Time Off -> Managers -> Time Off and accept the time off created;
Go to manager's Google Calendar.

Current behavior:
Google event is created and visible for manager, employee has an event since is an attendee of the first.

Expected behavior:
Google event is created and visible for employee, manager is not involved.

Fix:
Group the leaves with user and create events with this user.
We could not modify easily the behavior of the calendar sync modules.
The following approach was tested: odoo/odoo#86385
But it has some side effects on recurring events, oultier events
(events not following the recurrence) and could bring performance issues.
The solution of this fix was chosen because it is less intrusive.

opw-2761158

closes odoo/odoo#88124

Signed-off-by: Arnaud Joset <arj@odoo.com>

The problem is that we have a limited space in the filename for
differentiating one file from the other. Only the five characters at the
end of the filename are used, this looks like:

    <CODICE_FISCALE>_NNNNN.xml (where N is a character a-zA-Z0-9)

The current version utilises the invoice id to get the unique filename.
This has a couple of problems:
 - It doesn't utilise the (lowercase) a-z characters
 - Draft invoices still have invoice ids
 - In a multicompany environment, the invoice ids are not unique to the
   company (i.e. another company creating an invoice will increment the
   value of the invoice.id on your company)
These above problems mean that we're not currently utilising the hashing
space available to us by the characters of the filename.

The solution is to utilise an ir.sequence, that is used to determine
each filename. This has the benefit of being editable by the user, so if
they continue to get duplications, they can offset them by adjusting the
value of the sequence's next number.

A more descriptive error message and its translation term have also been
added for when a filename duplication occurs.

relates to

closes odoo/odoo#88005

Task-id: 2813957
Ticket-id: 2788927
Signed-off-by: Josse Colpaert <jco@odoo.com>

closes odoo/odoo#86971

Signed-off-by: Josse Colpaert <jco@odoo.com>

When validating a picking that comes from a subcontractor, if there is a
backorder, it will lead to an odoo error

To reproduce the issue:
(Need purchase)
1. Create a product category PC:
    - Costing Method: FIFO
2. Create two products P_compo, P_finished
    - Both storable
    - P_compo:
        - Tracked by lot
    - P_finished:
        - With a vendor V
3. Create a BoM:
    - Product: P_finished
    - Type: Subcontracting
    - Subcontractors: V
    - Components:
        - 1 x P_compo
4. Create and confirm a PO:
    - Vendor: V
    - Products:
        - 10 x P_finished
5. On the receipt, record the production of 7 x P_finished
6. Validate the receipt (with backorder)

Error: An Odoo Error is displayed "ValueError: Expected singleton"

When recording the production, because the producing quantity is not the
expected one, a second manufacturing order MO02 is created. Therefore,
the stock move SM01 that brings the P_finished in the stock has now two
origin moves: the finished moves of MO01 and MO02.

Then, when validating the picking, SM01 is split into two SM:
https://github.com/odoo/odoo/blob/30cc4b5050f538ac4b9152dd78686682d42e7036/addons/stock/models/stock_move.py#L1542-L1547
And this new stock move SM02 has the same origin moves (i.e., the
finished moves of MO01 and MO02). Later on, still while validating the
receipt, it leads to:
https://github.com/odoo/odoo/blob/6c086d820b05602c149f4387d3d19c8e4eed0c8c/addons/mrp_subcontracting_account/models/mrp_production.py#L10-L14


where `self` is MO01. So, here is the issue: as explained above, the
finished moves of M01 contains two moves: SM01 and SM02. Therefore,
reading `is_subcontract` on the recordset or calling `_get_price_unit`
(which is an `ensure_one` method) on this recordset will raise the
error.

OPW-2814448
OPW-2817512

closes odoo/odoo#88214

Signed-off-by: Arnold Moyaux <arm@odoo.com>

In case the user is not in the accounting group, they won't be able to
see the expenses they generate if the expense has account entry.

closes odoo/odoo#87524

Signed-off-by: Kevin Baptiste <kba@odoo.com>

Unnecessary call to _create_check_sequence because is called in create method and create is called in supper().copy()
TT35608

closes odoo/odoo#88111

X-original-commit: 2f83737b
Signed-off-by: Florian Gilbert <flg@odoo.com>

closes odoo/odoo#88101

X-original-commit: 1d46b388
Signed-off-by: Raphael Collet <rco@odoo.com>

Steps to reproduce:
- Create an invoice: select a product; set the price to 23.00$; change the currency to €; confirm the invoice.
- Create a receiving payment from the same customer: select the $ currency and put 100$
- Go back to the invoice and select the payment/reconcile the invoice and the payment.

Issue:
The payment is partial with 0.01€ to be paid.

Cause:
(conversion rate: 1.5289$/1€)

1) When the currency is changed or the price assigned, we convert the price EXCL. and then we convert the tax amount.

https://github.com/odoo/odoo/blob/582b43bdf46c485be8219e1cbeb60dbed033f1e7/addons/account/models/account_move.py#L3953-L3954

In our example:
- price EXCL.: 23€ * 1.5289 = 35.1647$
    price._convert() -> 35.16$
- Tax amount: 3.45€ * 1.5289 = 5.274705$
    tax_amount._convert() -> 5.27$
Real Sum = 40,439405$
Sum returned after convertion = 40.43$ != 40.44$

2) To compute what is left to be paid, we use the converted amount and convert it back to the currency of the invoice. Double conversion, double mistake.

https://github.com/odoo/odoo/blob/582b43bdf46c485be8219e1cbeb60dbed033f1e7/addons/account/models/account_move.py#L4873-L4878

In our example:

3) We convert back the 40.43$ to know the residual:
- 40.43$ / 1.5289 = 26.443848519€ => rounded = 26.44€ != 26.45

We then compute the `debit_amount_residual_currency` (26.45€) by substracting from it the `min_debit_amount_residual_currency`(26.44€).

https://github.com/odoo/odoo/blob/582b43bdf46c485be8219e1cbeb60dbed033f1e7/addons/account/models/account_move.py#L4886-L4887

Which lefts us with a `debit_amount_residual_currency` 0.01€ (0.0099999..801).
https://github.com/odoo/odoo/blob/582b43bdf46c485be8219e1cbeb60dbed033f1e7/addons/account/models/account_move.py#L1421-L1437



closes odoo/odoo#87963

Ticket: 2765223
Signed-off-by: Olivier Colson <oco@odoo.com>

Currently, when modifying an invoice line and setting taxes
(price included) for 100%, the price_unit field will
be displayed as 0.

This is incorrect and is being fixed here.

opw-2793284

closes odoo/odoo#87960

Signed-off-by: Laurent Smet <las@odoo.com>

How to reproduce:
1- Create Product Category "PC" AVCO|FIFO Automated.
2- Create Storable Product "P" with product category PC and unit cost to 1.
3- Create SO with 10 units of P.
4- Create PO with 10 units of P and unit cost of 2.
    Delivery of the SO should now have 2 IV layers, with one being "Revaluation of XXX (negative inventory)"
    Global IV of P should be 0 qty, 0 value.
5- Return the delivery order of SO.
6- Open valuation of the return

Error: The value is 0, should be 20
In `_get_price_unit`, `price_unit` is taken on the last svl of the origin_returned_move_id, in our case it's the revaluation layer.
`_get_price_unit` now take all svls of origin_returned_move_id into account.

OPW-2784033

closes odoo/odoo#88110

X-original-commit: f8e2f2a4
Signed-off-by: Arnold Moyaux <arm@odoo.com>

This speeds update the peformance of searching empty one2many fields

closes odoo/odoo#78607

Signed-off-by: Raphael Collet <rco@odoo.com>

Part-of: odoo/odoo#78607

``get`` default is a dict that gets evaluated to be sent as parameter,
causing an unnecessary read on the component's computed fields.

The read should only happen only if we don't have a value in ``res``.

closes odoo/odoo#88007

X-original-commit: 4d16869e
Signed-off-by: Arnold Moyaux <arm@odoo.com>

On a receipt, when defining the expiration date of a lot, the SML keeps
<today> as expiration date

To reproduce the issue:
1. Edit the operation type "Receipts":
    - Show Detailed Operations: True
    - Use Existing Lots/Serial Numbers: True
2. Create a product P:
    - Type: Storable
    - Tracking: By Lots
    - Expiration Date: Enabled
3. Create a planned receipt R with 1 x P
4. Mark R as Todo
5. Add a detailed operations:
    - 1 x P with new lot L
6. Edit the lot:
    - Expiration Date: <today + 7days>

Error: When saving the picking (with the lot updated), the expiration
date is incorrect (set to <today>).

OPW-2785256

closes odoo/odoo#87699

Signed-off-by: Steve Van Essche <svs@odoo.com>

Before this commit:

When you create a new channel HTML tags are visible in Autocomplete text area
for a split second

After this commit:

Added prevendDefault for the autocomplete select event to stop it's defaullt
behaviour as changing the autocomplete text area's value by the selected item's
value

Task-2792365

closes odoo/odoo#88097

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

When using a pricelist with a currency different than the one
of the product, the prices used in the pricelist (surcharge, min_margin,
& max_margin) are using the default currency of the company which is invalid.

To reproduce the issue:
1. Enable multiple currency and enable a second one with an exagerated rate for the sake of clarity.
2. Create a formula pricelist with the newly activated currency using either surcharge or the margin.
3. Create a SO with a standard product. By switching between pricelist, you will see an invalid price.
E.G.:
        EUR_rates = 2 compared to USD        PRICELIST = surcharge of 10€ on any product
        PRODUCT_price = 300$      PRODUCT_price_euros = 150€
        CURRENT_SO_price = (300 + 10)/rate_EUR = (300 + 10)/2 = 155€
        EXPECTED_SO_price = (300 + 10*rate_EUR)/rate_EUR = (300 + 10*2)/2 = 160€

Solution:
Convert the pricelist item margin & surcharges to the base price currency.
To do so, the needed currency conversion date is given through the context.

opw-2760720

closes odoo/odoo#88039

X-original-commit: b7ec0a2e
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Signed-off-by: Desausoi Laurent (lade) <lade@odoo.com>

This patch solves memory problem on exporting `account.move.line` records:
while export method invalidate cache for `account.move.line`, it keeps cache for
`account.move`, which may lead to memory error.

opw-2764457

closes odoo/odoo#88029

X-original-commit: 80c65498
Signed-off-by: Raphael Collet <rco@odoo.com>

Rewrite stock_picking._create_move_from_pos_order_lines
to make calls in batches. Change the order of some operations
so that methods such as stock.move._action_confirm() and
stock.production.lot.create can be called only once and in batch.

Modify test_order_to_pickings02 to add a check
on product tracked by lot but without a preexisting
stock.production.lot. i.e. check that
_create_move_from_pos_order_lines properly creates
a new lot.

opw-2766512

closes odoo/odoo#86643

Signed-off-by: Masereel Pierre <pim@odoo.com>

Canceled and draft entries are the same color as posted entries. They should be in a different color (grey/blue) in order to be distinguished from other invoices/bills.

Task=2801521

closes odoo/odoo#87985

Signed-off-by: Laurent Smet <las@odoo.com>

Steps to follow

  - Use a browser timezone of GMT +2
  - Create a pricelist ending in an hour with a matching product
  - Add the pricelist to advanced pricelists in the POS settings
  - Open a POS session
  - Add the aforementioned product
  - Apply the pricelist
  -> The custom price is not applied

Cause of the issue

  `date_start` and `date_end` are stored in utc
  They are then off by the amount of the offset in the browser timezone

opw-2794490

closes odoo/odoo#87544

Signed-off-by: Masereel Pierre <pim@odoo.com>

The fix made in odoo/odoo#87723 was not taking into account the active
field.

closes odoo/odoo#87903

X-original-commit: ce624547
Signed-off-by: Kevin Baptiste <kba@odoo.com>

The e-faktur contains amounts that are not well rounded

Steps to reproduce:
1. Install Accounting app and l10n_id_efaktur module
2. Switch to ID Company
3. Open Accounting
4. Go to Customers > e-Faktur
5. Create a new range (at least one number available)
6. Create a new Customer Invoice for a customer in Indonesia with ID PKP
enabled, specify a 'Kode Transaksi' and add a product with a price of
147.5 and a tax of 10%
7. Download the e-faktur
8. The amounts on the product line are not rounded but truncated

Solution:
Round the amounts that are translated to int

opw-2793009

closes odoo/odoo#87924

X-original-commit: dbe11ced
Signed-off-by: William André (wan) <wan@odoo.com>

Have a CL company setup
Issue a vendor bill
Then generate the credit note via 'Add Credit Note' wizard
Add a reason and confirm
Error will raise “You can not use a invoice document type with a refund
invoice”

As
https://github.com/odoo/odoo/commit/c9ff9d28ab75c02093ca54d9fbd1d2e203c5ee2e


for the invoice case
we need to add specific logic to handle credit notes in l10n_cl

opw-2801576

closes odoo/odoo#87910

Signed-off-by: Josse Colpaert <jco@odoo.com>

Currently, if the tip does not have any content set in step (happens a
lot in test tours), the tip is not displayed properly. This happens
because the height of the tip is set based on the tip content which is
not available in our case.

This commit fixes the behavior by providing a default content in such
cases saying "Click here to go to the next step.". It has two benefits
(in case someone is manually walking through a test tour):
- The tip is displayed properly.
- We can guide the devs with a friendly message.

task-2792218

closes odoo/odoo#87322

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

In the editor menu, the buttons 'Blocks', 'Style', and 'Select a
template' are not visible because they are hidden by the theme selector
When clicking on 'Change Style' in fullscreen, the dropdown menu hides
the button so it is impossible to exit the theme selector without
choosing one

Steps to reproduce:
1. Install Email Marketing
2. Create new mailing
3. Select a Mail Body (except 'Plain Text')
4. The buttons are hidden by the button 'Change Style'
5. Go in fullscreen and click on 'Change Style'
6. The dropdown menu hides the button so we cannot exit the theme
selector properly

Solution:
Delete the absolute position of the theme selector
Put the dropdown menu lower so that it doesn't hide the 'Change Style'
button
Hide the 'Select a template' button because it is useless

opw-2743460

closes odoo/odoo#85672

Signed-off-by: Antoine Guenet <age@odoo.com>

opw-2729810

closes odoo/odoo#87872

X-original-commit: ca4300d5
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
Signed-off-by: Hubert Van De Walle <huvw@odoo.com>

To reproduce
============

- Create one french company and one italian company with their respective localization packages.
- Go to the French company and create a contact, first set the country and then the VAT.
An error message will appear referring to Codice Fiscale but this information is not relevant on the French Company.

Purpose
=======

The VAT field has an onchange trigger `_l10n_it_onchange_vat`  to set `l10n_it_codice_fiscale` value.
on `_l10n_it_onchange_vat` there is no verification if the VAT number is Italian, so we try to get
a Codice Fiscale from it, which leads to error if the VAT number is not Italian.

Specification
=============

To solve the issue we added a verification on the VAT number to make sure that it is an Italian one before
trying to get Codice Fiscale from it.

opw-2777519

closes odoo/odoo#87603

Signed-off-by: Josse Colpaert <jco@odoo.com>

=> Create an invoice in foreign currency
=> Register a payment of 0 using the currency of the company and select "Keep open"
A traceback is raised

closes odoo/odoo#87768

Signed-off-by: Olivier Colson <oco@odoo.com>

- Create an invoice having a foreign currency
- Register a payment of 0.0 using a different currency with a write-off of any account
=> traceback

Task: 2809565
Part-of: odoo/odoo#87768

When a filename is given to the function binary_content it was shadowed
by _binary_ir_attachment_redirect_content if it is an ir.attachment.

To reproduce:
  1. Start a brand new database in V14, install any app on which you can add an attachment (like Project or CRM)
  2. Add a file as an attachment
  3. Try to call the route "/web/content/<string:model>/<int:id>/<string:field>/<string:filename>"

closes odoo/odoo#87725

Solution: Use another variable to store the return value of _binary_ir_attachment_redirect_content and use it if the filename is not provided.
X-original-commit: 0eb69d75
Signed-off-by: Julien Castiaux <juc@odoo.com>
Signed-off-by: Wanderscheid Mathieu (mawa) <wama@odoo.com>

Improve 06188f61

The user does not have the possibility to create a delivery to the
inter-warehouse transit location (the destination location is
invisible). Same for the receipt.

So, the user should only avoid transferring some products between two
warehouses if the internal transfer is a planned one.

closes odoo/odoo#87797

X-original-commit: 09fd3867
Signed-off-by: Arnold Moyaux <arm@odoo.com>
Signed-off-by: Adrien Widart <awt@odoo.com>

Demo data to improve the flow of testing the edi. A bank account and a
partner with a street/city/zipcode/codice fiscale are required for the
edi, so having these as demo data is useful.
The demo company vat code and codice fiscale are also changed to those
of a valid company, so that they will be accepted by the sdi testing
environment. The address of the demo company is updated so that, if by
accident, an invoice is sent using the demo company, through the
official channel, the address will make it an obvious test.

closes odoo/odoo#87249

Task-id: 2809328
Signed-off-by: Josse Colpaert <jco@odoo.com>

Open a activity view(record modal), that will show records, clicking on the
'o_activity_btn' of a record will show dropdown and make sure that there are
many scheduled activity there .

Before this commit:

The dropdown was bigger than the record modal which had a scroll bar. It was not
scrollable properly and "+ Schedule Activity" button is not accessible.

After this commit:

The dropdown follows the scroll, and it will be possible to click the button.

Task- 2528111

closes odoo/odoo#72441

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>