- Feb 05, 2020
-
-
Hardik Prajapati authored
Python module vatnumber doesn't seem maintained anymore. Therefore, we should: - call directly stdnum (which is maintained and mostly used everywhere in vatnumber) Also improve stdnum import, vat fix method and vat expected formats task-1915371 closes odoo/odoo#36978 Signed-off-by:
Quentin De Paoli (qdp) <qdp@openerp.com>
-
- Feb 11, 2020
-
-
Andrea Grazioso (agr-odoo) authored
Go to Accounting / Reporting / Management / Invoices Select Pivot view Add "Total" measure expand results adding "invoice #" and product Total will be incorrect because it is summing up the value reported from several lines of the query in which the total is taken as the invoice total, so it will display total * # lines. Using the price retrieved from the single lines fix the issue, but it needs to be converted according to the currency rate of the invoice. Moreover the test need to be modified because the amount_total variable of the report should NOT be the move amount_total but the amount from all the lines converted in company currency opw-2187369 closes odoo/odoo#45050 X-original-commit: 1558bb2a Signed-off-by:
Nicolas Martinelli (nim) <nim@odoo.com>
-
- Feb 07, 2020
-
-
Sebastien LANGE authored
closes odoo/odoo#44823 X-original-commit: 633d1f3e Signed-off-by:
Arnold Moyaux <amoyaux@users.noreply.github.com>
-
Sebastien LANGE authored
Usecase to reproduce: - Set the lot_stock_id as a view location - Create a PO and validate it -> The forecast quantity on stat button is correct but it's missing in the forecast quantity report. It happens because the condition for stock_move is based on valuation strategy. However it's not correct since it's not True that a product is in the stock if it's valuated (as subcontracting, owner, ...) In order to fix it uses the warehouse in order to define if a move is in or out (the same way than the _get_domain_locations on product). X-original-commit: d7da1b73
-
- Feb 10, 2020
-
-
Richard Mathot authored
When adding a custom field, the ORM also adds it to all the inherits'ed models, but with the state `base`, because those inherited fields are automatic (created by the ORM). However, dependencies are enforced for `base` fields, while they can be ignored for `manual` ones. This is a problem when a custom field is fucked up: its inherited fields will make the registry crash. We fix the issue by not enforcing dependency check on fields inherits'ed from custom fields. opw-2191114 closes odoo/odoo#45024 X-original-commit: 2db0787d Signed-off-by:
Raphael Collet (rco) <rco@openerp.com>
-
jerome hanke (jhk) authored
Steps to reproduce: - have Odoo with Dutch language and install Belgian accounting - print "Periodieke BTW aangiften" report - the report is wrongly translated see this document for reference: https://financien.belgium.be/sites/default/files/downloads/165-625-richtlijnen-2016.pdf%22 related pr: https://github.com/odoo/enterprise/pull/8233 opw-2176688 closes odoo/odoo#45009 X-original-commit: 32b385b7 Signed-off-by:
Nicolas Martinelli (nim) <nim@odoo.com>
-
- Feb 07, 2020
-
-
Julien Castiaux authored
The translation alert dialog was attached to the entire view in case no status bar was found. This resulted in the following layout on large screens: chrome -------------------------------------- | alert dialog | form view | chatter | | | | | -------------------------------------- Whereas when a status bar was set on the form view, the rendering was as follow: chrome -------------------------------------- | status bar | chatter | | alert dialog | | | form view | | -------------------------------------- The fix make sure the alert dialog is always placed just above the form view just like when there is a status bar. closes odoo/odoo#44878 Task: 2075172 X-original-commit: dacdc30681510e9c2db23610c5be5285a72a8949 Signed-off-by:
Julien Castiaux <Julien00859@users.noreply.github.com>
-
- Feb 11, 2020
-
-
Yenthe666 authored
Before this commit the purchase_rfq action had two context keys defined. One being empty {} and one with quotation_only set to True. After this commit there is just one context (the one that is actually used and applied) on the action. Empty key added in 12.0 at 6138686d Second key added in 13.0 at b5cea7e2 closes odoo/odoo#44990 Signed-off-by:
Martin Trigaux (mat) <mat@odoo.com>
-
- Feb 10, 2020
-
-
snd authored
In a database with many users / events to synchronize, the cron `ir_cron_sync_all_cals` may time out. Consequently, even if a `commit` is performed for each user, some users are never synchronized. In this commit, we first sort the users by last synchronization date, meaning that all users will ultimately be synchronized, even if the cron times out. On top of that, we introduce the context key `last_sync_hours` to prevent the synchronization in case the cron is restarted after timeout. opw-2158372 closes odoo/odoo#45032 X-original-commit: 2f21def6 Signed-off-by:
Nicolas Martinelli (nim) <nim@odoo.com> Co-authored-by:
Nicolas Martinelli <nim@odoo.com>
-
Joren Van Onder authored
Without these magic filters the various options in the activity widget (late, today, future) will show all activities instead. opw-2172833 closes odoo/odoo#45036 X-original-commit: 081cb02d554760be1da0d4d10ad9a287c7bf462e Signed-off-by:
jorenvo <jorenvo@users.noreply.github.com>
-
Yannick Tivisse authored
Purpose ======= Launch the test at 00:05:00. Then when opening the advance payment wizard, the field date_invoice_timesheet would be set to yesterday, instead of today. Adapt the default value on the wizard, and the related tests. closes odoo/odoo#45023 Taskid: 2178983 X-original-commit: 0a46e92cf742ca811b1685860619dba1d0dc7bd5 Signed-off-by:
Christophe Monniez (moc) <moc@odoo.com>
-
Johan Demaret Rivarola authored
When reading binary content such as `image_128` on `res.users`, `AccessError` should be raised when necessary. Steps to reproduce: - Populate cache in superuser mode. - Access cached field with public user. - Read access is allowed but should not. Concrete example: - Unpublish `demo` user. - Access `/slides` with `public` user. - The template data is generated as `sudo`. - The same data is then accessed as `public`. - AccessError should be raised when requesting `/profile/avatar/<int:user_id>` but is not. Closes #43826 closes odoo/odoo#45033 X-original-commit: e0112db4 Signed-off-by:
Christophe Simonis <chs@odoo.com>
-
Samuel Degueldre authored
Previously, when clicking on the next post at the bottom of a blog post, a spinning loader circle would always appear in the bottom left of the screen in an incorrect position. This commit removes that spinner. This commit also adds support for the half-screen cover size, which until now would animate as though it was full screen. All in all this just makes the transition animation much more seamless, which was the point of having it in the first place. task-2166790 closes odoo/odoo#44198 Signed-off-by:
Quentin Smetz (qsm) <qsm@odoo.com>
-
Denis Ledoux authored
closes odoo/odoo#45025 X-original-commit: ba1acb26 Signed-off-by:
Denis Ledoux (dle) <dle@odoo.com>
-
Romain Derie authored
The user is never able to delete a website, since there is at least one page, the homepage, which is bootstraped during website creation. From that point, even if nothing was done on that website, it was not possible to remove it. As website deletion is already a technical thing (debug mode), and since website.page do not make sense without their website, removing those on cascade will allow the user to remove a non-modified website. task-2092845 closes odoo/odoo#45018 X-original-commit: ba6206ba Signed-off-by:
Romain Derie <rdeodoo@users.noreply.github.com>
-
Romain Derie authored
As an admin or website publisher, you have the possibility to switch website in the navbar. This will force a website in your session*. If this website is removed at some point, your session will be broken as the dispatch will lead to a traceback, trying to read un unexisting website. * There is other way to have the website forced in the session: theme install, go to website from settings, create website from settings.. opw-2092845 X-original-commit: 835d1201
-
qsm-odoo authored
When snippets deeply alter the DOM (e.g. image reordering in gallery), the related option might be destroyed since they are referencing old DOM. If such a case occurred, the destroyed option was still waiting for an option update response by the editor before being considered as finished... which then never occurred and blocked the editor. closes odoo/odoo#44998 X-original-commit: 9eeea4c4107dc15984c475582d5ee58a17cd2568 Signed-off-by:
Quentin Smetz (qsm) <qsm@odoo.com>
-
Kevin Baptiste authored
closes odoo/odoo#44997 X-original-commit: a8094108a4e469f5bc4a3ba541ede7a61f28d522 Related: odoo/enterprise#8311 Signed-off-by:
Yannick Tivisse (yti) <yti@odoo.com>
-
jvm-odoo authored
Issue - Install Blog - Go on a Blog post - Customize > Enable Share links & Sidebar - Click on a social share link Redirected to # Cause The website_blog.js has been refactored fron v12 to v13, it seems that the onShareLink method has been forgotten in the event handlers. Solution I added it and make it working with the actual view. OPW-2170706 closes odoo/odoo#44992 X-original-commit: 0e90afb7 Signed-off-by:
Quentin Smetz (qsm) <qsm@odoo.com>
-
Samuel Degueldre authored
When the apply-to data attribute was first introduced, a mistake was made when storing the results of the methods calls, using _.each instead of _.map to associate each target element with the promise of the method execution, as a result, Promise.all would resolve immediately instead of waiting. While there are no currently documented bug caused by this, they are just waiting to happen. This commit fixes that. closes odoo/odoo#44988 X-original-commit: 32271be1f696c11b3e5157426b8f7c9efa93134b Signed-off-by:
Quentin Smetz (qsm) <qsm@odoo.com>
-
fja-odoo authored
Selecting a css color equals to a theme color via the custom color was not selecting the theme color. Opening and closing the custom color without picking a color was unselecting the selected color. Now the custom color picker has the selected color as default even if it does not appear in the palette as selected. This was appearing in the parallax snippet as no custom color is displayed. closes odoo/odoo#44986 X-original-commit: 0c8be24ac72c223c12eadbdcf635628f203a6766 Signed-off-by:
Quentin Smetz (qsm) <qsm@odoo.com>
-
qsm-odoo authored
Since we use Promise instead of jQuery deferred, the onRemove method class was no longer triggered before the actual removal of the elements. Original fix with https://github.com/odoo/odoo/pull/43918 This PR is the same with the async/await form, not breaking the history of half of the removeSnippet method's lines. closes odoo/odoo#44963 X-original-commit: 37941159c82d487ff172f0e6b27028f23ab32810 Signed-off-by:
Quentin Smetz (qsm) <qsm@odoo.com> Co-authored-by:
fja-odoo <fja@odoo.com>
-
fja-odoo authored
*: website Some dialog promises were not resolved on close, blocking the editor. closes odoo/odoo#44953 X-original-commit: 20f97470cdc59a817526305806e94b222f26a0f2 Signed-off-by:
Quentin Smetz (qsm) <qsm@odoo.com>
-
- Feb 08, 2020
-
-
Swapnesh Shah authored
Follow-up on https://github.com/odoo/odoo/commit/22f02af6bf002324ebafc38d4eefeda60063247a Use the correct reference for the file. closes odoo/odoo#44919 Signed-off-by:
Victor Feyens (vfe) <vfe@odoo.com>
-
- Feb 10, 2020
-
-
Swapnesh Shah authored
Followup on 5ce8f1e3 Before this commit, There would be traceback on Launching Plan with `Responsible` set to `other` and No `Responsible Person` defined on activity due to Extra argument. In this commit, We remove that extra Argument. closes odoo/odoo#44965 X-original-commit: 009e5526 Signed-off-by:
Thibault Delavallee (tde) <tde@openerp.com>
-
David Beguin authored
Purpose ======= Whenever a visitor start a livechat session but finally close the session without sending any messages, the livechat session is empty and stay in DB. Livechat session counter counts all the sessions (with and without message) but when opening the sessions tree view, the view is filtered by default on session with messages. There is no reason to see the empty sessions as it does not give any information (except "the visitor hesitated to start livechat and finally did not" which is quite useless info) The goal is to keep only sessions with messages. When the visitor is closing the livechat window, if the session is empty, the session should be deleted. But what happens if a visitor start a livechat session, send no message and just leave the website without closing the livechat window ? --> empty live chat session will remains in database. The ir_autovacuum already handle the deletion of empty sessions to main a clean DB. Specifications ============== - Apply 'with messages' domain on session count in the livechat channel view - Apply 'with messages' domain on session count in the lead view - Apply 'with messages' domain on livechat session view - Remove With message filter - Remove Without message filter - If send message on a deleted session : just tell the visitor that operator is not available anymore AND delete livechat session cookie (as he waited 1 day to send a message) Empty sessions becomes invisible : not possible for users to see empty session (in count or in views) and cron is cleaning empty sessions every day. This commit also adapts visitor session count and view accordingly. Task ID: 2146962 PR #41065 Signed-off-by:
Thibault Delavallee (tde) <tde@openerp.com>
-
- Feb 07, 2020
-
-
Goffin Simon authored
The filter for Purchase orders in the Purchase report did not filter out Sent RFQ, despite the fact that they were not really ordered yet. opw:2158248 closes odoo/odoo#44892 X-original-commit: 201cfb46 Signed-off-by:
Simon Goffin (sig) <sig@openerp.com>
-
- Feb 10, 2020
-
-
Michael Mattiello (mcm) authored
When grouping records in kanban view, if a quick create widget was already opened, clicking on the "+" to launch another quick creation would crash. Fixes https://github.com/odoo/odoo/issues/44680 closes odoo/odoo#44949 X-original-commit: b482df17058e6f2117b616e6b152a7f2c90dc121 Signed-off-by:
Aaron Bohy (aab) <aab@odoo.com>
-
oco-odoo authored
This parameter declared on mailing and project classes is not used anymore. Let us remove it to clean model definitions. closes odoo/odoo#39401 Signed-off-by:
Thibault Delavallee (tde) <tde@openerp.com>
-
- Feb 07, 2020
-
-
fda-odoo authored
The typical command to launch odoo in the install documentation is usable as it is after following the complete instructions. There is two changes done here: - Remove the ../my_modules from the command, as it is a directory not used in the page at all. - Remove the db-filter option not mandatory since the 11.0 version and add a '-d' argument. This will create the db instead of showing the database selector to the reader. closes odoo/odoo#44899 X-original-commit: 6a5d43da Signed-off-by:
Denis Ledoux (dle) <dle@odoo.com>
-
fja-odoo authored
* = website_crm, website_hr_recruitment, website_sale Changing label position on existing field was replacing the label with the default one. Redirection message was not updating the overlay Going from show message to redirect without hidding the mesage made the form d-none When a select field's label's position was changed the select was not editable anymore. Some other miscellaneous fixes task-2191409 closes odoo/odoo#44911 X-original-commit: 3cf87cc1cb179598cecb736728378e330d3b2e22 Signed-off-by:
Quentin Smetz (qsm) <qsm@odoo.com>
-
- Feb 10, 2020
-
-
Nicolas Martinelli authored
Make sure `force_company` context key is set on the SO in all cases. Indeed, when the context key is not properly set, an incorrect fiscal position can be retrieved in: https://github.com/odoo/odoo/blob/cc557f1e4de88466d0d159c5edf1a606a0c0bc6f/addons/account/models/partner.py#L99-L100 This is for example the case when we go through the route `/shop/confirm_order`. opw-2186682 closes odoo/odoo#44451 closes odoo/odoo#44933 Original-signed-off-by:
Toufik Benjaa (tbe) <tbe@odoo.com> X-original-commit: 5691e733e2d860baa012140fc35d3f39ddf747c8 Signed-off-by:
Nicolas Martinelli (nim) <nim@odoo.com>
-
- Feb 07, 2020
-
-
oco-odoo authored
[FIX] l10n_eu_service: wizard: don't copy tags when creating the service tax for the selected EU country This restores the behavior for 12.0; we don't want those amount within the national tax report. closes odoo/odoo#44894 X-original-commit: bd21046f9259f0c755deeba8a1d207da6578e957 Signed-off-by:
oco-odoo <oco-odoo@users.noreply.github.com>
-
Martin Trigaux authored
This route was public by mistake, probably introduced to test during ddf32f4f but no reason to make it public, public user has not the write access on models anyway. Courtesy of Swapnesh Shah closes odoo/odoo#44915 X-original-commit: 66ac96b2 Signed-off-by:
Martin Trigaux (mat) <mat@odoo.com>
-
Nicolas Martinelli authored
- Go to Settings > Technical > Resource > Working Times - Have a Resource Calendar RC with Average hour per day != 8.00 - Have an Employee E with Working Hours == RC - Leaves > Configuration > Leave Types - Have a Leave Type LT with Take Leaves in Hours - Leaves > Managers > All > Allocations - Create an Allocation A with Employee E and Leave Type LT - Enter any number in Duration The number of hours entered changes as we leave the field. Being totally honest, what happens here is not clear at all, but using the corresponding `resource_id.calendar_id` field seems to fix the problem. opw-2191795 closes odoo/odoo#44903 X-original-commit: e239b354 Signed-off-by:
Nicolas Martinelli (nim) <nim@odoo.com>
-
- Feb 08, 2020
-
-
Nicolas Seinlet authored
If some filter domains use M2O to models current user cannot access, using sudo() permit to filter even when user cannot access linked models. for the accuracy of the fix, add a unit test which reproduce the exact reported bug. closes odoo/odoo#44923 X-original-commit: 30e2153539643491fad889811a54a8e580fa9c58 Signed-off-by:
Raphael Collet (rco) <rco@openerp.com>
-
Thibault Francois authored
When you have su == True in your env and you call _name_search the _name_search was switching back to su = False when you call with_user with the same user or with None To reproduce the issue, take a model where a user has no access.control.list allowing to read the model call name_search with sudo. X-original-commit: 8755269f9877e039663adaec8500b530b6d67c68
-
Raphael Collet authored
X-original-commit: ba1d04ac8a23a2f3cfad7f332dab96f7e460eb53
-
- Feb 07, 2020
-
-
jvm-odoo authored
Issue - Install Website - Go on your website - Add text block with image - Change ONLY the image's alt and/or the image's title text - Save dialog - Save page Not saved Cause The element doesn't become dirty after changes in alt dialog. Solution Trigger content_changed to make the element become dirty. OPW-2189909 closes odoo/odoo#44885 X-original-commit: 4f171207 Signed-off-by:
Nicolas Lempereur (nle) <nle@odoo.com>
-
Ernesto Tejeda authored
closes odoo/odoo#44877 X-original-commit: 4c5aea41 Signed-off-by:
oco-odoo <oco-odoo@users.noreply.github.com>
-