We create the document types data with a csv file, but the active field
should be not updatable so the users could active or inactive records.

closes odoo/odoo#78484

Signed-off-by: Josse Colpaert <jco@openerp.com>

Current behaviour:
Unbuilding order use the last BOM created for the product

Expected behaviour:
Unbuilding order should use the BOM that has been used for the MO

Steps to reproduce:
Create a product with a BOM
Create a MO and mark it as done
Create another BOM for the same product
Create unbuild order for the MO
The wrong BOM is selected by default

opw-2636632

closes odoo/odoo#78467

Signed-off-by: Rémy Voet <ryv-odoo@users.noreply.github.com>

closes odoo/odoo#78387

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

There was a missing translation for apply/cancel button in
daterangepicker widget. With this change, we provide the odoo
translation to the library when initializing the picker.

opw-2628117

closes odoo/odoo#78518

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Since changes made in currency rate default value made in this PR
https://github.com/odoo/odoo/pull/76513

 the date is stored based on user
timezone, and so doesn't work if the test runs around midnight with the
belgian timezone on the servers.

closes odoo/odoo#78452

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

This commit fixes issues with downpayment and credit notes in project
profitability report.

Steps to reproduce opw-2596224:
- Go to sale
- Make a RFQ for a service product with service_policy set at
delivered_timesheet (Timesheets on tasks), set quantity as 10
- Confirm order and create two invoices for 15%, confirm the two
invoices
- Create a credit note for one of the invoice and confirm it
- Go back to the Sale Order and click on Project Overview
=> Inconsistencies (Downpayment reported twice)
- Add an expense
=> Inconsistencies in expense amount untaxed invoiced

This issue is fixed by :
- Excluding downpayments which are linked to a reversed invoice line
- Use expense amount to invoice and expense amount invoiced separetely
in the project overview.
- Do not report not invoiced SOLs in the expense amount invoiced.
- Exclude negative amounts in analytic account which are linked to
credit notes.

opw-2596224

closes odoo/odoo#78310

Signed-off-by: LTU-Odoo <IT-Ideas@users.noreply.github.com>

This commit makes the picking search by product more consistent with
the general product search as the following case could happen:

  - Have a product with two variants;
  - Each variant has the following internal reference:
    - Variant 1: 'SoMething'
    - Variant 2: 'SomethingElse'
  - Create two pickings, each one containing one of the variant;
  - Then filter pickings by product and the result will vary:
    - Searching for 'SoMething' -> Found one picking
    - Searching for 'Something' -> Found two pickings

The expected behavior is to find the two pickings in both cases.

opw-2646214

closes odoo/odoo#78085

Signed-off-by: Steve Van Essche <svs-odoo@users.noreply.github.com>

Steps to reproduce:

- Set the Decimal Accuracy at 5 digits for Product UoM
- Create a product X
- Create a kit BOM for X with a component Y, and qty 0.08600
- Create a Sale Order for 10 product X, confirm and deliver all

Issue

- On the SO, quantity delevered is 9.00000 instead of 10.00000, same
  issue occur with the same flow with a Purchase Order.

Cause

As the quantity per kit was rounded when calling _compute_qty,
the calcul of quantity ratio was not well computed.

Solution

Avoid rounding the quantity per kit, as the quantity ratio is rounded
a few steps after.

opw-2590126

closes odoo/odoo#78400

Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

Translation files contained multiple instances of the same reference.
This caused a traceback when loading the translations.

closes odoo/odoo#78398

Fixes: #68552
Signed-off-by: Josse Colpaert <jco@openerp.com>

On sale.order.line, the onchange on product_packaging ensures that a warning
is raised when changing the package if the qty on the line is not a multiple
of the package qty.
With this commit, a same warning is raised when changing the qty if the qty
on the line is not a multiple of the package qty.

closes odoo/odoo#49150

Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

Creating lots of production lot can take a huge amount of time if the
mail message follower is added on each chatter.

This commit removes this functionality to speed up the creation as
there is no real need to have the lot creator as follower of it.

closes odoo/odoo#78370

Signed-off-by: Rémy Voet <ryv-odoo@users.noreply.github.com>

Searching the stock move line candidate to update at reservation can be
shorten by breaking the loop once one is found

Part-of: odoo/odoo#78370

Part-of: odoo/odoo#78370

The recomputation of stock move state is often done with already
the correct state (for instance in the case of move line deletion only
one of the deletion will change the state).

This commit check the move state before changing it only when it's
necessary.

Task: 2507143
Part-of: odoo/odoo#78370
Co-authored-by: Remy Voet <ryv@odoo.com>

Steps to follow

  - Set the thousands_sep of the current lang to an empty string or null
  - Create a report
  -> The thousand separator from the system locale will be used instead to format numbers

Solution

  Use an empty string if there is no thousands separator

opw-2507441

closes odoo/odoo#75868

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

In some cases when creating a new ticket, the default product
type shown is a "Consumable". It should rather be handled as a
"Service". In later versions, a detailed type is created, but the
base product type should be set to service too.

This commit uses the `product_id` `context` to set the default
type to "service".

Task-2655226

closes odoo/odoo#78046

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

closes odoo/odoo#78328

Signed-off-by: Josse Colpaert <jco@openerp.com>

scrap_qty field was missing the digits attribute, and therefore the user
could not create a scrap with a quantity with more than two decimal places.
With this commit, scrap_qty will follow the 'Product Unit of Measure'
precision setting, just like any other quantity fields.

closes odoo/odoo#78220

X-original-commit: 14322fc4
Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

In case an invoice is already paid it is useless to provide
a QR Code for scanning to pay a residual of zero.

closes odoo/odoo#77997

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

The processing of the LINK command in a one2many should fail when the
line being linked does not exist.  However, there is one case where it
should not fail: when that line existed and was linked before applying
the commands.  That use-case may seem strange, but it actually exists:
deleting a line in a sales order automatically deletes the corresponding
reward lines.

closes odoo/odoo#78014

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

When calling `_get_signup_url_for_action` on more than one partner,
because the `url` input parameter was re-used for the actual signup
URL before assigning to the partners map (in
559bdc97), from the second iteration
onwards the signup URL will almost certainly get misgenerated to
redirect to the previous signup URL (accumulating).

As `signup_url` is not normally accessed in bulk this should not
usually be an issue.

Reported by Andreas Brückl

closes odoo/odoo#78196

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

new transaction

Previously, when cancelling an Ingenico transaction, the cancellation
was considered done from the POS' point of view even though it hadn't
actually finished on the terminal yet. Starting a new transaction from
the POS meant it would fail and the POS and terminal's states would get
out of sync.

In an enterprise PR for the pos_iot module, a fix was made so the
cancellation request is only considered done when the terminal has
confirmed that.

In the case of pressing cancel on a payment line, this means that the
button will block and remain in a loading state with a spinner until
the operation finishes. After this the user can press the retry button
the payment line.

There are two other workflows where waiting for the cancel operation to
finish wasn't done until now, and that's what this PR is for.

The first is when a transaction was requested and the
back button was pressed in the UI. This cancels the active transactions.
If you wait a while after pressing the back button, the UI will be
notified when the cancellation finishes, and the payment line's state
will be updated in the local db, even if it's not visible on screen.
When you go back to the payment screen, you'll be able to retry the
transaction again. However, if after pressing the back button you
immediately go back to the payment screen, you'll see the spinner of the
wait for the cancellation, but it would never update. That's because
while the local db gets updated when the cancellation finishes, the
payment screen lines didn't get refreshed. Hence a call was added to
`stop_electronic_payment` that re-renders the payment lines (if we are
present on the payment screen) once the cancellation finishes. In this
way, the payment state in the UI will correctly update.

The second case is when a transaction is requested and the user deletes
the payment line. This used to happen immediately without waiting for
anything. This PR changes that so the line goes to the `waitingCancel`
state instead, and will only be deleted once the operation finishes. If
there's nothing to be cancelled, the line will get deleted immediately
like before.

opw-2525010

closes odoo/odoo#77585

Related: odoo/enterprise#21342
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

Before this commit, selecting elements on a newly added slide of the
carousel was not displaying the editor overlay.
It was due to the fact that adding a new slide to the carousel was done
making a deep clone of the slide, and therefore of its editor.
Now, the slide is cloned without its editor.

task-2657532

closes odoo/odoo#77335

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

How to reproduce the problem:
- Install the website_slides modules
- Go to the website -> Courses -> choose a course -> Add Content (Webpage)
- In the new Webpage -> Edit -> Drag and drop a Form Builder -> Save
The form is unusable: you can't write in the form's fields.

Cause of the problem : usefull attributes and values of the form were
removed due to the sanitizing of the HTML component.

Solution : the HTML components in slide are not sanitized anymore,
in order to keep valuable information for building forms.

opw-2588089

closes odoo/odoo#77128

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

1. Have Bank journal with 'Post At' is set to 'Bank Reconciliation'
2. Create and validate a bill with reference and register a payment.
3. For said payment create a bank statement line.
4. Be sure to have other posted account.move.line's with a similar
reference so they could be considered for this payment (if that's not
the case reconcile will work but only because it will fall back to
checking any move lines for the partner with matching amount regardless
of the reference).
5. Try to reconcile.

The proper move line of the payment will not be selected. This occure
because it's not correctly detected the communication flag of the draft
move, thus not giving the correct priority.

opw-2657393

closes odoo/odoo#78090

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

Bug introduced by this commit: https://github.com/odoo/odoo/pull/76965/commits/509db2371f9122a47af867e3b90841e115c712cf



Steps to reproduce the bug:
- Install purchase and mrp
- Add to “Marc Demo”, user access rights only for purchase app
- As demo, Create a PO and add any product
- Confirm the PO

Problem:
An access error is triggered when searching for a BOM linked to the selected product in the POL

closes odoo/odoo#77754

X-original-commit: c7476f80
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
Signed-off-by: Djamel Touati <DjamelTouati@users.noreply.github.com>

Have two taxes included in price in two different companies
Have a product with both taxes
Have the 2 companies selected
Make a SO and add the product

The price on the SO will add both taxes rather than just 1

opw-2657752

closes odoo/odoo#78032

Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com>

* = website_slides

The option to sanitize or not the forms was not available, this will
allow better flexibility on whether forms should be sanitized or not on
an HTML field.
Also we use this new param to allow forms to be added on an already
existing html field where the form was sanitized out.

This is a backport of 388c222c
adapted to the needs in 13.0

closes odoo/odoo#77266

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

Issue:
When computing the landed cost for a transfer with quantity 0, the validation of the LC wasn't working since there was a quantity 0

Steps to reproduce :
Create a PO for some items
Confirm, validate the delivery
Edit and unlock the delivery, set one quantity to 0, save
Create a landed cost for that transfer
Compute it
Validate -> Traceback

Why is that a bug:
There should not be a traceback, this is caused by trying to validate a landed cost for a product where there is no quantity, if there is no quantity, it should be part of the landed cost computation

Background:
Following the fix recently applied in 14.0 and replicating for 13.0.

opw-2599799

closes odoo/odoo#78041

Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>
Co-authored-by: atremblay-biktrix <69811674+atremblay-biktrix@users.noreply.github.com>

This commit removes `Add a column` from Grouped
Kanban view of Journal Items.

Creating new Records from `Add a column` should not be supported
from Journal Items and also it is not working for Journal/Account
as required fields are not set. (and also gives Traceback)

closes odoo/odoo#77219

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

Right now when editing the opportunity, all the activity types are listed in
the drop-down, even those which are specific to other models.

After this commit  while editing the opportunity, we now display
only activity types which are either specific for 'crm.lead', or those
which are not linked with any models (common for all).

TaskId-2443894

closes odoo/odoo#76567

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Before this commit:
If the "Base: Auto-vacuum internal data" is archived since a long time, auto-vacuuming models may timeout. As the commit was previously done at the end of the cron, the process wouldn't have been applied. As a consequence the Scheduled action will timeout every time

After this commit:
The commit is done right after each model vacuuming

OPW-2638706

closes odoo/odoo#77832

X-original-commit: 1c9e998b
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

Without this commit, if you had:
- 3 Qty for product P in WH1
- 10 Qty for product P in WH2
- no warehouse set on website
- set show stock and prevent sales if not enough stock enabled

And then:
- Add 3 P in your cart
- In cart, add more P, it would let you do it, while it shouldn't

You would then be stuck on payment step as it would tell you only 3 are
available.

This commit improves 6b05fb2b by ensuring the warehouse_id used is the
correct one (the one that will be used on the SO (required field)).
That commit was fixing a case that was not supposed to happen[1], it is that
case that should have been fixed (which is fixed by previous commit of this PR)

[1]: it would fix the 'issue' when you add a product which has no stock
     available for the warehouse that will be used when creating the SO, by
     letting you through the warning, but you would then be stuck on the
     payment step as the qty check would be correctly done.
     The fix should have been to display the correct qty and prevent the add to
     cart in that case.

closes odoo/odoo#77308

Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Co-authored-by: Romain Derie <rde@odoo.com>
Co-authored-by: Adrien Widart <awt@odoo.com>

In multi-warehouses, the available quantities shown on product page is not the
same one used to compute the max quantity that can be bought in the checkout.

Indeed, a sale order has a required `warehouse_id` field, and the quantity that
can be bought is computed based on that warehouse.
But if the website has no warehouse set to it (in settings), the shown quantity
on product page will be computed based on all available warehouses.

It will then show an error on payment step, if the user has selected more
quantities than there is available on the warehouse used for his order.

Considering the structure of `sale.order`, displaying the quantities in
several warehouses does not make sense.

To reproduce the issue:
1. In Settings:
    - Enable 'Multi-Warehouses'
    - Make sure the option Website > Inventory > Warehouse in undefined
2. Create a second warehouse WH02
3. Update the quantity of "Storage Box":
    - 18 in first WH (should already be present)
    - 12 in WH02
4. Edit "Storage Box":
    - eCommerce > Availability: "Show inventory on website and prevent
sales if not enough stock"
5. On the eShop, go on "Storage Box"
    - Note that there are 30 units available
6. Add 22 "Storage Box" to the cart
7. Process checkout

Error: When trying to pay, a Server Error is raised: "We are not able to
redirect you to the payment form. You ask for 22.0 products but only
18.0 is available." This is confusing since the available quantity on
the product page is 30

opw-2630804

Part-of: odoo/odoo#77308
Co-authored-by: Adrien Widart <awt@odoo.com>
Co-authored-by: Romain Derie <rde@odoo.com>

[I18N] l10n_cl: relax the condition for registering entries in purchase journal, in order to allow to record expenses without warnings.

closes odoo/odoo#77651

Signed-off-by: Josse Colpaert <jco@openerp.com>

51955505 mitigated an issue of being
able to try and download files which don't exist yet, make the fix
more reliable by clearing out the field completely and hiding the
content if the (readonly) field has no value *or the record is not
saved yet*.

Also clean up the code:

* an old-style forward port created a duplicate fixprovement
  (a8d01cbf) which seems less correct
  as it applies conditionally
* and the code is branchier than necessary, we can make it simpler by
  judiciously leveraging jquery's API

closes odoo/odoo#77746

X-original-commit: 05db9be15d75dc0794095aad75c80d0c2e540808
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

With bank synchronization, having information about changes done by
the user on the bank statements can be useful when looking into issues.

We'll now log changes in the starting/ending balance as well as the
state of the statement to keep better track of what is happening on
the statements.

Task id #2647224

closes odoo/odoo#77297

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

Purpose is to assert current behavior as this may change in master. Two
kind of tests are added: performance and multi company.

This is done in stable to better see evolution of those counters in various
stables.

Task-2661036
Prepares Task-36879 (MultiCompany Aliases)

closes odoo/odoo#77709

Related: odoo/enterprise#21395
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>