closes odoo/odoo#29730

Since a recent ControlPanel/Search view refactoring [1],
all client actions must be adapted [2]. Discuss was updated,
but not discuss mobile, which this commit fixes.

[1] https://github.com/odoo/odoo/commit/4cd379cf6ecffa00e0085a9833228128b484d48a
[2] https://github.com/odoo/odoo/commit/b1ef0001f61d29fc3d3be384422c0fb35a09806f

Task-ID 1918722

closes odoo/odoo#29601

This commit adds the ability to upload and delete
attachments from the chatter.

Task: #1911277

closes odoo/odoo#29702

The 'Actions' menu displayed in the control panel (aka sidebar, or
toolbar), wasn't displayed anymore since the control panel
refactoring of 4cd379cf. Rev. c1752b83 correctly made it appear
again in list and form views. However, there was another issue as
the additional model-related items (like Print, or custom actions)
weren't fetched anymore. Thus, the sidebar only contained the
default 'Export' and 'Delete' actions. This rev. fixes the second
issue.

fixes #29546

closes odoo/odoo#29633

Before this commit, emojis from the emoji menu in the
composer were small. This is especially true in mobile.

The cause of this issue was the style of bootstrap button
links. This commit fixes the issue by no longer considering
each emojis as button for their style, so that they do not
inherit bootstrap styles.

Task-ID 1918767

closes odoo/odoo#29606

Before this rev. a crash occurred when pressing backspace in the control panel
view searchbar input if there was no facet to remove.

The use case is now correctly handled and nothing happens.

Task 1902826

closes odoo/odoo#29602

The rev. odoo/odoo@3aa6c94 has recently been forward-ported but was in conflict
with the rev odoo/odoo@856c2e9 ; both have created a inherited view to add their
test file in the qunit_suite view.

As both inherited views have the same id, one of the two files was not correctly
loaded in the test suite.

closes odoo/odoo#29586

The `context` key wasn't correctly taken into account when computing the search
query for `filter``tags.

It is now correctly handled.

Task 1917628

closes odoo/odoo#29529

Before the forum redesign, the .container element which contains the
forum navbar had the 'website_forum' class. Now this class was moved
to encapsulate the whole forum page.

Problem is that themes were styling that container element specifically
and the `#wrap` element of the forum by respectively targeting
`.website_forum` and `.website_forum + #wrap`. This commit solves this
by adding a 'o_wforum_navbar_container' class on the element allowing
to modify the themes selector with `.o_wforum_navbar_container` and
`.website_forum #wrap`.

closes odoo/odoo#29581

This commit fixes the following issues regarding the mail tour:

1. Start from discuss app (not app switcher)
2. Adapt from recent changes on discuss app https://github.com/odoo/odoo/commit/9f6f9c71d3258ce3652b4a5793b7dcfef6f01d25

Note there is an error if we let runbot run this tour automatically:

```
Tour mail_tour failed at step Messages can be <b>starred</b> to remind you to check back later.
(trigger: .o_mail_discuss .o_mail_thread .o_thread_message_star)
```

This comes from the mail tour requiring longpolling to work, which is
intentionally disabled when running tours automatically on runbot.
We plan making this tour run without longpolling in the future, which
requires a design change from the client code (e.g. reduce reliance
on the longpolling).

Task-ID 1916093

closes odoo/odoo#29575

Before, the name of the channel was not always matching the real channel operator,
as a second random was made on operators.

This commit fix this.

Task ID : 1918350
Closes PR #29570

Following commit 983c7e81.

`_compute_display_name` is overridden in partner to force `show_adress` and some
other context variables to None. When those values are in the context, calling
`display_name` can give a different result than calling `name_get()[0][1]`.

This commit reverts the changes of the mentioned commit where the behavior is
actually different, that is, when `show_address` is in the context.

It also adds a comment on the `_compute_display_name` method to avoid further
mistakes.

closes odoo/odoo#29510

Due to the recent refactoring in control panel 40dd1219,
some css rules have been broken in mobile.

To fix this, we need to set 'o_current' class inside the
displayed column because we need to know which one to
display in mobile.

This issue doesn't occur in desktop because all kanban columns
are displayed.

closes odoo/odoo#29457

Before this commit, we don't assure fetch's deferreds were resolved to
return _readGroup. Thus, in some conditions, kanban was rendered before
records data was updated so many2many tags could be missing.
Now, we return _readGroup when fetch's deferreds were resolved.

Task #1910805

closes odoo/odoo#29508

closes odoo/odoo#29500

Theses records used to have a domain/context set [1]. Force a empty one
for updated databases.

[1] see 1da63f0a

closes odoo/odoo#29487

In task 1893160, we wanted to shorten the 'planned_revenue' and
'probability' fields on the crm.lead formview.

For simplicity's sake, we are reverting this change.

closes odoo/odoo#29476

With multi-website support, the key field is more important than ever as it
kind of replace the xml_id behavior.

Thus, on the ir.ui.view list view it is usefull to see the key.

closes odoo/odoo#29419

The fields `analytic_tag_ids` and `second_analytic_tag_ids` on model
'account.reconcile.model' were accidentally using the same table and columns,
because of the automatic generation of the table name.  Make them explicitly
use distinct table names.

closes odoo/odoo#29376

closes odoo/odoo#29438

* portal

In our default theme, when hovering links (or .btn-link elements), the
text is underlined. This effect is however not desired for links which
contain only an icon, especially in the forum.
This commit removes that underline effect for all icon buttons in the
frontend (at least by default, this is a theme choice). Icon buttons are
defined as link or .btn-link elements which directly use the "fa" class
on them.

This commit also solves the flag button of the forum which did not have
any effect because of bad bootstrap use.

closes odoo/odoo#29434

In some cases, the web client may receive a search view with invisible
filters.  This is due to the way field_view_get works.  For
example, if there is a group on a filter, then this will be transformed
into an invisible attribute.

In that case, the search view should simply ignore the filter and not
display it.  This was broken in the recent control panel refactoring
(note that the search view lacked the possibility of testing that kind
of situation).

closes odoo/odoo#29430

When sending a message through the chatter, the user context (including
the language) is not sent to the server. This causes issues to render
the mail templates in the appropriate language.

closes odoo/odoo#29422

Some product template with attributes never have variants because
the attributes have the field 'create_variant' set to 'no_variant'
So "Tuple index out of range" was raised due to these kind of products.

opw:1911962

closes odoo/odoo#29428

With the recent control panel refactoring, abstract actions had to be
adapted.  The base import action is actually quite
complicated, it relies on introspection and is fragile.  With this
commit, I attempt to make it work again.  The main issue is that now,
the root of the abstractaction is a div, which contains the root of the
content template, so most of the code was assuming that the $el of the
import action was the form tag, and not a parent.

Note that there are no meaningful tests for import actions, because
testing iframes are tricky.

closes odoo/odoo#29421

The recent refactoring of the control panel moved the sidebar management
from the action manager to the view itself.  However, the sidebar
parameter was forgotten, which resulted in the fact that it was no
longer created.

This fix was a little tricky, because the sidebar needs to be
instantiated in some tests, but not in most of them (in particular, the
document application changes its behaviour, which is annoying).

closes odoo/odoo#29389

Commit 5804246e introduced some improvements to speed up performances.
One of them was to check if a customize_show view was active or not but the
condition was on view.customize_show instead of view.active.

Thus, as that view is always a customize_show, the condition would always be
met.

closes odoo/odoo#29414

There was a traceback when reloading the webclient with an act_window and an
empty id in the URL (ex: after saving Settings). A `read` without id was
peformed when loading data instead of a `default_get`.

Before rev. odoo/odoo@40dd121 the action environment was generated by the
ActionManagerActWindow, which was currently defaulting the `currentId`.

Now that this is not the case anymore, the `loadState` should have this responsability.

Task 1902826

closes odoo/odoo#29411

Task 1889687 adds the activity view to Studio>Views, the view is represented by
icon fa-clock-o. Task 1894990 was supposed, among other things, to change the
current activity view icon (fa-th) to fa-clock-o. Since this task was not merged
it creates an inconsistency between the 'view switcher' and Studio.

Task 1902826

closes odoo/odoo#29392

Usecase to reproduce:
- Set manufacture step to 2 or 3 steps
- Create a MO
- Go on the PC picking and validate some quantities w/h BO

Traceback because there is no documents to log the activity.

It happens because the function used in groupby and sorted
(in the method _log_less_quantities_than_expected) expect a picking.
The purpose of _log_less_quantities_than_expected is to generate
an activity on the next picking in order to notify that some quantities
will be missing due to the cancelation of the back order. In order
to find the following picking it uses the destination moves from the
current's picking moves.

	Picking w/h BO		Next Picking (activity to post)
		|			|
	      moves -----------> destination moves

However in the case of 'pick components' picking type(PC) the destination
moves are linked to a manufacturing order and not a picking. So it
_log_activity_get_documents return an empty parent since picking_id is
False.

In order to fix it, _log_activity_get_documents only add the tuple
(object where the activity should be log, responsible for the activity)
if the object is not False. It also add a hook in order to add
(mo_id, repsonsible) during _log_less_quantities_than_expected on top
of (picking_id, repsonsible) in order to log activity on MO directly
linked to PC.

This commit also add a missing precision_rounding in backorder
confirmation

opw-1908753

closes odoo/odoo#29385

closes odoo/odoo#29413