Skip to content
Snippets Groups Projects
  1. Feb 18, 2019
  2. Feb 12, 2019
  3. Feb 18, 2019
  4. Feb 15, 2019
    • David Monjoie's avatar
      [FIX] hr_payroll: use calendar as default view · e154d2c1
      David Monjoie authored
      The webclient doesn't handle a non-existing view as the default
      view. However, it must handle it correctly if it is not the
      default one since it does it for mrp.production already.
      
      closes odoo/odoo#31161
      e154d2c1
    • Robot Odoo's avatar
      [MERGE][IMP] website_slides: improve inclusion of gamification and ranks · f34a7edd
      Robot Odoo authored
      Purpose of this merge is to improve inclusion of gamification and ranking
      in elearning new main pages [1][2]. Ranking and profile information, links
      and templates are added.
      
      Some fixes are included in this merge, notably statistics computation, better
      slide image fetch and demo data. See sub commits for more details.
      
      Commit linked to task ID 1941250.
      
      closes odoo/odoo#31133
      Unverified
      f34a7edd
    • Thibault Delavallée's avatar
      [FIX] website_slides: fix text / html mismatch in demo data · 5822e309
      Thibault Delavallée authored
      Slide description is actually a text field, no need to put html tags that
      are displayed raw.
      
      Commit linked to task ID 1941250 and PR #31133.
      5822e309
    • Thibault Delavallée's avatar
      [IMP] website_profile, website_slides: add user ranking and karma on elearning main pages · bd2dae4f
      Thibault Delavallée authored
      Purpose of this commit is to improve karma and gamification inclusion in
      elearning [1].
      
       * remove a border, replaced by a standard hr, in rank template. It allows to
         reuse it easier as we don't necessarily want that border in other templates
         using it;
      
      Commit linked to task ID 1941250 and PR #31133.
      
      [1] task ID 1922159 (landed at 5fa651cb)
      bd2dae4f
    • Thibault Delavallée's avatar
      [FIX] website_profile, website_slides: clean user avatar controller and add one for slides · 1bb7b242
      Thibault Delavallée authored
      Purpose of this commit is to
      
       * clean user avatar controller and its calls;
       * extract default image computation;
       * add a controller to get slide image even when not having access to the slide
         as all slide name and images are displayed even if not available to the
         current user;
      
      Commit linked to task ID 1941250 and PR #31133.
      1bb7b242
    • Thibault Delavallée's avatar
      [REF] gamification: clean next rank motivational implementation · e7b35358
      Thibault Delavallée authored
      Purpose of this commit is to clean motivational capabilities of gamification
      ranks[1]. It makes more sense to store a motivational to achieve on next rank
      itself. We therefore rename the field and provide nice demo data that will be
      used in elearning use of gamification ranks.
      
      Commit linked to task ID 1941250 and PR #31133.
      
      [1] task ID 1922159 (landed at 91ee6ba5)
      e7b35358
    • Thibault Delavallée's avatar
      [FIX] website_slides: fix some statistics and publication issues · 6a9f6876
      Thibault Delavallée authored
      This commit fixes various issues introduced by recent commits in slides
      
       * fix slide type computation: using a dict in a fromkeys makes a shared
         object for all keys. It is better to fix that behavior;
       * correctly display number of course steps in elearning homepage. Currently
         number of steps of a course is simply the length of its one2many;
         holding slides. However this one depends on access rights which give funny
         results like a course with 2 steps for public users and 7 for admin;
         Right computation is: number of published lessons, whatever your access
         rights are. This is already computed as total_slides;
       * people that cannot publish should not be able to unpublish;
      
      Commit linked to task ID 1941250 and PR #31133.
      6a9f6876
    • Robot Odoo's avatar
      [MERGE][ADD] website_slides_survey: add a new bridge between slide and survey · b2149bc7
      Robot Odoo authored
      Task #1940360
      Subtask of #1902304
      
      Purpose
      =======
      
      Adds certification capabilities to the website_slides module.
      Channel/courses can now include certifications as a new type of slide.
      
      This new type of slide is available as a "Certification" button on the slide creation
      frontend view (next to "Video", "Presentation", ...).
      Users have to link the slide to an actual survey that has the 'certificate' field
      set to true (that will populate the slide's survey_id field).
      
      Slides of type certification are handled in frontend in a very simple way for now:
      - A button "Begin certification" that redirects the user to the related survey frontend.
      - A button "Download certification" when the user has succeeded the certification.
        (A new download route has been added in the survey module to make it work.)
      - When the survey is done, if it's linked to a slide, a button "Go back to course" allows
        the user to go back to the slide frontend.
      
      (There is a special use case for when the website_publisher designing the survey lands on a
      certification slide: he is allowed to test the survey with a survey_input created as test_entry)
      
      Survey creation as well as limited time, limited number of attempts, ... are still completely
      handled in the survey module. That means that the user will have to first create a suitable survey
      that is a certification and only then create a slide of type "certification" and link
      the created survey to it.
      
      Ideally, the taking of the survey should be transparently included in the slide frontend but
      it requires a full refactoring of the way surveys are submitted. This will most likely come in
      a later commit.
      
      This commit is an advanced merge of full eLearning module (see task #1902304).
      
      closes odoo/odoo#31060
      Unverified
      b2149bc7
    • Aurélien Warnon's avatar
      [FIX] website_slides: fix channel statistics computation · 171c7028
      Aurélien Warnon authored
      Purpose
      =======
      
      Channel statistics computation in the _compute_slides_statistics method
      did not work for a batch of channels.
      
      (The stats dict was shared for all the channels).
      171c7028
    • Aurélien Warnon's avatar
      [ADD] website_slides_survey: add a new bridge between slide and survey · f322816a
      Aurélien Warnon authored
      Task #1940360
      Subtask of #1902304
      
      Purpose
      =======
      
      Adds certification capabilities to the website_slides module.
      Channel/courses can now include certifications as a new type of slide.
      
      This new type of slide is available as a "Certification" button on the slide creation
      frontend view (next to "Video", "Presentation", ...).
      Users have to link the slide to an actual survey that has the 'certificate' field
      set to true (that will populate the slide's survey_id field).
      
      Slides of type certification are handled in frontend in a very simple way for now:
      - A button "Begin certification" that redirects the user to the related survey frontend.
      - A button "Download certification" when the user has succeeded the certification.
      - When the survey is done, if it's linked to a slide, a button "Go back to course" allows
        the user to go back to the slide frontend.
      
      (There is a special use case for when the website_publisher designing the survey lands on a
      certification slide: he is allowed to test the survey with a survey_input created as test_entry)
      
      Survey creation as well as limited time, limited number of attempts, ... are still completely
      handled in the survey module. That means that the user will have to first create a suitable survey
      that is a certification and only then create a slide of type "certification" and link
      the created survey to it.
      
      Ideally, the taking of the survey should be transparently included in the slide frontend but
      it requires a full refactoring of the way surveys are submitted. This will most likely come in
      a later commit.
      
      This commit is an advanced merge of full eLearning module (see task #1902304).
      f322816a
    • Aurélien Warnon's avatar
      [IMP] website_slides: support slide_type param in slides/all route · dcce7716
      Aurélien Warnon authored
      Task #1940360
      Subtask of #1902304
      
      Purpose
      =======
      
      The slide/all route now supports a 'slide_type' param that will filter channels
      to contain at least one slide of type 'slide_type'.
      
      This is a preliminary work for the slides_survey bridge.
      dcce7716
    • Aurélien Warnon's avatar
      [IMP] survey: add a route to download a certification pdf · b5c90c78
      Aurélien Warnon authored
      Task #1940360
      Subtask of #1902304
      
      Purpose
      =======
      
      This commit adds a route allowing to download a certification for
      a user that has succeeded it.
      
      It's currently not used in any views but it's a preliminary work
      for the future slide bridge.
      b5c90c78
    • Aurélien Warnon's avatar
      [FIX] website_slides: fix publisher slides frontend access · 949f6412
      Aurélien Warnon authored
      Purpose
      =======
      
      Website publisher should be allowed to access slides on the frontend even if
      he's not a member of the channel.
      949f6412
    • Aurélien Warnon's avatar
      [IMP] website_slides: add visibility criteria to some slide fields · 1cb7290c
      Aurélien Warnon authored
      Task #1940360
      Subtask of #1902304
      
      Purpose
      =======
      
      Some fields displayed on the slide.slide form view are not relevant
      for all slide_types and should be hidden.
      1cb7290c
    • Jérome Maes's avatar
      [FIX] rating: value range of star notation · 98052fb5
      Jérome Maes authored
      When rating with the smiley mecanism, the rating value will be 1,
      3 or 7. The rating model allow value in range [0, 10]. When using
      the star mecanism, usually, only 5 stars are used to introduced a
      rating. This will set a rating value in the range [0, 5], which
      is not aligned with the range of the model, nor the smiley range.
      
      Purpose of this commit is to uniformize the range of rating, so if a
      model is using both mecanism, the average will be correct. Solving
      this problem implies to apply a conversion factor between the
      database value and the displayed one.
      
      Migration:
      As only product.template was using star mecanism in odoo community,
      a migration step should be applied to multiply of ratings of
      product.template by 2.
      
      Task-1941432
      
      closes odoo/odoo#31141
      98052fb5
    • Jérome Maes's avatar
      [FIX] portal: posting message without token · 3d607880
      Jérome Maes authored
      This commit e8477974 factorize the check of
      special access to post a message using a token mecanism, but it breaks the
      case without token. Indeed, on some models, it is allow to post a message
      on a document when having a certain access. This is handle with the
      `_mail_post_access` attribute on model inheriting mail.thread.
      Using this mecanism, a user that can read (or write) the document can also
      post a message. This is used in the eShop to review product and in blog to
      comment blogpost.
      
      This commit restore posting a message without token. the normal access rights
      will be applied by message post and raise if the user can not post message,
      taking `_mail_post_access` into account.
      The balance is now restored in the universe.
      
      Task-1902304
      3d607880
    • Geoffroy Larue's avatar
      [REM] project, hr_timesheet: remove date_start · 400f7697
      Geoffroy Larue authored
      Remove date_start in project.task model, because it is not
      useful. Now using date_assign instead for reporting.
      
      Add two ids in settings views to refer from enterprise modules.
      
      closes odoo/odoo#31101
      400f7697
    • Aaron Bohy's avatar
      [FIX] web_tour: consume step on click · 872c11dd
      Aaron Bohy authored
      Before this rev., steps were consumed on 'mousedown' events. This
      caused an issue with the RainbowMan displayed at the end of tours
      (which closes itself on 'click' events outside its $el).
      
      Here is what occured when the user clicked on the last step's
      element:
       - 'mouseenter' event triggered
       - current step consumed, as well as the tour, and a RainbowMan
         is instantiated and appended to the DOM
       - 'click' event triggered
       - RainbowMan closes itself because of that 'click' event
      
      closes odoo/odoo#31148
      872c11dd
    • qsm-odoo's avatar
      [REF] website: remove useless code · 8f4c595f
      qsm-odoo authored
      Part of https://github.com/odoo/odoo/commit/f4ba72a7593b67595852fc52ec0997d3276dbc67
      became useless after forward-port in the new editor. Indeed, that
      commit handled what happened with data-editor-message attributes on
      save but as the new editor can discard changes without reloading the
      page, the forward-port of that commit made the code handle the attribute
      removal on editor *close*.
      
      closes odoo/odoo#31143
      8f4c595f
    • qsm-odoo's avatar
      [REF] web_editor, website: remove useless code · bd2624a7
      qsm-odoo authored
      Commit https://github.com/odoo/odoo/commit/29075a8e2c734624cec4f6009185616634f70dea
      introduced some python methods which became useless with commit
      https://github.com/odoo/odoo/commit/aef6a5aaed22b250799ce92b5021d240fed9e12e
      
      They were not removed with that commit since it was a stable version and
      because it would have made forward-port difficult because of master
      tasks. Now that those tasks are merged, this commit removes the useless
      methods.
      bd2624a7
    • Lucas Lefèvre's avatar
      [FIX] hr_payroll: Use jquery API to build benefit buttons · ff9be593
      Lucas Lefèvre authored
      Use the proper jquery API instead of handcrafting dom elements.
      + fix traduction
      
      closes odoo/odoo#31137
      ff9be593
    • Pierre Masereel's avatar
      [FIX] crm_iap_lead_website: change name · 49597e3f
      Pierre Masereel authored
      The module has the same name as the module crm_iap_lead.
      
      closes odoo/odoo#31134
      49597e3f
    • Robot Odoo's avatar
      [MERGE][IMP] website_slides: introduce a new home page for slides · 6c6179e5
      Robot Odoo authored
      This merge proposes a new homepage for slides module evolving towards
      an eLearning platform. This merge closes task 1936153 and PR #30770.
      More generally this merge is linked to currently under heavy work slides
      module update to eLearning [1][2].
      
      It includes
      
       * a new main page displaying top courses / channels. It displays 3 most
         popular and newest channels as well as its ongoing courses (if logged).
         Achievements and karma update done by eLearning community allow to
         give a gamification look and feel;
       * an 'All' page displaying all courses / channels. Tag groups and tags
         allow to search / filter displayed courses;
       * a new pimped and revamped display for main course / channel page;
       * new demo data for slides and small addition of demo data in bridge module
         with website_sale and website_forum;
      
      Some features may not be completely working as other tasks will continue to
      improve the display, notably new slide display [1], some forum / slide
      link improvements [3] and certification integration [4]. Some code cleaning
      will come in future update as this merge allows to unblock those other tasks.
      
      For more details see sub commits. And thanks to the RD Fun SM Team. Much
      fun, much SM.
      
      [1] main eLearning task: task ID 1902304 - PR #29876
      [2] new user profile /gamification: task ID 1922159 - PR #30514
      [3] forum and comments upgrade: task ID 1940516 - PR #30514 and #31097
      [4] certification inside eLearning: task ID 1940360 - PR #31060
      Unverified
      6c6179e5
    • Thibault Delavallée's avatar
      [IMP] website_slides_forum: add forum navigation tab in course display and add demo data · e900e9b0
      Thibault Delavallée authored
      Purpose of this commit is to add the forum tab in course main new page
      when the course is linked to a forum. Some demo data are added.
      Some more work to better include forums and courses are ongoing [1].
      
      This commit is linked to task ID 1936153 and PR #30770.
      
      [1] forum and comments upgrade: task ID 1940516 - PR #30514 and #31097
      e900e9b0
    • Thibault Delavallée's avatar
      [REF] website_sale_slides: improve demo data · 2efb7e09
      Thibault Delavallée authored
      Pimp my demo data. Purpose is to have some additional informations on demo
      data defined in bridge module sale / slides. This one notably defines
      a payment-based channel.
      
      This commit is linked to task ID 1936153 and PR #30770.
      2efb7e09
    • Thibault Delavallée's avatar
      [IMP] website_sale_slides: support payment channels in new channel homepage · ded92c62
      Thibault Delavallée authored
      
      Purpose of this commit is to effectively support payment channels in the
      new channel homepage. Specifications
      
       * display a 'Buy Course' button on payment based channels;
       * redirect to eCommerce;
       * display price;
      
      We used everything available from eCommerce and product configurator to
      find a real price to display. I must say I am quite happy with it.
      
      This commit is linked to task ID 1936153 and PR #30770.
      
      Co-Authored-By: default avatarAurélien Warnon <awa@odoo.com>
      Co-Authored-By: default avatarThibault Delavallee <tde@odoo.com>
      ded92c62
    • Thibault Delavallée's avatar
      [REF] website_slides: propose new shiny (incomplete) demo data · 8f295a64
      Thibault Delavallée authored
      
      Purpose of this commit is to rewrite slides demo data. More channels, more
      slides, more images, less Odoo oriented content.
      
      Everything is still not completely clean but at least it begins to look like
      something we could show to people. Thanks to @awa-odoo who gave some demo
      data. No thanks to @xmo-odoo who did not give demo data about the emu war.
      
      This commit is linked to task ID 1936153 and PR #30770.
      
      Co-Authored-By: default avatarAurélien Warnon <awa@odoo.com>
      Co-Authored-By: default avatarThibault Delavallee <tde@odoo.com>
      8f295a64
    • Thibault Delavallée's avatar
      [IMP] website_slides: new homepage and main channel page · 2cfacfc6
      Thibault Delavallée authored
      
      This commit proposes a new homepage for slides module evolving towards
      an eLearning platform. It includes
      
      * a new main page displaying top courses / channels. It displays 3 most
        popular and newest channels as well as its ongoing courses (if logged).
        Achievements and karma update done by eLearning community allow to give
        a gamification look and feel;
      * an 'All' page displaying all courses / channels. Tag groups and tags
        allow to search / filter displayed courses;
      * a new pimped and revamped display for main course / channel page;
      
      For more details about specifications, send an email to aware people that
      will be able to send you mockups. Or see the related task. Thanks to
      @qmo-odoo who helped developing this homepage based on its work.
      
      This commit is linked to task ID 1936153 and PR #30770.
      
      Co-Authored-By: default avatarqmo-odoo <qmo@odoo.com>
      Co-Authored-By: default avatarThibault Delavallee <tde@odoo.com>
      2cfacfc6
    • Thibault Delavallée's avatar
      [REF] website_slides: perform some model code cleaning · c437832e
      Thibault Delavallée authored
      
      This commit squashes several fixes / light improvements related to the new
      slides / elearning homepage [1][2].
      
      Containing notably
      
       * clean promote strategy field on channel model: less entries as they
         are now used only to display lessons in a given order on channels of
         documentation type;
       * remove promotional fields, not used anymore since partial access on channel
         allowing to have some kind of small preview of slides has been removed;
       * use standard image field (image, image_medium and image_small) and use
         image_resize_image from tools like all other odoo applications;
       * improve image resizing to have medium images better looking on frontend
         and use that nice image_large that broke my build yesterday;
       * add last publication date change on channel;
       * clean dead code;
      
      [1] new homepage task: ID 1936153 and PR #30770
      [1] main elearning task: ID 1902304 and PR #29876
      
      Co-Authored-By: default avatarAurélien Warnon <awa@odoo.com>
      Co-Authored-By: default avatarThibault Delavallée <tde@odoo.com>
      c437832e
    • Thibault Delavallée's avatar
      [IMP] gamification, website_slides: add challenges in slides and improve ranks · c971b622
      Thibault Delavallée authored
      
      Purpose of this commit is to add challenges related to slide / elearning
      module. 5 new challenges with their badges are added. Portal user partner
      is now also published to have bioutifoul demo data. Commit linked to
      eLearning tasks [1][2]
      
      Co-Authored-By: default avatarDavid Beguin <dbe@odoo.com>
      Co-Authored-By: default avatarThibault Delavallee <tde@odoo.com>
      
      [1] new homepage task: ID 1936153 and PR #30770
      [2] new user profile / gamification task: ID 1922159 and PR #30514 and #30988
      c971b622
    • Thibault Delavallée's avatar
      [IMP] website_profile: add a specific route to access avatar of users · 00bf73cd
      Thibault Delavallée authored
      Purpose of this commit is to give a specific route to access users image
      used as avatar in profile and various frontend applications.
      
      Indeed current web/image controller basically checks record access rights
      with current user. However in some cases we want to display user avatars
      even if current user cannot read user records, which is generally the case.
      Indeed res.users is a private and technical model.
      
      To solve that issue we add a controller for avatar. Basically published
      and frontend active user avatars are available.
      
      This commit is linked to task ID 1936153 and PR #30770.
      00bf73cd
    • Thibault Delavallée's avatar
      [IMP] website_rating: improve popup / composer rating display · cab98785
      Thibault Delavallée authored
      This newly introduced widget for rating [1] is very cool. This commit
      simple improves a bit the display and have the stars + review button
      displayed as a small one liner to take less place when displayed.
      
      This commit is linked to task ID 1936153 and PR #30770.
      
      [1] See https://github.com/odoo/odoo/commit/4cb228d823e0346e6052091d397249b8e39d576b
      cab98785
  5. Feb 14, 2019
    • Jérome Maes's avatar
      [FIX] website_rating: default value is not 'false' in composer · d233ac23
      Jérome Maes authored
      When website_rating is installed, all frontend chatter will have
      the string 'false' by default in the composer. This commit fixes
      that, restoring the placeholder
      
      closes odoo/odoo#31097
      d233ac23
    • Jérome Maes's avatar
      [IMP] website_slides: allow comments on slides · 8ad65abd
      Jérome Maes authored
      With this commit, the user can activate review on channel content when
      creating a channel from frontend, or editing it from backend. Once
      activated, the comment tab below the slide content will allow user
      to post a comment with optional rating.
      The way of commenting is different regarding channel type:
      - documentation: user can post comment and vote (list/dislike) on
      slide content
      - training: user can post comment with review (rating)
      
      Task-1902304
      8ad65abd
Loading