On a list view, Add a custom filter on a date
Change the operator to "in between"
Change it back to "equal"
Apply the search

Before this commit, the label of the filter still was in between
Whereas it should have been "equal to ..."

After this commit, the label of the filter is correct

OPW 2085951

closes odoo/odoo#38705

closes odoo/odoo#38869

closes odoo/odoo#38898

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>

In a list view, create a custom filter involving a date or datetime field

Before this commit, the domain that was sent to the server
contained the date or datetime as the pure string
representation that Moment.js constructs
that is a ISO compliant one, containing info on timezone

After this commit, the format is the one of the server, in UTC
and NOT ISO compliant. Also, the format for date is dealt with

OPW 2085936

In 12.0, the function onchange_default defined in odoo/models.py
was triggered on model 'account.invoice' for the fields type, company_id,
partner_id

In 13.0, as the model 'account.invoice' has been removed by 'account.move',
the same logic must be applied on this model.

opw:2086812

closes odoo/odoo#38849

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Steps to reproduce the bug:

- Create a portal user U
- Try to update the details of U from portal

Bug:

A server error was raised because the country_id was set as a character.

opw:2082450

closes odoo/odoo#38795

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Steps to reproduce the bug:
- Create a RFQ
- Add a line with a product
- Add a line with a note and save
- Duplicate the RFQ

Bug:

A traceback was raised because the function _select_seller was called on a line
with no product.

opw:2085977

closes odoo/odoo#38784

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

closes odoo/odoo#38912

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

The issue here is, for modal dialogs (eg newsletter popup), when we close
the dialog, the modal is destroyed and so after the delayed execution due to
timeout, the dialog will not be available and it will generate the issue.

removed delayed execution for the traceback, which is relevant to
the modal dialogs.

task-2075232

closes odoo/odoo#38506

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

The issue here is, the modal for the newsletter is part of the editable area,
and when we click on the 'close' button of that modal, it is destroyed but the
'summer note' tries to bind the events related to the button(because close is a button).

fixed the traceback, to disable invoking 'summer note' events on click of
the 'close' button on modal

task-2075232

set current assets or current liabilities type insted of Podatki

Fixes #38004

closes odoo/odoo#38875

Signed-off-by: Josse Colpaert <jco@openerp.com>

Usecase to repdroduce:
- Create a manufactured product with route manufacture and a RR
- Run the scheduler.

Orderpoint will prepare procurement values's date as string. Other
module could possibly also use string as date and a call to from_string
will not break anything if the value is already a date or a datetime.

closes odoo/odoo#38895

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

closes odoo/odoo#38272

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

[FIX] web: Correctly aggregate values in exported parent groups
--------------------
When exporting a grouped list view with some nested groups, the aggregate value
of parent groups are not correct. It always sums aggregated values of children
whether the group operator is 'sum' or not (could be 'max', 'avg', ...).

This behavior is wrong and can even lead to a crash if the aggregated field is a
date field (e.g. with group_operator='max'). (Try two sum two dates...)

To avoid the crash a quick fix was merged 85cf47fc just before OXP. This fix
limited the support of aggregates to only int and float fields.
This commit remove this limitation.

This commit correctly implements the aggregation for parent group for all
field types and all group_operator.

This commit also improves the export feature tests.

[FIX] base export: Manage False in groupby title
--------------------
Before this commit, when we export a list with a groupby on
boolean, the groupby title 'False' is replaced by 'Undefined'
in xls document.

After this commit, with an export and groupby on a boolean, we
will have correct title: True and False.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#38373

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

The attribute `self._fields` is not well named. This is not a list of instances
of the Field class.
It is a list of field names to export.
e.g. 'journal_id', 'account_id/name'

When exporting a grouped list view with some nested groups, the aggregate value
of parent groups are not correct. It always sums aggregated values of children
whether the group operator is 'sum' or not (could be 'max', 'avg', ...).

This behavior is wrong and can even lead to a crash if the aggregated field is a
date field (e.g. with group_operator='max'). (Try two sum two dates...)

The quick fix 85cf47fc was merged just before OXP to avoid any crash. This fix
limited the support of aggregates to only int and float fields.
This commit remove this limitation.

This commit correclty implements the aggregation for parent group for all
field types and all group_operator.

This commit also improves the export feature tests.

Before this commit, when we export a list with a groupby on
boolean, the groupby title 'False' is replaced by 'Undefined'
in xls document.

After this commit, with an export and groupby on a boolean, we
will have correct title: True and False.

With a Right to Left lang.
Go to an employee form view.
Click on the small pill with the number of subordinates (in the org chart).
The popover opens but on the right side of the window instead of next to the
pill.

Fixes #38722

closes odoo/odoo#38776

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Before this commit:
Private email and phone are related of partner 'address' fields.
But the phone was read-only and the email is editable.

After this commit:
As phone and mail are related, they are read-only. We must edit
them on the partner of Address field.

close #38518

closes odoo/odoo#38713

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Before this commit:
When there few elements in kanban and a search panel, all kanban
cards try to take a maximum of height and become deformed.

After this commit:
The behaviour of dimensions of kanban cards must be the same with
or without searchpanel.

closes #38556

closes odoo/odoo#38703

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

SMS reminders are not timezoned

closes #38243

closes odoo/odoo#38400

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

In the employee form view and in the employee profile, the stat button
displaying the equipment count is wrong.
It counts the equipment owned by the user, not equipments assigned to the
employee.

closes odoo/odoo#38627

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

closes odoo/odoo#38456

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

We should check that we have a picking_id before calling a method that
uses `ensure_one`

We should avoid crashing in case active_ids is not in the context

A compute method should always assign something to the computed field(s)

It is possible to get to a situation where Odoo would try to send an email without a `From:` header address.

In such case, you're unlucky if you don't have access to the underlying deployment, or if you use multiple databases in a single Odoo instance and each of them uses a different mail configuration.

To make this configuration easier to use and cover those use cases, here I add support for a new ICP: `mail.default.from`. It will be used when present, so it shouldn't affect existing deployments. When present, it will allow a admin to configure the default sending address just with Odoo itself.

closes odoo/odoo#38865

X-original-commit: 5010ce63
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

When a reconciliation proposition's amount is computed from a regex, we
cannnot be sure the regex captured something. If it didn't we don't want
to display a badly formatted line so we set the amount to 0.

closes odoo/odoo#37578

Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>

closes odoo/odoo#38834

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Once we add an address in Peru we need it to be displayed in the next
way for the reports:

Name of the partner
Street name, number
Apartment(optional)
District
City

The level State and Country are added to complement the street address.

closes odoo/odoo#38764

Signed-off-by: Josse Colpaert <jco@openerp.com>

- base_vat: Correct management of the check of peruvian VAT without prefix.
- l10n_pe: Correct income account the last one is not correct.
- l10n_pe: Forced Round globally for peruvian companies once l10n_pe is
installed, and with the onchange.
- l10n_pe: For peruvian companies it does not make sense a sequence per
year and the year in the prefix is incorrect, we must force XXX- as
a sequence prefix.

This option, if set to True, prevents the user from modifying the
color of the tags.

Part of task 2070454

closes odoo/odoo#38785

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

closes odoo/odoo#38824

X-original-commit: 62d7eaf8
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Since we are not using document only in invoice by now we remove the
option to incoude receipts.

closes odoo/odoo#38439

Signed-off-by: Josse Colpaert <jco@openerp.com>

The im_support module was broken in 12.0 after bus refactorings between
11.0 and 12.0.

closes odoo/odoo#38831

X-original-commit: db37e0ce
Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
Co-authored-by: @alexkuhn

Have a reconciliation model that applies to some particular journals
And that will match some of those journals' lines
The field journal should be filled too
(this field is only the default journal that a proposition will be filled with)

Open the reconciliation widget on a given journal, within the list of
possible journal (from the account dashboard)

Before this commit there was a crashed. This was caused by the fact that
one of the lines that should be displayed had a reconcile model that was not fetched beforehand

After this commit, there is no crash as all relevant reconcile
models are fetched

Note that, on reconcile models, the field journal_id is just there to prefill
the propositions it will create

corrects commit e5c80714

OPW 2084942

closes odoo/odoo#38817

X-original-commit: 2f4344cce6672e5dbe319047c5c7db293a05ba54
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>

Before this commit, trying to print a registration without a name
specified (not required), was failing

Fixes odoo/odoo#38564

Replace and closes odoo/odoo#38582
Courtesy of Swapnesh Shah

closes odoo/odoo#38811

X-original-commit: a21a81e9
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

companies.

We revert the change we apply in order to let the user to define their
own fiscal positions, now the fiscal position will be set depending on
the afip responsability.

With this change we fix the error that the fiscal position is properly
setted for the customers that are of type "Responsable Inscription" and
"Consumidor Final".

Before this change the "Compras / Ventas en el Exterior" fiscal position
was wrongly seted, now the fiscal position is leave empty so the related
invoice taxes are properly matched

closes odoo/odoo#38431

Signed-off-by: Josse Colpaert <jco@openerp.com>

In 12.0 it was 3.5 but for 13.0, it is acceptable 3.6.
Debian Buster has 3.7 and Ubuntu 18.04 LTS has 3.6
This will avoid undeterminist errors with OrderedDict

CentOS 7 still does not ship python3 by default but it is possible to
install it and CentOS 8 with python 3.6 was released in septembre 2019

closes odoo/odoo#38364

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>