Skip to content
Snippets Groups Projects
  1. Dec 24, 2015
    • qsm-odoo's avatar
      [IMP] web(_planner),website: navbars & menus merge · bcca4a44
      qsm-odoo authored
      Merge appswitcher navbar and app navbar.
      Merge planner menu and user menu.
      bcca4a44
    • Goffin Simon's avatar
      [FIX] website_sale: t-debug oversight · 615ff654
      Goffin Simon authored
      615ff654
    • Martin Trigaux's avatar
      [FIX] wrongly translated planners · ef762f43
      Martin Trigaux authored
      breaking the rendering
      ef762f43
    • Yenthe's avatar
      8899b7fc
    • Aaron Bohy's avatar
      [FIX] bus,mail: user presence · f6c20fa4
      Aaron Bohy authored
      Commit 5d1b3232. re-enabled the user presence updates and notifications.
      Unfortunately, it showed poor performance due to the high frequency of bus
      notifications triggered on our instance (~600k users).
      
      In this rev., we don't trigger notifications on presence changes anymore, but
      we rather send the presence of users we have a DM open with, at the end of each
      poll period. For performance reasons, we ensure not to do that more than once
      every 30 seconds.
      
      We also refined the detection of the 'away' status client side. 'Last presence'
      timestamps are stored in the local storage, and the current inactivity period
      is sent at each poll. Those presence timestamps now rely on browser activity
      detection (click, keypress... events) rather than on the focus on Odoo tabs.
      
      Finally, we removed the no more necessary cron introduced in 5d1b3232.
      f6c20fa4
    • Aaron Bohy's avatar
      [FIX] im_livechat: matching rule in cache · d8605b79
      Aaron Bohy authored
      The problem was that the matching rule was evaluated before sending the html
      page, and the script was inserted in the page according to the matching rule
      (it wasn't inserted if the rule was 'hide_button'). However, the matching rule
      wasn't re-evaluated if the page was already in the cache. The page content thus
      might depend on a matching rule computed for someone else in that case.
      
      Rather than inserting the script according to the matching rule, we insert it
      only if there is an operator available. We then ask for the matching rule in
      the livechat widget, by RPC, and we reject its willStart deferred if the rule
      says so. We also re-check for operator availability in the same RPC.
      d8605b79
    • Martin Trigaux's avatar
      [I18N] Update French translation terms from Transifex · 4be1a8cc
      Martin Trigaux authored
      Some planners were incorrectly translated, breaking at rendering
      Fixes #10190
      4be1a8cc
    • Aaron Bohy's avatar
      [FIX] mail: client action: traceback on composer focus · 26b00a84
      Aaron Bohy authored
      wrong copy-paste introduced in c4fb2b50.
      26b00a84
  2. Dec 23, 2015
    • Denis Ledoux's avatar
      [FIX] mail: unfollow buttons for portal users · 5e51dc99
      Denis Ledoux authored
      The route `/mail/unfollow` is used by the button
      `Unfollow` in the mail notification template so a user
      can remove himself from the followers of a thread.
      
      To be able to remove yourself from the followers,
      you need to have the write access on the thread
      (see `message_unsubscribe` in `mail/mail_tread.py`)
      which you perhaps do not have, for instance if you
      are a portal user.
      
      The unsubscribe of this follower from the thread
      should therefore be done as sudo.
      
      opw-659295
      5e51dc99
    • Denis Ledoux's avatar
      Revert "[FIX] models: in `onchange`, add missing fields when comparing values" · 79a0d1de
      Denis Ledoux authored
      This reverts commit 882bbf46.
      
      This revision leads to a crash when creating a new user:
      
      Traceback (most recent call last):
        File "/home/dle/odoo/9/openerp/http.py", line 643, in _handle_exception
          return super(JsonRequest, self)._handle_exception(exception)
        File "/home/dle/odoo/9/openerp/http.py", line 680, in dispatch
          result = self._call_function(**self.params)
        File "/home/dle/odoo/9/openerp/http.py", line 316, in _call_function
          return checked_call(self.db, *args, **kwargs)
        File "/home/dle/odoo/9/openerp/service/model.py", line 118, in wrapper
          return f(dbname, *args, **kwargs)
        File "/home/dle/odoo/9/openerp/http.py", line 309, in checked_call
          result = self.endpoint(*a, **kw)
        File "/home/dle/odoo/9/openerp/http.py", line 959, in __call__
          return self.method(*args, **kw)
        File "/home/dle/odoo/9/openerp/http.py", line 509, in response_wrap
          response = f(*args, **kw)
        File "/home/dle/odoo/enterprise-9/web/controllers/main.py", line 907, in call_kw
          return self._call_kw(model, method, args, kwargs)
        File "/home/dle/odoo/enterprise-9/web/controllers/main.py", line 899, in _call_kw
          return getattr(request.registry.get(model), method)(request.cr, request.uid, *args, **kwargs)
        File "/home/dle/odoo/9/openerp/api.py", line 238, in wrapper
          return old_api(self, *args, **kwargs)
        File "/home/dle/odoo/9/openerp/api.py", line 369, in old_api
          result = method(recs, *args, **kwargs)
        File "/home/dle/odoo/9/openerp/models.py", line 5998, in onchange
          record.mapped(name)
        File "/home/dle/odoo/9/openerp/models.py", line 5497, in mapped
          recs = recs._mapped_func(operator.itemgetter(name))
        File "/home/dle/odoo/9/openerp/models.py", line 5477, in _mapped_func
          vals = [func(rec) for rec in self]
        File "/home/dle/odoo/9/openerp/models.py", line 5715, in __getitem__
          return self._fields[key].__get__(self, type(self))
      KeyError: u'in_group_18'
      79a0d1de
    • Goffin Simon's avatar
      [FIX] account: difference in account.bank.statement · 7021221e
      Goffin Simon authored
      Since balance_end and balance_end_real are floats, they cannot be compared without rounding.
      
      opw:660299
      7021221e
    • Goffin Simon's avatar
      [FIX] website_sale: discount display in e-commerce · 045a8594
      Goffin Simon authored
      Each time the quantity of a product is changed, the price must
      be updated according to the pricelist of the user.
      When the price given by the pricelist is less then the unit price
      of the product, the reduction of the price must be displayed.
      
      opw:660178
      045a8594
    • Denis Ledoux's avatar
      [FIX] purchase: confirm of purchase orders with kit boms · 24eee9d7
      Denis Ledoux authored
      When using phantom/kit boms,
      `action_confirm` on the move can lead to the move unlink,
      as new moves with the different parts of the product have
      been created.
      
      See `_action_explode` in `mrp/stock.py`
      
      The method `action_confirm` on `stock.move` returns the list
      of remaining moves.
      
      `force_assign` should therefore be performed on this new
      moves list, returned by `action_confirm`, rather than
      be performed on the moves list sent to `action_confirm`
      
      opw-660722
      24eee9d7
    • Géry Debongnie's avatar
      [FIX] web_kanban: disable jquery sortable in mobile mode · b6f0e485
      Géry Debongnie authored
      It does not work anyway.  But the real issue is that it intercepts touch
      events and prevents horizontal scrolling in grouped kanban views.
      b6f0e485
    • Géry Debongnie's avatar
      [IMP] mail: extended composer for mailing channels · c4fb2b50
      Géry Debongnie authored
      In Discuss, when the user opens a channel, the composer was the same,
      regardless of the channel type.  This is fine for chat channels, because
      we expect mostly small one liners to be written.  But for mailing
      channels, it is a problem:  it is too easy to send a mail to everyone
      just by typing ENTER, when the user wanted to go to the next line.
      
      This commit introduces a new widget, the extended composer, to be used
      for those channels.  It allows the edition of the subject line, and
      don't sent messages when the enter key was pressed.
      c4fb2b50
    • Denis Ledoux's avatar
      [FIX] website_forum: set a name for answers · 9c283609
      Denis Ledoux authored
      When replying to a question,
      there is no possibility to set a title (`name`)
      in the answer form, there is no input for the title,
      even if the controller `/reply` would accept it.
      
      This revision sets a title for answers so:
       - The answers doesn't appear as `False` in the breadcrumb
       - The subject of the mail notifications sent
         for these answers are set with a meaningful title
      
      opw-659279
      9c283609
    • Damien Bouvy's avatar
      [FIX] sale: no more refund invoices overload · ed6a52a5
      Damien Bouvy authored
      When fetching the invoices linked to a sales order,
      the system looked for all refunds which had an 'origin'
      field that was the number of an invoice of this SO.
      
      That's nice, except that invoices that are not yet
      validated do not have a number, which caused sales
      order with an uncofirmed invoices to be 'linked' to
      all 'out_invoices' that had no origin (which could
      be 1000+ for a substantial db) (basically all out
      invoices which had the origin field set to false)
      
      This commit simply extends the domain to exclude
      refunds that did not originate explicitly from one
      of the SO's invoices.
      ed6a52a5
    • Christophe Matthieu's avatar
      [FIX] web: Can't save a x2m in list editable if contains a m2m_tags with a color field · c7337bf3
      Christophe Matthieu authored
      m2m_tags inlist editable view try to get color on validation, the field is invalid because the mutex is pending.
      Fix: don't re-render the fields
      
      Issue: steps to reproduce:
      - Create a new instance, install "sale"
      - Create a product "prepayment", service, invoice on ordered qties
      - Create aproduct "project phase", service, invoice on delivered qties, manually track delivered qties
      - Create a SO with once prepayment, and twice a line with "project phase". ( the name (description) of the lines should be "phase 1" and "phase 2" )
      - Create invoice => The prepayment is invoiced
      - Go back to the SO, try to change the delivered qties of the first phase to 1
      - Save => error, odoo doesn't let you save.
      c7337bf3
    • Martin Trigaux's avatar
      [FIX] web_planner: untranslated planner · edfa2c47
      Martin Trigaux authored
      Missing context in call to render the planner leading to untranslated planner.
      Use the session to get the user context as outside of the view manager.
      
      opw 660627
      edfa2c47
  3. Dec 22, 2015
    • Denis Ledoux's avatar
      [FIX] account: prevent recomputation of related field `internal_type` · f3ef7001
      Denis Ledoux authored
      When creating a new `account.account`,
      or writing on an existing one, changing the
      `type`, the source of the related field
      `internal_type`, `user_type_id.type`, was
      re-written (re-stored) because the field
      was not read-only.
      
      In addition, the re-store of the value
      of this field triggered the re-store of the related
      field `internal_type` on all other `account.account`
      records using this `internal_type`, which leaded to:
       - Performance issues
       - Potential access rights issues, if this leaded
         to write operations on records to which the user
         does not have the access (multi-company rules, among others)
      
      Forcing the field as read-only allow to not pass the value of this
      `internal_type` from the web client to the server when
      creating or editing an `account.account`.
      
      Besides, the field is required in the view, to correctly trigger
      the according onchange method:
      ```
      @api.onchange('internal_type')
      def onchange_internal_type(self):
      ```
      
      opw-660292
      Closes #10143
      f3ef7001
    • Damien Bouvy's avatar
      [IMP] project: add link from analytic account form view · 1057542f
      Damien Bouvy authored
      Analytic accounts are inherited by project.project, and in some cases it is useful to have a link from the account to the project.
      
      This is a usability-fix, not a code-fix
      1057542f
    • Nicolas Martinelli's avatar
      [FIX] hr_timesheet_sheet: link account line and sheet · fd8e9da7
      Nicolas Martinelli authored
      When an expense is recorded and linked to an analytic account, the
      associated line will appear in the timesheet.
      
      This fix links prevents linking an account analytic line to a timesheet
      sheet if the line is not a timesheet.
      
      Somehow related to a4b6e3a8
      
      opw-657917
      fd8e9da7
    • Nicolas Lempereur's avatar
      [FIX] web_kanban: reference for loaded more records · 3e2369fb
      Nicolas Lempereur authored
      If the kanban view is loading grouped records, the dataset of the view
      itself is the concatenation of the dataset of each groups.
      
      But when using "Load  more..." on a column, these records are not added
      in the view dataset which is thus desynchronised. This could lead to an
      error down the road.
      
      closes #10156
      opw-659016
      3e2369fb
    • Martin Trigaux's avatar
      [FIX] typo with en->en translations · edf276c2
      Martin Trigaux authored
      edf276c2
    • Denis Ledoux's avatar
      [FIX] website_quote: · 7dc25658
      Denis Ledoux authored
      This revision is related to 7be2403c
      
      The payment acquirers must be fetched if the quote
      needs a payment.
      
      Besides, as explained in the above revision, the state
      `manual` no longer exists sales orders, and therefore
      this must no longer be used to determine if a quote
      needs a payment or not.
      
      opw-660575
      7dc25658
    • Goffin Simon's avatar
      [FIX] hr_payroll: cleaning and writing in new API · 0a7ee85c
      Goffin Simon authored
      Cleaning and writing in new API "onchange_employee" and "onchange_contract".
      
      opw:659338
      0a7ee85c
    • Denis Ledoux's avatar
      [FIX] web: client action change password · e04ddeaa
      Denis Ledoux authored
      1. To change the page title, you now have to call
      `set_title` from `require('web.web_client')`
      
      2. Without the `type="button"`, the `Change Password`
      button is regarded as a `type="submit"`, therefore
      submitting the form, on `web` on click,
      and `web` doesn't expect this POST request.
      The POST request must be done on
      `/web/session/change_password` only.
      
      opw-660567
      e04ddeaa
    • Goffin Simon's avatar
      [FIX] tools: colon in a URL · f7dab86a
      Goffin Simon authored
      When writing an URL in the chatter with a colon inside, the function
      "html_keep_url" must detect all the URL.
      
      opw:660116
      f7dab86a
  4. Dec 21, 2015
    • Jeremy Kersten's avatar
      [FIX] wesite_slides: use embed for document and presentation · 9f795ef2
      Jeremy Kersten authored
      For performance, we could use iframe with embed document.
      But it's more styled to use our own slide design that an iframe
      with a long scrollbar.
      9f795ef2
    • Denis Ledoux's avatar
      [FIX] point_of_sale: POS user access rights · df745c25
      Denis Ledoux authored
       - A simple POS user doesn't have the rights to write
         on pos.config, not even to write the `current_session_id`,
         so it must be done as sudo.
       - If no fields is specified to `search_read`, it reads all fields.
         The simple POS User cannot access all fields on `account.journal`,
         (e.g., the computed fields implying `account.payment` records)
      
      opw-659079
      df745c25
    • Denis Ledoux's avatar
      [FIX] project_timesheet: timesheets order in task form · 7427972f
      Denis Ledoux authored
      This revision is related to 432f199f.
      
      Since the above revision make sure to change the
      editable list to `bottom`,
      the order of the list should be done on the `date` (asc),
      on this view, as this is more likely that, when adding a new line,
      that the date set on this new line is
      more recent than the dates on the other lines.
      
      The new added line should therefore appear directly at the bottom
      of the list, to avoid consufing the user.
      
      Besides, the default order of the model `account.analytic.line`
      is set to `date desc, id desc`
      
      opw-659892
      7427972f
    • Xavier Morel's avatar
      [IMP] csrf: better warning and documentation · 8595bc2f
      Xavier Morel authored
      After initial implementation CSRF protection had been left poorly
      documented tripping up users and developers (#9538, #10139).
      
      Add a warning in the logs for developers, and a more extensive
      explanation of the whole thing in the @route docstring (and the official
      documentation).
      
      Fixes #10158
      8595bc2f
    • Xavier Morel's avatar
      [FIX] sudo() docstring · f839c935
      Xavier Morel authored
      rST uses double-backticks for literal text, not single
      f839c935
  5. Dec 20, 2015
  6. Dec 18, 2015
Loading