Issue

	- Install CRM
	- CRM > Reports > Activities
	- Add a custom filter > Created on
	- Select the date

	You can't, the date picker is not shown

Cause

	Actually, the date picker is shown but
	very quickly and it is closed by a scroll
	event thrown by Chart.js.

Solution

	Close the date picker only if the user
	scrolls manually.

OPW-2245019

closes odoo/odoo#50434

Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>

In a calendar with 2 weeks mode (odd and even), before this commit, all
new created periods (placed in one of the two sections) don't have the
week_type field set. This generates a confusion, because a period that
should be applied only in odd weeks, for instance, it was applied also
in the even weeks.

Now, the new periods will have the week_type field set with the
week_type of the section where is it. Also, an error message is raised
if a period is not in one of the two sections.

opw-2239966

closes odoo/odoo#50393

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

- In Website > Settings, set 'Show inventory on website and prevent
  sales if not enough stock'
- Create a consumable product P, publish on the eCommerce
- As user 1, buy 1 units of P => validate the SO => 1 unit is reserved
- As user 2, add 1 unit of P to the cart. In the cart click on the `+`
  to add a unit

The product is removed from the cart.

This happens because `virtual_available` quantity is taken into account,
while it shouldn't be since it is a consumable.

opw-2245075

closes odoo/odoo#50428

X-original-commit: ec6f281f
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

closes odoo/odoo#48952

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

[FIX] l10n_nl: fix bad forward-port of https://github.com/odoo/enterprise/commit/82608e25033fde6f93b8d0face5774f70930fcd2



closes odoo/odoo#50432

X-original-commit: 4556c0409d7022a2186dcb95307c5a57577d5081
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

_onchange_product_id() used to always (re)set hr_expense analytic_account_id & analytic_tag_ids to default values.
Or set those to false if no default values are found.
Installing account_analytic_default_hr_expense made odoo/addons/hr_expense/tests/test_expenses.py tests fail

- changed function name (no need to be a _onchange_product_id override)
- removed super() & return
- only set default value to var if var is False

closes odoo/odoo#46449

Task: 2205544
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

There is no way to select all the posted invoices; only the posted and
unpaid.

closes odoo/odoo#50443

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

Cache should be invalidated when updating `arch_db` via `arch`.

closes odoo/odoo#40012

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

Co-authored-by: Christophe Simonis <chs@odoo.com>

In some situations it is important to protect the Odoo service from
direct access from the internet, or to protect internal network
resources from the Odoo server itself.

This is heavily dependent on deployment requirements, and for standard
installations on a public cloud system, this may not be necessary.
Yet it seems useful to mention it in the deployment recommendations,
as it may not be obvious to our users.

Our thanks to Ameya Darshan for raising this concern!

closes odoo/odoo#50417

Signed-off-by: Paul Morelle <madprog@users.noreply.github.com>

1. Create an invoice and upload a picture file as the only attachment
2. Try to print "origin bill" for the invoice (From the invoice tree
view select one and click print > origin bill )

An error will raise "PIL.PdfParser.PdfFormatError: trailer end not found".
Fixing by using another BytesIO object as the output.

opw-2244625

closes odoo/odoo#50313

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

This reverts commit cc8994a4.

opw-2153840

closes odoo/odoo#50280

Related: odoo/enterprise#10239
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

- Create a consumable product
- Assign a FIFO product category, automated valuation
- Purchase some units
- Go to the Inventory Valuation report

The product appears in the list, while consumable should not.

We only show products linked to stockable products.

opw-2153840

Replaces unnecessary (harmless in this case, but still), 't-raw'
by 't-esc'. Also replace a t-raw used in the SwitchCompanyMenu
(unnecessary and harmless as well).

closes odoo/odoo#50387

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>

Steps to reproduce:
- install eLearning
- go to the website > courses > enroll in any course > leave the course

Previous behavior:
you are not unsubscribed from the slide channel and still receive mail
notifications

Current behavior:
you are unsubscribed from the channel when you leave the course

opw-2244716

closes odoo/odoo#50200

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

When an expense is create from email, if the product is not set, when you want set the product it is erase the unit price.

closes odoo/odoo#48516

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

   
limit identification type search result in one
record to avoid apparent singleton error

closes odoo/odoo#50364

Signed-off-by: Josse Colpaert <jco@openerp.com>

Steps to reproduce:
- create a new invoice.
- add a line has a subtotal of amount 0.00 (e.g. set the price or quantity 0)
- post the invoice
- go to reporting > management > invoices > view pivot > amount due

Previous behavior:
traceback - division by zero

Current behavior:
no traceback

opw-2244781

closes odoo/odoo#50325

Signed-off-by: mightyjol <jhk-odoo@users.noreply.github.com>

Before this change, the SSF would read from the record after
creation but wouldn't do so after a write.

This doesn't conform to the behaviour of the web client (which does a
read() after saving a form), and means the effect of field
inverses (when the dependencies of a writable field are also in the
form) or overrides to write wouldn't be visible afterwards.

It's always possible to just re-create the form from scratch, but the
intention has always been that the form would work correctly after a
save.

closes odoo/odoo#50360

X-original-commit: 45398c09
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

In the case of an <ol> in an <ol> we would have something like:

```
1.
   1.
   2.
3.
```

because the sublist itself in version of summernote.org we are using
is a list item, so it takes one extraenous item.

With this changeset we have something that makes more sense:

```
1.
   1.
   2.
2.
```

Because there are tons of use case of different selection of list level
and indent or outdent, this commit also simplify outdenting (eg. now we
outdent all the element of the same level than the first indented).

opw-2185406
closes #48194

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Create a journal entry with accounts payable receivable in the journal
lines and no partner. Reach out Aged payable/receivable report. Click on
the unkown partner: all lines from the partners will be fetched
(duplicated)

This occur because the function which takes the values from the database
does not handle the null partner case

opw-2242031

closes odoo/odoo#50291

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Steps to reproduce:
- Create a second company
- Enable this company only
- Create a new company
=> Access error is raised because the `intercompany_user_id` is
OdooBot by default and OdooBot's partner cannot be read from
other companies. Hence, the company creation fails.

Like all other internal users/partners, OdooBot's partner should
be shared across companies, even if its user is inactive.

Task 2157039

See also 2390ba60

Task 2157039

closes odoo/odoo#49926

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

If there isn't any customer set on the task, the current behavior
will display 'Hello False,' in salutation rating email as intro.

This commit will fix it by display only 'Hello,' if there isn't
any customer set.

Task ID 2238816

closes odoo/odoo#49877

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Commit 8c1bb22e forgot to take into
account migrations, during a migration it is possible that some modules
need to be uninstalled because the target version may have removed /
moved them and since during a migration all modules are set `to
upgrade`, the previous condition made this impossible for migration
scripts that use the ORM for module uninstalls (not Odoo's case, mind
you)

With this commit it is again possible to uninstall modules from a
migration script during a migration.

closes odoo/odoo#50309

X-original-commit: a7c90a6d
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Signed-off-by: Adrian Torres (adt) <adt@odoo.com>

closes odoo/odoo#46280

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

This commit fixes the crm.lead form view to always display UTM information when
the lead is of type "opportunity".

Before this change, the UTM information (as well as the 'referred' field) were
only displayed for members of the 'base.group_multi_company', which did not
make sense on a functional point of view.

The 'company_id' field however, that is in the same form group, is still
correctly displayed only for members of the 'base.group_multi_company' group.

Task 2237318

closes odoo/odoo#50290

X-original-commit: 69bbe848f50a80f215cf42f619e2128e9302ba0f
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Signed-off-by: awa-odoo <awa-odoo@users.noreply.github.com>

Before this commit, if a many2X field with a big comodel was added
in a search panel, the view using it would crash. For instance that
problem occured in the kanban view for hr.job, where res.users
appears as the comodel for the field user_id.

Now, we fix an arbitrary limit of 200 to the numbers of values to fetch
for each many2X fields in the search panel. This avoid the problem
mentionned above.
Furthermore, in case the limit is attained for a field used
as select="one", the values are displayed without being hierarchized.
Indeed the limit can leads to gaps in the knowledge of the hierarchy
and consequently to a bad representation of it.

Task ID: 2154668

closes odoo/odoo#49857

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Issue

	- Install Studio & Employees
	- Edit Search View
	- Try to add a field in group by

	RNG Validation Error
	Invalid attribute studio_groups for element field

Cause

	There is a group on a field in the searchpanel
	of this view.

	This group is converted into studio_group which
	is an invalid attribute for the RNG validation.

Solution

	I found that in this case, the check for
	searchpanel part be validated independently
	is bypassed because the node tag is not search
	but searchpanel.

	I added this case in the condition.

OPW-2228602

closes odoo/odoo#49105

Related: odoo/enterprise#10031
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

- Install PoS and "l10n_fr_pos_cert";
- Erase the country in the current company;
- Open a PoS session;
- Click on any product.

Before this commit, a JavaScript traceback was raised: TypeError: Cannot read property
'code' of null.

Now, an error message is raise, that informs the user that the company don't have country
setted.

opw-2241993

closes odoo/odoo#50296

Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

Purpose
=======
We should not be able to duplicate the link trackers (as it
makes no sense from a functionnal POV).

Task-2090344

closes odoo/odoo#50279

X-original-commit: 850e7442
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

This happens far too often (daily quota exceded, event
already deleted (?)).
This is a big source of support tickets.
The sync will be retried next time.

Task 2169121

closes odoo/odoo#49401

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

- Create 2 companies C1 and C2, set a COA for both
- Allow the user on both companies in the company switcher
- Create a partner P
- Switch to C2 and an Account Payable and Account Receivable of C1
- In C2, create an invoice for P, add a product, save

The receivable account of C1 is used while the invoice is in C1.

We add the company check on the `account_id` field of the
`account.move.line` to prevent this.

opw-2243441

closes odoo/odoo#50145

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

When the PostgreSQLHandler is used to store some logs in the ir_logging
table of a database, the log record pathname is truncated to keep only
the relevant part of the path. In some circumstances, the path is
wrongly truncated, leading to totally invalid paths.

e.g.: When using an addon-path like `/data/build/enteprise` the removed
part correspond to the length of `/data/build/odoo/`. The resulting path
is `prise/....`.

With this commit, the full path is kept.

This commit is mainly a fix for the runbot logs and should not have an
impact on existing databases.

closes odoo/odoo#50238

X-original-commit: f3c96aa2
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

Steps to reproduce:
- install account
- print any invoice

Previous behavior:
the css rule and classes are ignored on the total table

Current behavior:
displays as intended

This PR fixes two issues:
1/ class attribute was not taken into account anymore ( table-sm )
2/ page-break-inside didn't work

closes #48682
opw-2229181

closes odoo/odoo#50250

X-original-commit: e4b0040a
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Not so stable apparently

closes odoo/odoo#50206

Related: odoo/enterprise#10214
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Avoid messing up with style by translating it

The name was autogenerated to "XMas Promo 2020-04-27 09:15:11" (which
is rather technical)
Make a static one to avoid changing it everytime the translations are rexeported

8b921471 has introduced wrong context key which replaces `res_partner_search_mode` with the depricated `search_default_customer` which was breaking search functality added by 8766f388 

In this commit we correct context's key.

closes odoo/odoo#50176

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>