When breaking a page from a Carousel or other slider snippet (eg by
hitting the backspace key at the beginning of a page), the editor's
history gets reverted but ends up applying the `active` class to all
pages. This is due is some way to the `_computeHeights` method of the
slider snippet, which applied the class to all pages to observe their
heights, then put them back in place. It seems in the labyrinth of ticks
the history step somehow started from a place where every page was
active, so we reverted back to that. The point where these classes were
applied should have never been observed in the first place since it's
purely technical. Not observing it fixes the bug.

task-3081259

closes odoo/odoo#106696

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Reproduction:
1. Install Expense, make sure in the product list of test data, we have
Expenses(without cost e.g. 0.00) and Daily Allowance(with cost e.g. 100)
2. Create a new expense with the product Daily Allowance, and attach a
file to the attachment, save expense
3. Edit the created expense, change the product to Expenses and save
4. The UI is not changed and can’t edit the total amount of the expense

Reason: the recomputation of product_has_cost is based on the
unit_amount. However, when there’s an attachment, the recomputation of
unit_amount doesn’t consider the case when the product is changed to one
without standard_price (unit_amount).

Fix: add a condition to make sure when the product is changed from one
with standard_price to one without standard_price, the unit_amount of
expense is recomputed correctly

opw-3051726

Related commit: https://github.com/odoo-dev/odoo/commit/918a5f2cc022994ee08bead25dd79072bf3fba87



closes odoo/odoo#106660

Signed-off-by: Kevin Baptiste <kba@odoo.com>

Simple refactor in order to make changes to these line trigger the CI/Security

closes odoo/odoo#106309

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

*: website_sale_wishlist

Commit [1] and [2] introduced test tours but did not mark them as test
tours properly, thus showing them to users (who are in debug=tests mode)
by mistake.

[1]: https://github.com/odoo/odoo/commit/7655bface7f9e9bae8579e14e9a87b4f4801cc33
[2]: https://github.com/odoo/odoo/commit/a0c33c5f896718d1c03a6a50c981d6d75ce0d169



closes odoo/odoo#106678

X-original-commit: 11d023f0
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Reproduction:
1. Install eCommerce, Events, in the settings of Events, toggle
“Tickets” and “Online Ticketing”
2. Go to Website -> Go to Website -> Event, at the top bar, Customize ->
Track Visitor, turn it off
3. Click on the event “Open wood collection”, also turn off “Track
Visitor”
4. Click on the register button for this event, also turn off “Track
Visitor”
5. Copy the URL of the registration page, open it in an incognito tab.
Don’t go through from the beginning of the main website
6. Register a standard free ticket, enter the information, and click
confirm
7. The website throws a 404 not found error

Reason: when we turn off “Track Visitor” on the event registration page.
If we directly access the registration page, the created visitor’s
access token is not written in the cookies. Thus, when we call
_get_visitor_from_request after redirecting to
event_registration_success, the visitor isn’t retrieved and it causes a
404 not found error. A detailed case study is attached below.

Fix: before the redirection of successful registration, we check if the
logged visitor_uuid is the same as created visitor’s access token. If
not, e.g. the visitor_uuid is not logged, we log it in cookies.

opw-2828682

closes odoo/odoo#101635

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

When an SVG element changes and is filtered by the
`filterMutationRecords` method, the method tries to split its
className (Since [1]). This is not supported by the browser however,
because the className property of an SVGElement is not a String.
Rather, it is an SVGAnimatedString [2].

This commit fixes that by using the getAttribute method instead.
Ensuring that the attribute returned is always a String.

[1]: https://github.com/odoo/odoo/commit/1c25ddb42393b136cac2a0ee0b9b7280fd803e7d
[2]: https://developer.mozilla.org/en-US/docs/Web/API/SVGAnimatedString



opw-3077287
opw-3074434

closes odoo/odoo#106671

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

closes odoo/odoo#106646

Related: odoo/enterprise#34433
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Before this commit:
1. Create PO with quantity 10, confirm (creates receipt-1)
2. Receive 2 quantities on first receipt (receipt-1), backorder (receipt-1 is 'done', creates receipt-2)
3. Receive 3 quantities on second receipt (receipt-2), backorder (receipt-2 is 'done', creates receipt-3)
4. Change quantity to 5 in PO
5. An exception is created on all receipts (1, 2 and 3)

In the scenario above, receipt-1 and receipt-2 are partial receipts that are set to 'done'.
It is not necessary to create an exception in these receipts when the quantity is changed to less than originally expected in the PO.
Since the system checks that the new quantity has to be equal or greater than the received quantities, the already received quantities cannot be impacted.

After this commit:
The exception is only propagated to the receipts that are not done.
e.g. in the example above, an exception appears only in receipt-3.

task-2648209

resolves #76297

closes odoo/odoo#106597

X-original-commit: d6fad232
Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Before this PR Odoo don't pre-search on location.

closes odoo/odoo#106576

X-original-commit: 71a3b5b2
Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Current behavior:
When splitting the order in a pos_restaurant session, the order was not
correctly saved in the backend. It resulted in an order that still had
all the product of the original order and another order with the
correctly splitted products.

Steps to reproduce:
- Start a pos_restaurant session.
- Go to table A and add 3 products to the table.
- Go back to the floor screen
- Go back to the table A
- Split the order in 2
- Click on payment, and go back to the product screen without paying
- Click on the ticket button, and click on the order that was splitted,
  it still contains all the products from the original order.

opw-3061569

closes odoo/odoo#106553

X-original-commit: a61c2b88
Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

Stepts to reproduce:

Go to Time-off app > configuration > Public Holidays.
Try to create a new holiday and select working hours.

Issue:

It will show up all the working hours available for all companies even
if we are not in that company at the moment.

Solution:

We need to take into account the company for this field in order to only
show the working hours available for this specific company. I've added
to the field the `domain="[('company_id', 'in', [company_id, False])]"`
in order to follow the same behavior as next versions.

This issue affects 15.0 and saas-15.2

opw-3068827

closes odoo/odoo#106415

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Commit 7fbb337e introduced performance slowdown when reconciling a
bank statement line with multiple invoices. This is due to the
compute function being called a lot of times and each time need to
trigger a search for CABA moves (even if the company do not use
cash basis).

This commit aims to not trigger the search if the company do not use
cash basis and add some domain conditions on indexed fields to speed up
the search when it's a cash basis company.

opw-3013391

closes odoo/odoo#106402

X-original-commit: 9d6db3af
Signed-off-by: John Laterre (jol) <jol@odoo.com>
Co-authored-by: Arnaud-Sibille <arsi@odoo.com>

1/ When approving / refusing a leave spanning multiple days, the
   overtimes were only recomputed for the starting date and not the
   whole period.

2/ Overtimes should be computed whatever the kind of time off that's
   been taken (Absence or Other).

task-3073155

closes odoo/odoo#106298

Signed-off-by: Kevin Baptiste <kba@odoo.com>

closes odoo/odoo#105637

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Provide a hook for clean specification of additional fields, without
relying on risky default dict method parameters.

Use the existing `_group_by_sale` to cleanly add additional
"group by" information.

Partial backport of 740a507d

closes odoo/odoo#105246

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Co-authored-by: Victor Feyens <vfe@odoo.com>

Currently in Sale/Orders/Sales Teams menu , The Sales Analysis dashboard
have text overflow bug for large numbers in USD/EUR this bug might be
rare but in currency like Yuan or VND its common

closes odoo/odoo#104782

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Usecase to reproduce:
- Product A with Vendor supplier lead time=1day
- Product B with same Vendor supplier lead time=4days
- Launch the replenishment report for both products at the same time

Current Behavior:
The expected arrival is correct but the order date deadline is today - 3
days

Wanted Behavior:
Same but the order date dead line is today

It happens because it does the minimum of expected arrivals - max of
supplier delays. However the supplier delays are already correctly
apply on each procurement (correct expected arrival). To know the
correct order deadline we should instead take the minimum date planned
with the related supplier delay.

opw-2822588

closes odoo/odoo#90586

X-original-commit: 1d542b91
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

In large database with lot of user, the browser don't respond.

closes odoo/odoo#106631

X-original-commit: 0f597b3a
Signed-off-by: Romain Derie (rde) <rde@odoo.com>

When creating draft deferred entries in a reconcilable account,
we should not attempt to reconcile them, because only posted entries
can be reconciled.

closes odoo/odoo#106565

X-original-commit: edaf019e
Signed-off-by: William André (wan) <wan@odoo.com>

In this commit [1] (merged in 16.0) a bugfix has been made in the
`removeSlide` function but this one should have been applied on all
supported versions because the bug it fixes is present on all versions.
The bug it fixes is the following:
- Drop a carousel block on a page
- Remove the *first* slide

=> There is no active indicator.

Moreover, the bugfix made in 16.0 [1] introduces another error: when a
slide is removed from the carousel the indicators are not in a correct
state anymore.

Following the same steps with the changes of [1]:
- Drop a carousel block on a page
- Remove a slide

=> Indicators are no longer consistent with the slides so tracebacks
appear during the carousel slides. The list of indicators must have on
each element a `data-slide-to` attribute which must reflect the
position of the slide (starting with 0).

So this commit is to backport the fix from 16.0 [1] to 14.0 and to fix
the new bug that [1] introduces.

[1]: https://github.com/odoo/odoo/commit/f7055d3dbabfbe471f490bd65c2032f5251f3f37



task-3040931
opw-3051615

closes odoo/odoo#106611

X-original-commit: 16405934
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Before this commit, the buttons to scroll to the next element might not
work if the next element was invisible.
Steps to reproduce the bug fixed by this commit:

(Note that these steps are only reproducible from 15.0. We decided to
merge this fix in 14.0 to be custo-friendly)

- Install two languages on a website
- Drop a cover block (1), with a height of 100% and a scroll down button
- Drop a new block (2) only visible for language B below the block 1
- Drop a new block (3) visible for everyone below the block 2
- Save and go to the site in language A
- Click on the scroll down button

=> No scroll at all while the user expects to scroll to the block
visible to everyone (3). This commit fixes that by making the user
scroll down to see the next visible element.

opw-2967706

closes odoo/odoo#106455

X-original-commit: 076d7ac7
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Because of css limitation, the child of a parent that define a
text-decoration cannot "neutralize" that decoration defined by its
parent with a css property (ie. the text-decoration cannot be
overridden).

When a block define an inline style or any tag that have a class, the
method `formatSelection` tries to "neutralize" the style by calling
`addNeutralStyle`. As it is impossible to "neutralize" the style for
underline nor strikeThrough, there is no method `addNeutralStyle`
defined for those properties.

Before this commit the method `formatSelection` was crashing because
`addNeutralStyle` was not defined.

Task-3002123

closes odoo/odoo#105953

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Only active boms should be returned by the domain even if
they match a product id.

closes odoo/odoo#106449

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

closes odoo/odoo#106447

Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>

Steps to reproduce:
- edit RFQ model with studio
- add a toggle widget to the product list
- activate/deactivate the toggle multiple times on different products

Bug:
sometimes the element on the widget is undefined when trying to rerender

Fix:
check the element is defined before trying to render it

opw-3013024

closes odoo/odoo#103186

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

When a one2many is used as a search default, its label has to be fetch
via a name_get in order to get a correct display of the facet
corresponding to that field in the search bar. It turns out that the
search model did not wait properly the return of the name_gets before to
start to compute the facets.

closes odoo/odoo#106522

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

In Factur-X, there is no way to represent a tax "price_include" because
every amounts should be tax excluded.

Currently in Factur-X, a line with a tax price_include = True will be
incorrectly exported. Indeed, the Factur-X.xml is generated by setting the
GrossPriceProduct as the price_unit. In Factur-X, this amount (and the others
in the line details) should be tax excluded. Thus, it's wrong to set the
GrossPriceProduct as the price_unit.

To fix this, the GrossPriceProduct should be the price_unit if no tax
price_include = True is set, otherwise, the gross price = price_unit/(1+tax/100).

This way, the Factur-X file will be consistent with the norm.

Note that the import of a Factur-X xml will thus try to pick taxes with price_include = False,
and the price_unit will be tax excluded. If no matching tax with price_include = False is
retrieved, a tax with price_include = True is searched, if found, the price_unit is
recomputed accordingly. In both cases, the lines subtotals are the same.

opw-3032382

closes odoo/odoo#106465

X-original-commit: 649e0f2d
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Julien Van Roy <juvr@odoo.com>

- Currently the label of the lines is not limited to the number of characters. When the user gives a name that is too long, the graph will not be displayed.
- This commit limits the number of labels, if exceeded it will display as ...

closes odoo/odoo#106149

X-original-commit: 11dc2cec
Signed-off-by: Mathieu Duckerts-Antoine <dam@odoo.com>

The default hours of a time off created from the Day view would be the
range of hours that was selected in the calendar view, thus resulting in
leaves of half an hour.

closes odoo/odoo#106513

Signed-off-by: Kevin Baptiste <kba@odoo.com>

update to this PR[1]

BUG:
some discounts are still displayed on the middle of the order

FIX:
move all discounts to the end

[1]:https://github.com/odoo/odoo/pull/102700


opw-2985632

closes odoo/odoo#106508

X-original-commit: af8cc475
Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>

This reverts commit https://github.com/odoo/odoo/pull/106401/commits/bff333873c77e4879f6b991ed67ed9986f8dbf8e



It was not a bug.
Users are automatically added to the Time Off Responsible group when they are added as approvers on an employee
If the user does not have the access rights it is because they have been manually removed.

opw-3062225

closes odoo/odoo#106505

Signed-off-by: Kevin Baptiste <kba@odoo.com>

closes odoo/odoo#106466

X-original-commit: 94dd698d
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>

Before this commit:
 If we remove a payment line using an Adyen payment method,
 `pending_adyen_line()` return `undefined`.
 With the `_poll_for_response` still being executed,
 it will pop some JS traceback each call with:
 ```js
 TypeError: Cannot read properties of undefined (reading 'terminalServiceId')
 ```

After this commit:
 No JS traceback loop

OPW-3032391

closes odoo/odoo#106431

X-original-commit: 52a517ca
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

PG12 introduced an optimization for CTEs that automatically inlines
CTEs if they are only refered once in the parent query. Prior to that
CTEs were always materialzed, meaning that PG created a sort of temp
table on the fly to store the result of the CTE's evaluation.

Whereas this leads to performance improvements in general, in the
particular case of _select_companies_rates this inlining becomes a
performance bottleneck. This is because while the currency_rate CTE
is only refered once in both purchase_report and product_margin,
the join condition (cr.date_end is null or cr.date_end > ...)
requires evaluating the CTE's date_end subquery twice. This, combined
with the fact that in PG12 the planner goes for a Nested Loop JOIN instead
of a HASH Join in PG10 makes the performances of the whole query
much worse in PG12 than in PG10.

Adding an ORDER BY (or an OFFSET 0, the resulting plan is the same)
creates a kind of optimization fence that forces PG to evaluate the
subquery first using its own plan. This removes the need to rescan the
subquery each time the Merge JOIN filter has to be applied, which
is a good strategy in this specific situation.

The same result could be achieved by adding the keyword "MATERIALIZED"
in the CTE definition. The issue is that this keyword did not exist
in PG 10 so using it would require to check the PG version at runtime
from python.

Examples of query timings change before and after PR:

Number of POs | Before PR | After PR
      2000    |     7s    |    345ms
      7000    |     23s   |    1.1s

opw-2930578

closes odoo/odoo#106086

X-original-commit: 8b7a3941
Signed-off-by: Raphael Collet <rco@odoo.com>

Bug:
- enable wave transfers
- Kanban view should not have a create button

Fix:
removed the button

opw-2978078

closes odoo/odoo#99970

Signed-off-by: Adrien Widart <awt@odoo.com>

First correction: force a simple order to `read_group` in order to avoid
useless joints on table product_template and ir_translation when the
grouping key is a Many2One.

Second correction: add an index on workorder's `state` field. The
get_conflicted_workorder_ids() method search for ready workorders that
are in conflict relate to their planning. The state value is searched to
many times to not index it

closes odoo/odoo#106436

Task: 2852423
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

The user could make the mistake to put a large number in the `Guests`
input in the POS order and this is not validated, even an number more large
for the capacity of an integer, raising an uncontrolled error:

`psycopg2.errors.NumericValueOutOfRange: integer out of range`

this commit is adding a validation error in order to limit the number of `Guests`
with the maximum number for an integer:  2**31 - 1

closes odoo/odoo#105393

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

Steps to reproduce:
    - install the "hr_holidays" module;
    - remove the "Time Off Responsible" group of a user (activate developer mode);
    Remark: the user must not be an "Administrator" or a "Time Off Officer"
    - for an employee add this user as approvers for time off;
    - with a user which matches the employee, request time off;
    - if the user, whose rights have been removed, has "Handle in Odoo" in his preferences, he will receive a notification;
    - try to approve the demand of employee leave.

Issue:
    The user does not have access rights but he has been chosen as approver.

Cause:
    It is possible to select any user to approve leaves without checking if he has the access rights.

Solution:
    Add a domain to be able to select only users who are in the "Time Off Responsible" group.

opw-3062225

closes odoo/odoo#106401

Signed-off-by: Kevin Baptiste <kba@odoo.com>

If the method `_auto_install_l10n` is called programmatically on a DB
where the localization has already been installed, useless processing is
performed by `button_install`.

Do not call this method if no module need to be installed.

closes odoo/odoo#106381

X-original-commit: 11e9d3f1
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>