Skip to content
Snippets Groups Projects
  1. Mar 21, 2019
  2. Mar 20, 2019
  3. Mar 19, 2019
  4. Mar 20, 2019
  5. Mar 19, 2019
  6. Mar 20, 2019
  7. Mar 19, 2019
  8. Mar 18, 2019
    • Romain Derie's avatar
      [FIX] link_tracker: prevent undeterministic order on new/recent filter · a0923684
      Romain Derie authored
      
      Before this commit, ordering by `create_date DESC` and `write_date DESC` could
      lead to undeterministic order if multiple records had the exact same date.
      This is the case during tests as `crate_date` is set to transaction start time.
      (That's what NOW() in PSQL does)
      
      Now, we enforce that order to avoid randomness.
      
      Related to #31829
      
      Signed-off-by: default avatarJérémy Kersten (jke) <jke@openerp.com>
      a0923684
    • Romain Derie's avatar
      [FIX] website_links: fix remaining bugs and restore skipped test · d0cd971a
      Romain Derie authored
      This commit is following c78da8a8 that fixed website_links module.
      
      We had to merge it with a skipped test as there was an error only appearing
      with Docker (on runbot or on local with Docker).
      
      This commit fix that test error and some other remaining bugs not found during
      the first fix:
      1. Fix the test error by adding a step to show recently used links. Indeed the
         bug was that newest links would return inconsistent order as both 2 links
         created during the steps have the same creation date.
         On runbot it would click on the wrong link, the one which has 0 clicks.
         Then JS would crash (see error bellow).
      2. `websiteLinksCharts` JS animation class would execute all the `start`
         method code even if there was no `_totalClicks`. JS would then crash as
         `beginDate` would not be set correctly. Before the refactoring all that code
         would be skipped as surrounded by an if/else condition.
      3. BS3 to BS4 broke the nav-tabs layout to switch between 'Newest, Most Clicked
         and Recently Used. `mt16` needed to be removed.
      
      Closes #31829
      d0cd971a
    • Lucas Lefèvre's avatar
      [FIX] hr_payroll: Generate payslips with datetime · b5c31bdd
      Lucas Lefèvre authored
      
      When payslips are generated from the benefit calendar
      view by clicking on the "Generate Payslips" button, the js
      puts the start and end date in the context.
      Start and end are js Date objects, respectively the start and end of the month
      
      e.g.
      start: `Fri Mar 01 2019 00:00:00 GMT+0100 (Central European Standard Time)`
      end: `Sun Mar 31 2019 23:59:59 GMT+0200 (Central European Summer Time)`
      
      The Dates are first transformed to a string before being sent to the server
      by `time.datetime_to_str`.
      Because this function change the timezone to UTC, the start date becomes
      the previous day at 23:00:00.
      The payslip start date is therefore wrongly set to the previous day.
      
      closes odoo/odoo#31919
      
      Signed-off-by: default avatarYannick Tivisse (yti) <yti@odoo.com>
      b5c31bdd
  9. Mar 19, 2019
    • David Beguin's avatar
      [FIX] website_slide{_survey} : apply various fixes on elearning views · a13e33dd
      David Beguin authored
      
      - Fix certification card in user's profile page
      
      Since design review, certification card were not displaying well.
      This commit applies the course card template on certification card
      and modifies the way the certification get downloaded by calling directly the
      controller instead of using class catched in javascript that calls afterward the
      controller.
      
      - Allow review button only if allow_comment in FS mode + redirect url
      
      'write a review' button in fullscreen mode must not be displayed if the course
      is not in allow_comment mode. Also, the url if this button was redirecting
      to slide view in non fullscreen mode. As no review can be done from this point,
      the url redirect now to the course view.
      
      - Fix fullscreen slide height.
      
      - Fix all slides view per category pager and page rendering
      
      Since the introduction of categorized data dictionnary that is given to the template,
      if a category is empty, it's rendered anyway, which is good for publisher,
      to quickly see all existing categories.
      But other users should not see those empty categories.
      
      Also, if the slides from a course are filtered (with View all button) by category,
      all the slides should be reachable, using the pager. This was not the case as
      categorized slides dictionnary returned no slides if page <= 2.
      (as bound of array was from offset to limit and offset and limit were equals)
      The number of slides per category must be overwritten if search category is activated,
      to see more than the 4 first slides of the category.
      
      Finally, if search category is activated, only the target category should be displayed,
      and not the others, for performance reason.
      
      - Show 'not verified' next to user's name if user karma = 0
      
      Instead of using the email_validation_done flag. As email validation is only used
      to offer the user some karma in order to be able to interact in the forum or eLearning.
      If the user already has karma, he is already considered as active and 'verified'
      
      - Correct URL of certification in FS mode
      
      Task ID : 1941250
      Closes PR #31567
      
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      a13e33dd
    • David Beguin's avatar
      [REF-FIX] website_slides : review and fix access, vote, comment and rating · 12fd6a01
      David Beguin authored
      Commit 5798ca28 was assuming the vote and
      comment access on slide was related to is_preview mode and was, consequently,
      depending on each slide separately.
      
      In fact, it's not because a slide is in preview mode that the user has the right
      to vote for this slide. He must be course member to interact with this preview
      slide, even if he has the right to read it.
      
      So the vote and comment right are now computed at the level of the course,
      and apply to all the slides of this course.
      
      This commit also reviews and apply fixes on review - rating access.
      
      Here are the applied rules regarding vote, comment and rating on course and slides:
      
      A user can review a course:
      - If allow_comment is activated on the course AND
      - If the user is publisher OR
      - If the user has enough karma AND is member of the course.
      
      Note : if the rating is not allowed on the course, not only the button
      to review must be hidden but also the entire rating composer.
      
      A user can vote and comment a slide:
      - If allow_comment is activated on the course AND
      - If the user is publisher OR
      - If the user has enough karma AND is member of the course.
      
      Other fix applied is this commit :
      - Avoid crash when no promoted slide : When going on course homepage
      (documentation type), if no promoted slide, we got a internal server error.
      
      Task ID: 1941250
      Partial revert of commit 5798ca28
      PR #31567
      12fd6a01
    • sri-odoo's avatar
      [IMP] website_profile: merge ranks/badges pages · 8ecff655
      sri-odoo authored
      Merge ranks & badges pages. This commit adapt the final page
      layout, controllers and templates.
      
      Added the badge category filter. If used in url parameter, hide ranks and show
      only the badge part of the page, filtered on matching badge_category.
      
      Task ID : 1941250
      PR #31567
      
      Co-authored-by: @stefanorigano
      Co-authored-by: @dbeguin
      8ecff655
  10. Mar 18, 2019
  11. Mar 17, 2019
  12. Mar 15, 2019
    • William Henrotin's avatar
      [FIX] delivery: free_over management · 150d7730
      William Henrotin authored
      
      The commit 9a9cb9e refactored the way delivery carrier price
      are added on sale orders. The management of free delivery price
      was not taken into account past then.
      This commit put the free price message directly on the sale order line
      and on the wizard. The carrier price is showed on the wizard but is 0 on
      the SO.
      
      Task : 1943480
      
      closes odoo/odoo#31315
      
      Signed-off-by: default avatarpimodoo <pimodoo@users.noreply.github.com>
      150d7730
  13. Mar 18, 2019
  14. Mar 19, 2019
    • Robot Odoo's avatar
      [FIX] lunch: make it work on mobile · b07dfedb
      Robot Odoo authored
      
      This module didn't worked on mobile: user cannot select the products or
      see their cart.
      
      This commit reworks the LunchKanbanWidget template and introduces a
      dedicated template for mobile. This template introduces a button at the
      bottom of the screen to toggle the "cart" widget on mobile (hiding it by
      default).
      
      It tries to make the best use of the existing Bootstrap classes allowing
      to have a more responsive layout and reducing the custom CSS required by
      this module (both in desktop and in mobile).
      
      This commit adds a decent JS tests-suite (mobile & desktop) to this
      module as the existing one left substential parts of the UI untested
      (opening wizard when clicking on a kanban record, cart's lines content,
      clear cart button, widget structure and content based on the state...).
      Those tests are also less based on DOM nodes order/tag names and use
      instead dedicated classnames.
      
      It also modifies the LunchKanbanRecord click handling to had a dedicated
      event handler instead of overriding the default _onGlobalClick() and
      make it more testable.
      
      Finally this commit also remove unused code.
      
      Task ID: 1945032
      
      closes odoo/odoo#31428
      
      Signed-off-by: default avatarAdrien Dieudonné (adr) <adr@odoo.com>
      b07dfedb
    • Pierre Paridans's avatar
      [FIX] lunch: make it work on mobile · bdc0b4b8
      Pierre Paridans authored
      This module didn't worked on mobile: user cannot select the products or
      see their cart.
      
      This commit reworks the LunchKanbanWidget template and introduces a
      dedicated template for mobile. This template introduces a button at the
      bottom of the screen to toggle the "cart" widget on mobile (hiding it by
      default).
      
      It tries to make the best use of the existing Bootstrap classes allowing
      to have a more responsive layout and reducing the custom CSS required by
      this module (both in desktop and in mobile).
      
      This commit adds a decent JS tests-suite (mobile & desktop) to this
      module as the existing one left substential parts of the UI untested
      (opening wizard when clicking on a kanban record, cart's lines content,
      clear cart button, widget structure and content based on the state...).
      Those tests are also less based on DOM nodes order/tag names and use
      instead dedicated classnames.
      
      It also modifies the LunchKanbanRecord click handling to had a dedicated
      event handler instead of overriding the default _onGlobalClick() and
      make it more testable.
      
      Task ID: 1945032
      bdc0b4b8
    • Robot Odoo's avatar
      [MERGE][IMP] website_slides_survey: handle certification re-enroll/purchase flow · 7e35c40c
      Robot Odoo authored
      
      Task #1945036
      
      Purpose
      ======
      
      If the user fails his last attempt at a course certification, we remove him from
      the members of the course (and he has to enroll again).
      He receives an email in the process notifying him of his failure and suggesting
      he enrolls to the course again.
      
      The purpose is to have a 'certification flow' where the user can re-purchase the
      certification when they have failed it.
      
      This could lead to some issues if the course containing the certification also has
      other slides with content because the user will not have access to them after failing.
      This also prevents configuring courses with multiple certifications since the membership
      will be removed at the first failure.
      
      These use cases are considered "non standard" by the business and are thus not handled
      in the code. We assume that users will configure their courses "correctly".
      
      closes odoo/odoo#31484
      
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      7e35c40c
  15. Mar 18, 2019
  16. Mar 14, 2019
  17. Mar 19, 2019
  18. Mar 18, 2019
Loading