The event registration form is made up of a public widget that
instantiates an internal normal widget. All public widget are
automatically destroyed when entering in edit mode as well as the widget
it created. Therefore, it's main element is removed from the DOM when
the widget is destroyed. Here, we're detaching the main element from the
internal widget before the widget is destroyed so that we avoid to
destroy his main element from the DOM when entering in edit mode.

task-2210733

closes odoo/odoo#48215

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Courtesy of Federico (fza)

closes odoo/odoo#52392

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

According to http://cpe.sunat.gob.pe/sites/default/files/inline-files/anexoV-340-2017.pdf


The right tax for the FRE tax should be 9996 and not 9997

closes odoo/odoo#52294

Signed-off-by: Josse Colpaert <jco@openerp.com>

Save in l10n_ar_vat field the cleaun up CUIT number (without spacings,
dashes and points.

This way we can use it so sent it properly as a number to AFIP.

closes odoo/odoo#51135

Related: odoo/enterprise#10553
Signed-off-by: Josse Colpaert <jco@openerp.com>

The `get_string` method from the `pyusb` package has changed its
signature after version 1.0.0b1 so we used to force the IoT Box to use
this version to avoid an error. The problem is that version 1.0.0b1
has dependencies that raise DeprecationWarings in Raspbian Buster.
We then want to update the version of pyusb that is installed on the
IoT Box in 14.0.

As the Driver might be loaded to old versions of the IoT Box as well
as new ones, we need to check what version of the package is present
on the IoT Box before calling `get_string`.

This check will be removed in 14.0, as people will have to use the
latest version of the IoT Box.

closes odoo/odoo#51230

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

Steps to reproduce the bug:

- Let's consider a customer company partner P
- Let's consider, P1, a child partner of P
- Create a SO for P1
- Archive P1

Bug:

The SO count in the smart button Sales of P was 0 instead of 1

opw:2267828

closes odoo/odoo#52324

X-original-commit: 31ded31d
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

- Create a lead and set a language
- Convert to opportunity and choose 'Create a new customer'

The new customer created doesn't have the language of the lead set.

This is more logical to set the same language to the new customer.

opw-2270321

closes odoo/odoo#52342

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Cause

	When kit BOM line quantity is equal to zero in a sale order, it raise error
	because trying to divide bom_line_data['qty'] / bom_line_data['original_qty']
	when computing kit quantities.

Solution

	As BoMs allow components with 0 qty, a.k.a. optionnal components,
	we simply skip those to avoid a division by zero.

Cherry-pick of #38890

opw-2262540

closes odoo/odoo#52192

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Before this commit, a user with attendance administrator rights can see
the attendances of all users of all companies and not only the companies
he is allowed.

Now, the administrator will only see the attendances of the users of the
companies he is allowed.

opw-2263577

closes odoo/odoo#52339

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

- Add a product => 1 unit is added
- Try to change the quantity to 1.2

The 'Decrease Quantity' pop-up appears when pressing 1.

opw-2263913

closes odoo/odoo#52245

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Before this commit, `self.env.user.company_id.id` may represents different company from the current company based on context.

In this commit, we use correct company based on contextual company.

Follow up on b39173a8

closes odoo/odoo#52288

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

closes odoo/odoo#51918

Related: odoo/enterprise#10774
Signed-off-by: Josse Colpaert <jco@openerp.com>

closes odoo/odoo#51509

Signed-off-by: Josse Colpaert <jco@openerp.com>

closes odoo/odoo#52290

X-original-commit: 81949e68ebd731b786194b9ee81d69c42d566e74
Signed-off-by: Alex Tuyls <alt-odoo@users.noreply.github.com>
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Before this commit:
Traceback when printing invoice QR-bill after setting the company and partner with correct switzerland bank configured.
Note that the fields changed here were defined in version 12 but do no longer exists in version 13.

OPW-2264923

closes odoo/odoo#52283

Signed-off-by: Richard Mathot (rim) <rim@openerp.com>

Before this commit, the Start now button uses the first slide (a content
slide or a category slide). If the first slide was a category slide then
an error was raised.

Now, only content slides are used to start the survey.

opw-2265250

closes odoo/odoo#52263

Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

In case a third-party module adds `company_id` on `product.product`, the
SQL query becomes ambiguous and crashes.

Closes #52024

closes odoo/odoo#52112

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Co-authored-by: Nicolas Martinelli <nim@odoo.com>

Issue

	Step done with "CRM" since main kanban view can be
	grouped by 'res.partner' model:

	- Install "CRM" app
	- Go to crm and group by "Customer".
	- Add a Column.

	Traceback is raised.

Cause

	Wrong "default_type" in context ('opportunity' in this case)
	when creating new kanban stage and grouped by "Customer".

Solution

	On "default_get" for "res.partner", if "default_type" is in
	context and not in 'type' selection choices field; then
	remove it from context.

Cherry-pick of #47723 in 12.0

opw-2256905

closes odoo/odoo#52272

X-original-commit: e5796429
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Consider a context-dependent field, and successively access it on a
recordset with different contexts.  On the first context, the field is
correctly computed in batch.  After that, the field is always computed
one by one.

The bug is in the method that determines which records in a given set
have no value in cache.  On the first context, the cache is empty for
the field, so all records are returned.  After that, the method
considers that all records have a value in cache: they do, but for
another context key!  Simply using the context key when looking up the
cache fixes the issue.

closes odoo/odoo#52266

Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
Co-authored-by: Xavier-Do <xdo@odoo.com>

- A custom COA could be passed as parameter.
- Merge the invoice setup to the generic suite like it is in master.

closes odoo/odoo#52140

Related: odoo/enterprise#10855
Signed-off-by: Josse Colpaert <jco@openerp.com>

The *Reload File* import functionality stands on an undefined behavior
or the HTML File API. The API is not clear about what should done in
case the underlying file change on the filesystem after it has been
imported in the browser.

It turns out the actual behavior vary among browsers and even among
OSes. The *Reload File* button only works as intended when importing
files via Chrome on Linux.

In other cases, the browser may refuse to send the file or may send it
in a corrupted HTTP request. Such malformed request is rejected in the
best cases by the backend web application but there is chance it hangs.

Security-wise, this problem is not much likely to happen as it requires
an authenticated user with importation privileges to perform the
operation. When it comes to the severity, it is possible to exhaust the
available workers by forcing every one of them to hang.

As there is a security impact, we decided to disable the *Reload File*
functionality.

Steps to reproduce
------------------

1) Import a CSV or XLSX document in any model.
2) Wait for the data visualization to come back to the browser.
3) Change the file on disk to
  a) remove a few lines
  b) add a few more lines.
4) Click the Reload button.

Wrong `size` attribute on Firefox.
----------------------------------

Impact: Firefox

The advertised `Content-Length` HTTP header in the POST request is
a) *greater* than the actual body length. The backend web application
   hangs on a `socket.recv` like function waiting for those missing
   bytes.
b) *smaller* than the actual body length. The request is truncated
   and futher processing is impossible.

The malformed request should have been detected and reported by the http
web application as requested by the HTTP/1.1 spec [1]:

> When a Content-Length is given in a message where a message-body is
  allowed, its field value MUST exactly match the number of OCTETs in
  the message-body. HTTP/1.1 user agents MUST notify the user when an
  invalid length is received and detected.

Mitigating the issue is possible using nginx as reverse-proxy. The
connection is closed after one minute if data are missing.

Invalid `ERR_UPLOAD_FILE_CHANGED`
---------------------------------

Impact: Chrome on Windows

Chrome prevent sending the XHR due to a `ERR_UPLOAD_FILE_CHANGED` error,
this error should only happens when the underlying file content have
been changed the second before the request. On Windows, the error
is triggered as soon as the file have been changed, not considering the
modification time.

[1]: https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html

 Section 4.4

opw-2252440

closes odoo/odoo#52246

X-original-commit: aacd95a8ec0952d2b04432aebd1cd469c19f2618
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
Signed-off-by: Julien Castiaux <Julien00859@users.noreply.github.com>

website visitor testing had some flaws.

task-2079873

closes odoo/odoo#38513

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Go to Reconciliation Models > Invoices Matching Rule
Set the parameter 'Amount Matching'
Set 'Partner Is Set & Matches'
Save
Edit
Unset 'Partner Is Set & Matches'

'Amount Matching' will switch to invisible but is not disabled.
Removing the invisibility check so that the field is always
editable

This also reverts commit 61f1ca63.
Due to a misunderstanding this solution was chosen while the real
intention was to always show the field

opw-2261134

closes odoo/odoo#52153

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Steps to reproduce:
- Create a bank journal, with "post at" = "Bank reconciliation"
- Create a new expense paid by "Company"
- Create a report and confirm

Current behavior:
- the bank move is posted

Expected behavior:
- the bank move is not posted (and i will posted during the bank reconciliation"

closes odoo/odoo#51650

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Installing sale_margin module on a db with a lot of sale.order was impossible.

This commit significantly improves performances.
Went from many hours (forecasted) to 15 minutes on a db with 300k orders

For sale.order:
  - Duplicating logic between edit mode and non edit mode
  - Edit mode logic stays the same as before
  - Non edit mode uses read_group to speed up the computation

closes odoo/odoo#52010

X-original-commit: 554fb1e3
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

https://github.com/odoo/enterprise/commit/7d17dad678361f161c259eddd45d9b5186941bd0

 fixed the sign used for cash basis entries in the tax report, but this change had to be reflected on the tax_audit computed on cash basis entries as well.

Before that, cash basis entries never were made on sales journals, and their move lines never had a refund-typed invoice_id. So it means those factors, when present on the original invoice, never influenced the audit string computed for cash basis entries. This was obviously wrong.

closes odoo/odoo#52187

X-original-commit: cecddfb6301138db8e7a8a9ec4a044959b990d82
Related: odoo/enterprise#10865
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

The module l10n_generic_coa was installed in every single case when
loading a new db from the console because the country is US by default.
If we have a `-i l10n_*`, we dont need to install another CoA based on
the country.
The fact that it is installed was messing with the demo data because we
were searching for a type of account not necessary present in the CoA
installed on the company.

closes odoo/odoo#52117

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Issue

	- Install "Website" app
	- Go to Website->Configuration->Redirect
	- Click on Create
	- Set "Action" to 308
	- Set "Url to" to nothing or any url
	  with no leading '/'

	The DB is broken.
	Error in 'werkzeug' python library.

Cause

	Missing leading slash in url or empty url.

Solution

	Add a counstraint to check if url is valid (not empty and
	with a leading slash).

opw-2266935

closes odoo/odoo#52132

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

When owner and/or packages are activated, a MO doesn't give the
possibility to set the proper owner/package of the reserved products.

We add the fields in the view, and set them as optional.

Important note: this will only work with the move lines created during
the reservation. If additional move lines are created manually, this
won't work. Indeed, it would be necessary to add both fields to
`raw_workorder_line_ids`, hence to `mrp.abstract.workorder.line`.

opw-2260450

closes odoo/odoo#52042

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Inverse fields are stored in a `set` and `set` is not ordered. It depends on the memory address of its elements which change each time the registry is rebuilt.

Inverse `_set_move_ids_without_package` set the .move_lines on the record
Inverse `_set_scheduled_date` set the scheduled_date on the move_lines

If `_set_scheduled_date` is called first, then the record doesn't contain any move_lines, the scheduled date is ignored and set to default (now)

This fix ensures that if a scheduled_date is set, it is applied after `_set_move_ids_without_package`.

OPW-2212391

closes odoo/odoo#51502

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

The quotation template edition allows to save and use the description
of an optional product.

But when a quotation template is set, the description of optional
product is lost so we the optional product description was never used.

opw-2260457
closes #52133

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Added `future_driver_id` in the 'Changed Driver' subtype.

OPW-2242321

closes odoo/odoo#52087

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

PR https://github.com/odoo/odoo/pull/49964 fixed manual payment flow
but broke automatic payment flow.

This commit should allow both by raising the exception only for
manual flow, giving only an error for automatic flows.

FW-PORT of https://github.com/odoo/odoo/pull/50908/commits/46e977a21743644a2e98344e3491f0dd6fcbe892



closes odoo/odoo#51948

Signed-off-by: Toufik Benjaa (tbe) <tbe@odoo.com>

We found an error by trying to post journals entries from an expense with a use_document journals.
Add new constraint that only let the user to create invoices in use documents journals, it can not create account.move of type entry

closes odoo/odoo#50425

Signed-off-by: Josse Colpaert <jco@openerp.com>

Issue

	When pressing UP or DOWN arrow in search bar with empty text a traceback
	occurs.

Step to Reproduce

	- Install website_sale "eCommerce" application
	- Go to Website
	- Go to Shop
	- Click in Search Bar
	- Press Up or Down Key

Cause

	When no text is entered in the search bar, the $menu is undefined
	so trying to access children causes the error

Solution

	Test that $menu is defined prior to try accessing its children

task id-2252923

closes odoo/odoo#51920

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

The accounts of these taxes were inverted for the invoices and refunds.
now are properly configured.

closes odoo/odoo#51917

Signed-off-by: Josse Colpaert <jco@openerp.com>

Steps to reproduce the bug:

- Go to settings => Purchase
- Enable Dropshipping
- Go to Inventory => Configuration => Warehouse Management => Operations Types
- Open Dropship
- Remove the sequence (field is not required)
- Go to Inventory => Master Data => Products
- Let's consider product P (Inventory tab: Check "Dropship" and "Buy" and vendor V as supplier)
- Create Quotation Q with customer C and product P
- Confirm Q (a PO has been created for V)
- Confirm PO

Bug:

A traceback was raised because the sequence was not defined on Operation Type dropship

opw:2263799

closes odoo/odoo#52049

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Issue

	- Have IE 11 or not chromium-based Edge
	- Install Contacts
	- Add a salesperson on any contact
	- Save
	- Try to remove the salesperson with
	  the cross icon on the input
	- Save

	The value comes back

Cause

	We do not handle this feature in dropdowns

Solution

	Remove the dropdown cross icon

OPW-2262749

closes odoo/odoo#52071

X-original-commit: cdb07237
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>