If there isn't any customer set on the task, the current behavior
will display 'Hello False,' in salutation rating email as intro.

This commit will fix it by display only 'Hello,' if there isn't
any customer set.

Task ID 2238816

closes odoo/odoo#50366

X-original-commit: e7b71c6e497aa8d823181440333f371f1da5ade8
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

   
limit identification type search result in one
record to avoid apparent singleton error

closes odoo/odoo#50380

X-original-commit: fe62fbc5
Signed-off-by: Josse Colpaert <jco@openerp.com>

Steps to reproduce:
- Create a second company
- Enable this company only
- Create a new company
=> Access error is raised because the `intercompany_user_id` is
OdooBot by default and OdooBot's partner cannot be read from
other companies. Hence, the company creation fails.

Like all other internal users/partners, OdooBot's partner should
be shared across companies, even if its user is inactive.

Task 2157039

See also 2390ba60

Task 2157039

closes odoo/odoo#50372

X-original-commit: 379d14d4aa7862176fb7e3f79292a1228c254aa9
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Signed-off-by: lul-odoo <LucasLefevre@users.noreply.github.com>

In the case of an <ol> in an <ol> we would have something like:

```
1.
   1.
   2.
3.
```

because the sublist itself in version of summernote.org we are using
is a list item, so it takes one extraenous item.

With this changeset we have something that makes more sense:

```
1.
   1.
   2.
2.
```

Because there are tons of use case of different selection of list level
and indent or outdent, this commit also simplify outdenting (eg. now we
outdent all the element of the same level than the first indented).

opw-2185406
closes #48194

closes odoo/odoo#50352

X-original-commit: bbf4ad7d
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Before this change, the SSF would read from the record after
creation but wouldn't do so after a write.

This doesn't conform to the behaviour of the web client (which does a
read() after saving a form), and means the effect of field
inverses (when the dependencies of a writable field are also in the
form) or overrides to write wouldn't be visible afterwards.

It's always possible to just re-create the form from scratch, but the
intention has always been that the form would work correctly after a
save.

closes odoo/odoo#50363

X-original-commit: 45398c09
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

Since the commit https://github.com/odoo/odoo/commit/46cf65d68e9c13193dff4b563b9b0bbb2199dfc1


when help is not defined in action then nocontenthelp is displayed as
[object, object] due to the desciption passed from renderder of the
pivot view.

So in this commit while calling the NoContentHelper pass the
descitption as string instead of jquery element.
we can use the t-value in template but that string will create
issue for transalation so pass the desctiption from the pivot render.

closes odoo/odoo#50347

Taskid: 2240167
Closes: #49859
X-original-commit: c7cc672aba669175280d619ad39b14daefd7733f
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

This commit fixes the crm.lead form view to always display UTM information when
the lead is of type "opportunity".

Before this change, the UTM information (as well as the 'referred' field) were
only displayed for members of the 'base.group_multi_company', which did not
make sense on a functional point of view.

The 'company_id' field however, that is in the same form group, is still
correctly displayed only for members of the 'base.group_multi_company' group.

Task 2237318

closes odoo/odoo#50337

X-original-commit: d5b07b7c
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Signed-off-by: awa-odoo <awa-odoo@users.noreply.github.com>

Handling of escapes (`\`) was performed during evaluation rather than
parsing, so strings in the AST stored the escaped form (rather than
the proper one), and _formatAST had to mess around in order to try and
get it back into a semblance of relevance (especially as the AST would
store the escaped string without delimiters).

Fix: perform the escapes handling (aka normalisation) during
tokenization where it belongs. This means the AST formatter can now
just JSON.stringify the data. Until and unless we decide to produce a
cpython-compliant
repr (https://github.com/python/cpython/blob/0169d3003be3d072751dd14a5c84748ab63a249f/Objects/unicodeobject.c#L12902-L13006

)
which is unlikely.

closes odoo/odoo#50236

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

Before this commit, if a many2X field with a big comodel was added
in a search panel, the view using it would crash. For instance that
problem occured in the kanban view for hr.job, where res.users
appears as the comodel for the field user_id.

Now, we fix an arbitrary limit of 200 to the numbers of values to fetch
for each many2X fields in the search panel. This avoid the problem
mentionned above.
Furthermore, in case the limit is attained for a field used
as select="one", the values are displayed without being hierarchized.
Indeed the limit can leads to gaps in the knowledge of the hierarchy
and consequently to a bad representation of it.

Task ID: 2154668

closes odoo/odoo#50334

X-original-commit: 8d57153b
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Commit 8c1bb22e forgot to take into
account migrations, during a migration it is possible that some modules
need to be uninstalled because the target version may have removed /
moved them and since during a migration all modules are set `to
upgrade`, the previous condition made this impossible for migration
scripts that use the ORM for module uninstalls (not Odoo's case, mind
you)

With this commit it is again possible to uninstall modules from a
migration script during a migration.

closes odoo/odoo#50322

X-original-commit: a7c90a6d
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Signed-off-by: Adrian Torres (adt) <adt@odoo.com>

- Install PoS and "l10n_fr_pos_cert";
- Erase the country in the current company;
- Open a PoS session;
- Click on any product.

Before this commit, a JavaScript traceback was raised: TypeError: Cannot read property
'code' of null.

Now, an error message is raise, that informs the user that the company don't have country
setted.

opw-2241993

closes odoo/odoo#50320

X-original-commit: 5ed4b0cb
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

Update to the version **1.0.7** of the Owl framework.
Some code conflicting with the new behaviour of `mount(target, { position: self })` has been slightly tweaked to work as expected.

closes odoo/odoo#50240

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Keep a reference to the 'mount' method arguments to ensure that components will
be mounted on the same node and in the same way they were originally mounted.

This fix is related to the following changes in the Owl framework:
https://github.com/odoo/owl/commit/b4ad14edc03d4fb2d7a4622c6c1f63f6df5b4541



Co-authored-by: Julien Mougenot <jum@odoo.com>

account.fr.fec model needs to have write access as it
explicitely calls write() on its records.

closes odoo/odoo#50081

X-original-commit: f02a783be445238b9497ebd55838143945c99d2d
Related: odoo/enterprise#10162
Signed-off-by: Josse Colpaert <jco@openerp.com>

Purpose
=======
We should not be able to duplicate the link trackers (as it
makes no sense from a functionnal POV).

Task-2090344

closes odoo/odoo#50303

X-original-commit: c236b976
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

[FIX] account: don't raise an error when using account controls together with section/notes lines on invoices

Section and note invoice lines are now account.move.line objects with a distinct value in display_type field. When restricting the use of accounts on a payable/receivable journal and making an invoice in it with at least one section or note, and only using legal accounts, it always failed, as the note/section account was empty, hence not in the allowed accounts.

closes odoo/odoo#50297

X-original-commit: 28cd50f203c019b78f55fc16120af81c901caef2
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

Steps to reproduce:
- install account
- print any invoice

Previous behavior:
the css rule and classes are ignored on the total table

Current behavior:
displays as intended

This PR fixes two issues:
1/ class attribute was not taken into account anymore ( table-sm )
2/ page-break-inside didn't work

closes #48682
opw-2229181

closes odoo/odoo#50259

X-original-commit: d8bfae0a
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

X-original-commit: b9d6b548

Purpose
=======

For a tag to be displayed on a kanban card, it needs to have a color set.
We won't be changing that behaviour, since it would mean having
two options > the color, and whether or not to show it in the kanban

The purpose of this task is to set a color on new tags to make the user
save a bit more time, set a color for him as he might not find the feature,
and make sure the tag will be on the kanban cards.

Specification
=============

For each of the following models, at creation, set a random integer between
1 and 11 in field 'color'

Models:
res.partner.category
crm.tag
project.tags
hr.applicant.category
helpdesk.tag
hr.employee.category
event.track.tag
mrp.eco.tag
repair.tags

closes odoo/odoo#49967

Taskid: 2234527
Related: odoo/enterprise#10112
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Impacted modules: account_analytic_default, crm, event,
hr_recruitment, maintenance, mass_mailing, project,
purchase_requisition, stock_picking_batch, website_slides

The default image displayed when the record is unassigned is
confusing, so we are removing it.

FP request
Task 2234524

closes odoo/odoo#49333

Related: odoo/enterprise#9834
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Currently, Some filters of the 'My Timesheets' menu do not make
proper sense So purpose of this task is to remove those filters
from the 'My Timesheets' menu.

In this commit, we remove the following filters from the
'My Timesheets' menu:
  -Employee
  -Department
  -My Timesheets
  -My Team
Also, rename the 'My Project' filter into 'My Projects' and that
filter is inside the my timesheet menu so also filter the line for
current user.

closes odoo/odoo#48663

Taskid: 2224472
Related: https://github.com/odoo/enterprise/pull/9564


Related: odoo/enterprise#9564
Closes: 48663
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

The population of res users was emptying the list of populated partner
ids.

The lunch.supplier population was crashing because no partner id was
present in the partner population registry to use as `partner_id` for
the generated lunch suppliers.

closes odoo/odoo#50266

X-original-commit: a2adc346906ee753df6d8e49caa4ee5381629695
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

* = mass_mailing, web_editor, website_crm, website_event, website_form,
website_forum, website_hr_recruitment, website_mail_channel,
website_mass_mailing, website_sale, website_slides

When an outdated snippet's option are activated we display a warning
in the left panel that inform the user about the potential
malfunctions.

To do so the snippet's template key is added to the snippet as
data-snippet.
If a snippet is "t-call" inside another snippet, it will need to use
t-snippet-call instead of t-call to have the key on himself.

Those unique keys are used on snippet selection to retrieve the
snippet's version in the left panel and compare it with the currently
selected snippet's version. Versions are describe with data-vcss,
data-vjs and data-vxml. If a snippet's key is not in the left panel we
consider that snippet as outdated.

Added some tests to ensure that t-snippet and t-snippet-call really have
their template key as data-snippet

Adapted the views to the data-snippet changes adding
data-snippet="tmpl_key".

Part of: https://github.com/odoo/odoo/pull/44569


task-2189669

closes odoo/odoo#50254

X-original-commit: 28a6cd49b6e87b75c2e70771e241c41778bf9e87
Related: odoo/enterprise#10236
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

The web_editor snippet_options were duplicated

Part of: https://github.com/odoo/odoo/pull/44569
task-2189669

X-original-commit: c8ec4ca2bb12e3a65665f5bdd7ad079243e030bd

some s_btn snippets were not removed.

Introduce by: https://github.com/odoo/odoo/commit/4ca401a8556448d0ec1cf0e5e0f04de5fd602a1e

Part of: https://github.com/odoo/odoo/pull/44569
task-2189669

X-original-commit: 8575ef7186c2abfb2f562ccb1d98c1e3f622ed63

Commit 4497077f was intended to show address type for contacts without
company, but we should still keep it invisible for company contacts.

closes odoo/odoo#50260

Signed-off-by: Alex Tuyls <alt-odoo@users.noreply.github.com>

When the PostgreSQLHandler is used to store some logs in the ir_logging
table of a database, the log record pathname is truncated to keep only
the relevant part of the path. In some circumstances, the path is
wrongly truncated, leading to totally invalid paths.

e.g.: When using an addon-path like `/data/build/enteprise` the removed
part correspond to the length of `/data/build/odoo/`. The resulting path
is `prise/....`.

With this commit, the full path is kept.

This commit is mainly a fix for the runbot logs and should not have an
impact on existing databases.

closes odoo/odoo#50246

X-original-commit: f3c96aa2
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

Part of task-2211013 which optimizes performances, this PR focuses on `/blog`, `/blog/post` performances.

For a database with 20 blog posts & 20 tags, based on 50 tests, this is the optimistic stats:
```
| /blog                 | Query |   Time | Remaining Time |
| --------------------- | ----- | ------ | -------------- |
| Before                |   136 |  0.055 |          0.200 |
| Now                   |    26 |  0.015 |          0.090 |
```

/blog/post from 60+ query to less than 30

task-2211013

closes odoo/odoo#48552

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Followup of 73dc42d6: catchall or bounce alias reset to the same value
should not raise an UserError. This happens for example when reinitializing
mail module.

Also enable batch write again.

closes odoo/odoo#50248

X-original-commit: 00709025a9436b35744908481c5e5faa1e3ef655
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Avoid messing up with style by translating it

closes odoo/odoo#50251

X-original-commit: 6151757a8357693e189ff1ab31ece5efdbac65d6
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

The name was autogenerated to "XMas Promo 2020-04-27 09:15:11" (which
is rather technical)
Make a static one to avoid changing it everytime the translations are rexeported

X-original-commit: 52a630eb28ead7b21f39dccbbff628ea594c7099

Add in one shot all the states (active or not) for all keys of customize_view

task-2211013

Co-authored-by: Romain Derie <rde@odoo.com>
Co-authored-by: Jeremy Kersten <jke@odoo.com>

Followup fix of #48912

The multi-company group should be given to users if they have access to
multiple companies and do not already have this group.

closes odoo/odoo#50233

X-original-commit: 0c721d90c5cd428ef8d51f195da8e02ee91d4364
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

- In a res.partner;
- Schedule activity;
- Choose 'meeting' as activity;
- Set a summary : 'test summary';
- Open Calendar;
- Chose a date and an hour;
- Edit the meeting;
- Add a description with a line break;
- Save the meeting;
- open the res.partner view;

Before this commit, the note on the planned activity lack the line
break.

Now, the note in the planned activity has the same output as the
description of the calendar meeting.

opw-2236838

closes odoo/odoo#50226

X-original-commit: 2e9cc92fb45f9328c45520275ab11c7a486a2590
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

To backport in v13
+ check for optimistic lock

task-2211013

Co-authored-by: Romain Derie <rde@odoo.com>
Co-authored-by: Jeremy Kersten <jke@odoo.com>

Avoid extra call to session_store.save if we don't touch to the session
Use an explicit name to storage post_viewed in the session

task-2211013

Co-authored-by: Romain Derie <rde@odoo.com>
Co-authored-by: Jeremy Kersten <jke@odoo.com>

task-2211013

Co-authored-by: Romain Derie <rde@odoo.com>
Co-authored-by: Jeremy Kersten <jke@odoo.com>

task-2211013

Co-authored-by: Romain Derie <rde@odoo.com>
Co-authored-by: Jeremy Kersten <jke@odoo.com>

Http routing and websits module will already do it later and handle the case.

The only ModelConverter used that will be impacted is:
   /web_editor/attachment/<model("ir.attachment"):attachment>
that is a json controller called with eisting data

task-2211013

Co-authored-by: Romain Derie <rde@odoo.com>
Co-authored-by: Jeremy Kersten <jke@odoo.com>