Skip to content
Snippets Groups Projects
  1. Feb 06, 2019
    • Jérome Maes's avatar
      [IMP] website_slide: allow to edit comment · e8477974
      Jérome Maes authored
      When a portal user post a message to review a channel, we
      want to allow him to edit its own comment and rating.
      This commit modifies the special check access method in
      portal to extract the security check and reuse it to
      allow user to update its comment on slide.channel only.
      We decided to reuse existing widget (new rating popup
      composer) to do the message modification.
      
      Task-1902304
      e8477974
    • Jérome Maes's avatar
      [FIX] website_rating: display label when rating · cd3b6026
      Jérome Maes authored
      This commit fix the display of a label when the user add
      a review; when selecting desired stars, the label corresponding
      to the star is displayed in a badge.
      The bug probably comes from the update to bootstrap 4.
      cd3b6026
    • Jérome Maes's avatar
      [IMP] website_slides: allow to rate slide channel · e97b40ba
      Jérome Maes authored
      This commit allows user to rate a slide channel: using the new Popup
      Rating Composer, users having access to the slide channel can submit
      a rating with a comment. Then, lower in the page, they can see the
      ratings of other users.
      
      Task-1902304
      e97b40ba
    • Jérome Maes's avatar
      [REF] portal: posting message with signed token · 17ac041b
      Jérome Maes authored
      Before this commit, it was possible to post a message on a document
      the user has no access, thanks to a token. In addition to this token,
      if a hash (signed token with a partner id), the author_id of the message
      was forced.
      This commit change a little bit that logic by distinguish 2 cases:
      1/ Token only: anyone with the token can post a message on the document. If
        the user is not logged (public with token), the author_id will be the
        customer of the document (or the public user). This case is moslty used
        for business document, through the portal or with the "share link" for
        instance.
      2/ Signed token: user has no write access to the document, but can post a
        message on it. The user have to be logged, as the token is signed with its
        identifier. The goal here is to avoid leaking the access token's document
        to all visitors. This case is mostly used for public content, such as blog
        posts, slides, ...
      
      The token case was already existing. The second is now working with this
      commit. To do so, it was required to
      - move `_sign_token` from the portal mixin to mail.thread.
      - transfering 'pid' and 'hash' parameters from the controller to template
      to js widgets.
      
      This commit also change the `_message_post_helper` signature by making
      the 3 first parameters required, as to post a message you need at lease
      res_model, res_id and the message body. The optional argurments and kwargs
      are here to check the bypassing access rights mecanism.
      
      Task-1902304
      17ac041b
    • Jérome Maes's avatar
      [IMP] portal,website_rating: new popup composer to submit rating · 4cb228d8
      Jérome Maes authored
      Rating document available on a website will become more common, but
      we want to do it with different UI widget. This commit introduces a
      new "popup rating composer": the idea is the rating average is
      displayed with stars, and when clicking on it, a popup with the
      composer appears. The user can so submit its review.
      
      To do so, we factorize the Portal Composer into a dedicated widget
      (instead of natively inside Portal Chatter).
      
      Task-1902304
      4cb228d8
    • Jérome Maes's avatar
      [IMP] rating: add rating average on mixin · 8c840f75
      Jérome Maes authored
      This commit provides 1 more field on the rating mixin: the average of
      the ratings of the document. Before that, the only way to get the
      average was to call `rating_get_stats` record per record.
      As we are on a mixin, this new field is not stored to avoid recomputation
      each time a rating is added. To improve performance, we decided to
      compute `rating_count` and `rating_avg` in one `read_group`.
      
      This commit also set an extendable method to get the domain of the
      rating to include in those statistics computation, called `_rating_domain`.
      This way, each model inheriting the rating.mixin can define the subset of
      pertinent ratings.
      
      As consequence, this commit uniformized the way average is displayed:
      instead of taking the closer value to the 0.5 value, it only round it
      at 2 digits.
      
      Task-1902304
      8c840f75
    • Jérome Maes's avatar
      [IMP] website_slides: provide search bar on channel · 1ed3cb37
      Jérome Maes authored
      Visitor are now able to search a channel, based
      on the name or description with a search bar on
      the channel list page.
      
      Task-1902304
      1ed3cb37
  2. Feb 05, 2019
  3. Feb 06, 2019
    • Nikunj Ladava's avatar
      [IMP] purchase: Set supplier currency on product supplier info · 6f602437
      Nikunj Ladava authored
      - if currency is set on vendor, and set that particular vendor to product, the currency will not being changed by vendor's currency.
      -  after this commit currency in pricelist will be changed by the currency of the vendor
      
      This commit is related to Task ID 1826166
      
      closes odoo/odoo#24468
      6f602437
  4. Feb 05, 2019
  5. Feb 06, 2019
    • Robot Odoo's avatar
      [MERGE] website, *: improve CSS edition usability + add JS edition · 88e76a7f
      Robot Odoo authored
      * web, web_editor
      
      See sub-commits for details.
      
      Currently, when an user wants to edit the css of its website, he has
      access to lots of files and, in debug mode, to even more files. While
      the feature is nice for people who know what they are doing, a lambda
      person can easily break its website by changing the wrong files. Also,
      nothing warns the user that the files that are edited will never receive
      updates anymore (unless if they are reset). The goal is to prevent
      those behavior while still allowing the add custom css. Another goal
      is to be able to *add* custom javascript.
      
      Custom files created for the user:
      SCSS: user_custom_rules.scss, user_custom_bootstrap_overridden.scss
      JS: user_custom_javascript.js
      
      task-1919350
      
      closes odoo/odoo#29999
      88e76a7f
  6. Feb 05, 2019
  7. Feb 04, 2019
  8. Feb 05, 2019
    • RomainLibert's avatar
      [IMP] various: optimize _name_search · 6dbdfb9b
      RomainLibert authored
      In the overrides of _name_search we should avoid creating domains with
      huge lists of ids as it is inefficient.
      We can also make sure that we optimize the empty search as in this case
      the custom domain doesn't make sense, we can simply search on an empty
      domain and, thanks to the limit argument, still keep a fast query.
      
      Linked to task 1918906
      
      Thanks to @odony and @nseinlet
      
      closes odoo/odoo#30155
      6dbdfb9b
    • Robot Odoo's avatar
      [IMP] board,web: cleaner layout and kanban/pivot integration on mobile · 0b796871
      Robot Odoo authored
      This merge improves the Dashboard app and make it more usable on mobile:
      - The layout is fixed to 1 column.
      - Embedded Kanban view is fitted to its content and handle correctly empty columns.
      - Embedded Pivot view has smaller left indentation for readability purpose.
      
      Task ID: 1904747
      
      closes odoo/odoo#30467
      0b796871
    • Hetal Dhanak's avatar
      [IMP] project: Clean timesheet related fields on task form · b8f7df1a
      Hetal Dhanak authored
       -Moved the share Button to the dropdown Action menu as it was better suitable there.
       -moved sale order item field to extra info as it was better suitable there.
       -changed display of settings for project to give it organized look.
      
      Related Task ID: 1928422
      
      closes odoo/odoo#30310
      b8f7df1a
  9. Feb 04, 2019
    • Parth Choksi's avatar
      [IMP] base: Hide Save/Discard on Settings until there are modifications · 514d6fb9
      Parth Choksi authored
      
      Purpose
      =======
      
      It only makes sense to display 'Save' and 'Discard' if the user actually
      changed something in the settings.
      
      So after this commit, the 'Save' and 'Discard' buttons of statusbar in
      general settings will only appear when you make any changes.
      
      Also when there are changes, there will be a message shown that will tell
      the user that he/she has unsaved changes.
      
      The commit is related to Task ID: 1917637
      
      Co-authored-by: default avatarMohammed Shekha <msh@openerp.com>
      
      closes odoo/odoo#29726
      514d6fb9
  10. Feb 05, 2019
    • Mohit Ghodasara's avatar
      [IMP] various: prevent unlink of automated activity types · bbd64c22
      Mohit Ghodasara authored
      Purpose of this merge is to update main addons and set activity types used
      for automated activities as master data. This means they cannot be removed.
      Indeed those activity types are used in business flow to generate activities
      and removing them may break some flows.
      
      This commit is linked to task ID 1907970 and PR #29257.
      bbd64c22
    • Mohit Ghodasara's avatar
      [IMP] mail: improve usability of activities · 0db0e66e
      Mohit Ghodasara authored
      Purpose of the task is to improve the usability of activity types and
      activity scheduling.
      
      Another purpose is alto to protect some master data activity types by flagging
      them and preventing their deletion.
      
      Containing
       * make the activity type as master data so deletion will be prevented;
       * improve the usability of the activity type;
       * prevent the deletion of activity type which are used for automated activity;
       * change the usability of activity scheduling modal;
      
      This commit is linked to task ID 1907970 and PR #29257.
      0db0e66e
    • Darshil Trivedi's avatar
      [ADD] l10n_ie: Introduce localization for Ireland · 7214173f
      Darshil Trivedi authored
      closes odoo/odoo#23031
      7214173f
    • Vandan Shah's avatar
      [IMP] web: Improve calendar display when no partner is set on event · f757b5ec
      Vandan Shah authored
      Task:- 1906798
      PR:- #28669
      Co-authored By:-  Mohammed Shekha <msh@odoo.com>
      f757b5ec
  11. Feb 04, 2019
  12. Feb 05, 2019
  13. Feb 04, 2019
  14. Feb 01, 2019
  15. Feb 03, 2019
  16. Feb 01, 2019
Loading