When switching a invoice to a refund, the bank account to which the move
should be paid should be removed: while it (might) contain the partner's
bank account before, when becoming a refund it makes no sense to keep
the partner's bank account as the recipient.

closes odoo/odoo#43085

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

Before this commit, the invoice creation flow of a sales order checked
if the amount of the generated invoice was positive or negative - if it
was negative, then the invoice would be converted to a refund instead.

Unfortunately, this check was done before the move was actually created
\- meaning that the only way to compute the total of the move was to
multiply the quantities and unit prices of what was about to be included
in the move - ignoring taxes altogether. Since taxes would then be
applied during the move's creation, you could in fact have a refund that
ended up being negative because some products would end up with
different taxes.

A simple (although weird) example would happen if you registered a
down payment that was actually greater than the subtotal of your
quote (but lower than the total with taxes included).
Example:
Create a quote for a 100$ product with 15% tax
Register a downpayment of 105$ and validate that invoice
Invoice the rest:
 => you end up with a refund of -10$, while you should have a 10$
invoice instead.

Since the downpayment did not have taxes, the second invoice was
computed as being negative (100$ for the product - 105$ to deduce the
down payment), even though after the 15% tax gets applied on the product
(but not on the downpayment), the invoice is actually positive.

This commits moves the switch from invoice to refund to *after* the move
actually gets created, ensuring taxes are taken into account.

- Set the company currency in USD
- Create a pricelist in EUR
- Create a SO with the EUR pricelist
- Add a stockable product
- Click on 'Add Shipping'
- Select 'Normal Delivery Charges' which has a fixed price

The price is not updated according to the USD - EUR exchange rate.

This happens because no company is set on the delivery method, so no
conversion is performed.

We fall back on the order company, then the current environement
company.

opw-2159838

closes odoo/odoo#43119

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Issue

    - Install CRM for example
    - Add 41 leads
    - Create an activity on each of them

    Everything ok, load more shows up

    - Add another activity on one of them

    Load more doesn't shows up

Cause

    The uniquify method:
    https://github.com/odoo/odoo/blob/saas-12.3/odoo/models.py#L4187:#L4191



    Consider the second activity as a duplicate and removes it.
    So, in `web_search_read`:
    `len(records) <= limit` is `True` and we ignore all
    the others records

Solution

    Add `force_search_count` in the context when using this action
    to avoid uniquify to falsify the records length.

    I added the tree view for this action too. It improves UX.

OPW-2165455

closes odoo/odoo#43143

X-original-commit: 13ec3503fbfb5d3d2b1e824059737bd866a3a9f4
Signed-off-by: Jason Van Malder <jvm-odoo@users.noreply.github.com>

closes odoo/odoo#43136

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Closes #29363

closes odoo/odoo#42803

X-original-commit: 23f3282a
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

order_lines_layouted() can not work due to layout_category_id no longer existing

closes odoo/odoo#43110

X-original-commit: de7a717b195f93f94a9794029eb10b2fa92c8701
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

closes odoo/odoo#43067

X-original-commit: 6dacdefa
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

opw-2169164

closes odoo/odoo#43061

X-original-commit: 5432e24a990885a68df5a691388eb5c3584d9759
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

When accessing stock_barcode module to validate pickings, is not
possible to add floating point quantities for any localizaton which uses
',' as decimal separator.
The numeric field is now defined via browser tags <input="numeric"> to
make the numeric keyboard popup automatically on mobile devices
(commit 8f5840369b28962ab2be9edfce7331a836c3df22)
Adding the override to avoid further processing when the input
is already anumber

opw-2154657

closes odoo/odoo#42745

X-original-commit: 1ccc60deeb067f8d461d48cbf51719317c22cb90
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Some library versions are outdated since the release of Debian Buster.

With this commit the required libraries versions will match as close as
possible the versions available in the current Debian stable release
(Buster).

Also, the requirements were tested against a Windows Python 3.7 to
ensure that a "pip install -r" can be used without the need of a CPP
compiler.

As Babel format_time now returns 'HNE' (Heure Normale de l'EST) for Fr
locale instead of the zone offset, the test is adapted.

Finally the babel.dates is explicitely imported, otherwise the proper
import of this submodule is relying on a side effect.

closes odoo/odoo#40361

Signed-off-by: Olivier Dony (odo) <odo@openerp.com>

From the PoV of the customer, there is no difference between an
authorized payment and a captured payment; they should get redirected to
the confirmation page in both cases.

closes odoo/odoo#42765

X-original-commit: 45267673
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

Fix a mixup between `bounced_msg_id` that is sometimes tought as a list
of string or directly as a string.

Now `bounced_msg_id` is always a list or `False` if there is no bounce.

opw-2157793
closes #43084

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Revision on https://github.com/odoo/odoo/commit/a55c78836f172dba1cfa6db3df0e927a9c7e6471



Before this commit, marking all messages as read from Discuss inbox
did not update the UI correctly, hence requiring a page reload.

This bug comes from a typo in the commit above, which passed a list
of mail_notification instead of message ids, so that messages were
handled as marked as read by the web client.

Task-Id 2158452

closes odoo/odoo#43030

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Steps to reproduce:
- install contacts and vat number validation
- setup your company country to "Netherlands"
- go to contacts > add a company > try to add a dutch vat number
 (NL264077921B03)

Previous behavior:
Proper vat numbers are considered unvalid and raise a ValidationError

Current behavior:
Specific check added for dutch vat numbers

Related:
http://kleineondernemer.nl/index.php/nieuw-btw-identificatienummer-vanaf-1-januari-2020-voor-eenmanszaken
https://business.gov.nl/regulation/using-checking-vat-numbers/
http://www.pruefziffernberechnung.de/U/USt-IdNr.shtml



opw-2166380

closes odoo/odoo#43069

X-original-commit: b7a82684a311d736dfffd822c2fce8896104b96d
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Co-authored-by: Nicolas Martinelli <nim@odoo.com>

Activate Multicurrency
Create a Journal Entry with default currency (USD)
Save

Error will trigger because of the sql constraint
'check_amount_currency_balance_sign'
The currency_id and company_currency_id are the same while they
shouldn't because company_id should be unset if it is the same as the
company_currency.

Fix to update the error message to let the user know that it's best to
keep the field empty so the company_id would not be set

opw-2169523

closes odoo/odoo#43011

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

This will be use to make testing of the MiPyme FCE document types

closes odoo/odoo#42890

Signed-off-by: Josse Colpaert <jco@openerp.com>

- In a multi currency company, create an invoice with the domestic
  currency ($);
- Add a product (500$) with taxes;
-  Change the currency to a foreign one (€);
- The product don't change of amount but only of currency (500€);
- Save the invoice, and print it.

Before this commit, the base_amount_tax of the tax wasn't be updated.
Note that the base_amount_tax it should be expressed in domestic
currency. As this field didn't update in this case, the base_amount_tax
is expressing the amount in foreign currency. As this amount is supposed
to be in domestic, for the sake of the reports, it's change in currency
of the invoice (in this case the foreign one), and it's shown in the
report. The amount shown is not correct.

Now, the base_amount_tax is recompute and setted in domestic currency.

opw-2157853

closes odoo/odoo#43006

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Task:2155803
Closes:42845

closes odoo/odoo#41845

Signed-off-by: Josse Colpaert <jco@openerp.com>

This feature has been lost when removing the account.invoice model.

closes odoo/odoo#42933

--task: 2154792
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

self-explanatory

opw-2161939

closes odoo/odoo#42858

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

closes odoo/odoo#43024

X-original-commit: c062273c
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Install stock, go to Configuration>Settings, activate "Storage
Locations". Go to Configuration>Locations select locations and print

The reported will not follow the documentation, barcode will be one
after the other and not side by side, arranged in a 2x2 grid.
Fixing require to apply style changes since new bootstrap
code is not handled well by wkhtmltopdf

opw-2162698

closes odoo/odoo#42956

X-original-commit: 7ac26d0e
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Issue

    - Install eCommerce
    - Select Zap theme
    - Go on a product in the shop

    The quantity is hidden behind the buttons
    The quantity height is not the same than the buttons

Cause

    By default, there is a max width of 125px on the div containing
    the buttons and the quantity label. As this theme increase the
    button size, the quantity is hidden.

    The quantity label has `.form-control` class who override
    his height, so it's not using flex anymore.

    More details from QSM in design-themes closed PR #199:
        Bootstrap is not correct about input-group form-control height
        -> bootstrap_review.scss fix for the height of input-group
           form-controls

        Our max-width on css_quantity is not right, it should be a
        max-width on the internal input

Solution

    Restore the initial height in bootstrap_review for input-group form
    control

    Set the max-width only on the internal input.

OPW-2166311

closes odoo/odoo#42934

Signed-off-by: Jason Van Malder <jvm-odoo@users.noreply.github.com>

Before this commit, function _get_payment_type was declared twice in SaleOrder model.

closes odoo/odoo#43018

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

If the opening entry is balanced, the auto-balance line is unlinked.
However, before unlinking we test if it is balanced, which it is not. A
solution is removing the line from the move and it will be unlinked
automatically.

closes odoo/odoo#42930

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

Using a lazy translator as this file is processed when loading the web
client, no during rendering (the translation memory was not ready yet).
Turn escFormat into a lazymethod to evaluate it only after translation
resolution.

Fixes odoo/odoo#36494

t push de#

closes odoo/odoo#43015

X-original-commit: 5510d8193c3091bba15798a3e989cee75eadfb3b
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Before this commit, the breadcrumb was lost when user validates an
inventory adjustment. Now, it's not the case anymore.

fixes #41891

closes odoo/odoo#43012

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

closes odoo/odoo#42907

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

Issue

    - Install planning
    - Go on a planning view where you have 2 filters (employee/roles)
    - Unselect all items of one filter

    All the filters disappear.

Cause

    By doing this:

    ```
    if (!_.find(options.filters, function (f) {return f.display == null || f.display;})) {
        return;
    }
    ```

    We break the function's recursion:
    ```
    return self._renderFiltersOneByOne(filterIndex + 1);
    ```

    So the others filters are not rendered.

Solution

    Return the next filter rendering instead of nothing.

OPW-2166932

closes #42703, closes #42433

closes odoo/odoo#43002

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Create an invoice, click on send and print without an associated
template.

Traceback will occur because the lang parameter is set correctly only
from a template. Adding a fallback in case there is no template setting

opw-2168623

closes odoo/odoo#43000

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Currently an onchange on event type copy the mail schedulers information from
event type to the event. In order to ease inheritance, some white listed
attributes are directly copied using direct getter (line[attribute], see code
for clarity). However mail and sms templates are many2one fields and the
id should be copied, not the browse record.

There is no issue when the onchange is trigered from interface because a
mapping is done. However when calling the onchange in code there is a crash
as the record is directly given to write.

closes odoo/odoo#42977

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

At model level, activity_type_id is not a mandatory field on mail.activity.
Indeed required is added in views, meaning people could have activities
without type.

This make the activity views crash with `TypeError: 'bool' object is not
subscriptable` error when computing aggregated activity data. This commit
fixes that error.

Activities without type are still not displayed in the activity view as
columns are based on available activity types. It means activities without
type have no column to be displayed. As this is a corner case that should
not happen when using activities using the interface this is considered
as a limitation of current implementation.

closes odoo/odoo#41689

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Followup on https://github.com/odoo/odoo/commit/14648272dadfbc9e2c7069de76770d5c052cd37f


Field failure_type was visible on the list view only.
In this commit, we display field on form view as well.

closes odoo/odoo#42878

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Now use direclty the posted state from account move.

* This was changed in a constraint in l10n_latam_invoice_document module, also extend the constraint docstring
* This old states where also in a view domain in l10n_ar module for account.move view. We remove the field for the view (AFIP Responsibility) instead of fix the state name.

closes odoo/odoo#42140

Signed-off-by: Josse Colpaert <jco@openerp.com>

The purpose of this partner is that we do not need to report to AFIP the identification number.

Since this partner identification was configured as DNI it was throwing an error when validate an invoice for that partner in AFIP, AFIP was requesting us to sent the DNI number.

Now we activate the Sigd "Sin identificar/venta global diaria" identification type (code 99), proper configure the  it to Anonymous Final Consumer partner, with this change AFIP validate the invoice directly and does not request us the identification number.

Now we set this partner sequence to the biggest one so far to show this identification type as the last in the list of identifications types

closes odoo/odoo#41676

Signed-off-by: Josse Colpaert <jco@openerp.com>

Fix an error which occurs during an attempt to access the string
attribute of a non existing measure
If a pivot view is defined with a "string" attribute of a field of
type "row", e.g.

   <field name="stage_id" string="Stage" type="row"/>

an error was raised "TypeError: measures[name] is undefined"

closes odoo/odoo#42941

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

The company_id is filtering the lot_id, but when you add extra component lines the
company is not set, which makes the expected lots unavailable.

The fix is a copy 644663eb.

closes odoo/odoo#42921

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>