Had questions more than once about those.

closes odoo/odoo#75299

Signed-off-by: Florian Gilbert <FlorianGilbert@users.noreply.github.com>

When creating a new task the name field was not automatically focused.

closes odoo/odoo#75262

Taskid: 2585999
X-original-commit: a1f4cc03
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Signed-off-by: Kevin Baptiste <kba@odoo.com>

This reverts the following commits:
- 164409b0
- f11c8072
- c92ebc91

The fix we initially made did not cover every possible scenario,
and applied to every fiscal position, which was not required.

It requires a more in depth rework that is under way
and will come in a future PR.

closes odoo/odoo#75238

X-original-commit: eba1f006
Signed-off-by: Florian Gilbert <FlorianGilbert@users.noreply.github.com>

If an internal user does not belong to Sales / Administrator group, and wants
to convert a lead into an opportunity, he will face an access rights error if
another lead exists with the same email because we are trying to merge them.
We should allow him to convert and merge them without error.

closes odoo/odoo#75216

Signed-off-by: Alex Tuyls <alt-odoo@users.noreply.github.com>

If the prefix of the production sequence contains some dashes, it can
lead to undesirable behaviors

To reproduce the error:
(Enable debug mode)
1. Settings > Technical > Sequences & Identifiers > Sequences, edit "San
Francisco Sequence production":
    - Prefix: "WH-MO-"
2. Create a MO
    - Quantity: 2
3. Confirm, Edit:
    - Quantity: 1/2
4. (Keep MO's name in mind and) Validate + Create backorder

Error: Backorder's name is "WH-MO-002" instead of "WH-MO-0000X-002".
Going back to the initial MO, its name became "WH-MO-001" (was
"WH-MO-0000X")

OPW-2618971

closes odoo/odoo#75130

Signed-off-by: Rémy Voet <ryv-odoo@users.noreply.github.com>

We do not need to see this bugfix module in the list of modules, and
certainly not with a new category that shows up in the controlpanel.

closes odoo/odoo#75240

Related: odoo/enterprise#20316
Signed-off-by: Josse Colpaert <jco@openerp.com>

In a multi-currencies environment, if the user creates an expense with a
different currency than the company's, one of the associated account
move lines will have an incorrect base amount.

To reproduce the issue:
(Need account_accountant. Let USD be the company's currency)
1. In Settings, enable "Multi-Currencies"
2. Edit the currency rates:
    - EUR: 2
    - USD: 1
3. Create an expense:
    - Currency: EUR
    - Unit Price: 700
    - tax: 15%
4. Create Report, Submit, Approve, Post Journal Entries
5. Accounting > Reporting > Tax Report, This Financial Year
6. Audit of "Tax 15.00%"

Error: Base amount of the expense is $700, which is incorrect. It should
be either 700€ or $350

OPW-2613547

closes odoo/odoo#74963

X-original-commit: b57cdc9d
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

When creating a bill when we specify a French account in the recipient's account we receive the following warning "Please fill in a correct ISR reference in the payment reference. The banks will refuse your payment file otherwise."

This PR adds a condition to limit the verification to Swiss accounts

opw-2581434

closes odoo/odoo#75210

X-original-commit: b0e94b24
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Signed-off-by: Achraf <abz-odoo@users.noreply.github.com>

In 12.0+ when adding an XI (Northern Ireland) VAT number on a vendor and specifying the country as United Kingdom, an error shows the VAT number as not valid. This is because the method to check specifically XI VAT numbers doesn't recognize XI as a country, and thus uses the GB VAT number verification, which doesn't recognize XI VAT numbers as it isn't up to date yet.

A temporary method to check XI VAT number was already added, but is never called because XI is not recognized as a country code.
With this commit, we add a list of known legitimate country codes, that are not considered as such in Odoo.

opw-2534541

closes odoo/odoo#75189

X-original-commit: d8b8ad47
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: pvh-odoo <SwagSamaSempai@users.noreply.github.com>

Steps:
1. Create new time off allocation
2. Set type to accrual and set start date other than present day
3. Set the accrual to add every month
4. Validate and run the scheduled action for Accrual Time Off
5. Check the field 'nextcall' with Studio or editing form view
Result:
Nextcall date is set to 1 month after the date of creation of allocation record instead of start date.

Solution:
Nextcall is now based on start date.

opw-2558480

closes odoo/odoo#75177

Signed-off-by: Anh Thao PHAM <kitan191@users.noreply.github.com>

task- 2486484

closes odoo/odoo#74488

Related: odoo/enterprise#19978
Signed-off-by: Josse Colpaert <jco@openerp.com>

- Go to any record with a chatter (i.e. a SO)
- Use full composer to send a message
- In editor, use "File/Image" option to upload a document to the body of the message
- Upload any document (i.e. a PDF file)
- PDF icon will appear in the message
- Send the message
In the chatter, PDF icon appear in the message, allowing to download the file.
But in the sent email, the link is present but it is not visible. There is no icon.

Such link is a <a> element with "o_image" class. When converting to inline, an <img>
element is added with an icon depending on file mime-type.
However, when getting its value, a cleaning is executed, removing this added <img>.

It should not be cleaned when converting to inline.

opw-2558602

closes odoo/odoo#75204

X-original-commit: 2924d0e9
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: Anh Thao PHAM <kitan191@users.noreply.github.com>

In 14.0, when adding a form to a website and selecting "Create a Task" without
an active project, an error pops up because no projects are found.

In this commit, we prevent an error from popping up when adding the form
without projects, by allowing the field to be empty (not required).

task-2580436

closes odoo/odoo#73269

Signed-off-by: Romain Derie <rdeodoo@users.noreply.github.com>

Steps to reproduce the bug:

Go to your computer's date settings
Change region, e.g: (US or choose a region with a negative UTC)
Go to the preferences settings in odoo > Change the timezone to US too
Go to Time Off app > Manager > Allocations > Create a new one
Allocation type : "Accrual Allocation"
Set the end date to, e.g: "04/07/2021"
save

Problem:
The end date moves back by one day.
The field " date_to " is of ”datetime” type, so we use in the view "widget="date"
Therefore, the user can only choose the date. We save the time in the database at" 00: 00:00 ".
But as we use in the view "widget="date", after saving the record,
the datetime will be converted to a date, based on the user's UTC.

For example, in our case:
in database, date_to = "2021-07-04 00:00:00"
user UTC = "UTC-6"
result = "2021-07-04 00:00:00" - 06:00:00 → "2021-07-03 00:18:00"

Solution:
Remove the widget date to allow a user entering the full date (eg: 2021-07-04 23:00:00), that
will be stored correctly in UTC afterwards, instead of having the widget making the date switch to
another day.

opw-2607082

closes odoo/odoo#75193

X-original-commit: ceef1983
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Signed-off-by: Djamel Touati <DjamelTouati@users.noreply.github.com>

The editor sometimes compare CSS values, in particular in the
selectStyle method where a given style is not applied if it would have
no effect (e.g. applying an inline pink background-color is useless if
the block is naturally pink because of CSS rules). That comparison
failed when it was comparing 'var(--XXX)' and 'YYY' as 'var(--XXX)' was
not processed as the CSS variable 'XXX' to be read.

Related to task-2599770

closes odoo/odoo#75188

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

When clicking on the 'New quotation' action,
if no current customer is linked to the lead,
a popup opens with the following options:
- Create a new customer
- Link to an existing customer
- Do not link to a customer

If odoo found a potential matching customer but we decide it is the
wrong one and select the first option, a new one should always be
created

opw-2545065
Task-2622793

closes odoo/odoo#74988

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Steps to reproduce the bug:
- Go to Expenses > Expense Reports to approve
- Select expense reports with different managers
- Click on the Action drop-down button > Approve report

Problem:
Traceback is triggered because we try to access `"self.user_id"` (manager) of expenses as a single element,
While we have several `”user_id”`

Solution:
- Filter the `"hr.expense.sheet"` which must be approved
- Approve each expense separately

opw-2622837

closes odoo/odoo#75093

Signed-off-by: Djamel Touati <DjamelTouati@users.noreply.github.com>

closes odoo/odoo#75064

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Previous implementation always updated *current website*, which is not
always the same as the value from `res.config.settings`.

---

opw-2623007

Before this commit, Scrap move was copied to new record on
duplicating Scrap order.

With this commit, Scrap move is not copied.

closes odoo/odoo#75167

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

Steps to reproduce:

- create a sale order with an event registration,
- on the event, the number of attendees is well computed
- cancel the sale order
- on the event, the number of attendees is still the same as before

Cause of the issue

There was no specific action for canceling a sale order linked
to an event registration

Solution

Add a action_cancel method which cancel also the sale order lines when
canceling the sale order

Also add a test to ensure the flow will not break in the future

opw-2576790

closes odoo/odoo#75102

X-original-commit: 12f96f85dc262c99b53bc843e41dd185eb5488e6
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Signed-off-by: guva-odoo <guva-odoo@users.noreply.github.com>

closes odoo/odoo#75124

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

closes odoo/odoo#75137

X-original-commit: 6f8b65c5
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

`update_list` is an expensive operation and could be avoided when no modules are
updated. Particually, it speeds up initial theme installation on website, which
has following code:

```
    themes.filtered(lambda m: m.state == 'installed').button_upgrade()
```

Benchmark for Odoo 15: `/website/configurator_apply` spends 1.3 sec for unneeded
`update_list` call.

closes odoo/odoo#75120

X-original-commit: 82ba4994
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Signed-off-by: Ivan Yelizariev // IEL <yelizariev@users.noreply.github.com>

closes odoo/odoo#74865

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

When a color combination was used as "color" (base case) for the menu,
the menu background in the boxed template, the footer or the copyright
section, it was not properly marked as selected in the color palette
widget of the editor panel.

Related to task-2599770

closes odoo/odoo#75132

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Issue: When closing a PoS session, the user can Cash In/Out of the
register but it requires Accounting/Billing group or Purchase/User
group. However with Purchase/User group, there was an access right
error (not allowed to create account.move.line

Steps to reproduce :
 1) Install PoS Module
 2) PoS > Your Shop > Settings and enable Advanced Cash Control
 3) As administrator and in debug mode go to
  Settings > Users & Companies > Users
 4) Remove Accounting, Inventory and Purchase group of [User A]
 5) Log in with [User A], open a PoS Session, close it, and in Cash
 Control form, click Cash In/Out
 6) Remove or add money
 -> Access right error, you need to be Accounting/Billing or
 Purchase/User
 7) As administrator, add the User group to Purchase for [User A]
 8) As [User A], click Cash In/Out, removed or add money
 -> Still access right error

Why is that a bug:
 The first warning asks us to give the Purchase/User group to the user
 if we want to Cash In/Out but even when doing that, the access rights
 are still not enough to allow the creation of the entry

opw-2611298

closes odoo/odoo#75029

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

Got an older version without 2692dab7

closes odoo/odoo#75122

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

All accross Odoo, when a document is assigned to a salesperson, that person is notified via email.

However, the `account.move` model is inconsistent with that behavior, because the salesperson field name is `invoice_user_id` instead of just `user_id`.

With this fix:

- When creating an invoice from a sales order, the salesperson will get the assignment notification.
- When modifying the salesperson in the invoice form, the new salesperson will get the assignment notification.
- In both cases, the salesperson will get subscribed to the invoice.

This restores the behavior that `account.invoice` had in v12. For master, a better fix should be considered (a.k.a. simply removing the `invoice_user_id` field and using only `user_id` to avoid these kind of inconsistencies).

@Tecnativa TT29909

closes odoo/odoo#74074

X-original-commit: 22645694
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

How to reproduce the problem:
- Install the sale_coupon module
- Sales -> Products -> Promotion Programs
- Create a promotion with "Fixed Amount" discount, "Apply on current
order", with Based on Products as "Name = Large Cabinet"
- Create a SO with 3 Large Cabinet.
- Modify the quantity on the new reward line: the price unit became 0.

A client should be able to manually change the discount quantity.
That was not possible before due to the fact that the reward products of
a promotion are saved in the DB with a list price of 0.
As the reward generation handles the job of computing the correct
unit price on a reward SOL, that unit price is simply re-used when
the quantity is changed.

Also corrects the case where a Free Product is different from the
Rule Product(s): with the promotion
"Buy 1 Product A, get 1 free Product B", if the Sale Order has
3 Product A, for example, the promotion will offer only 1 Product B,
while it should offer 3.

opw-2522604

closes odoo/odoo#75003

X-original-commit: 609abfa3
Signed-off-by: Romain Derie <rdeodoo@users.noreply.github.com>
Signed-off-by: prro-odoo <proose@users.noreply.github.com>

To reproduce the error:
1. In Settings, enable "Multi-Step Routes"
2. Create a storable product P
    - Available in POS
3. Update P's quantity:
    - Location: WH/Stock/Shelf 1
    - On Hand Quantity: 1
4. In a POS session, process an order with one P
5. Close the session
6. Consult P's moves

Error: The location used to sell P is Stock instead of Stock/Shelf 1

At some point, the step 5 triggers `_create_move_from_pos_order_lines`.
Because "Consignment" isn't checked in the settings, the if-blocked is
skipped and therefore the move isn't assigned:
https://github.com/odoo/odoo/blob/4bcc63cf49a8c3ab73812de3d171024aa8059b8f/addons/point_of_sale/models/stock_picking.py#L152-L161
Then, on L161, when setting `quantity_done`, it triggers the inverse
method `_quantity_done_set` which will create a SML (because there isn't
one yet):
https://github.com/odoo/odoo/blob/2841525a3a2f1273783874947884b57494def849/addons/stock/models/stock_move.py#L355-L359


but using the location of the move (i.e. Stock)

The if-condition was introduced with d59fc6c9
to fix another issue. In the meantime, another fix has been deployed for
a second issue fe4323b5 However, this
second commit also fixes the first issue, therefore the if-condition is
no longer required. As a result, `_action_assign` will be called and a
SML with the correct location will be created.

OPW-2607748

closes odoo/odoo#75090

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

closes odoo/odoo#75017

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Backport of 14.0 PR odoo/odoo#73082 with some slight changes.

Backport of master PR odoo/odoo#62083.

Improve stock.picking._compute_state by computing pickings new state conditions
beforehand. This avoids looping through picking.move_lines for each
condition for each picking.

opw-2613931

closes odoo/odoo#74970

X-original-commit: 591a726f
Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>
Signed-off-by: Rémy Voet <ryv-odoo@users.noreply.github.com>

closes odoo/odoo#69321

Related: odoo/enterprise#17721
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

The term was untranslated
Export missing stock terms

It may be a recordset in case of partner duplicates. The variable
bounced_partner is simple search by email:

https://github.com/odoo/odoo/blob/72b5a17fc0e6f439d462647a7b55c9a26235a8df/addons/mail/models/mail_thread.py#L1349



closes odoo/odoo#70447

X-original-commit: 5996bdd1
Signed-off-by: Ivan Yelizariev // IEL <yelizariev@users.noreply.github.com>
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Bug
===
1. Login as "Portal"
2. Go to "/my/opportunity"
3. Create an opportunity
4. Edit this opportunity from the frontend and set the probability empty
=> Save, an error is raised

Technical
=========
The probability is set to "None" and not to "False", therefor the
verification "probability >= 100" in the write method of the lead will
raise an error.

By using False instead of None, this verification will work.

Task-2613208

closes odoo/odoo#75084

X-original-commit: 6453a03e
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

In the xml file of the list view, it is possible to define a button that
will be placed in a new column. When the user clicks on a button from a
list view, the script will execute the action linked to the corresponding
button. Unfortunately, all the buttons of the list views are not necessary
linked to an action: This is for example the case for the trophy icon of
the survey module. An exception can hence be thrown if the user clicks on
such button.

To solve the issue, we will add the 'disabled' property support for the
buttons and we will add that property to the buttons that do not have
an action. With this property, the script will bind no listener to the
button and it will hence not call the listener causing the error.

task-2612033

closes odoo/odoo#75013

X-original-commit: 0f177045
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Steps to reproduce the bug:
- Create a storable product, e.g:”Product A”, with a AVCO + Automated category
- Make sure to assign an account in the price difference account field
- Create an RFQ with the “Product A”
- Confirm RFQ and receive the product
- Create the vendor bill and edit to change the unit cost from 55 to 56
- Post the bill
- Check journal items

Problem:
Price difference accounts have no partner_id

opw-2616388

closes odoo/odoo#75038

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>