This field was never intended to be editable, and indeed all the views
on mail.channel.partner I could find either don't list the field at
all, or explicitly make it readonly.

The editability is actually an artefact from when related fields were
changed from editable by default to readonly by default, all existing
fields were bulk-set to `readonly=False` in
3f4f77fd with the intent of eventually
reviewing this status. That eventuality apparently never came to be,
and so most of those fields are probably flagged `readonly=False` for
no reason to this day.

closes odoo/odoo#126641

Signed-off-by: Louis Wicket (wil) <wil@odoo.com>

Broken by commit [1], where only the `url_to` should've been part of the
check for 301/302. The rest of the `if` was about relative URL check,
routing map check and converter check, all related to 308 only.

Note that in the meantime, commit [2] was added in those checks and
needs to be part of 301/302 too.

[1]: https://github.com/odoo/odoo/commit/14a850976711431f36b7f889ea9cf31b1114513d
[2]: https://github.com/odoo/odoo/commit/26fa923f6ab01298bf1a1e9f6a615c9aa9e2e5ed

Fixes https://github.com/odoo/odoo/issues/129290



closes odoo/odoo#129410

Signed-off-by: Benoit Socias (bso) <bso@odoo.com>

Steps to reproduce:
- Go to `/blog`.
- Enable "Show Sidebar" in the "Customize" menu.
- Edit the page.
- Click on an icon of the "Follow Us" section of the sidebar.
- Click on the "Link" icon of the editor toolbar.

=> An error popup appears.

In further versions, the link parameters can be edited - but they are
lost upon save.

The social media links sections of the blog and blog post pages is
generated and is not supposed to be editable.

This commits makes these social media links sections non editable.

If a user needs to configure such a content specifically, it can be done
inside the "About Us" section of the sidebar above.
E.g.:
- Deactivate the "Follow Us" section from the "Customize" menu.
- You can use copy/paste to duplicate the existing style of the
"About Us" section if you want.
- Click on the "File / Image" icon of the editor toolbar (or type
"/image" to use the Power Box as of 15.0).
- Select a pictogram.
- Click on the "Shape: Circle" icon of the editor toolbar.
- Select the "Font Color" from the editor toolbar.
- Click on the "Link" icon of the editor toolbar to specify an URL.

opw-3450880

closes odoo/odoo#131058

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Some external tools send email as pure html (no multipart) and when
parsing such email we ends up having the raw HTML as body (text)

This commit ensure we correctly parse and sanitize the body as HTML
for such emails.

closes odoo/odoo#130489

Task-id: 3451889
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

closes odoo/odoo#129482

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Currently, When the user is adding a double hyphen or space or anything within a
comment in a view's architecture and tries to save the view, then an error
occurs.

To reproduce the issue:
1. Go to Settings > Technical > Views > open a view.
2. In View Architecture comment out a line.
3. Add a double hyphen or space or anything within the comment.
4. Then save manually, the error will occur.

To solve this issue the error has been handled using a try-except block in
'parse_html' method.

sentry-4306359331

closes odoo/odoo#129969

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Steps to reproduce:
- Create a manufactured product P with AVCO valuation
- On the bom of the previous product add a component C with unit cost 5$
- Manufacture product P (Unit cost correct so far 5$)
- Change component cost to 0 and manufacture again
- Unit cost of P is still 5$ were it should be 2.5$

Bug:
since the move unit price is 0 the standard price of the product P is
used insted for the valuation of the newly created qty

Fix:
force unit price to 0 in the case of manufacturing

opw-3374462

closes odoo/odoo#130592

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

In a SaaS server, the _meta_data variable will be translated when the
HTTP worker is spawned and it will be translated into whichever language
is set on the DB that spawns said worker. This causes issues when other
DBs use this worker as the variable may be translated into a language that is
not present in that DB. To rectify this issue, we use lazy translate so
the translation lookup is executed at rendering.

opw-3385997

closes odoo/odoo#128601

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Create a vendor bill with a specific attachment (on ticket)
Go to vendor bill list view
Select the created bill and another one
Print > Original Bills

Traceback due to unhandled ValueError on pdf read

opw-3420507

closes odoo/odoo#128454

Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>

closes odoo/odoo#131436

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Incorporate Andrea Geraldo (AndreaGeraldo) as Vauxoo's contributor.

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#131437

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Currently, configuring opening hours for event sponsors 'at midnight' is not
handled properly.

If you set either the start time or the end time opening hours to "00:00",
the sponsor will be considered as always open.

We fix that by correctly taking into account that configuration.

(Note: if the user configures a sponsor to be open 'until midnight', we assume
it means midnight 'the next day').

Tests have been altered to take this into account.

Task-3459777

closes odoo/odoo#131348

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

As the move is posted,
no editing should ever
be allowed to the expense sheet

task-3458179
opw-3446247

closes odoo/odoo#131173

Signed-off-by: Habib Ayob (ayh) <ayh@odoo.com>

before this commit, if the user profile is opened
from a particular forum, the votes tab is displaying
the votes from all the forums for this user.

where us, the questions and answers tab is filtering
the data based on the selected forum.

after this commit, the data displayed in the votes
tab will also be filtered based on selected forum,
similar to questions and answers tab.

closes odoo/odoo#127023

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Steps to reproduce
------------------
* install l10n_de
* switch to a german company
* create an invoice
* add a line such that the account's default tax is different from the
  tax set on the line (ex, account: `8400 Erlöse 19% USt` and
  tax: `7% Umsatzsteuer`)

Attempt to confirm the invoice, you should see that you can't. The
system requires the account's default tax to be the same as the tax set
on the line. This should not be the case. It's a practice in Germany to
link a tax to an account like this, but it's not a legal requirement.

opw-3324323

closes odoo/odoo#127238

Signed-off-by: Habib Ayob (ayh) <ayh@odoo.com>

If you have large amount of product.template records (e.g. over 40k),
`hr_expense` module can't be installed as you would get MemoryError. It
would consume all memory while computing `can_be_expensed` field.

For that, using `_auto_init` to make it less of a memory hog.

closes odoo/odoo#109729

Signed-off-by: Habib Ayob (ayh) <ayh@odoo.com>

Versions:
---------
- 14.0
- 15.0

Steps to reproduce:
-------------------
- in Members app, add a membership product;
- add a "Payment Terms" on a contact (Sales & Purchase tab);
- in Membership tab click on "Buy Membership";
- add the membership product and invoice;

Issue:
------
There is no payment term on the invoice.

Cause:
------
In the invoice creation flow, the following logic is not triggered:
```py
if self.is_sale_document(include_receipts=True) and self.partner_id:
	self.invoice_payment_term_id = self.partner_id.property_payment_term_id or self.invoice_payment_term_id
```
Consequently, we have no invoice_payment_term_id.

Solution:
---------
Specify `invoice_payment_term_id` in the values used for invoice creation.

Note:
-----
This FIX solution only handles the invoice creation
from the membership module, to be as non-invasive as possible.

In version 16.0, this is handled by the account module,
which has made the `invoice_payment_term_id` field computed and dependent on `partner_id`.

opw-3382398

closes odoo/odoo#130998

Signed-off-by: Andrea Grazioso (agr) <agr@odoo.com>

Before this commit there are no rollback if raise.

closes odoo/odoo#130831

Signed-off-by: John Laterre (jol) <jol@odoo.com>

closes odoo/odoo#130631

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

Incorporate Alejandro Mellado (alejandromellado) as Vauxoo's contributor.

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#131135

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

closes odoo/odoo#131005

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

closes odoo/odoo#130977

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Steps to reproduce:

- Install website_sale
- Go to website shop in the frontend
	- Login, Edit
	- Click on 3rd or 4th kanban item
	- Push down

Issue:

The item goes to the end of the list instead of moving one element to
the right/down. Pushing an element down searches for the next element
with a higher `website_sequence` and places the current element right
after, by switching their sequence values.

Normally the logic works fine, but the problem arises when the
`website_sale` module is installed, when records with
`website_sequence = NULL` are set to the same default value, namely
10000. Then, when an item with `website_sequence = 10000` is pushed
down, it will skip many items, before finding one with a higher
`website_sequence`.

Solution:

When updating records with `website_sequence = NULL`, assign an unique
sequence to each one. We can set the `website_sequence` relative to the
inverse of the id to ensure that the order on the shopping page remains
the same as it was prior to the fix.

opw-3318867

closes odoo/odoo#127982

Signed-off-by: Stefan-Calin Crainiciuc (stcc) <stcc@odoo.com>

When applied, this commit will restore the edition of a block when
the content has a height > 10000px.

Steps to reproduce:
1) Go to a runbot
2) Go to a blog or on the homepage
3) Enter edit mode
4) Add some text in one bloc with a total height above 10000px
5) The text will be uneditable on the top

Current behavior:
If the text is too important in one block (more than 10000px),
the text will be uneditable

Expected behavior:
The text should be accessible and editable even if the block
has too much content

opw-3393570

closes odoo/odoo#127719

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

When updating taxes, creation of taxes of type 'group' does not
work correctly if either a child or the parent itself has been deleted.
Indeed the creation of _generate_tax() method suppose that both the parent
and the child needs to be created in the same batch while we can have
databases where one of those already exists and will go in the 'update'
and not 'creation' part of the script.

closes odoo/odoo#130407

Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

Remove tax demo data:
- They have the same tax name which breaks a uniqueness constraint, and
cause error at migration.
- It doesn't make sense to have taxes demo data
Also remove assignation of those taxes on other aml demo data.

closes odoo/odoo#129866

Signed-off-by: Laurent Smet (las) <las@odoo.com>

We now split the export of the FEC files per batch of move lines. This was necessary, as the fetchall() ran on the cursor to get the results could return a huge amount of data on big databases, saturating the RAM.

This fix is not exhaustive, and memory consumption could be lowered by removing the need to convert the whole file to base 64 and write it in attachment. Those changes are not doable in stable ; further improvements will come to master.

OPW 3442579

closes odoo/odoo#130247

Signed-off-by: de Wouters de Bouchout Jean-Benoît (jbw) <jbw@odoo.com>

Denmark is comprised in the EAS list but is not currently supported in
Odoo. This commit makes UBL Bis 3 available for Danish companies.

The schemeId "0184" corresponds to the "DIGSTORG" and is mandatory for
Danish Suppliers (see: rule DK-R-014,
https://docs.peppol.eu/poacc/billing/3.0/rules/ubl-peppol/DK-R-014/

).

issue-130519

closes odoo/odoo#130564

Signed-off-by: Laurent Smet (las) <las@odoo.com>

Before this PR, when we remove the ToC snippet, underneath the hood
navbar position of the ToC snippet was still trying to update which
should not. This is because we have bound the
`_updateTableOfContentNavbarPosition` method to scrolling events so
whenever we scroll up/down navbar position is trying to update, which is
the intended behavior when we have a ToC snippet available, but
unexpected behavior when the snippet is removed.
With this fix, we prevent that by unbound the method when the public
widget is destroyed.

task-3081442

closes odoo/odoo#108374

Signed-off-by: Guillaume Dieleman (gdi) <gdi@odoo.com>

The user has the option to remove the last block from the Table of
Content snippet prior to this commit, but doing so breaks the Add Item
feature because there is no reference to adding a new item in the
snippet area, and doing so is also not a good idea.

If the block is the final one in the Table of Content after this commit,
removing the last Content will remove the ToC snippet.

task-3081442

Part-of: odoo/odoo#108374

before this commit, on expense report kanban view
after adding group by status, it allows the
to quick create expense report in approved
status.

after this commit, quick create is disabled

closes odoo/odoo#128831

Signed-off-by: Laurent Smet (las) <las@odoo.com>

The function `get_adyen_endpoints` was renamed to `_get_adyen_endpoints`
It was a typo in the method name, so it was not called and a traceback
was raised.

closes odoo/odoo#130396

Signed-off-by: Robin Heinz (rhe) <rhe@odoo.com>

Versions:
---------
- 14.0+

Steps to reproduce:
-------------------
1. Settings -> Configure document layout
2. Select the Boxed layout
3. Go to Invoices -> create a new invoice and register payment
4. Click on Preview
5. The field “Amount due” is in the wrong color and barely visible

Issue:
------
The field “Amount due” is in the wrong color and barely visible in
invoice boxed layout

Cause:
------
The issue is happening because we have `<strong>`  before the text
”Amount due” and it changes the font color to gray because of the CSS definitions

Solution:
---------
We need to make the text bold in a different way, to do it we can use the bootstrap
class font-weight-bold, this way we keep it bold and do not break the colors

OPW-3374092

closes odoo/odoo#128451

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

To reproduce the issue, follow these steps:

1. Install the Timesheet and Project.
2. From the settings menu, create a new company.
3. Create a project using the newly created company(e.g. New Company) and add
   a task to it.
4. Open the Timesheet application and create a new timesheet.
5. In the timesheet, select the project created in step 3, and observe that the
dropdown for tasks does not display any task.

Cause for this issue:
-The timesheet application has a domain set for the task field where the company
associated with the task_id should be the same as the company selected in the
current environment.
-However, when a new project is created with a 'New Company', the tasks
associated with it also have the  'New Company' assigned to them. On the other
hand, the current environment has a default company called 'Your Company'
associated with it.
-Therefore, due to this domain setting, the task field does
not display any tasks since there are no tasks associated with the
'Your Company' in the current environment.

Fix:
Since the cause of the issue is related to the company domain set in the task
field, we can solve it by removing it from the domain.

task-3323027

closes odoo/odoo#122631

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

Previously, when account moves were set to auto post, and the cron was triggered to post them, if a single invoice triggered a UserError, none of them were posted (User error might be for example missing required field to post, archived journal, inactive currency, ...). This commit enables to post all valid invoices. The invoices that could not be posted are now visible on the accounting dashboard on their respective journal card with the 'to check' attribute, and a note is written on the chatter of the problematic invoices, describing the reason why the move could not be posted.

For performance reasons, we lowered the number of moves that can be posted in a single batch. This way, if a move among a batch cannot be posted, all moves of this batch must be handled one by one. Doing batch of 100 is already the case in 16.0

task-3244310

closes odoo/odoo#128420

Signed-off-by: John Laterre (jol) <jol@odoo.com>

Issue:
When opening the daterangepicker, but not modifying anything and
closing it, and then discarding the record, the timezone is
reapplied on the input. (value in DB is correct).

Steps to reproduce:
- Install an app that has a daterange field (ex: FSM in 14, Project
  for 15->saas-15.2)
- Edit the daterange, don't change anything, close it, discard the
  record.
- Observe the timezone has been reapplied on the input value.

Cause:
When opening the daterangepicker, the initial dates read from the
input field were already localized based on the tz, but the
daterangepicker object expect it to receive datetime in utc.

Fix:
Parse the input and make sure it's in utc.

Affected versions:
- 14.0
- 15.0
- saas-15.2

opw-3342274

closes odoo/odoo#127962

Signed-off-by: Bruno Boi (boi) <boi@odoo.com>

Bugfix. When installing l10n_eu_oss with l10n_de_skr03, an OSS account
'17010 Unsatzsteuer 19% OSS' is created. However, this account has
no account tags set on it, so it gets left out from the Balance Sheet
report. (Note that in Germany, due to there being two CoAs, the Balance
Sheet report still works using account tags.)

The solution: when creating the OSS account, re-use the account tags
of the account we are copying.

closes odoo/odoo#130185

Signed-off-by: John Laterre (jol) <jol@odoo.com>

closes odoo/odoo#67316

Signed-off-by: Rémy Voet (rvy) <rvy@openerp.com>