As the original PR was forgotten, let's achieve the JCVD style big gap
beteween Ubuntu stable and Debian stable 11.6 Bullseye.

closes odoo/odoo#118286

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

The field `requires_allocation` is a selection field
that is required.
Using it in an if statement without a comparison
operation will always return true.

opw-3274826

closes odoo/odoo#118840

X-original-commit: 486498dd
Signed-off-by: Kevin Baptiste <kba@odoo.com>
Signed-off-by: Lefebvre Thomas (thle) <thle@odoo.com>

Steps to reproduce:

- Go to accounting > journal entries > create a new journal entry.
- Add a line with an account.
- Add a second line.

Previous behavior:

We are going to get in the second line a suggestion of the first line
introduced, also even if we don't select the suggestion the taxes of
the suggestion will be applied.

Current behavior:

As discussed with the PO, we only want to get suggestions when we used 2
accounts in a row, so the 3rd line will be the one getting the
suggestion. And we also avoid seting the taxes of the suggestion if we
don't select it.

Related to #39784

opw-3098361

closes odoo/odoo#110821

Related: odoo/enterprise#39784
Signed-off-by: William André (wan) <wan@odoo.com>

before this commit, after running an older version,
 lets say odoo 14 and trying to access 16 in the
 same browser return traceback without redirecting
  to db selector page

 and this happens due to the missing env in request,
 which returns as None.

 after this commit, no traceback wont be shown and
 will open the db selector page

closes odoo/odoo#116351

Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>

When creating an employee with a private contact,
the contact will not be automatically added to the employee's followers.

The desired behavior is that the contact is added
to the followers even if it has a private address.
Commit: 8760a4d0

However, this behavior will not be possible because
adding a contact with a private address is forbidden.
Commit: 20536e1b

Solution:
The solution is to use the private method `_message_subscribe`.
This is not a problem in the business case.
Indeed, the people who have access to the employee's file
also have access to the private contacts.
Moreover, the access rights of the public method `message_subscribe`
do not concern this business case.

opw-3249646

closes odoo/odoo#118779

X-original-commit: b06857afa371d2164f1f5ec402a6074a237d8230
Signed-off-by: Kevin Baptiste <kba@odoo.com>

Since the upgrade to Bootstrap 5 and especially since this [BS5 commit],
there is a gap between the mega menu and the navbar when the user opens
a mega menu. This commit removes that gap.

Steps to reproduce the bug fixed by this commit:
- Have a mega menu on your website.
- Drop a block of a dark color at the top of the page (it helps to see
the problem).

=> When you open the mega menu, you can see a small piece of the block
of dark color between the navbar and the mega menu.

Technical explanation:
This [BS5 commit] introduces a new css rule that adds a
`margin-top: 0.125rem;` on the `.dropdown-menu[data-bs-popper]`. However
when [mega menus were introduced], another css rule prevents having a
gap between the nav and the mega menu (`margin-top: 0;` on
`.o_mega_menu`). This commit makes sure that it will be a `margin-top`
of 0 by making the property more important.

[BS5 commit]: https://github.com/odoo/odoo/commit/c48f57ea2538ad51e00ac27d58f8e191781444f3
[mega menus were introduced]: https://github.com/odoo/odoo/commit/1345702258adbfbee0d780dc22e552395e6d1df7



task-3133137
opw-3226013

closes odoo/odoo#117070

Signed-off-by: loco-odoo <loco@odoo.com>

This commit allows to reopen submenus and mega menus if one of them was
opened when scrolling on a page of a website.

Steps to reproduce the bug fixed by this commit.
- Have a submenu or a mega menu in the navbar
- Open a dropdown of the navbar
- Scroll down

=> It is no longer possible to open the dropdown.

This commit fixes this issue and adds a test for this flow.

task-3133137
opw-3226013

Part-of: odoo/odoo#117070

Currently the POS does not load if a Stripe payment method is configured and there is no internet connection.
This commit fixes the loading of Stripe resources
to allow the opening of the POS and the display of related errors

task 3177045

closes odoo/odoo#114421

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

After this commit, we will be using float_compare function to compare
points. This will ensure that any floating point errors are properly
handled and that we receive correct responses from the
`validate_coupon_programs` function.

opw-3264681

closes odoo/odoo#118740

Signed-off-by: Heinz Robin (rhe) <rhe@odoo.com>

An error is raised when trying to set the date of a note in the
activities

Steps to reproduce:
1. Install Notes
2. Click on the activities icon (top right of the screen)
3. Click on 'Add new note'
4. Set a date to the note
5. An error is raised

Solution:
Use the eventDate only if the input is set, get the locale from the
getOptions function and set the datepicker warning regardless of where
we get the date from

Problem:
`this.date` can be undefined

closes odoo/odoo#118630

Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>

Before this commit, the project onboarding tour: the step to create a new stage
get validated if the user clicks on the 'add' button without actually creating a
new stage

After this commit, it will point first to the text area for the name and then
add tooltip will be highlighted so tour does not consumed without adding the
stage.

task-3049636

closes odoo/odoo#104844

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

Before this commit, when the user changes the access rights of another
user, he will see a warning message the other access rights will change
with his changes. In that warning message, `Other` category could be
displayed and that category is only displayed in the user form view if
the user is in debug mode since it is a Technical category.

This commit hides the `Other` category in the warning message when the
user is not in debug mode to be consistent with the visibility of that
category in the form view.

task-3049636

Part-of: odoo/odoo#104844

This update contains the following commits:

[FIX] components: solve missing update (concurrency issue)
[DOC] remove old references to comp for useRef hook
[FIX] devtools: Fix build commands for windows users
[FIX] devtools: Fix devtools in detached window
[IMP] devtools: Add a button to navigate to the doc
[IMP] devtools: Add devtools documentation
[IMP] Allow app to be mounted in shadow DOM
[IMP] playground: allow sharing playground links
[IMP] runtime: allow validating object values using a type description
[FIX] devtools: Increase vertical padding of the search bar
[FIX] devtools: Hide the collapse all button
[FIX] devtools: Fix bad computation of highlight boxes on the page
[FIX] package: Auto-update package-lock.json

closes odoo/odoo#118722

Notes: https://github.com/odoo/owl/releases/tag/v2.1.1


Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

The 'Generate payment link' action on account move records was only
shown to the users of the group 'Show Full Accounting Feature'
(and to salesman when sale is installed).

This means that if you only have invoicing app (`account` module) installed,
you don't see the action.

This commit makes sure the action is visible to all accounting users, like
the refund wizard.

closes odoo/odoo#118671

X-original-commit: 8d2253b4
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

If applied, this commit will solve the external id issue of the base admin user.

Before this commit:
==========================
When we delete the admin user (base.admin_user) and try to login with a new user
or try to write in a new user, this error will come.

After this commit:
===========================
The issue will be resolved after this commit and authorize new users without
any errors.

sentry - 3973828005
see - https://tinyurl.com/2jm772jm



closes odoo/odoo#118666

X-original-commit: 567027b4d4e3efdbbabab3a7a3c5e090df51dbf8
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Steps to reproduce
==================

This only seem to happen on Firefox

- Go to Email Marketing
- Open a campaign
- Go back to the homepage by using the topleft square button

-> `$(...).offset() is undefined`

Cause of the issue
==================

The ResizeObserver used in MassMailingFullWidthViewController is still
triggered, even though it shoudln't.

Solution
========

Disconnect the observer when the component is unmounted.

opw-3271101

closes odoo/odoo#118345

Signed-off-by: Hubert Van De Walle <huvw@odoo.com>

When updating the recipient bank on a posted vendor bill the chnages
will not be saved.

Steps to reproduce the error:
1-Go to accounting
2-Create a vendor bill and confirm it
3-Change the bank recipient and click manual save
4-Reload and you can see the changes disappeared

The error was happening because the recipient bank was not displayed as
readonly on a posted state of the account move.

opw-3247282

closes odoo/odoo#118294

Signed-off-by: Quentin De Paoli <qdp@odoo.com>

Since the Owl conversion of the partner autocomplete widgets, the search
by VAT number on a `Many2one` field of `res.partner` wasn't working
anymore.

closes odoo/odoo#118071

Signed-off-by: Florian Daloze (fda) <fda@odoo.com>

Unsupported operand type(s) for +: 'NoneType' and 'relativedelta'
occur when we create payment terms without a preview date (date_ref).
This is because date_ref has no value.

This commit solves the issue by adding a condition if date_ref is not
available, so it adds current date instead of it.

sentry-4068322613

closes odoo/odoo#118027

Signed-off-by: William André (wan) <wan@odoo.com>

This commits aims to improve the search feature in the export dialog.
Now, the search isn't resetted when a field is added to the export list
anymore. It is also possible to search in the list of fields using the
technical name of the field.

A test has been added for the search feature in debug mode, and another
one has been adapted to verify that the search input still contains the
string previously entered.

task-3266632

closes odoo/odoo#118398

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

This commit fixes the search feature of the export dialog. Before this
commit, it was impossible to display subfields that would match the
search pattern, since the filter was only applied to look for fields
at the 'root' of the available fields.

Now, it is possible to search and find subfields that matches the
pattern, and they are displayed inside their expanded parent(s).

A test has been added and verify the search feature.

task-3245492

Part-of: odoo/odoo#118398

The current profiler will add default value in the user session
using disk space without valid reason.

This commit makes those parameters optional in the session.

closes odoo/odoo#118295

Signed-off-by: Jérémy Kersten <jke@odoo.com>

Steps to reproduce
==================

- With the Chrome devtools, add a network delay of 1 second
- Go to Purchase
- Create RFQ
- Add vendor
- Add products and navigate by using the 'TAB' key
- Add another product line
- Repeat process quickly

`this.list.editedRecord is null`

Cause of the issue
==================

Order of events:
- First tab pressed
- onchange_1 triggered
- Second tab pressed
- onchange_2 triggered
- onchange_1 resolves
- The editedRecord is switched to readonly
- onchange_2 resolves
- There is no more editedRecord

opw-3115650

closes odoo/odoo#117938

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Co-authored-by: FrancoisGe <fge@odoo.com>

before this commit, the form view of
ir.actions.act_window.view was not properly aligned.

* open any menu linked with type ir.actions.act_window
* click on Edit Action from debugger button
* click on Add a line from the View one2many field

after this commit, the view will be
aligned properly.

closes odoo/odoo#117066

Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>

There is a bit of a dance on the lambda function to filter the MOs
that should be autoconfirmed out of a procurement. To the point
that the logic is different in v14 and v15/16.

Refs:

- v14: https://github.com/odoo/odoo/commit/5fd6c7251331de2600eaee76114b76f535652fec
- v16: https://github.com/odoo/odoo/commit/2ab878aecb67930a9a7cd35901cb6c4b98c7e442
- v16 previous: https://github.com/odoo/odoo/commit/2b003b8d3917b45772b5f16edf21292446e96601



It would be great for partners to be able to extend it and be able
to control the logic used even if the default behavior gets changed
again.

closes odoo/odoo#112831

X-original-commit: 82e8ece7
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

To reproduce the issue:
1. In Settings, enable:
   - Multi-Step Routes
   - Storage Categories
   - Packages
2. Create a Storage Category SC:
   - Allow New Product: same
   - Max Weight: 100 kg
   - Capacity by Package:
     - 2 x Pallet
3. Create two locations L1, L2:
   - Parent: WH/Stock
   - Type: Internal
   - Storage Category: SC
4. Create a putaway rule:
   - When in: WH/Stock
   - Package type: Pallet
   - Store to: WH/Stock
   - Having Category: SC
5. Edit the warehouse:
   - Incoming Shipments: 2 steps
6. Create a product P:
   - Type: Storable
   - Weight: 1 kg
7. Update L1:
   - There is 1 x P in a pallet
8. Create a planned receipt R:
   - To: WH/Input
   - Operations:
     - 2 x P
9. Mark R as Todo
10. Create two packages:
    - 1 x P in PK01 (! PK01 must be a Pallet)
    - 1 x P in PK02 (! PK02 must be a Pallet)
11. Validate R
12. Open the related internal transfer T

Error: Both packages are redirected to L2 but one of them should be
redirected to L1

When checking L1, we ensure that the policy 'all same products' is
respected. To do so, we compare the products of the quants of L1
with the given product. Here is the issue: when moving a package, we
don't provide any `product` value to the methods used in the putaway
rules process.

Note: There was also another issue with the 'all same products'
policy. Suppose L1 is empty, and we move a pallet with two different
products, the move line is redirected to L1, which breaks the 'all
same products' condition.

OPW-3204924

closes odoo/odoo#118656

X-original-commit: 3a6d82de77e0ab477b3f22985f6d41995e25f652
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Adrien Widart <awt@odoo.com>

from april 3, the transifex has changed domain
from www.transifex.com to app.transifex.com

after this commit, the transifex project url
in the system parameter will be updated to
the new domain

closes odoo/odoo#118634

X-original-commit: c79164f6
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

This issue occurs when the user changes the Journal 'journal_id' in this
'report.pos.order' model then traceback will be generated.

Step to Produce:-
- In POS, Click on Reporting Menu > Order.
- Click on graph > Open any One record.
- Try To Change the Journal('journal_id').
- Trace-back will be generated.

sentry:- 3929247828

closes odoo/odoo#118632

X-original-commit: 87ed00e6
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

Steps to reproduce
==================

- Register two events listener on the same target
- Unregister them

Only the first one is unregistered

Cause of the issue
==================

`cbs` is used instead of `listeners`. This means that after any `.off`
call, the target is removed from the Map and it is not possible anymore
to unregister any events for it

closes odoo/odoo#118218

Signed-off-by: Samuel Degueldre <sad@odoo.com>

before this commit, while duplicating an user,
karma points is also getting copied to newly
created user

after this commit, the copying of karma on
duplicating an user will be stopped.

closes odoo/odoo#118173

X-original-commit: b1be3262
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

This commit is a small fix to avoid reloading several form views
(like crm leads or helpdesk tickets) when a message is posted in
the chatter. This is linked to an old issue where relational fields
like the tags do not keep changes properly in the base model,
therefore dropping the changes on reload in this case. Do note that
it will still reload (and keep the bug) when a recipient is linked
to the message and perform the initial purpose of the reload (like
updating the customer field) as it was done before.

opw-3245717

closes odoo/odoo#117500

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Since odoo/odoo@04e972660b3f38c8dfa42111b1fe88adbcff4699
The session `modified` flag has been renamed `is_dirty`.

However, it has not been renamed correctly in these
three different places.

The goal to set `modified` at this three places
is to force the session to be saved,
for instance because a mutable (a list or a dict)
contained in the session was modified,
but not the dict of the session itself,
therefore `modified` is not flagged automatically.

As the flag `modified` has not been renamed to `is_dirty`,
a key/value `modified: True` was actually assigned to the
session dict, and saved in file. The behavior
to save the session in these three places was kept,
as one key/value of the session has been changed,
but by the way to assign a new value in the session file,
which is not ideal.

It's better to assign the correct flag to avoid
setting a new key/value in the session for no reason.

closes odoo/odoo#118321

Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>

When replacing an image by a pictogram inside columns, the pictogram
right-alignment is neutralised by the fact that the section of the card
inside the column spans over 100% width.

This commit makes pictograms in those sections rely on their auto width
instead - thus letting the right-alignment happen as expected.

Steps to reproduce:
- Drop a "Columns" block.
- Replace an image by a pictogram.
- Select the pictogram.
- Click on the "Float Right" icon in the toolbar.
=> Pictogram remained aligned to the left.

task-2841127

closes odoo/odoo#118657

X-original-commit: 2a15e9f28c0445a88104d162855f1da31fbd2435
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Align images to the right by using an auto left margin.

Steps to reproduce:
- Drop a "Columns" block.
- Select an image.
- Resize image to 50%.
- Align image to the right.
=> Image did not get aligned to the right.

task-2841127

X-original-commit: 785ea10014c9ab3bd8da9eeecd2d6910786edbc7
Part-of: odoo/odoo#118657

In Indian government required audit trail report for private limited companies
So from this commit user can't delete journal entries after posting once.

Create an audit trail report from mail.message to show a full log of journal entries

task - 3239932

closes odoo/odoo#117344

Signed-off-by: Josse Colpaert <jco@odoo.com>

Before this commit when choosing the program rule type "Buy X get Y"
an error occured: after adding rewards and trying to save the record
the rewards were reset to the default value for program rules
of type "discount".

This ocurred because the program type was not being sent to the
`default_get` method of the `loyalty.reward` record.
After this commit rewards are correctly preserved.

opw - 3240558

closes odoo/odoo#116244

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

### Contains the following commits:

https://github.com/odoo/o-spreadsheet/commit/2b4831d0 [REL] 16.0.7
https://github.com/odoo/o-spreadsheet/commit/e7594e86 [FIX] github: update release-action to latest version
https://github.com/odoo/o-spreadsheet/commit/d3d19a60 [FIX] tests: fix indeterministic ui sheet
https://github.com/odoo/o-spreadsheet/commit/4e18d1ce [FIX] demo: Align font family with Odoo Task: 3269724
https://github.com/odoo/o-spreadsheet/commit/1217b277 [FIX] ColorPicker: Fix checkmark symbol Task: 3269724
https://github.com/odoo/o-spreadsheet/commit/e2c96599

 [FIX] viewport: infinite loop with hidden headers

closes odoo/odoo#118611

Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>

Install only the “purchase” module and run the test, it’ll always fail
since the product type is added in the stock module

Bug introduced in: https://github.com/odoo/odoo/pull/117956



Solution:
Use the consumable type instead

closes odoo/odoo#118598

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Disable performance tests from both tef and tcf.

Too many PR are blocked due to broken assertQueryCount, either there are
too many queries, either there are too few.

It is too much work to run all tests three times only to update a comment
with the final count (module alone + community + enterprise).

It is too hard to keep track of the hundreds queries to determine those
that moved, those that are missing and those that are new between two
branches. We have to apply tons of string-replace and sorts just to help
some diff tools (e.g. meld) into showing what changed.

Basically, except a few people, nobody care to do the investigation work
and just increase the query count (without changing the comments).

We tried for one year, now it is time to let those test go.

closes odoo/odoo#118591

X-original-commit: 353074fa1f362560737bb2905270ef4ae35e177e
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>