- Create a product A with a barcode, UOM as 'Unit(s)' with a BOM
- Create a MO for A with more than one unit, validate
- Print the 'Finished Product Label (PDF)'

A single label is printed for all units, although it is not logical: a
label should be printed for each unit, as already done for the Zebra
labels.

In case the product UOM is 'Unit(s)', we print a label per unit. At the
same time, we remove useless horizontal lines.

opw-2091663

closes odoo/odoo#39247

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

closes odoo/odoo#36149

closes odoo/odoo#39192

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Some external ids of account.fiscal.position.tax.template were
duplicated

closes odoo/odoo#38843

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

The message was not evaluted

closes odoo/odoo#38578

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

When duplicating maintenance request, the stage should be reset to the
first one (which is +/- what the default does).

Fixes odoo/odoo#38558

closes odoo/odoo#38573

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Makes it easier for users to match Odoo payments with information
from the Stripe dashboard.

closes odoo/odoo#39136

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

In the leaves app, you can create an allocation request where you can
select a leave type.

Before this commit:

    - The leaves type order is not correct when you have a lot of them.
      You should have your remaining leaves on the top of the list
      and for the leaves who has 0 remaining they should be at the end
      of the list.

      When you click on search more, the order is correct.

After this commit:

    - The leaves type order is correct.

Odony's comment: Leave types are reordered after each search(), based on
some context-dependent, non-stored conditions. The problem is that the
initial search() applies the given *limit*, so the "post-sort" will only
sort a limited number of random result from the initial search,
rather than all types matching the domain.

If you have more than 7 leaves types matching the domain, you have a
chance that the m2o auto-completion on the leave request form will not
suggest the correct leave types, because the post-sort will not even
receive them. So you may not see a leave type for which you have
remaining leaves!

OPW-2089593

closes odoo/odoo#39158

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Co-authored-by: odony <odo@odoo.com>

Commit https://github.com/odoo/odoo/commit/68d71b8eafa3227269de12ba3c64b9860fbcf63c


introduced a wrong domain
Falsy m2m must be explicited and put outside of the "in [ids]" leaf

This commit corrects it

OPW 2090865
OPW 2091449
OPW 2091778
OPW 2091778

closes odoo/odoo#39208

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>

Was comparing b'0x02' and '0x02'

closes odoo/odoo#39206

X-original-commit: 838cb0e8
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

closes odoo/odoo#39180

X-original-commit: 25d6e9a6
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

shop page link and popover use the same route which make a write on db
to recompute coupon lines. Can lead to concurent updates if unlucky on
timing.

task-2070507

closes odoo/odoo#38996

X-original-commit: https://github.com/odoo/odoo/commit/b5cffa8ce5c68b3389ef0bbd2ea416614afe81c7


Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

In form views, when the window size is too small, a "More" button
appears and it should contain the overflow buttons.

On all browsers, the "More" dropdown doesn't contain the expected
amount of buttons, so it is shifted on the second line.

Before this commit:

    - The "More" dropdown doesn't contain the expected amount of
      buttons, so it is shifted on the second line.

After this commit:

    - The "More" dropdown contains the expected amount of buttons
      and it is not shifted on the second line anymore.

OPW-2079694

closes odoo/odoo#38853

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>

The XML file homepage view record is not supposed to be deleted as it is used
to bootstrap newly created website.

If that view is deleted, everything's fine. But if that view's page is not
found (m2o link broken somehow), then the code would crash.

This would only appear if the user is playing in the backend in technical but
it seems to happen more than it should.

This commit will prevent the code to crash in such a case.

Step to reproduce:
1. Go to settings > technical > views (debug)
2. Find the xml homepage view (with xml_id)
3. Go to its website.page and break the m2o view_id
4. Try to create a new website, it will crash

opw-2081894

closes odoo/odoo#38897

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Due to commit odoo/odoo@f4031c62f97fa170b74b0d13a0856b7d58ed4da6
it was not more possible to scroll in a grouped kanban.

Steps to reproduce:
* Go to project app
* Select a project with a few numbers of task
* Create as need new task to have more task than visible on the screen
* Try to scroll (BUG)

Note: we also fix the swipe in empty column

opw-2080491

closes odoo/odoo#39103

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>

Actually, docker is used to test Linux packages once they are built.
The packaging process is done on the host system where package.py is
run.

Consequences:
    * difficult to reproduce an exact same build on another host
    * changing a Debian/Ubuntu target version means some upgrade steps
      on the build host (mix that with the fact that the host also
      could build old Odoo versions)
    * Fedora rpm package is built on an Ubuntu system (which is not a
      real problem but it could be)

With this commit, the package.py utility is refactored to use Docker
containers to build the Gnu/Linux packages.

closes odoo/odoo#39091

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

Without this patch, if a view defines a `<label for="forbidden_field"/>` anywhere, the web client tries to fetch the field data, but since the user has no access, it gets an error.

Now, if the label targets a forbidden field, it gets removed from the view, as happens with the related field. The client doesn't know of that field's existence and no errors happen.

closes odoo/odoo#38860

X-original-commit: a41aa063
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

closes odoo/odoo#39053

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Purpose
=======

Time to load systray messaging menu is too slow.

Time to load systray messaging menu:
- With 300 direct message channels, it takes at least 1.2 seconds.
- With 300 direct message channels and a dozen of "big" multi-user
  channels (#All, #News, #R&D, etc.), it takes at least 2 seconds.

The RPC 'channel_fetch_preview' is very slow. After some investigating,
it looks like 80% of the time takes place during message_format
postprocess when updating messages based on notifications:

Specification
=============

Now, we avoid to make query for each message.
And for attachment's message, we check attachment access rules and
search object only if the message has an attachment.

closes odoo/odoo#34863

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

closes odoo/odoo#39035

X-original-commit: c986b921
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Before this commit, the trash icons and "OR" indicator of each filter
was too far and couldn't be seen

Now, both of them are closer to the filter and can be seen in any circumstance.

Task 2073707

closes odoo/odoo#37722

Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>

Commit 83bb8224 introduced some fixes to make a few test of the
normal stripe module work, but unfortunately introduced a bug in
the process.

The reference we want to find the transaction is *not* contained
in the metadata dict but indeed in the reference param of the whole
response dict. Unfortunately, even the fallback of the get call did
not work - the metadata dict is still there, we just don't use it
anymore...

opw-2080651

closes odoo/odoo#38989

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

Users sometimes define custom models on SQL views
e.g. @nseinlet
In such a case, Odoo should not attempt to create foreign keys
as it just cannot work on views.

This could prevent the migration of a database
with such a custom model using a view
when it attempted to fix the missing foreign keys
when updating the modules.

closes odoo/odoo#38978

X-original-commit: dfaea03d
Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>

This test was raising an assert error if the DB has other websites than  the
data/demo ones.

As we have a new module in Odoo 13.0 (https://github.com/odoo/design-themes/pull/178

)
which is creating 25 websites, and since the design-themes runbot is now
running tests, we were having a red design-themes runbot.

closes odoo/odoo#38972

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Chart of Accounts (COA) Template for Lithuania's Accounting (VAS-15).

Data is multi language (English and Lithuania).

This module also includes:

* List of available banks in Lithuania.
* Tax groups (to map different tax amounts).
* Most common Lithuanian Taxes.
* Fiscal positions for different countries/groups.
* Account Tags used for reporting purposes.

closes odoo/odoo#35566

Signed-off-by: Josse Colpaert <jco@openerp.com>

With Anglo-Saxon accounting, invoices with stock_moves on a product
having 'real_time' valuation cannot be validated: there is a user error
when the interim account is not reconcilable.

We modify _anglo_saxon_reconcile_valuation so that we do not try to reconcile
when the account is not reconcilable.

OPW-2080180

closes odoo/odoo#38867

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

On a list view, Add a custom filter on a date
Change the operator to "in between"
Change it back to "equal"
Apply the search

Before this commit, the label of the filter still was in between
Whereas it should have been "equal to ..."

After this commit, the label of the filter is correct

OPW 2085951

closes odoo/odoo#38705

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>

In a list view, create a custom filter involving a date or datetime field

Before this commit, the domain that was sent to the server
contained the date or datetime as the pure string
representation that Moment.js constructs
that is a ISO compliant one, containing info on timezone

After this commit, the format is the one of the server, in UTC
and NOT ISO compliant. Also, the format for date is dealt with

OPW 2085936

It is possible to get to a situation where Odoo would try to send an email without a `From:` header address.

In such case, you're unlucky if you don't have access to the underlying deployment, or if you use multiple databases in a single Odoo instance and each of them uses a different mail configuration.

To make this configuration easier to use and cover those use cases, here I add support for a new ICP: `mail.default.from`. It will be used when present, so it shouldn't affect existing deployments. When present, it will allow a admin to configure the default sending address just with Odoo itself.

closes odoo/odoo#38833

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

The method ``action_pos_order_invoice`` is multi, and has a ``for`` to
each record, then, inside of that for, is called the method
``_action_create_invoice_line``, but is called with self, not with
order, that is each record.

This was fixed to avoid singleton error.

closes odoo/odoo#38828

X-original-commit: b3c88566
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

closes odoo/odoo#38810

X-original-commit: 62d7eaf8
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

In manufacturing orders, there is a kanban view.

The kanban items are drag & droppable from a column into another.
When moving an item into the "cancelled column", the stock move
is not applied.

Actually, you can't change the state of a MO by clicking on the state
in the status bar. So, the expected behavior is that you can't drag
and drop an item into another column.

According to this, I reproduced the same behavior than in V13.

Before this commit:

    - The kanban items can be drag and dropped from a column into
      another but there is no stock move

After this commit:

    - The kanban items cannot be drag and dropped like in V13.

OPW-2081255

closes odoo/odoo#38799

X-original-commit: 3e27de5a
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Before this commit, trying to print a registration without a name
specified (not required), was failing

Fixes odoo/odoo#38564

Replace and closes odoo/odoo#38582
Courtesy of Swapnesh Shah

closes odoo/odoo#38792

X-original-commit: a21a81e9
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

The im_support module was broken in 12.0 after bus refactorings between
11.0 and 12.0.

closes odoo/odoo#38479

Signed-off-by: Toufik Benjaa (tbe) <tbe@odoo.com>
Co-authored-by: @alexkuhn

Back port of #37160 adapted for the new sca module.

* External payment fetching the stripe API need valid account/key in order
  to perform the tests.
* 1st test is testing the previous stripe API, it has been disabled.
* 2nd test is testing for values removed by 595c0ad8, the test has
  been updated to only ensure the form renders without error.
* 3rd test is testing for amount sent as integers while stripe requires
  as cents.

closes odoo/odoo#38780

Signed-off-by: Julien Castiaux <Julien00859@users.noreply.github.com>

Have a reconciliation model that applies to some particular journals
And that will match some of those journals' lines
The field journal should be filled too
(this field is only the default journal that a proposition will be filled with)

Open the reconciliation widget on a given journal, within the list of
possible journal (from the account dashboard)

Before this commit there was a crashed. This was caused by the fact that
one of the lines that should be displayed had a reconcile model that was not fetched beforehand

After this commit, there is no crash as all relevant reconcile
models are fetched

Note that, on reconcile models, the field journal_id is just there to prefill
the propositions it will create

corrects commit e5c80714

OPW 2084942

closes odoo/odoo#38726

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>

- Create a SO with a pricelist in USD, add a line
- Change to a pricelist in EUR

The currency symbol on the SO line (subtotal field) is not updated.

This is because the dependency is not correct.

opw-2086907

closes odoo/odoo#38759

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

As the python3-xlrd package is available in Debian stretch and Ubuntu
bionic, there is no reason to not include it in Odoo debian package.

However, it cannot be used in Odoo 11.0 package as it does not exists in
Ubuntu Xenial.

ubuntu package:
https://packages.ubuntu.com/bionic/python3-xlrd

debian package:
https://packages.debian.org/stretch/python3-xlrd



closes odoo/docker#276

closes odoo/odoo#38728

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

preparation for cleaning of v13
task-2065018

closes odoo/odoo#38511

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Translate 'hours' and 'days' in leave allocation
This is not an ideal way to construct the sentence (cf
https://github.com/odoo/odoo/pull/38352#issuecomment-540548720

) but
the best to be done in stable, will be improved in 13.0.

closes odoo/odoo#38352

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>