Skip to content
Snippets Groups Projects
  1. Feb 19, 2019
    • Christophe Monniez's avatar
      [IMP] tests: replace browser_js success and failure strings · fec86404
      Christophe Monniez authored
      When evaluating js tests using the browser_js method, they are
      considered a success when 'ok' is found in the console log and a failure
      if 'error' is found instead.
      
      This is not very robust and recently failed with this commit : 7410de11
      It adds a filter named 'Error' in a view, when the 'click_all' test
      clicks on this filter, a message with the name of the filter is written
      in the console, wrongly leading to a test failure.
      
      With this commit, the browser_js method expects a log message in the
      browser console with the explicit text "test successful".
      On the other hand, any error in the console log will lead to a test
      failure but a test can be forced to fail with the explicit error message
      in the browser console "test failed".
      
      As a bonus, the python logger should now also log browser js trace messages.
      
      closes odoo/odoo#31158
      fec86404
    • Robot Odoo's avatar
      [FIX] website_slides: hide publish widget if user cannot publish · 83e6faf9
      Robot Odoo authored
      Purpose
      =======
      
      The "publish/unpublish" widget is always shown on slide.channel/slide.slide for
      a website_publisher user even if he's not allowed to manage the publishing of
      the channel (see slide.channel.can_publish field).
      
      This commit will hide the widget on both the slide.channel and the slide.slide frontend
      pages if the user doesn't have the right to publish/unpublish. A generic solution
      implemented directly in the publish mixin has been chosen to ease understanding
      and allow easy reuse in other applications.
      
      Commit linked to task ID 1902304 (main elearning task).
      
      closes odoo/odoo#31187
      Unverified
      83e6faf9
    • Robot Odoo's avatar
      [FIX] doc: build errors & some warnings · d56402a5
      Robot Odoo authored
      closes odoo/odoo#30835
      Unverified
      d56402a5
    • Aurélien Warnon's avatar
      [FIX] website_slides: handle publishing rights of channel/slide · 3c88e75c
      Aurélien Warnon authored
      Purpose
      =======
      
      Handle publishing of the slide.slide/slide.channel accordingly to the new
      'can_publish' field in the website published mixin.
      3c88e75c
    • Aurélien Warnon's avatar
      [IMP] website: add a field to handle publish rights for publish mixin · 91696805
      Aurélien Warnon authored
      Purpose
      =======
      
      The "publish/unpublish" widget is always shown on the frontend as long as the user
      is a website_publisher and the object has a "website_published" field.
      
      In some modules (namely website_slides) we need to handle a more refined level of access.
      
      This commit adds a "can_publish" computed field that can be overridden to add some additional
      access rules to the object and hide the widget if the user doesn't have the rights to
      publish/unpublish.
      91696805
  2. Feb 18, 2019
  3. Feb 15, 2019
    • Juhil Somaiya's avatar
      [IMP] mail_bot: Blocked notification alert to User · 02eebe15
      Juhil Somaiya authored
      If user has blocked odoo push notifications
      then there's no way to enable via the OdooBot notification in the systray as it depends on the navigator
      so display the alert message under users preference section.
      
      Related Task ID: 1929547
      
      closes odoo/odoo#30496
      02eebe15
  4. Feb 18, 2019
  5. Feb 12, 2019
  6. Feb 18, 2019
  7. Feb 15, 2019
    • David Monjoie's avatar
      [FIX] hr_payroll: use calendar as default view · e154d2c1
      David Monjoie authored
      The webclient doesn't handle a non-existing view as the default
      view. However, it must handle it correctly if it is not the
      default one since it does it for mrp.production already.
      
      closes odoo/odoo#31161
      e154d2c1
    • Robot Odoo's avatar
      [MERGE][IMP] website_slides: improve inclusion of gamification and ranks · f34a7edd
      Robot Odoo authored
      Purpose of this merge is to improve inclusion of gamification and ranking
      in elearning new main pages [1][2]. Ranking and profile information, links
      and templates are added.
      
      Some fixes are included in this merge, notably statistics computation, better
      slide image fetch and demo data. See sub commits for more details.
      
      Commit linked to task ID 1941250.
      
      closes odoo/odoo#31133
      Unverified
      f34a7edd
    • Thibault Delavallée's avatar
      [FIX] website_slides: fix text / html mismatch in demo data · 5822e309
      Thibault Delavallée authored
      Slide description is actually a text field, no need to put html tags that
      are displayed raw.
      
      Commit linked to task ID 1941250 and PR #31133.
      5822e309
    • Thibault Delavallée's avatar
      [IMP] website_profile, website_slides: add user ranking and karma on elearning main pages · bd2dae4f
      Thibault Delavallée authored
      Purpose of this commit is to improve karma and gamification inclusion in
      elearning [1].
      
       * remove a border, replaced by a standard hr, in rank template. It allows to
         reuse it easier as we don't necessarily want that border in other templates
         using it;
      
      Commit linked to task ID 1941250 and PR #31133.
      
      [1] task ID 1922159 (landed at 5fa651cb)
      bd2dae4f
    • Thibault Delavallée's avatar
      [FIX] website_profile, website_slides: clean user avatar controller and add one for slides · 1bb7b242
      Thibault Delavallée authored
      Purpose of this commit is to
      
       * clean user avatar controller and its calls;
       * extract default image computation;
       * add a controller to get slide image even when not having access to the slide
         as all slide name and images are displayed even if not available to the
         current user;
      
      Commit linked to task ID 1941250 and PR #31133.
      1bb7b242
    • Thibault Delavallée's avatar
      [REF] gamification: clean next rank motivational implementation · e7b35358
      Thibault Delavallée authored
      Purpose of this commit is to clean motivational capabilities of gamification
      ranks[1]. It makes more sense to store a motivational to achieve on next rank
      itself. We therefore rename the field and provide nice demo data that will be
      used in elearning use of gamification ranks.
      
      Commit linked to task ID 1941250 and PR #31133.
      
      [1] task ID 1922159 (landed at 91ee6ba5)
      e7b35358
    • Thibault Delavallée's avatar
      [FIX] website_slides: fix some statistics and publication issues · 6a9f6876
      Thibault Delavallée authored
      This commit fixes various issues introduced by recent commits in slides
      
       * fix slide type computation: using a dict in a fromkeys makes a shared
         object for all keys. It is better to fix that behavior;
       * correctly display number of course steps in elearning homepage. Currently
         number of steps of a course is simply the length of its one2many;
         holding slides. However this one depends on access rights which give funny
         results like a course with 2 steps for public users and 7 for admin;
         Right computation is: number of published lessons, whatever your access
         rights are. This is already computed as total_slides;
       * people that cannot publish should not be able to unpublish;
      
      Commit linked to task ID 1941250 and PR #31133.
      6a9f6876
    • Robot Odoo's avatar
      [MERGE][ADD] website_slides_survey: add a new bridge between slide and survey · b2149bc7
      Robot Odoo authored
      Task #1940360
      Subtask of #1902304
      
      Purpose
      =======
      
      Adds certification capabilities to the website_slides module.
      Channel/courses can now include certifications as a new type of slide.
      
      This new type of slide is available as a "Certification" button on the slide creation
      frontend view (next to "Video", "Presentation", ...).
      Users have to link the slide to an actual survey that has the 'certificate' field
      set to true (that will populate the slide's survey_id field).
      
      Slides of type certification are handled in frontend in a very simple way for now:
      - A button "Begin certification" that redirects the user to the related survey frontend.
      - A button "Download certification" when the user has succeeded the certification.
        (A new download route has been added in the survey module to make it work.)
      - When the survey is done, if it's linked to a slide, a button "Go back to course" allows
        the user to go back to the slide frontend.
      
      (There is a special use case for when the website_publisher designing the survey lands on a
      certification slide: he is allowed to test the survey with a survey_input created as test_entry)
      
      Survey creation as well as limited time, limited number of attempts, ... are still completely
      handled in the survey module. That means that the user will have to first create a suitable survey
      that is a certification and only then create a slide of type "certification" and link
      the created survey to it.
      
      Ideally, the taking of the survey should be transparently included in the slide frontend but
      it requires a full refactoring of the way surveys are submitted. This will most likely come in
      a later commit.
      
      This commit is an advanced merge of full eLearning module (see task #1902304).
      
      closes odoo/odoo#31060
      Unverified
      b2149bc7
    • Aurélien Warnon's avatar
      [FIX] website_slides: fix channel statistics computation · 171c7028
      Aurélien Warnon authored
      Purpose
      =======
      
      Channel statistics computation in the _compute_slides_statistics method
      did not work for a batch of channels.
      
      (The stats dict was shared for all the channels).
      171c7028
    • Aurélien Warnon's avatar
      [ADD] website_slides_survey: add a new bridge between slide and survey · f322816a
      Aurélien Warnon authored
      Task #1940360
      Subtask of #1902304
      
      Purpose
      =======
      
      Adds certification capabilities to the website_slides module.
      Channel/courses can now include certifications as a new type of slide.
      
      This new type of slide is available as a "Certification" button on the slide creation
      frontend view (next to "Video", "Presentation", ...).
      Users have to link the slide to an actual survey that has the 'certificate' field
      set to true (that will populate the slide's survey_id field).
      
      Slides of type certification are handled in frontend in a very simple way for now:
      - A button "Begin certification" that redirects the user to the related survey frontend.
      - A button "Download certification" when the user has succeeded the certification.
      - When the survey is done, if it's linked to a slide, a button "Go back to course" allows
        the user to go back to the slide frontend.
      
      (There is a special use case for when the website_publisher designing the survey lands on a
      certification slide: he is allowed to test the survey with a survey_input created as test_entry)
      
      Survey creation as well as limited time, limited number of attempts, ... are still completely
      handled in the survey module. That means that the user will have to first create a suitable survey
      that is a certification and only then create a slide of type "certification" and link
      the created survey to it.
      
      Ideally, the taking of the survey should be transparently included in the slide frontend but
      it requires a full refactoring of the way surveys are submitted. This will most likely come in
      a later commit.
      
      This commit is an advanced merge of full eLearning module (see task #1902304).
      f322816a
    • Aurélien Warnon's avatar
      [IMP] website_slides: support slide_type param in slides/all route · dcce7716
      Aurélien Warnon authored
      Task #1940360
      Subtask of #1902304
      
      Purpose
      =======
      
      The slide/all route now supports a 'slide_type' param that will filter channels
      to contain at least one slide of type 'slide_type'.
      
      This is a preliminary work for the slides_survey bridge.
      dcce7716
    • Aurélien Warnon's avatar
      [IMP] survey: add a route to download a certification pdf · b5c90c78
      Aurélien Warnon authored
      Task #1940360
      Subtask of #1902304
      
      Purpose
      =======
      
      This commit adds a route allowing to download a certification for
      a user that has succeeded it.
      
      It's currently not used in any views but it's a preliminary work
      for the future slide bridge.
      b5c90c78
Loading