Skip to content

Refactor PortabilityWithoutPhoneNumberException

Administrator requested to merge refactor-PortabilityWithoutPhoneNumberException into master
  • The exception was captured to send to OTRS in the wrong piece of code: It is raised instantiating the NewLineRequestMapping, and not the return of PyMasMovil's OrderItem.create() method.
  • Introduce changes with the exception instantiation to automatically call OTRS when it is raised, without the need to specify it in a try except clause.

Commit 2: Also refactor NewNumberRegistrationWithPhoneNumberException following the same logic

Commit 3: Delegate OTRS error communication logic to an exception handler

⚠ TODO: test that when celery gives an error we sent the exception to OTRS)

Edited by Administrator

Merge request reports