When printing a draft invoice, it raises an error.

The error comes from fix #65320: the latter registers the printed
invoice as main attachment, but this needs to be done only with posted
invoices.

OPW-2427247

closes odoo/odoo#66516

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Steps to reproduce the bug:

- Let's consider a product P with a subcontracting BOM B and subcontractor S
- Create a purchase order PO with S as vendor
- Add P on PO and confirm it
- Change quantity of P two times

Bug:

A traceback was raised

opw:2419222

closes odoo/odoo#66440

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Using `read_group` to gather such a sum is always more performant
than a `search` followed by a `mapped`.

In the case of the studied database,
the computation never ended,
while it ends in a few seconds
using `read_group`.

upg-7528

closes odoo/odoo#66502

X-original-commit: 8547bb6145c3ddf9c7205ea10deef22473362cce
Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>

When importing some invoice lines, if the analytic account field of a
line has changed, the new invoice line will still keep the initial
analytic account value.

To reproduce the error:
(use demo data)
1. Create an invoice I01
    - Add one line with one analytic account (e.g., "Administrative")
2. Save
3. Go to Accounting > Customers > Invoices
4. Export I01:
    - Enable "I want to update data (import-compatible export)"
    - Fields to export:
        - Invoice lines
        - Invoice lines/External ID
        - Invoice lines/Analytic Account
        - Invoice lines/Analytic Account/Analytic Account
5. On exported file:
    - Delete column "invoice_line_ids"
    - Change the analytic account (e.g., "Operating Costs")
6. Import the file
7. Open I01

Error: The analytic account is still "Administrative". It should be
"Operating Costs".

The issue comes from both `._origin`: the module keeps the initial
values. Both `_origin` were introduced to fix an issue (see #49110), but
they are not useful anymore.

OPW-2452428

closes odoo/odoo#66433

Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>

Neither server, no browser cannot handle unlimited number of lines at the same
time. On server side it leads to series of heavy sql requests. On client side,
browser will eat all the memory on trying to render all of those lines.

This also prevents loading reconciled lines ids to browser.

Size of the batches can be customized via System Parameter
``account.reconcile.batch``

Details:
* ``action_bank_reconcile_bank_statements`` is used on clicking `[Reconcile]`
button in ``account.bank.statement`` form
* ``action_open_reconcile`` is used on clicking `[Reconcile]` for a journal in
Account Dashboard

---

opw-2424992
opw-2344807

closes odoo/odoo#65789

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Issue

	- Install "Sales" module
	- Go to settings and activate "Product Configurator" feature
	- Create a product X with mutilple color (variants)
	- Create a quotation
	- Add product X (Product Configurator should open)
	- Hover any color

	Popup with color name does not appear.

Cause

	'title' attribute value is removed.

Solution

	if element have 'value_name' data attribute, set it back as title else set no title.

opw-2438704

closes odoo/odoo#66451

X-original-commit: efa36bc522771e17805ee965bdc0f0315b5f34ff
Signed-off-by: bon-odoo <nboulif@users.noreply.github.com>

If a field is sanitized, a6e2b484 would hide the video button because
the video does not show in backend. It is better for the consistency but
if the field appear in frontend, the video would still show so we
prevent something that worked (but is very not user friendly when
editing in backend).

This changeset go back to the previous behavior (keeping the code
simplification), at one point there should be a fix so at least when
editing we see the video (currently we see an empty div in given
conditions).

opw-2463746

closes odoo/odoo#66434

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Enter keypress browser event were removed in 3c372d1d.

It was reintroduced in text fields with d2f024d2 and in source mode
of html field with b10ca1f6.

When doing ENTER in the editor, we do our special case of ENTER (eg. it
will split the container in two and have other custom behavior) but when
doing SHIFT+ENTER we let the browser handle it and add a normal newline.

With the "Enter" prevention, SHIFT+ENTER did not work.

opw-2463746

closes odoo/odoo#66426

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Steps:
- Log in as admin
- Install calendar
- Activate the developer mode
- Go to Calendar
- Create a new event:
  - Attendee: demo (1)
  - Misc tab:
    - Owner: demo (1)

Bug:
Access Denied:
(Document type: Message, Operation: read) - (Records: [84], User: 2)

Explanation:
The author of the message is not the current user from this commit
onward: https://github.com/odoo/odoo/commit/160d321b821c669185054b7fb8515e88fc22bd5a


The access denial appears when trying to add the ICS file to the
message. The current user is not allowed to read the old attachments
since they are not a part of the discussion.

opw:2454395

closes odoo/odoo#66166

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Currently a package level is created and has the newly created package
assigned to it when "Put In Pack" is used. Unfortunately if a move line
has its result_package_id changed after having a package assigned via
the Put In Pack, then the package level's package_id isn't correctly
updated. This leads to incorrect data in the db. This incorrect data
doesn't affect much since result_package_id from an entire package move
cannot be changed in any views, but it does mean that the created
package associated with the package level can never be deleted even if
it's never used.

Steps to reproduce:
1. active (delivery) packages in settings
2. create a picking and create some done values
3. use "Put In Pack" to put done move lines into a package
4. change the newly created Destination Package to another package
5. Go to Packages and try to delete the package created by Put In Pack

Expected result: able to delete the package
Actual result: Server error that package is still required by Stock
Package Level.

This is a short term fix. In the long run it would be better to fix the
package_level logic so it isn't unnecessarily assigned to moves/move
lines and/or updates in a cleaner way.

Task ID: 2418907

closes odoo/odoo#66386

X-original-commit: e5ab8cf9
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

Go to Website
Go to conatct us form
Switch in Edit mode
Click on “send” (or "submit")
click on edit link

A js traceback will apper. This occur because we refocus an elements
which may not be the correct one. In this case $editable will contain
all the contact form instead of just the relevant div of the submit
button

opw-2439090

closes odoo/odoo#66081

Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com>

The access rule on a project with invitation only will for example
check if the user is follower of a task inside this project.

Currently it used task_ids to do that, so:

- you would not see a project where you have access to project if the
  tasks you have access to are in folded columns

- there is an odd issue with computation of the field value and the
  domain where is might cause an error and make Project app
  inaccessible (when searching it doesn't filter on task_ids domain,
  so find too many results, when checking security for compute fields
  it filters on it

In any case, we should use tasks which also contains task in folded
stage and not just task_ids.

opw-2455780

closes odoo/odoo#66375

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Before this commit, the o_we_selected_image class was not removed from
forum post when saving.

task-2312878
Part of #66316

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

A comma was removed in the following commit for no reason
912996fe . Because of this, the click
event of the forum post submit button was not working.

task-2312878
Part of #66316

Let's assume the following scenario:
 - have an action in target new (e.g. a form view)
 - in the dialog, have an action/object button with confirm
   attribute
 - when clicking on that button, a confirm dialog opens
 - if validated, the following action returned by the server
   is again an action in target new

Before this commit, the confirm dialog remained in the DOM.

This issue occurred because it's parent wasn't correctly set (wrong
use of `this`), so when the first dialog was destroyed, the confirm
dialog wasn't automatically destroyed in turn.

OPW~2440712

closes odoo/odoo#66340

X-original-commit: 2016fe31af970976775c9df160a31abfbec742ba
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

91937764 added new selector to target other location where product name
could break the interface on short screen or with long unbreakable word
in title.

But there is some use case missing where overflow-wrap doesn't work and
word-wrap doesn't. Also adding overflow-wrap since word-wrap is
deprecated.

opw-2451496

closes odoo/odoo#66279

X-original-commit: e3eb5bf4
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

This commit ba32244c introduced an error when
validating pickings or reconciling

closes odoo/odoo#66331

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

- Install stock
- Go to Inventory > Configuration > Settings and enable "Lots" and "Storage Locations"
- Create a Product tracked By Lots (i.e. Product X)
- Go to Inventory > Operations > Inventory Adjustments
- Create an Inventory Adjustment for Product X:

     Product   |   Location   |   Lot/SN   |   Real Quantity
 -------------------------------------------------------------
    Product X  |   WH/Stock   |   LOT 01   |       20
    Product X  |   WH/Stock   |            |       10

- Validate Inventory
- Go to Inventory > Operations > Transfers and create one:
  * Source Location: WH/Stock
  * Destination Location: WH/Stock/Shelf1
  * Operation Type: Internal Transfers
  * Operations:
    [Product: Product X, Initial Demand: 25]
- Save Transfer, Mark As Todo and Check availability
- Click on list icon of Operation line for Product X to display Detailed Operations
- 20 units of LOT 01 and 5 units without lot have been reserved
- Set LOT 01 for the 5 reserved units without lot and confirm
- Open Detailed Operations again
- There are now 20 units of LOT 01 and 5 units of LOT 01
- Remove the row with 5 units and confirm
- Check availability and open Detailed Operation
- There is now only a row with 25 reserved units of LOT 01
- Unreserve
The following errror is raised:
"It is not possible to unreserve more products of P than you have in stock."

It happens because the system is not able to manage quants with lots and
wihtout lots at the same time. When modifying the move line to 25
reserved units. It's composed of 20 quants with lot and 5 quants without
lot. And when unreserving it will check if there is a quants with 25
units with the lot and if it's not found 25 units without lot. But never
25 units of quants with lots and without lots.

opw-2419444

Close #64497

closes odoo/odoo#66029

X-original-commit: 217c76b11e6c2bb5bf861284343c87b4ca241da1
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

before this commit: when there is only one page in the notebook tag and
there is a boolean field in form to show/hide that notebook page based on
invisibility attrs, if we toggle boolean field notebook hides, that's OK
but when we toggle boolean field again then notebook page is displayed but
it is not active and due to that content of notebook page is not displayed.

after this commit: when there is only one page in notebook and it has attrs
for invisibilty, when we toggle boolean field to hide/show notebook page
then notebook page as well as content is toggled.

task-2449053

closes odoo/odoo#66241

X-original-commit: 33e2c947f5af3bf4bd8944e5adc3a02a2f07243b
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Let's assume a <groupby> node in a list view containing a button
with an invisible modifier referencing a many2one field, e.g.

```
 <tree>
   <groupby>
     <field name="m2o" invisible="1"/>
     <button string="do it" attrs="{'invisible': [('m2o', '=',
False)]}"/>
   </groupby>
 </tree>
```

Before this commit, the m2o field was correctly read, but it's
value wasn't processed by the model, so the modifier wasn't
correctly evaluated.

Issue reported on PR https://github.com/odoo/odoo/pull/65316/



closes odoo/odoo#66286

X-original-commit: bbaeeb76bbef4ea371d3db5821af91bf1fe9ac4f
Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>

The unlink fail in __init__.py uninstall hook is managed, however
when it fail, the error is catch but the cursor is not rollback and
do not accept additional transaction. That result in a traceback at
uninstall.

opw-2453939

closes odoo/odoo#66278

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

When printing some invoices, they are not registered as main
attachment. Therefore, when sending a follow-up report, a UserError
message asks the user to print the invoices first.

To reproduce the error:
(Need account_accountant, use demo data)
1. Go to Accounting > Configuration > Invoicing > Follow-up Levels
2. Select "First Reminder Email"
3. Enable "Join open Invoices"
4. Create an invoice INV01 for customer C01 + Post INV01
5. Go back to Accounting > Customers > Invoices, select INV01
	- ! Do not open the invoice. Just select it.
6. Print > Invoices
7. Go to Follow-up Reports
8. Select C01
9. Send by mail

Error: An error message is displayed: "You are trying to send a followup
report to a partner for which you didn't print all the invoices" but it
does not make sense because the invoice has been printed.

For a follow-up report to be sent, the invoices must have the field
`message_main_attachment_id` defined (see
[code](https://github.com/odoo/enterprise/blob/476d862aba396c54c7a47950e02af7aed008a2db/account_followup/models/account_followup_report.py#L311-L313)).
There are two ways for this field to be set:
- When sending the invoice, `_message_set_main_attachment_id` is called,
select one attachment and mark it as main one
https://github.com/odoo/odoo/blob/437b49860b46b5abb8f55ced349fece984968998/addons/mail/models/mail_thread.py#L1918-L1924
- When opening the invoice, if the sreen is large enough, a pdf viewer
is opened next to the invoice. This pdf viewer will call
`register_as_main_attachment`, the latter marks the `ir_attachment` as
main one:
https://github.com/odoo/odoo/blob/e6a41b118a94c5b101d127f6b70fc54958e9346b/addons/mail/models/ir_attachment.py#L17-L20



However, when the user only prints an invoice, nothing will set the
`message_main_attachment_id` field. Thus, this fix will call
`register_as_main_attachment` when a pdf is generated and will mark it
as main attachment.

OPW-2427247

closes odoo/odoo#65320

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Do a transfer in two steps with several move lines (e.g.: Vendors => Input => Stock).

In the first picking, set quantity = 0 on a single line. Transfer it and say 'No backorder'.

In the second picking, set all quantities (you have two move lines confirmed and one canceled). Validate the
transfer. The backorder wizard is launched. It should not.

closes odoo/odoo#66122

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

The mail signature of an user did not inline the CSS like the body of a
message, so for example icons seemed to work but would not be seen
(unless the mail reader had the same font-awesome system).

With this change we inline the signature too.

On edition there was also an issue since the original icon was saved as
data-class which was stripped: so eg. when editing a mail.message with
working icon, the icons would disappear.

opw-2453912

closes odoo/odoo#66216

X-original-commit: 29347ceefa1f83a350a544a02d040e69f2906aaf
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

before this commit: when there is a horizontal scroll in view say for example
kanban view where there are too many columns and user scrolls horizontally and
go to form view by clicking on any record and then come back to kanban view
horizontal scroll is not preserved and user is moved to scroll position 0
this is due to commit: https://github.com/odoo/odoo/commit/19eacf7d23c9413de4430a3422b5ed74b37ef242



after this commit: scrolling horizontally and then go to form view and come
back to previous view will preserve scroll position, we also consider case for
kanban view where there are too many columns and user click on 'Add Column'
user will be scrolled to new column element.

task-2418275

closes odoo/odoo#66215

X-original-commit: 171036aefe21799f7a791cc3cd73a7d249aa0b00
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Before this commit:

If a next activity is "triggered", the discard button is not visible.

After this commit:

Even if a next activity is "triggered", the discard button will visible.

Task-2459645

closes odoo/odoo#66211

X-original-commit: 33ec55d8
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

In some location, a long unbreakable word would cause following columns
to be hidden (depending on size of unbreakable word, font, font size,
...). For example, this happened in the cart summary on payment page.

With this changeset, if not possible otherwise, line break happen inside
the word.

opw-2451496

note: from 13.0 the shop product lists are inside .card so the h5
override (that is now h6) is not necessary.

closes odoo/odoo#66191

X-original-commit: 91937764
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

The company is used to compute currency of:

- discount_fixed_amount
- discount_max_amount
- rule_minimum_amount

If currently we don't set a company, we have an error when using the
company.

opw-2458950

closes odoo/odoo#66210

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

This guarantees the cache consistency of the many2many field values.

closes odoo/odoo#66173

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

Fix pre-printed report so that invoice date remains
in same position as if not pre-printed

closes odoo/odoo#63592

Signed-off-by: Josse Colpaert <jco@openerp.com>

Before this commit, the preview of the dragged snippet didn't work
when moving a dragged snippet from a drop zone to an other drop zone
when there was no space between those drop zones.

It is because, in this case, the over event of the second drop zone is
triggered before the out event of the first drop zone.

task-2312878

closes odoo/odoo#66148

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Issue

	- Install "Accounting" module
	- Create a new bill :
	- Set vendor
	- Set no payment reference
	- Set a bill reference
	- Add products to bill
	- Confirm and click on Register Payment

	Memo field has no value.

Cause

	The memo field is based on lines name.
	Lines name is computed in `_onchange_payment_reference`
	and depends only on payment_referecence.

Solution

	If no `payment_reference`, fallback on `ref` to set line name.

opw-2440389

closes odoo/odoo#66032

Co-author: nboulif <bon@odoo.com>
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

Have grouped list with reference a m2o or a reference field

Select some records, edit them

Before this commit: the names of the reference fields and m2o disappeared

That was because the saveRecords function did not take into account a grouped list

manual forward port of #65999

After this commit: it works as expected

closes odoo/odoo#66043

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>

Have a list with multi_edit enabled
Have a widget boolean_toggle displayed on some field
Select some records to be in multi edit mode

Before this commit, the record on which the boolean toggle button was clicked was written
and then the multi edit feature was triggered and wrote on all the records
The first write is unnecessary and counter intuitive

After this commit, only the write with all the multi edited records is done

follows #59830

In a4d170ad there were some improvment to not show event totally empty
on the day calendar view because of different style (font + padding).

The lower part of the text was still a little cut, this commit try to
improve this for week and day view mode by removing 5 additional pixels.

opw-2422700

closes odoo/odoo#66078

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

with this commit, we fixes UI glitch on image widget when image is too small,
when hovering over too small image Edit and Delete icon will ne displayed but
it is displayed with glitch, so to avoid that glitch we added min-width to
icons div.

task-2376452

closes odoo/odoo#66056

X-original-commit: 7aaad848
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

The route for customer rating force the customer language.

If website is installed, this overrides the normal language so if
current website language is spanish and customer is english, either:

- we will have a page with two languages mixed with language selector
  set on spanish but showing mostly english

- or if english is not installed, we get an error

With this changeset, if website is intalled we just let it handle
language (previous language used, or if not browser language, ...).

Not necessary in 12.0 since we did not use frontend_layout (e9be0bb1).

opw-2449678

closes odoo/odoo#66055

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

closes odoo/odoo#66039

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>