Skip to content
Snippets Groups Projects
  1. Jan 15, 2019
  2. Jan 14, 2019
  3. Jan 10, 2019
  4. Jan 08, 2019
    • Jorge Pinna Puissant's avatar
      [FIX] account: error in Base amount tax · b1316589
      Jorge Pinna Puissant authored
      opw-1917605
      
      Before this commit, when accounting is set to global rounding, the base
      amount per tax is not correctly calculated.
      
      Now, the Base amount per tax is calculated adding the rounded lines.
      
      To test this issue, you need to set to global rounding and create a
      customer invoice with the following lines :
      line 1 = Qty:40; unit price:2.27; tax:15%; discount: 10%
      line 2 = Qty:21; unit price:2.77; tax:15%; discount: 10%
      line 3 = Qty:21; unit price:2.77; tax:15%; discount: 10%
      
      When the invoce is printed, you would notice that the amount is 186.43
      and it should be 186.42.
      
      closes odoo/odoo#30021
      b1316589
  5. Jan 07, 2019
  6. Jan 04, 2019
  7. Jan 03, 2019
    • Raphael Collet's avatar
      [FIX] models: avoid prefetch hell when reading fields · a07a076c
      Raphael Collet authored
      The method `read()` may be very slow when reading relational fields and
      computed fields, because the computed fields can be computed on a recordset
      that is larger than expected.
      
      The issue occurs on model 'res.partner' when reading fields 'child_ids' and
      'purchase_order_count', for instance.  Suppose we read those two fields on a
      partner with 1000 contacts.  First, the one2many field is read from the
      database and stored to the cache; the latter adds the value ids to the
      prefetching of 'res.partner'.  Then, the fields are fetched from the cache.
      When 'purchase_order_count' is accessed on the partner, the field is computed
      on all its children as well...
      
      closes odoo/odoo#29867
      a07a076c
  8. Jan 02, 2019
    • Denis Vermylen's avatar
      [FIX] purchase: loading time on partners with many children · e1767490
      Denis Vermylen authored
      When loading a partner form view, the ORM prefetches the computed fields
      purchase_order_count and supplier_invoice_count for all the related
      partners as well (parent, children, ..).
      
      Instead of reading the orders and invoices once per partner, we group
      them all together.
      
      opw 1919933
      
      closes odoo/odoo#29788
      e1767490
  9. Jan 11, 2019
    • Raphael Collet's avatar
      [FIX] models: make prefetching more specific in read() · 1b434ed8
      Raphael Collet authored
      Commit a07a076c restricts the prefetching to
      `self` when accessing the fields to return.  This is too restrictive, as it
      cancels prefetching of secondary records in computed fields.  In this commit we
      limit the scope of the restriction to `self`'s model only; this fixes the
      original issue without impacting other models.
      
      closes odoo/odoo#30133
      1b434ed8
  10. Jan 10, 2019
  11. Jan 02, 2019
  12. Dec 28, 2018
  13. Dec 18, 2018
    • wan's avatar
      [ADD] l10n_nl: tax codes for 9% · 9ef78025
      wan authored
      closes issue #29352
      The Dutch taxes will change the low tax 6% to 9% on 01/01/2019. Please add these tax code in the system and also change the affected fiscal positions. Both 6% and 9% needs to exist during the transition period.
      
      closes odoo/odoo#29374
      9ef78025
  14. Jan 01, 2019
  15. Dec 21, 2018
  16. Dec 19, 2018
    • David Tran's avatar
      [IMP] base: Vietnam Dong should have 1.00 as rounding. · 6bf8b25b
      David Tran authored
      No decimal part in Vietnam Dong (đ - Việt Nam Đồng)
      
      closes odoo/odoo#29650
      6bf8b25b
    • Denis Ledoux's avatar
      [IMP] product: name_get, use mapped to gain some memory · 5856dab3
      Denis Ledoux authored
      This revision is related to
      12df3c6a
      
      The above revision serve its purpose as well,
      but by avoiding to store the result in a variable,
      and using the records cache instead,
      we gain some memory, which is noticeable
      when there are hundred of thousands products.
      
      The sudo() is important, as it must be the
      same environment then the above call to read
      to use the same cache.
      Otherwise the values won't be in the cache
      of self (without sudo),
      and it will go get it and prefetch other fields
      in the database.
      5856dab3
    • Denis Ledoux's avatar
      [FIX] product: name_get, products can share the same template · 12df3c6a
      Denis Ledoux authored
      Oversight in revision
      a91ffcf1
      
      Multiple products can have the same template.
      
      Passing multiple times the same template id
      to the search domain to get the sellers
      works, but better avoid the repetition
      for the performances.
      12df3c6a
  17. Dec 17, 2018
    • Denis Ledoux's avatar
      [IMP] product: product & template name_get performance · a91ffcf1
      Denis Ledoux authored
      By prefetching only the fields required for the `name_get`
      
      `product.product` & `product.template`
      have a huge number of fields,
      and prefetching them just to compute
      the name is overkill.
      
      Especially, as the browse was done using
      sudo, the prefetch was a bit useless as
      it was stored in the sudo user cache,
      which was most-likely not used afterwards
      by the callee of name_get
      
      For a database with 50.000 products,
      this reduce the processing time
      by 15 (from 60 seconds to 4 seconds measured)
      a91ffcf1
  18. Dec 13, 2018
    • Nicolas Martinelli's avatar
      [FIX] account: missing translation · 8373bafb
      Nicolas Martinelli authored
      - Install a second language, e.g. French
      - Set Parter A language to French
      - Create an invoice for A with a date due in the past
      - On the partner form view, print the 'Due Payments'
      
      The body of the letter is not translated in French.
      
      Something quite weird appears:
      - The corresponding string is exported in the `stock` module
      - It is linked to the demo data `stock.res_company_1`, which corresponds
        to 'My Company, Chicago'.
      
      Therefore, the translation cannot be found by the corresponding query
      generated in `_generate_translated_field` and `_read_from_database`:
      ```
      SELECT "res_company"."id" as "id",COALESCE("res_company__overdue_msg"."value", "res_company"."overdue_msg") as "overdue_msg" FROM "res_company" LEFT JOIN
                      (SELECT DISTINCT ON (res_id) res_id, value
                       FROM "ir_translation"
                       WHERE name='res.company,overdue_msg' AND lang='fr_BE' AND value!=''
                       ORDER BY res_id, id DESC)
                   as "res_company__overdue_msg" ON ("res_company"."id" = "res_company__overdue_msg"."res_id")
                              WHERE "res_company".id = 1  ORDER BY "res_company"."sequence" ,"res_company"."name"
      ```
      
      Indeed, `res_company.id` is 1, while `res_company__overdue_msg.res_id`
      is 3.
      
      The root cause has been solved in v11, to we only export the necessary
      term.
      
      opw-1908337
      
      closes odoo/odoo#29525
      8373bafb
  19. Dec 11, 2018
  20. Dec 07, 2018
    • Raphael Collet's avatar
      [FIX] mail: wrong many2many definition · 54238c88
      Raphael Collet authored
      The definition of `attachment_ids` on model `email_template.preview` is wrong,
      because its table/columns refer to the model `mail.template`.  As the field is
      only used to preview a result in a wizard form, it does not need to be stored.
      
      closes odoo/odoo#29349
      54238c88
  21. Dec 10, 2018
  22. Dec 05, 2018
  23. Dec 04, 2018
    • Christophe Simonis's avatar
      69d342f5
    • Jairo Llopis's avatar
      [FIX] auth_ldap: Avoid sending email for newly created user · 81c26383
      Jairo Llopis authored
      If installed along with `auth_signup`, it sends an email when creating a missing user authenticated through LDAP.
      
      It is a confusing message that makes no sense, because the user is, from his POV, not actually creating a new user, but just authenticating with a new app with his known company-wide credentials.
      
      Besides, that invitation leads the user to change his password in Odoo, although he probably doesn't want to do that and have a password for Odoo and another in the LDAP server.
      
      The best option is to disable that email completely, which is what this commit does.
      
      closes odoo/odoo#29243
      81c26383
  24. Dec 05, 2018
  25. Nov 30, 2018
Loading