Skip to content
Snippets Groups Projects
  1. Aug 21, 2019
  2. Jul 30, 2019
  3. Aug 21, 2019
    • Shreya Modi's avatar
      [IMP] mail: improve create_uid heuristics in mail gateway · af80c68a
      Shreya Modi authored
      
      PURPOSE
      
      Currently mailgateway runner user is used to create most documents through
      incoming emails. Purpose of this commit is to try to link document creation
      and update to users, using the email to make the matching.
      
      SPECIFICATIONS
      
      New sudo implementation allow to bypass access rights while keeping effective
      user as creator. Use this mechanism to create documents still using the
      mailgateway runner user while linking creator to matching user.
      
      Heuristic to use to match email_from and users
      
      * if route is linked to an alias: check its owner record and check in its
      followers;
      * find users having this emails;
      * if route is linked to an alias: use alias_user_id field;
      * fallback on mailgateway user;
      
      Other side effect is that creator and author of incoming email linked to the
      new record will now better match the document creator when linked to an
      existing user.
      
      LINKS
      
      Task 1919267
      PR #30597
      
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      af80c68a
    • Thibault Delavallée's avatar
      [IMP] mail: remove unnecessary decorators · 109f3907
      Thibault Delavallée authored
      Purpose of this commit is to lessen complexity of stack chain in mail main
      methods. Removing decorators is a good start for this.
      
      LINKS
      
      Task 1919267
      PR #30597
      109f3907
  4. Aug 20, 2019
    • Raphael Collet's avatar
      [FIX] base: allow to remove fields when the registry is not ready · a9567a7f
      Raphael Collet authored
      
      When the registry is not ready, allow modifications of the selections
      
      The following use case must reset the values:
      - removing a selection on a custom field via studio
      - changing the static selection definition and updating the module
      
      The value must NOT be reset when:
      - trying to remove manually a base field
      - updating a module without all override being computed yet
      (i.e. install)
      
      Fully replacing the selections in an override should not happen
      
      Instead of relying on the context, check if the registry is ready
      before marking the selections as to remove.
      If a static selection is removed and the module updated, it will be
      removed correctly during the _process_end method as the selections
      will not be present in pool.loaded_xmlids
      
      Before this commit, updating a module A was doing a SET NULL for
      selection values added by a module B via a selection_add
      
      closes odoo/odoo#35871
      
      Signed-off-by: default avatarRaphael Collet (rco) <rco@openerp.com>
      
      
      Co-authored-by: default avatarMartin Trigaux <mat@odoo.com>
      a9567a7f
  5. Aug 21, 2019
    • Robot Odoo's avatar
      [MERGE] portal, website_{mail, rating}: fix frontend rating and reorganize portal chatter overrides · c2d4873e
      Robot Odoo authored
      
      PURPOSE
      
      Fix frontend rating and clean a bit module organization.
      
      SPECIFICATIONS
      
      Fix rating in frontend (website_slides, website_sale): rating is halved at each
      update and new entries have no rating.
      
      Also reorganize portal chatter overrides
      
      * rename files to ease code reading and discovering;
      * move assets in their own file to better understand modules;
      * move rating widget in its own file;
      
      LINKS
      
      Task 2057301
      PR #35870
      
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      c2d4873e
    • Robot Odoo's avatar
      [ADD] pos_epson_printer: Use Receipt printer without IoT Box · 59ac7281
      Robot Odoo authored
      
      Linked to odoo/enterprise#5182
      
      Add possibility to print receipts and orders on an ePOS compatible
      Epson receipt printer located in the same local network than the
      browser running the pos.
      
      TaskID: 2033442
      
      --
      I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
      
      closes odoo/odoo#35829
      
      Signed-off-by: default avatarQuentin Lejeune (qle) <qle@odoo.com>
      59ac7281
    • Hetal Dhanak's avatar
      [FIX] mrp: cast datetime from web interface · 9412695d
      Hetal Dhanak authored
      
      Updating a datetime field in a form view will fill the 'values' dict
      with a string.
      This commit casts the dates in mrp.production and mrp.workorder that are given to
      their respective stock move into actual datetime object. This prevent any
      converting error later in the process
      
      Task : 2055912
      
      closes odoo/odoo#35825
      
      Signed-off-by: default avatarSimon Lejeune (sle) <sle@openerp.com>
      9412695d
    • Thibault Delavallée's avatar
      [FIX] portal, website_rating: re-allow rating from frontend · 532b1a50
      Thibault Delavallée authored
      PURPOSE
      
      Fix frontend rating and clean a bit module organization
      
      SPECIFICATIONS
      
      Broken since 3620cb68
      
      LINKS
      
      Task 2057301
      PR #35870
      532b1a50
    • Thibault Delavallée's avatar
      [MOV] website_rating: rename portal files · 26b7b0e2
      Thibault Delavallée authored
      PURPOSE
      
      Fix frontend rating and clean a bit module organization
      
      SPECIFICATIONS
      
      In order to ease understanding of portal chatter dependencies let us name
      files according to guidelines. In this commit we rename a bit files in
      website mail to understand which widgets and portal parts are impacted by
      website mail bridge module.
      
      Assets are also moved in their own file to ease module discovering.
      
      LINKS
      
      Task 2057301
      PR #35870
      26b7b0e2
    • Thibault Delavallée's avatar
      [IMP] website_rating: remove useless templates · d6ac39c6
      Thibault Delavallée authored
      PURPOSE
      
      Fix frontend rating and clean a bit module organization
      
      SPECIFICATIONS
      
      Remove unused template to lessen noise in this module.
      
      LINKS
      
      Task 2057301
      PR #35870
      d6ac39c6
    • Thibault Delavallée's avatar
      [MOV] website_mail: rename portal related files · 241453aa
      Thibault Delavallée authored
      PURPOSE
      
      Fix frontend rating and clean a bit module organization
      
      SPECIFICATIONS
      
      In order to ease understanding of portal chatter dependencies let us name
      files according to guidelines. In this commit we rename a bit files in
      website mail to understand which widgets and portal parts are impacted by
      website mail bridge module.
      
      Assets are also moved in their own file to ease module discovering.
      
      LINKS
      
      Task 2057301
      PR #35870
      241453aa
    • Thibault Delavallée's avatar
      [IMP] website mail: remove useless public channel data · 226e21c4
      Thibault Delavallée authored
      PURPOSE
      
      Fix frontend rating and clean a bit module organization
      
      SPECIFICATIONS
      
      Remove useless mail.channel data as it makes noise without any added value.
      
      LINKS
      
      Task 2057301
      PR #35870
      226e21c4
    • ryv-odoo's avatar
      [FIX] website_rating: correctly take into account rating ratio in frontend · 57d51a40
      ryv-odoo authored
      PURPOSE
      
      Fix frontend rating and clean a bit module organization
      
      SPECIFICATIONS
      
      Currently when updating a review on slides, the rating value is divided
      by 2 on each update as the rating ratio is not taken into account. In this
      commit we correctly update the hidden input value during the start function
      using the rating ratio.
      
      LINKS
      
      Task 2057301
      PR #35870
      57d51a40
    • svs-odoo's avatar
      [FIX] mrp: can't open workorders from mrp overview · 9ff7758c
      svs-odoo authored
      
      How to reproduce:
      - Install mrp & mrp_workorder;
      - Open Manufacturing and plan a workorder;
      - Go on the Work Centers Overview;
      - Click on "WORK ORDERS" button -> You got a "Something went wrong !".
      
      closes odoo/odoo#35900
      
      Signed-off-by: default avatarSimon Lejeune (sle) <sle@openerp.com>
      9ff7758c
    • Hardik Prajapati's avatar
      [IMP] mrp: better labels for the fields on the WO to consistency with the MO. · 8b495f39
      Hardik Prajapati authored
      -hide the quantity done when the workorder has not start to work
      -change the label of done to consumed when finish workorder
      
      pad- https://pad.odoo.com/p/r.ed6d2ceefdd46214b72dc4e79552350e
      
      
      
      task-1889396
      
      closes odoo/odoo#34202
      
      Signed-off-by: default avatarSimon Lejeune (sle) <sle@openerp.com>
      8b495f39
    • Robot Odoo's avatar
      [MERGE][ADD] project_expense: setting project on expense · dc9c3aae
      Robot Odoo authored
      
      This merge commit provide the possibility for project user to select
      a project on an expense. Selectable project are only the one with an
      analytic account set. Setting the project will set the analytic
      account, so posting the expense will create analytic entries, and will
      finally appear on the project overview.
      If the analytic account still match an open sale order (and if the
      product is reinvoicable), a new SO line will be added on the SO (this
      flow does not change here).
      
      Task-1843241 (previsouly Task-1911581)
      
      closes odoo/odoo#29638
      
      Signed-off-by: default avatarJérome Maes (jem) <jem@openerp.com>
      dc9c3aae
    • Jérome Maes's avatar
      [IMP] sale_expense: cost tracking and reinvoice flow for expense · f871908e
      Jérome Maes authored
      Since 12.0, we wanted the employee to select directly the sales order on which
      the expense should be reinvoiced. The goal was to avoid employee to select the
      analytic account (too technical and usually unknown for employee). Problem is
      that we had to give read access to SO to simple employee, breaking the access
      rules "See your own document".
      
      As we want to allow all internal employees to determine if the expense should
      be reinvoice and on which sales order it should be, we need to allow them to
      select that sales order.
      This commit allows user to search on SO (simply get their name_get), no information
      more to avoid breaking "See your own document" for salesman. Falty ir.rule and
      access rights are now removed.
      
      We now clearly split the cost tracking and reinvoicing flow:
      - the analytic account field (visible only with group 'analytic' as considered
      as advance feature) allows user to track their expenses in some accounts.
      - the sales order is displayed for users or approvers to reinvoice the expense.
      As this operation implies the tracking, if the AA is not give, the SO will create
      its own AA in which the expense will be tracked.
      This SO field is only relevant when the product has a reinvoice policy, so we hide
      it if there is no reinvoice policy defined.
      
      Reinvoicing an expense has now a different flow from reinvoicing a "Vendor Bill",
      which still do magic to determine the SO from the AA set on its lines.
      
      Technical:
      to allow user to select SO from a m2o dropdown, the `name_search` is done in `sudo`
      for internal user. This is a borderline 'feature' of the system. A few thing show
      that the system does completely supports this ("Search More" gives access error, ...).
      We still keep this solution, as we don't want a sub group giving access to SO to all
      employee (aka an option allowing people to break the sales rights).
      
      Task-1843241
      f871908e
    • Jérome Maes's avatar
      [FIX] sale: name get uniformize API · 1f77ff3c
      Jérome Maes authored
      This commit makes the override of the `name_search` more
      consistent the basic implementation of the ORM (using lazy
      name_get and supports the `name_get_uid` parameters)
      
      Task-1911581
      1f77ff3c
    • Jérome Maes's avatar
      [FIX] analytic: missing depends · 7c5ce75a
      Jérome Maes authored
      This commit adds a missing `depends` on the `debit` and `credit` computed
      field on analytic account model. Indeed, without that, the recompute is not
      done when accessing thoses fields after adding lines in the same
      transaction (like in tests).
      
      Task-1911581
      7c5ce75a
    • Jérome Maes's avatar
      [FIX] project: portal user can not read AA · 00ac6c60
      Jérome Maes authored
      For historical reason (problably the inheritS between project and AA, removed in 12.0), portal
      user can read Analytic Account. This makes no sense, as it is a purely internal resource
      for companies. Removing the access rights don't change anything for portal user and make
      those data secure.
      
      Task-1911581
      00ac6c60
    • Jérome Maes's avatar
      [FIX] sale_timesheet_purchase: correct action xmlid · ba922611
      Jérome Maes authored
      Since the refactoring of the accounting model, some action changed
      but their xmlid were not adapted everywhere.
      
      Task-1843241
      ba922611
    • Denis Ledoux's avatar
      [FIX] sale: fix _compute_quotations_to_invoice following... · 4737e016
      Denis Ledoux authored
      [FIX] sale: fix _compute_quotations_to_invoice following odoo/odoo@9920f20e4c7753bc17bea71dea3a90f7de687196
      
      closes odoo/odoo#35895
      
      Signed-off-by: default avatarDenis Ledoux <beledouxdenis@users.noreply.github.com>
      4737e016
    • Alexandre Kühn's avatar
      [FIX] base: update minifier regexp to rjsmin (1.1.0) · 8de430d2
      Alexandre Kühn authored
      This version adds full support of string templates.
      Before this version, rjsmin may produce wrong code with string
      templates. For example:
      
      ```js
      const url = `https://odoo.com`;
      
      
      console.log(url);
      ```
      
      was minified to:
      
      ```js
      const url=`https:console.log(url);
      ```
      
      Because `//` was wrongly handled as a comment inside the string
      template.
      
      closes odoo/odoo#35867
      
      Signed-off-by: default avatarGéry Debongnie (ged) <ged@openerp.com>
      8de430d2
    • jbm-odoo's avatar
      [ADD] stock_sms: Integration with stock pickings · c230cfa0
      jbm-odoo authored
      
      The user can already send a confirmation email when the
      Stock Picking is done. It'd be great to communicate the
      same information by SMS.
      
      In addition, the current mailing tool requires a manual
      action. The idea is to automate the process via a
      Setting instead.
      
      id=1972567
      
      closes odoo/odoo#35662
      
      Signed-off-by: default avatarYannick Tivisse (yti) <yti@odoo.com>
      c230cfa0
    • Pierre Masereel's avatar
      [FIX] point_of_sale: download invoice from POS · 93be40e6
      Pierre Masereel authored
      
      When you are creating an invoice from the POS, the report route is
      called to download the invoice, since changes made in rev: 118190f3
      
      The values for ids where empty, so we give them now the correct id list.
      
      closes odoo/odoo#35889
      
      Signed-off-by: default avatarpimodoo <pimodoo@users.noreply.github.com>
      93be40e6
Loading