Current behaviour :
When creating a leave type with both approval required for allocation and then setting allocation to 'Set by time off officer', we still require 2 approvals.

Behaviour after PR :
Leave type with allocation set to 'Set by time off officer' will only require one approval as expected.

opw-2671540

closes odoo/odoo#79718

Signed-off-by: Kevin Baptiste <kba@odoo.com>

Updating the producing quantity may wrongly change the consumed quantity
of tracked products

To reproduce the issue:
1. Create two storable products P1, P2:
    - P2 is tracked by lots
2. Update P2's quantity >= 10
3. Create a BoM:
    - Product: P1
    - Components: 1 x P2
4. Create and confirm a MO for 10 x P1
5. Check availability
6. Edit the MO and set the consumed quantity of P2 to 10
7. Edit the MO and set the producing quantity to 8

Error: The consumed quantity of P2 becomes 1

When saving the MO, it also writes the `lot_ids` on `move_raw_ids` while
it shouldn't. As a result, it triggers method `_set_lot_ids` for no
reason and lead to an undesirable behavior.

OPW-2667412

closes odoo/odoo#79565

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Declared as an api.model in all the other modules except auth_totp

closes odoo/odoo#79666

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

closes odoo/odoo#79667

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Actually the last status is deleted by the fist request who can reach it
So if a request is lost the answer too

With this fix we delete the last response only when we start a new one

closes odoo/odoo#79680

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

The flow has been broken multiple times across the years. Let's add a
test in all stable versions.

For this 14.0 forward-port, the test comes with a fix which restores the
13.0 flow which we tried to change in 14.0... but only ended up broking
it. Indeed, with [1], the 13.0 was fixed. And, with [2], we tried to
simplify the flow... but the explanation given by the commit is just
wrong: the flow was just broken and the simplification that was to be
done in fact practically never occurs. The more the reason to add a
test, proving how the flow is working. The simplification may be done
someday but not sure it is really worth it.

[1]: https://github.com/odoo/odoo/commit/076992bdf099f3a645c9a1ef6df2cdcccbf1c2b2
[2]: https://github.com/odoo/odoo/commit/5c007305c9998ade32c6677cac5552101c3a96af



closes odoo/odoo#79628

X-original-commit: dfb0ce4b
Signed-off-by: Romain Derie (rde) <rde@odoo.com>

closes odoo/odoo#79675

X-original-commit: adf28d52
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

We should rollback manually first to avoid concurrent access errors/deadlocks when
trying to refresh google calendar token.

opw-2687393

closes odoo/odoo#79635

Signed-off-by: Arnaud Joset <arj@odoo.com>

Before, when installing stock_picking_batch after l10n_it_stock_ddt,
it would give a traceback because the header was replaced in a view
in stock_picking_batch and that removed the invisible field that was
used in an attrs in another place.

So we add the field again in that other place.

closes odoo/odoo#79638

Signed-off-by: William André (wan) <wan@odoo.com>

The goal of this commit is to apply most of the improvement of microsoft calendar on 14.0 to fix different reported issues. The different improvement can be seen in #68700.

One of the major improvement not ported is the change of name for days in the recurrence (2 letters => 3 letters).

This fix is based on opw-2658427 but attempt ot fix issues separated in all the ticked link to this one (see opw-2658427 chatter).

On top of that, the different tests case that were implemented in master were also ported with this fix and more manual test were effectuated.

In addition, we fixed the following issues :
Traceback related to attendee without email (that are now not imported).
Timeout for big calendars.
Hardcoded time value.

opw-2658427

closes odoo/odoo#78161

Signed-off-by: Arnaud Joset <arj@odoo.com>

closes https://github.com/odoo/odoo/issues/79229



closes odoo/odoo#79606

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Steps to reproduce:

- On a company with multi currency
- Set the company currency rate to 1, and the foreign currency
  to 0.273748
- Create a vendor bill
- Set first the foreign currency, then select a product with a
  tax to 21% and a price unit of 155.32
- Go to 'Journal Items', the 'tax paid' line debit is computed to 119.15
- Reselect the foreign currency on form.
- Now the 'tax paid' line debit is computed to 119.16

The total is also impacted as the tax changed.

Explanation:

Before this commit, the taxes was both computed in foreign currency and company currency. However, when setting a new currency or changing the date, the taxes wasn't recomputed but the new conversion rate was applied.
This commit is fixing the issue by applying the same logic as in 14.0: the taxes are always computed only the foreign currency, then the conversion rate is applied to get the accounting balance.

opw-2569668

closes odoo/odoo#79489

X-original-commit: 8d978824
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Laurent Smet <las@openerp.com>

- Configure a Receipt Printer for POS
- Create a Product with a long name (> 20 chars) and a big price
(i.e. PRODUCT BCDEFGHMWPGHHH - price: 9999.00)
- Create a Product with a short name (i.e. PRODUCT Z - price: 12.00)
- Make a POS sale with long product first and short as second
On the receipt, the line containing long product is too small to
contain also its price.
So the price will be on another line justified on the right.
But the following product will be stacked on the same line, making
the price on the receipt unreadable.

Someting like this:
-------------------
PRODUCT BCDEFGHMWPGHHH
PRODUCT Z     12.009999.00

The issue also appears for taxes lines and on the report of all sales
of current POS session.

This is due to a css style (float: right) applied to the price part.

opw-2639120

closes odoo/odoo#79521

Signed-off-by: Anh Thao PHAM <pta@odoo.com>

Current behavior :
When a bom is created with uom set as dozens the report
operations time is not correct. For exemple if the operation
time is 10 minutes. The operation time for a dozen should be
120, but at the moment it's 10 minutes

Steps to reproduce:
Have a product in units.
Create a bill of materials in dozens.
Have a operation where the workstation that has a capacity of 1.
Look at the Bill of material cost and structure even though it uses a dozen it shows
the operation time for one unit.

opw-2669899

closes odoo/odoo#79080

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Problem : Free Shipping is not translated in delivery
New Behaviour : Free shipping will now be translated

opw-2679727

closes odoo/odoo#79543

X-original-commit: 511bede0
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Damhaut Florian (flda) <flda@odoo.com>

Steps to reproduce :

  - Install website module
  - Activate (and translate website) French language
  - Go to translated terms and fetch for "Discard" in website module
  - Replace the translated value by "Ne pas sauvegarder"
  - Go to Website -> Configuration -> Websites
  - Select main website and change language to french then save
  - Go to Website and edit homepage
  - Add any block

Issues :

  On top of editor sidebar, buttons are not displayed correctly.

Solutions :

  Add css class `d-flex` to the div arround the buttons.

opw-2683602

closes odoo/odoo#79515

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

closes odoo/odoo#79136

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Co-authored-by: Raphael Collet <rco@odoo.com>

As it was confusing to have some autogenerated sum on the parent model
we show the proper tax value of the report

+ add missing report line to related taxes

closes odoo/odoo#79419

Signed-off-by: Josse Colpaert <jco@openerp.com>

This commit fixes an issue of the webclient where the tab
was missing the name of the action in the title after a
fresh load of the page.
e.g. after a reload or when duplicating a tab in sales, the
title was 'Odoo' instead of 'S00001 - Odoo'.

closes odoo/odoo#79518

X-original-commit: 842ffc41
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Currently, when user open the question from helpdesk ticket and
user clicks on the back button of the forum page,
it redirects the user to the app switcher. It happens because the
back button contains the homepage URL as httprequest.referrer
does not support the fragment url with hash(#).

so this commit fixes the issue by binding the onclick event on the
back button so clicking on the back button redirects the user
to the helpdesk ticket.

task-2602604

closes odoo/odoo#79468

X-original-commit: e7dd314e
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>

Steps to reproduce the bug:
- Install sale_management and sale_mrp
- Create a product with BOM, which is a KIT and add any product in BOM line
- Create a SO for the product > Confirm
- Validate the delivery
- Cancel the SO >  Set to Quotation > Reconfirm

Problem:
A new delivery order is generated while the ordered quantity = delivered quantity
This is because `_get_qty_procurement` wrongly computed the product quantity based on the moves quantities in the kit case.

opw-2647856

closes odoo/odoo#79395

X-original-commit: aac70fd4
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Djamel Touati (otd) <otd@odoo.com>

On tablet, the call-to-action to install the app shouldn't show the QR
code... to be scanned by the tablet itself.

This commit fixes it by using the platform detection instead of the
screen size.

Steps to reproduce:
- Open "Expenses" on tablet
- ensure no records are listed (use filters if needed)
- click on the call-to-action to one of the app store
=> opens the QR code's modal instead of going directly to the store

task-2349194

closes odoo/odoo#78638

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>

This commit improves the fix made in e73e2019.
The improvement will be added in the forward port starting from saas-14.4.

opw-2581428

closes odoo/odoo#79467

Signed-off-by: Xavier <xbo@odoo.com>

When changing a value for a o2m (list) within a form, the _setValue
returned a Promise that did not take into account the real rendering of
the list renderer.

The use case at hand is:
- enable product configurator
- have a product with options
- add that product in a SO
- add the option as well through the product configurator
- confirm the configurator

The configurator triggers an add_record event, with an onSuccess callback

Before this commit, the onSuccess callback was called too early, when the previous
rendering operations were not finished yet.

After this commit, the onSuccess is executed when the list renderer is really ready

opw-2580044

closes odoo/odoo#79441

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>

closes odoo/odoo#79341

Signed-off-by: Olivier Colson <oco@odoo.com>

- fix updating context cannot recompute _compute_leaves method

closes odoo/odoo#78794

Signed-off-by: Kevin Baptiste <kba@odoo.com>

This commit reverts [1]. Otherwise, the same order lines may be
submitted several times.

To reproduce the issue:
(Use demo data)
1. Point of Sale > Configuration > Order Printers, edit Kitchen Printer:
    - Printed Product Categories: Food
2. Edit the POS Bar:
    - Enable Order Printer
3. Start a session of POS Bar
4. Select table T1
5. Add a Bacon Burger and submit the order
6. Open another table
7. Reopen table T1
8. Add a Cheese Burger and submit the order

Error: The ticket sent to the kitchen has the bacon burger and the
cheese burger. Only the last one should be sent to the kitchen

When selecting a table, a RPC call gets all information about the
current order. In the server response, the orderlines are sent as new
records:
https://github.com/odoo/odoo/blob/629a4f34ea66f10a981f4b25d5d69281f62853b6/addons/pos_restaurant/models/pos_order.py#L88


Therefore, the orderlines will have a new ID. However, since [1], the
lines identifiers are used to know which lines have changed. This
explains why the bacon burger is sent twice.

[1] 8159e5ac

OPW-2678701

closes odoo/odoo#79418

X-original-commit: 75fb0aa6
Signed-off-by: Masereel Pierre <pim@odoo.com>

What are the steps to reproduce your issue?

- Create a product with more than one attribute.
- Let say color White, black and purple
- Create a 'draft' invoice for the purple product variant
- Remove the 'purple' attribute value from the product
- It will archive that variant (because the account.move linked to it)
- Try to delete the attribute value from menu Sales > Cofinfiguration > Attribute
What is the current behavior that you observe?

- technical error message
What would be your expected behavior in this case?

- non-technical message for end-users
Solution :

- Change both message to tell user he cannot delete the value if the value has been referenced somewhere else.
opw-2623583

closes odoo/odoo#77631

Signed-off-by: Damhaut Florian (flda) <flda@odoo.com>

A bug currently makes the carousel snippet collapse/disappear when its
active contents are removed. This happens because after the removal,
the carousel no longer has an active item.

The solution that was chosen was to not allow the removal of slides
unless using the dedicated option which is there for that. This solution
has to advantage to also allow users to create empty slides (using a
background image for example) by simply removing the columns inside.

task-2506165

closes odoo/odoo#79340

X-original-commit: 3c194faa
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

stock.orderpoint._post_process_scheduler confirms
productions after procurements have been run.

This was introduced to avoid conflict between
procurements, conflicts that can happen e.g. in
the purchase_mrp module.

However, currently action_confirm might
also be called on done or cancelled productions.
That can happen if there are already been lots
of procurements for the same product/orderpoint,
i.e. MO with the same values have been created multiple times.

To avoid this, add ('state', '=', 'draft' in the search_domain.

opw-2666960

closes odoo/odoo#79403

Signed-off-by: Arnold Moyaux <arm@odoo.com>

The "Auto-complete" bills field does not show all POs for the Vendor that are waiting for invoices.

To reproduce the issue:

    - Create PO1 Vendor = "Supplier"
    - Create PO2 Vendor = "Supplier, John Doe"
    - Create Invoice for PO2
    - In the PO2 Invoice, "Auto-Complete" field try to select PO1, but it is not shown.

The "Auto-complete" bills field should show all POs for the Vendor that are waiting for invoices.
The problem is that the field's domain filters is using the partner_id
field when it should be using teh commercial_partner_id.

opw-2684409

closes odoo/odoo#79359

Signed-off-by: Arnold Moyaux <arm@odoo.com>

When an user clicks on the Meeting tab to open the calendar,
it should onyl display the events linked to the opportunity.

task-2665863

closes odoo/odoo#78679

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

How to reproduce the problem:
- Install the Sales and Invoicing apps
- Create a simple SO with a product
- Create Invoice -> Down Payment (percentage) 30% -> confirm
- On the SO -> Create Invoice -> with Deduct down Payment -> confirm
- On that invoice -> Add Credit Note -> Reverse -> confirm
On the SO, the Down payment is not counted as invoiced, even tough it
was already paid and not refunded. If the user wants to create a new
invoice, the system will create one with the full price (not taking the
already invoiced Down Payment into account).

Cause of the problem : when computing the quantity to invoice for
the SO, a condition was avoiding preventing the down payment invoice
line to be taken into account in a way that it was just ignored.
I don't really understand the reason for this condition, as
it specifically ignores the down payments, while it should not be
ignored.
When creating the draft for the refund invoice, the down payment's SOL
is correctly updated as `line.untaxed_amount_to_invoice == 0` is true.
But when confirming the invoice, the values changed and the condition
is thus not met anymore.

opw-2491225

closes odoo/odoo#78999

Signed-off-by: Roose Pierre-Rodéric ( prro) <prro@odoo.com>

Adding the date of a SM on the picking form allows a user to reschedule
the delivery of a specific product instead of rescheduling the delivery
of all products.

Linked to OPW-2651828

closes odoo/odoo#79316

Signed-off-by: Arnold Moyaux <arm@odoo.com>

Fixes odoo/odoo#78932
Closes odoo/odoo#79274

closes odoo/odoo#79360

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Fixes odoo/odoo#78932
Closes odoo/odoo#79273

Part-of: odoo/odoo#79360

Expected behaviour:
When you create a sale order with a project associated. When the sale order change state
from non upsell to upsell sales person should receive one email.

Current behaviour:
The sales person receive an email for every entry in the timesheet after the sale order goes
from non upsell to upsell.

Step to reproduce:
Create a sale order setup to create a project and task and the invoicing policy is ordered quantities.

Add a timesheet entry which takes it past the ordered quantity.

Create the invoice for the order.

The state of the line and order goes to upsell, and the upsell email is sent to the salesperson.

Add another line in the timesheet and the email is sent again to the salesperson

opw-2581428

closes odoo/odoo#79287

Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>

If the multiple quantity of a RR is less than 1.0, the buttons 'Order
Once' and 'Automate Orders' may remain invisible

(Need sale_management,purchase_stock)
1. Create a product P
    - Type: Storable
    - Add a vendor
    - Routes: Buy
    - Reordering rule:
        - Trigger: Manual
        - Min Quantity: 0
        - Max Quantity: 0
        - Multiple Quantity: 0.01
2. Create and confirm a sale order with 0.50 x P
3. Inventory > Operations > Replenishment

Error: P is present, its qty to order is 0.50, however the button 'Order
Once' is not displayed

OPW-2612472

closes odoo/odoo#79266

Signed-off-by: Arnold Moyaux <arm@odoo.com>