- Sep 03, 2019
-
-
Thibault Delavallée authored
Currently fullscreen takes all information from categorized slides to display its menu. In order to avoid calls to server some information is prepared in DOM to speedup loading. It means slide information is available even when not being member of a course which leads to some content leak. This commit fixes that by correctly checking that a slide can be accessed before allowing to have access to its information and embedded code. Access of a slide is either member of a course, either course publisher. Task 2058595 (eLearning v13 testing) Task 2064112 (fullscreen bug report)
-
- Aug 08, 2019
-
-
qmo-odoo authored
PURPOSE Like already done for sale order, invoice of survey, purpose of this commit is to remove category model and replace by a flagged line (slide). It allows to easily reorder slides in an embedded list view. SPECIFICATIONS Instead of having a fully fledged slide.category model, slide.slide will serve that purpose with a is_category flag. This will allow to drag and drop slides and sections in the channel form view. This change had an impact on the way slides were added/sorted on the front-end. In fact, whenever a slide is added from the front-end, a resequencing of all the slides in the course has to be triggered. Category of a slide is now a computed field based on the sequence. Order of slides is based on sequence, with categories splitting the slide list based on is_category flag. In this commit tests are added. Some cleaning in tests is also performed to speedup a bit tests (savepointcase) and some cleaning / renaming to ease their understanding. Future commit will add JS necessary to manage slides in the section list view. LINKS TaskID: 1978731 PR: #33255
-
- Aug 05, 2019
-
-
fja-odoo authored
* = website_forum, website_profile, website_sale, website_sale_comparison, website_slides, website_slides_survey Some image links were hard coded in the xml views of website, now they are replaced with website.image_url(model, field). Part of https://github.com/odoo/odoo/pull/34149 task-2007400 closes odoo/odoo#34149 Signed-off-by:
Quentin Smetz (qsm) <qsm@odoo.com>
-
- Aug 12, 2019
-
-
Aurélien Warnon authored
The 'index_content' field was only filled when uploading from the frontend. That would lead to inconsistent results when creating/updating 'presentation' slides from the slide.slide form view. The field was also not cleaned if the slide content changed. As it's usage was not very clear (only on a 'search', and not very intuitive), we simply removed the field.
-
- Aug 02, 2019
-
-
Sébastien Theys authored
image_original => image_1920 (now resized to 1920) image_big => image_1024 image_large => image_256 image_medium => image_128 image_small => image_64 image replaced by image_1920 (when writing) or by image_1024 (when displaying what was previously the big size) + add new intermediate format: image_512 PR: #34925
-
- Jun 24, 2019
-
-
qmo-odoo authored
This commit improves the elearning onboarding on the quizzes If the user is not logged in, a log in button will show up under the quiz If he is logged in but not a member of the course and the course is public, a join button will appear under the quiz If the course needs to be bought, a buy button will appear under the quiz. If the course is on invite only, a message under the quiz will inform the user about it TaskID: 2003986 PR: #33861 Signed-off-by:
Thibault Delavallee (tde) <tde@openerp.com>
-
- Jun 18, 2019
-
-
Patrick Hoste authored
Including * change h4 to h1 on the slide page; * add the rel='canonical' link header on the fullscreen view in order to improve SEO and links; * add space between quiz questions; * remove social share statistics as they are broken and not really useful; * moved tabs before the Quiz on the slide page; * allow to modify slide in backend by removing some readonly attributes; Linked to task ID 2010024 Related to PR #34176 Signed-off-by:
Thibault Delavallee (tde) <tde@openerp.com>
-
- Jun 14, 2019
-
-
sri-odoo authored
closes odoo/odoo#34137 Signed-off-by:
Jérémy Kersten (jke) <jke@openerp.com>
-
- Jun 12, 2019
-
-
sri-odoo authored
Slightly increase margins between questions in a test. closes odoo/odoo#34055 Signed-off-by:
Jérémy Kersten (jke) <jke@openerp.com>
-
- Jun 11, 2019
-
-
sri-odoo authored
The '#wrap' id is needed by website themes to correctly handle layout options. closes odoo/odoo#34024 Signed-off-by:
Quentin Smetz (qsm) <qsm@odoo.com>
-
- Jul 31, 2019
-
-
qmo-odoo authored
This commit adds the number of comments on the comments tab and also improves the design of the pdf sharing options Task: 1978736 PR: #34232 Signed-off-by:
Thibault Delavallee (tde) <tde@openerp.com>
-
- May 03, 2019
-
-
qmo-odoo authored
This commit fixes a few issues with quizz * change background-color to white in fullscreen mode; * prevent going up to the top of the page when selecting an answer; * highlight selected answers in fullscreen; * fix the display of already completed quizzes Commit linked to task ID 1978530 (fixes linked to internal testing). closes odoo/odoo#33140 Signed-off-by:
Thibault Delavallee (tde) <tde@openerp.com>
-
qmo-odoo authored
This commit adds back the slide type icons on the sidebar list in fullscreen and not fullscreen mode. Commit linked to task ID 1978530 (fixes linked to internal testing).
-
- May 06, 2019
-
-
qmo-odoo authored
This commit removes the read access on slide.answer for all users except website_publisher and admin Task: #1947884 PR: #32083 Signed-off-by:
Thibault Delavallee (tde) <tde@openerp.com>
-
- Mar 21, 2019
-
-
qmo-odoo authored
This commit provides a few fixes for the non-fullscreen view: * remove the subquiz link on slides of type 'quiz' in the sidebar; * hide completion icons in sidebar if not member; * only show the 'embed on your website' option when a slide has an embed code. This will prevent slides of type 'certification' or 'quiz' to display an empty embed box; Commit linked to task ID 1941250 and PR #31977
-
qmo-odoo authored
This commit provides a few fixes for quiz feature: * fix amount of karma won by the user in a quiz; * correctly display the fact that a subquiz was completed by the user instead of just looking like a non-completed quiz; * going on a previously completed quiz, good answers are hightlighted and inputs disabled; * effectively put the quiz in readonly mode if not a channel member. Commit linked to task ID 1941250 and PR #31977
-
sri-odoo authored
Purpose of this commit is to perform a cleaning of * documentation course: add a new specific navigation for documentation course with a sort option and filters on slide types; clean overall layout of documentation course to have a better-looking result as this page was still not really updated; * lesson not fullscreen page: global layout and cleaning of not-fullscreen page to have a better-looking result. Notably related slides for documentation slide is set on right, and some UX bits are tweakes; Commit linked to task ID 1941250 and PR #31977
-
sri-odoo authored
Commit linked to task ID 1941250 and PR #31977
-
sri-odoo authored
Purpose of this commit is to improve the global look of course layout (notably banner, navigation, course / channel informations). Content list layout displayed in training (orderable) is also tweaked and improved. Commit linked to task ID 1941250 and PR #31977
-
- Mar 19, 2019
-
-
David Beguin authored
Commit 5798ca28 was assuming the vote and comment access on slide was related to is_preview mode and was, consequently, depending on each slide separately. In fact, it's not because a slide is in preview mode that the user has the right to vote for this slide. He must be course member to interact with this preview slide, even if he has the right to read it. So the vote and comment right are now computed at the level of the course, and apply to all the slides of this course. This commit also reviews and apply fixes on review - rating access. Here are the applied rules regarding vote, comment and rating on course and slides: A user can review a course: - If allow_comment is activated on the course AND - If the user is publisher OR - If the user has enough karma AND is member of the course. Note : if the rating is not allowed on the course, not only the button to review must be hidden but also the entire rating composer. A user can vote and comment a slide: - If allow_comment is activated on the course AND - If the user is publisher OR - If the user has enough karma AND is member of the course. Other fix applied is this commit : - Avoid crash when no promoted slide : When going on course homepage (documentation type), if no promoted slide, we got a internal server error. Task ID: 1941250 Partial revert of commit 5798ca28 PR #31567
-
- Mar 15, 2019
-
-
Jérome Maes authored
When a certification slide is display in no fullscreen mode, the done button is clickable. Same applies to quiz slide. This commit prevents user to manually mark a slide as done for slide type that requires an other action (submit answer, pass survey, ...). Task-1941250
-
David Beguin authored
As slides are returned in sudo to the template, the user rights were checked via a can_access variable set in the template directly. In order to disable the vote for user that cannot get access to the course all the checks are now done in backend (also to avoid to get access to slides in sudo mode with rpc calls). We add now, for each slide on the course view, the access and vote rights to the template : can_access and can_vote. Those two are computed in backend, using the user's access right instead of admin's. But, as if the user is not member of the channel, he cannot get access to the course slides (expect for Free Peview ones), so the check on can_vote will crash. This is why we check the access rights before checking can_vote, for each slides (as free preview slides are still accessible, even if the user is not in channel members). The vote widget is disabled if user's can_access or can_vote = False, enabled otherwise. If user have access but have not enough karma, the controller will handle this case and return an error to the user telling him he has not enough karma to vote. If user can vote but cannot access, the controller will handle this case and return an error to the user telling him he has no access to the lesson. Task ID: 1943788 PR #31321
-
David Beguin authored
To avoid eLearning to be spammed, the comment, review and vote behaviours are now allowed only if the user has enough karma to do it. Here is the new behaviour on courses and slides rating / comment / vote -If allow_comment is checked on Course : - Review (rating) is allowed on Course only if enough karma - Comment is allowed on slides within the course only if enough karma and course type is 'training' - Vote is allowed on slides within the course only if enough karma and course type is 'documentation' -If allow_comment is not checked on Course : - Review (rating) is not allowed on Course - Comment is not allowed on slides within the course - Vote is not allowed on slides within the course - Rating is not allowed on slides within the course anymore Task ID : 1943788 PR #31321
-
- Mar 12, 2019
-
-
qmo-odoo authored
When a slide is seen by user, it should be marked as completed (according to its type), and the user completion for the course is updated. But for public user, we don't want those RPC calls to be done, as completion for visitor makes no sense. This commit also hide progressbar when current user is public. Task-1942852 closes odoo/odoo#31700 Signed-off-by:
Jérome Maes (jem) <jem@openerp.com>
-
- Mar 08, 2019
-
-
Thibault Delavallée authored
Display * improve color of trophy displayed on top of course main page (success if course done, warning while working on it); * correctly fetch and display karma/xp points on course lesson list. It is either gain of next try, either awarded points depending on slide completion; * fix control buttons in course main page (prev, next, set done, set completed, fullscren), notably correctly set them disabled; Linting / Code * put demo in no update; * rename some parameter in website_slides_survey to avoid conflict between quiz (on a slide) and certification (a survey); Commit linked to task ID 1941250 and PR #31697. Signed-off-by:
Thibault Delavallee (tde) <tde@openerp.com>
-
- Mar 07, 2019
-
-
Thibault Delavallée authored
Purpose of this commit is to perform a cleaning and upgrade of the lesson view in front-end when not using the fullscreen mode. This page had not been updated since eLearning addition. A method is added on slide model to have a protected method computing quiz related information on a given set of slides, notably potential karma gain, gained karma and number of attempts. It is mainly a code move from controllers now working in batch. Some linting is also done, notably a badly-named file. See original eLearning task for main specifications [1]. Commit linked to task ID 1941250 and PR #31657. [1] See task ID 1902304 Signed-off-by:
Thibault Delavallee (tde) <tde@openerp.com>
-
Jérome Maes authored
This commit makes the quiz widget a real odoo widget that triggers up some events. The widget is now only responsible of * fetching quiz data (if not given) * decorating the anwsers according to the result * displaying message (error or modal) To do so, some code move/rewrite was needed * extract and factorize some template * add 'sudo' on technical model to avoid access rights error * factorize some python method from controller to model * remove some CSS classes to lighten the code * fixing access model error * make quiz widget handle the display of error message * give browse record for template rendering, rather than slug * cleaning some spaghetti code in Fullscreen widget * ... Commit linked to task ID 1941250 and PR #31584. Signed-off-by:
Thibault Delavallee (tde) <tde@openerp.com>
-
- Mar 06, 2019
-
-
Thibault Delavallée authored
Simple fix to already have the standard gray background. Future commits will improve display of not fullscreen lessons but this fix was necessary for incoming work. Commit linked to task ID 1941250 and PR #31512.
-
Thibault Delavallée authored
Currently there is a tool method on controller allowing to prepare some slide related data. However controllers still add values in the slide dictionary outside of this method, making it non consistent. Let us prepare all side related data in this tool method to simplify code understanding. Commit linked to task ID 1941250 and PR #31512.
-
- Feb 26, 2019
-
-
Jérome Maes authored
This commit replaces a widget with standard boostrap code: the progress bar classes. Creating a widget was a little bit over engineered, and since the progress animation is handle in CSS, this replacement does not cause any loss of feature. Commit linked to task ID 1942852 and PR #31394.
-
Thibault Delavallée authored
Moves * sidebar of course main template in its own template; * fullscreen templates in their own file; It will ease future modification of this page layout. Commit linked to task ID 1942852 and PR #31394.
-
Aurélien Warnon authored
Purpose ======= This commit introduces an icon template to factorize some xml code. It also correctly overrides this template in website_slides_survey to add the 'certification' case. Commit linked to task ID 1942852 and PR #31394.
-
Thibault Delavallée authored
Just apply some linting and naming convention. Commit linked to task ID 1942852 and PR #31394.
-
Aurélien Warnon authored
Purpose ======= This commit adds the management and display of uncategorized slides for both the frontend publishing management and the fullscreen course views. We add a "Uncategorized" section on top of all the categories that is hidden for the student if it's empty. Course publishers can drag and drop slides from and to that new "Uncategorized" section to easily reorganize the course. Commit linked to task ID 1942852 and PR #31394.
-
Aurélien Warnon authored
Purpose ======= This commit refactors the way slides and categories are reordered in the frontend course view (training courses). The use of jqueryui's "sortable" widget makes it easier and more user friendly to drag and drop both sections and slides to reorganize your course. Commit linked to task ID 1942852 and PR #31394.
-
Quentin Mourier authored
Purpose of this commit is to perform some linting and cleaning in lesson widget JS and its related css. Notably for fullscreen widget of eLearning. Containing * better naming of css classes; * deleted sidebar file as it is now included directly in the fullscreen widget; * removed unused css; * apply JS linting; * clean some controllers; Commit linked to task ID 1942852 and PR #31394.
-
- Apr 23, 2019
-
-
sri-odoo authored
Purpose: reduce some customization and ease eLearning link with themes. For that purpose use the body class name propagation recently added. Linked to task 1958372 Related to PR #32648
-
- Feb 21, 2019
-
-
David Beguin authored
- slidesChannelDropdownSort : dropdown items back to visible (was white on white) - Featured lesson : change icon to bullhorn instead of + icon - Pass certification fullscreen button : btn primary - set max height to fullscreen content to 100% minus header - Fix 'infographic' slide type image view - change image for 'Furniture Technical Specifications' course - fix fullscreen presentation mode: The condition to add the iframe that contains the presentation of the document was wrong and, so, never met. Those conditions are evaluated in javascript and not in python as it's part of t-name template linked to a javascript widget. Commit linked to task ID 1941250 and PR #31279.
-
- Feb 20, 2019
-
-
Thibault Delavallée authored
Purpose is to perform some linting in code. No functional change should occur with this commit, only some code move. Diff may appear huge but it is just because some files are split. This cleaning allow to better understand code and templates architecture now that eLearning feature has landed in Odoo Community. It will ease future additions, modifications and fixes. Containing : * [REF] make some internal slide-related methods private as they are not intended to be called by outside world; * [MOV] new channel invite wizard in wizard folder; * [MOV] split frontend templates in some files to better locate code. There is now files for homepage, course, lesson, embed and utils in addition to slide-related profile template; * [REM] dead (unused) templates; Commit linked to task ID 1941250 and PR #31272.
-
- Feb 19, 2019
-
-
Thibault Delavallée authored
Purpose is to ensure more advanced use cases are still supported in new elearning platform in addition to more public use cases. Fields controlling access are now * enroll: who can enroll on course: public (everyone, simply click on join button), invite (added by already members) and payment (in bridge with website_sale, if SO with product is confirmed); * enroll_group_ids: automatically add members of those groups to the channel to ease having groups for a given subset of users; * visibility: who can see a channel and its slides: public (everyone, it means channel is visible on website for example), members (hidden for non members) * website_published on channels and slides; non publishers cannot see what is not published, whatever other parameters; * upload_group_ids: who can upload on a channel; * download_security on a slide is completely removed as it makes no sense for most slide types; To ensure a better user experience responsible of a channel is added in its members. People uploading a slide are now also allowed to read it to avoid having inconsistency behavior between upload_group_ids and access rules. Some tests are added. This commit is linked to task ID 1942836 and PR #31239. Co-Authored-By:
Aurélien Warnon <awa@odoo.com> Co-Authored-By:
Thibault Delavallée <tde@odoo.com>
-