When a one2many is used as a search default, its label has to be fetch
via a name_get in order to get a correct display of the facet
corresponding to that field in the search bar. It turns out that the
search model did not wait properly the return of the name_gets before to
start to compute the facets.

closes odoo/odoo#106575

X-original-commit: 95ef4253
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Mathieu Duckerts-Antoine <dam@odoo.com>

- Currently the label of the lines is not limited to the number of characters. When the user gives a name that is too long, the graph will not be displayed.
- This commit limits the number of labels, if exceeded it will display as ...

closes odoo/odoo#106564

X-original-commit: d4b91b6c
Signed-off-by: Mathieu Duckerts-Antoine <dam@odoo.com>

When rendering, the form view looks for the element it should autofocus,
and defaults to the first text input it finds. This extends that default
behavior to the first textarea or contenteditable element.

closes odoo/odoo#106537

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

When rendering a form view that has a truthy `default_focus` attribute,
the renderer looks for the element in its tree that has its `name` as
`id`. However in the case of `html_field` it couldn't find it since
`html_field` failed to apply that `id` to its focusable element (the
editable root). This adds the `id` to the editable root when rendering
the element in `wysiwyg`, and also directly applies `contenteditable` to
it so the `focus` method actually does what we expect it to, even though
we are waiting for `HtmlFieldWysiwygAdapterComponent` to be mounted
before actually instantiating the editor itself.

task-3073096

Part-of: odoo/odoo#106537

With commit [1] we refactored the cookies bar to let the user decide if
he wants to accept the cookies (and/or only part of it).
Before that commit, the `website_cookies_bar` cookie could only hold
`true` as value, which now is holding an object like
`{"required": true, "optional": false}`.

This creates an issue if a user is coming from a previous version with
`true` as cookie value because since the refactoring it will crash both
in JS and PY because `in` instruction with a boolean value will fail in
both languages.

The decision taken here is simply to remove the cookie if we face such a
case so the user can decide again what he wants (since there is more
choices now).
It also means that we won't be holding an outdated value in the cookie
any longer.

[1]: https://github.com/odoo/odoo/commit/2cbda6c98ee947cea1d06c09880eee8c758304a8



opw-3074303

closes odoo/odoo#106476

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

This reverts commit 3ebe1185.

The code ECC200DataMatrix already exist in reportlab (that is already a dependance).
Some differences:
- ECC200DataMatrix only supports a Type 12 (44x44) C40 encoded data matrix.
  (214 alphanumeric characters and 14 to 27% of error correcting rate)
- pylibdmtx support more type and add a default to 24x24. So it means a
  (52 characters and 20 to 35% error correcting rate). It's also smaller
  to display.

We consider the gain too small compare to maintain an extra lib.

It also fix blured datamatrix in stock report if they contains too much
data.

*If you want to test 001234560000000018 is a valid sscc for package

closes odoo/odoo#106457

X-original-commit: 00a85de0d43a98a91f9199ccb388140fb79be647
Related: odoo/enterprise#34354
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

Purpose
=======
Prevents auto save of not dirty forms with
text fields on page reload and tab/browser closing.

Specifications
==============
The text field default value is making Odoo consider
the form as dirty even when it's not which triggers
auto saving for not dirty forms.

Change the text field widget setDirty condition to
prevent considering empty textarea string dirty.
Typically, if the previous value was false, false and
empty string should be considered as the same value.

Task-3031570

closes odoo/odoo#106439

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

closes odoo/odoo#106385

Signed-off-by: Kevin Baptiste <kba@odoo.com>

To reproduce:

1) activate qr code on invoices
2) print an invoice with a qr code
3) print a followup letter, and attach the printed invoice

-> error due to missing 'qr_code_urls' variable in invoice template

This can happen with any report calling this template, thus we decided to set the qr_code_urls
inside the `report_invoice_document` template directly, so we never need to set it again in _get_report_values()
This allows to remove the following report classes (done in master due to stable policy)
- `ReportInvoiceWithoutPayment`
- `ReportInvoiceWithPayment`
- `PosInvoiceReport` (not even used anywhere)

closes odoo/odoo#106448

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

Before this commit it is possible to archive a product if the current user have no access to all reward (multi company rules).

closes odoo/odoo#106559

X-original-commit: 5bafee8d0479367fd25b2fa2daefd4374ab38211
Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>

closes odoo/odoo#106552

X-original-commit: d9856868
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>

Bug:
- enable wave transfers
- Kanban view should not have a create button

Fix:
removed the button

opw-2978078

closes odoo/odoo#106551

X-original-commit: 3bc3631d
Signed-off-by: Adrien Widart <awt@odoo.com>
Signed-off-by: Walid Hanniche (waha) <waha@odoo.com>

First correction: replace call to `read_group` to `_read_group` in order
to avoid useless joints on table product_template and ir_translation
when the grouping key is a Many2One.

Second correction: add an index on workorder's `state` field. The
get_conflicted_workorder_ids() method search for ready workorders that
are in conflict relate to their planning. The state value is searched to
many times to not index it

closes odoo/odoo#106536

Task: 2852423
X-original-commit: e94937b6
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Use case:
in the reconciliation widget, we need to know when the pager
is updated before the next render because we need to select the
appropriate id to use.

cf the following PR: https://github.com/odoo/enterprise/pull/33631



opw-3031131

closes odoo/odoo#105738

Related: odoo/enterprise#33631
Signed-off-by: Georis François (fge) <fge@odoo.com>

Do like other enterprise modules in Odoo and display missing main applications
from enterprise in community: social and knowledge.

SPECIFICATIONS

Create `ir.module.module` records for knowledge, social and appointment apps
in Odoo Community, so that users searching for those apps can see them in the
correct category with the correct icon. They can then be redirected to Odoo
website for more information about the module or an upgrade plan to use the
enterprise version.

Knowledge
  * create the record
  * use the module_category_productivity category

Appointment
  * update the record to use the new icon
  * use the module_category_marketing category (instead of sales)

Social
  * create the record
  * use the module_category_marketing category

Task-3054412

closes odoo/odoo#103324

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

The session page could not be open in non-debug
due to create_date being restricted to debug.
This field is required for ordering of records.

There was no reason to restrict to just have it
only in debug, so we just make it available at
any time.

closes odoo/odoo#106535

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Activate Product variants and create a new products with attributes Legs, Size and color.

Now enable Variant Grid Entry and Purchase Agreements from purchase settings and now create a Blanket Order from Purchase -> Orders -> Blanket Orders with any products from above created variants.

Confirm the created blanked order and click on New Quotation, now a new RFQ will be created, and click on add an item button and select the product we have created before, now Choose Product Variants matrix will be opened. Enter some random quantities in multiple lines and click on confirm button.

Exception will be raised

closes odoo/odoo#106507

Signed-off-by: Tiffany Chang <tic@odoo.com>

mrp
===
- no time has been recorded on operations then give warning with apply button

- do not allow to mass edit UOM in any manufacturing state

- set value of lot/serial from MO and set read only on unbuild from MO

- remove "archive operation" icon

repair
======
Currently it is not possible to select a return on a repair order unless save it first. so after this commit user can able to select it without save it.
only show picking related to selected product

closes odoo/odoo#102596

Task: 2845380
Related: odoo/enterprise#34381
Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Purpose
=======
Fix the inline input fields which width seems broken
because of the new always edit mode.

Specifications
===========
Web :
Introduce new css classes to be added to the
input fields in order to constraint their width and avoid
white gaps in forms.

Event :
Limit the size of the confirmed attendees input
field in the event form and event type form to
display the confirmed attendees message in one line.
When using the debug mode, in the event templates,
inline the Register Button with its checkbox to avoid
line breaks.

Mail :
Limit the size of the delay count input
field in the activity type form and restore the
inline display of the schedule message to
avoid unnecessary white gaps.

CRM :
Fix the leads generation form inlined inputs
display by reducing the inputs width to match
their content display.
Fix the lead form view to align the expected
revenue with the probability for better UI.
Fix the geolocation field and send email button
of the Assigned Partner form tab by restoring
their inline property. Because of the form
grid layout, nested groups had to be used to
correctly restore the display. Alternative solutions
modify the DOM too much, which could lead to more
xpath and inheritance issues.

Task-2996467

closes odoo/odoo#102546

See: odoo/enterprise#32460
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Purpose
=======
Fix the inline input fields which
width seems broken because of the new
always edit mode.

Specifications
==============
Fix the leads generation form inlined inputs
display by reducing the inputs width to match
their content display.

Fix the lead form view to align the expected
revenue with the probability for better UI.

Fix the geolocation field and send email button
of the Assigned Partner form tab by restoring
their inline property. Because of the form
grid layout, nested groups had to be used to
correctly restore the display. Alternative solutions
modify the DOM too much, which could lead to more
xpath and inheritance issues.

Task-2996467

Part-of: odoo/odoo#102546

Purpose
=======
Fix the inline input fields which
width seems broken because of the new
always edit mode.

Specifications
==============
Limit the size of the delay count input
field in the activity type form and restore
the inline display of the schedule message
to avoid unnecessary white gaps.

Task-2996467

Part-of: odoo/odoo#102546

Purpose
=======
Fix the inline input fields which
width seems broken because of the new
always edit mode and the new form grid layout.

Specifications
==============
Limit the size of the confirmed attendees input
field in the event form and event type form to
display the confirmed attendees message in one line.

When using the debug mode, in the event templates,
inline the Register Button with its checkbox to avoid
line breaks.

Task-2996467

Part-of: odoo/odoo#102546

With the arrival of the new always edit mode,
some form views display are broken because of
the very big input width creating white gap
when having inline fields.

This commit introduces new css classes to be
added to the input fields in order to constraint
their width and avoid white gaps in forms.

Task-2996467

Part-of: odoo/odoo#102546

Since #106454 the `isOdooFocused` variable is not updated correctly.
This commit fixes this issue.

closes odoo/odoo#106514

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

In large database, if you try to get all subcontrat quant you can crach postgres with a big query.

closes odoo/odoo#106480

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Issue: In the MO view, the src location for components was editable and
the dest location for byproducts was editable when neither of these
should be.

Due to the same field appearing twice in the same x2many field list,
there were 2 issues:

1. something changed (probably during OWL refactoring) that made it so
   the 2nd invisible field instance of the field was overriding the
   "readonly='1'" property of the 1st instance when it was in the view
   (i.e. when multi-locations is active) [in previous versions this did
   not happen]
2. because of the change by https://github.com/odoo/odoo/commit/168cbe66bee7824bdf389de5c6c680342e27bc6d


   we ensure that these two required fields are always correctly set (to
   the MO's values as per the default when multi-loc is active) when the
   MO's moves are created.

Part of general bugfix task: 2985735

closes odoo/odoo#105959

Related: odoo/enterprise#34276
Signed-off-by: William Henrotin (whe) <whe@odoo.com>

closes odoo/odoo#104788

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

hr_*:
- hr
- hr_contract
- hr_work_entry
- hr_work_entry_contract

Fixes multiple visual issues in various models

task-3002444

closes odoo/odoo#102922

Related: odoo/enterprise#32638
Signed-off-by: Kevin Baptiste <kba@odoo.com>

Before this commit:
 If we remove a payment line using an Adyen payment method,
 `pending_adyen_line()` return `undefined`.
 With the `_poll_for_response` still being executed,
 it will pop some JS traceback each call with:
 ```js
 TypeError: Cannot read properties of undefined (reading 'terminalServiceId')
 ```

After this commit:
 No JS traceback loop

OPW-3032391

closes odoo/odoo#106461

X-original-commit: 52a517ca
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

The fix in #106174 was not good.
The translation dialog cannot update not translated terms

the initial term value may be empty "" when the source and the translation are
the same at first. So, the source to for update_field_translations should be
  const source = term.value ? term.value : term.source;

closes odoo/odoo#106360

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

PG12 introduced an optimization for CTEs that automatically inlines
CTEs if they are only refered once in the parent query. Prior to that
CTEs were always materialzed, meaning that PG created a sort of temp
table on the fly to store the result of the CTE's evaluation.

Whereas this leads to performance improvements in general, in the
particular case of _select_companies_rates this inlining becomes a
performance bottleneck. This is because while the currency_rate CTE
is only refered once in both purchase_report and product_margin,
the join condition (cr.date_end is null or cr.date_end > ...)
requires evaluating the CTE's date_end subquery twice. This, combined
with the fact that in PG12 the planner goes for a Nested Loop JOIN instead
of a HASH Join in PG10 makes the performances of the whole query
much worse in PG12 than in PG10.

Adding MATERIALIZED before the CTE definition forces PG to evaluate the
subquery first using its own plan. This removes the need to rescan the
subquery each time the Merge JOIN filter has to be applied, which
is a good strategy in this specific situation.

Examples of query timings change before and after PR:

Number of POs | Before PR | After PR
      2000    |     7s    |    345ms
      7000    |     23s   |    1.1s

opw-2930578

closes odoo/odoo#106097

X-original-commit: 8b7a3941
Signed-off-by: Raphael Collet <rco@odoo.com>

Some updates to Kenya localization:
- Withholing taxes support
- Inventory Interim accounts are set by default when automatic valuation of stocks is used
- Default temporary account for POS

closes odoo/odoo#105906

Task: 3067646
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

## Issues

- When the google and outlook sync plugins are not installed the admin user should see an option to install them from the calendar but other users should not see anything.

- The 'groups' guard would have prevented regular users from syncing their calendar at all if it had worked

- Users can get an obtuse error message if the administrator has not configured the installed sync modules

## Fix

- Replaces the 'groups' attribute in the calendar controller template with a t-if and a dynamic check as OWL doesn't process 'groups'.

- Update the structure of the calendar sync template to facilitate overriding the display conditions
- Update the inherits to override the display conditions and allow anyone to see the sync button once a module is installed

- Update the code that handles clicking 'sync' to throw the same error as it would have for other misconfigurations

task - 3056311

closes odoo/odoo#105461

Related: odoo/enterprise#33838
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

## Issue

Currently if an administrator installs one of the sync modules but does
not set any credentials. If the user tries to sync their calendar
they are met with an error.

## Fix

Make sure they get a clear dialog explaining why they cannot sync.

task - 3056311

Part-of: odoo/odoo#105461

## Issue

Regular users were not able to see the sync button
used to sync with external calendar services even after
these services were configured

## Fix

Conditionally display the whole sync section until one of the
services is configured.

Override the display conditions when one of the relevant modules are
installed.

task - 3056311

Part-of: odoo/odoo#105461

Issue
When the google and outlook sync plugins are not installed the admin user should see an option to install them from the calendar but other users should not see anything.

Fix
This replaces the 'groups' attribute in the calendar controller template with a t-if and a dynamic check as OWL doesn't process 'groups'.

task - 3056311

Part-of: odoo/odoo#105461

### Contains the following commits:

https://github.com/odoo/o-spreadsheet/commit/b167b3e6

 [FIX] selection: Altering selection should scroll the viewport

closes odoo/odoo#106387

Related: odoo/enterprise#34336
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>

The new get_views API inlines every subview into the main view in an effort to
optimize client/server communication.

In the situation:
```
<form>
  <field name="my_one_to_many" />
</form>
```

The server algorithm will fetch kanban or list views to display that x2many and inline them
in the final arch that is sent to the client.

This commit aims at factorizing the code which does just that in order for studio (or other modules)
to be able to detect whether the subview it receives is "real" or inlined

closes odoo/odoo#106271

Related: odoo/enterprise#34250
Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>

Steps to reproduce:

-Go to Journals > Bank journal > Remove all Incoming Payments
-Try to pay for an invoice
-The Bank journal will still appear

Issue:

Bank journal should not be an option if it doesn't have Incoming
Payments.

Solution:

We need to add the proper filter for journals in the default_domain in
order to not get the bank journal when it is not available.

This bug affects all versions from 15.2 until 16.

opw-3027346

closes odoo/odoo#106462

X-original-commit: 119676029b929512179a337f0f3b70837a5c2b37
Signed-off-by: William André (wan) <wan@odoo.com>

Before this PR, the presence service would crash on cross-origin
iframes. This is due to the fact that accessing the parent document
of a cross origin iframe is forbidden for security concerns.

This error was introduced when trying to synchronize the website iframe
and the window focus state in #102479.

This PR fixes the issue by catching the error and fallbacking to the old
behavior given than task-3006023 has been fixed by #53143 anyway.

task-3073242

closes odoo/odoo#106454

Signed-off-by: Stockbauer Matthieu (tsm) <tsm@odoo.com>