As the group_account_invoice doesn't have the access rights to unlink the
account.partial.reconcile/account.full.reconcile, there was impossible for
the user to undo a reconciliation.

closes odoo/odoo#40934

X-original-commit: 0288adb0
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

In case of a picking type where stock move lines are not shown, clicking
on 'Put in Pack' without 'Done' quantitites set shows a confusing error
message.

closes odoo/odoo#40928

X-original-commit: 76b72ab5
Related: odoo/enterprise#6906
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

- Activate product packing
- Create a PO for a stockable product, validate
- In the barcode interface, go to the created picking
- Set the product quantity
- Click on 'Put in Pack'

An error is raised: 'All the products currently reserved in the picking
are already in a pack...'

In the regular interface, the procedure is to create the move lines
manually, therefore setting a quantity done. However, this is not
possible in the barcode, and `move_line_nosuggest_ids` is always empty.

We introduce a special use case to bypass this in the case of the
barcode view.

opw-2127637

X-original-commit: d3a7b0e1

opw 2144639

closes odoo/odoo#40927

X-original-commit: 82de73f4
Signed-off-by: Nans Lefebvre (len) <len@odoo.com>

fixes #38014

closes odoo/odoo#40926

X-original-commit: dbd53289
Signed-off-by: lul-odoo <LucasLefevre@users.noreply.github.com>

This was broken during the recent colorpicker refactoring.

closes odoo/odoo#40925

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Some modules might want to add buttons in the form header of the employee public
(e.g. hr_appraisal).
This commit adds an empty header to easily allow view inheritance.

Note: this empty header is not displayed if no buttons are indide.

Task 2028794
PR odoo/enterprise#6495

closes odoo/odoo#39565

Related: odoo/enterprise#6495
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

In most use case, when we edit the website we have a situation such as:

```
<div id="wrap" branding-attributes="...">
    <section class="mycontent">hi!</section>
</div>
```

When we modify a part, we replace all child nodes of the branded
element.

But if we had more complex content such as:

```
<div id="wrap">
    <section class="mycontent" branding-attributes="...">ho!</section>
    <t t-call-assets="web.assets_common" t-js="false" t-css="false"/>
</div>
```

we have a t-call inside the div#wrap, so branding is distributed to
child that could have attribute modified (eg. changing background).

Then if `<section/>` node is saved, the possibly modified attributes
are lost.

Without the change, the added test fails with:

 '<div class="nice">hoi</div>' not found in '...<div>hoi</div>...' :
 saved element attributes are saved excluding branding ones

opw-2122947
closes #40345

closes odoo/odoo#40830

X-original-commit: 71b20a24
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

The current 'Newly Hired' filter is incorrect in several ways:
- the compute method doesn't assign the value correctly
- the search method mixes `hr.applicant` IDs with `hr.employee` IDs

Moreover, it relies on the fact that the job position is closed. Some
positions might always be opened, so the result is inaccurate.

We make the simpler assumption that the newly hired people are employees
created less than 90 days ago.

opw-2125861

closes odoo/odoo#40899

X-original-commit: ee928babbe433285883f1e878d83392d7199a37d
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Those cases are already checked in models._check_company() but not considered
when defining the default domain on `check_company=True` fields.

* Consider res_users relational field
	Companies allowed for user = user.company_ids
* Consider company-dependent fields
	Companies allowed = self.env.company

closes odoo/odoo#40906

X-original-commit: a8de9509
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

X-original-commit: 4205cb27

When clicking on stat button "Meetings" on a partner, just highlight the
partner meetings as is done for similar stat button instead of having
a domain that hides other event (so when creating meeting, we can take
into account other existing meetings).

A similar change with same reasoning has been done for "Meetings" stat
button of hr.applicant records.

opw-2131494
closes #40812

closes odoo/odoo#40900

X-original-commit: 957e7eb7
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

closes odoo/odoo#40905

X-original-commit: 1b2df29e
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

closes odoo/odoo#40902

X-original-commit: cf7017ea
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

A second edition is being written but not published yet

closes odoo/odoo#40405

X-Forwardport-of 2b99e0cb

closes odoo/odoo#40901

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

- Create a vendor bill for partner A with reference 'AAAAA'
- Create another vendor bill for partner A with the same reference:
=> Constraint is triggered.
- Create another vendor bill without partner with the same reference.
- Edit the vendor bill and set a partner:
=> Constraint not triggered.

closes odoo/odoo#40897

X-original-commit: 3f6254c8
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

closes odoo/odoo#40888

X-original-commit: fcbe9564
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

and uses it in customize_show.

closes odoo/odoo#40887

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

im_livechat main controller was referring to website.visitor but this module is
not depending on website. The usage of website visitor's name should have been
done in website_livechat module.

This commit fix this issue.

Task ID: 2116715
PR #40732

closes odoo/odoo#40884

X-original-commit: defb98c1
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Task 2085023
* Add a field that replaces the context to get the ids of the
entries/invoices
* Remove move_id, we can use move_ids instead
* Add text to explain invioces/bills will create refunds

closes odoo/odoo#38857

Related: odoo/enterprise#6263
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

In order to see the added value of digest in demo mode some demo data about
livechat conversations are added. Rating is also added.

Task ID 1883428
closes #29764

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Purpose of the task is to add a Live Chat section in the weekly digest email
template. Following value related to livechat are therefore added in digest
emails:

  * hit % of ratings;
  * amount of conversations he handled;
  * hit time to answer;

Task ID 1883428
closes #29764

* root the base.partner.merge wizard's logger in odoo.addons so the
  "odoo" logger configuration properly applies to it
* update the default logging configuration to set the root logger
  rather than independently set the odoo and werkzeug loggers

closes odoo/odoo#40872

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

The slide.slide "_compute_slides_statistics" method is missing the 'slide_ids.sequence' trigger.
It should be specified for cases when one of the slide_ids changes category (determined by the
sequence).

This can cause some CacheMiss and seem related to nondeterministic errors on the runbot.

PR #40705
Task#2123711
Runbot build error ID 247

closes odoo/odoo#40867

X-original-commit: 1994f544
Signed-off-by: awa-odoo <awa-odoo@users.noreply.github.com>

before this commit:
when creating a product from frontend and editing the product and
delete image, it doesn't get any url thus generating the traceback.

after this commit: if url is not defined then return None from
ir.qweb.field.image field converter

task-2063293

closes odoo/odoo#40866

X-original-commit: 2efad751
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Before this commit, the computation of kpi for last week, last 30 days and
previous period comparison was wrong due to cache. Indeed as first value
was in cache, other values were taken directly from cache itself instead
of recomputing each value based on start_date and end_date of the computation
timeframe.

As digest fields are computed fields used a bit off-side, let us manually
invalidate the cache before computing a kpi so that it correctly computes
the timeframe values.

Task ID 1883428

closes odoo/odoo#40861

Closes: #40834
X-original-commit: 2966ee59
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

steps to reproduce:
-change decimal accuracy for "Product Price"
-create a price list with fixed price
-the fixed price field does not takes the decimal accuracy into account

this was working in V11 and V12
fixed_price was a float field like other price fields

previous behavior:
fixed_price is a monetary field
when setting up a fixed price for a pricelist, it takes into account
the precision from the current currency

current behavior:
fixed_price is a float field
when setting up a fixed price for a pricelist, it takes into account
the proper decimal accuracy setting ("Product Price")

opw-2121964

closes odoo/odoo#40807

X-original-commit: 27b90fc7
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

before this commit: when creating a product from frontend and editing
the product and delete image and save edition, it throws traceback,
because ir.qweb.field.image doesn't get any url and due to which it
throws traceback.

after this commit: if url is not defined in ir.qweb.field.image field
converter then return None

task-2063293

closes odoo/odoo#40638

X-original-commit: 896127a6
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

- Group the SO list view by Analytic Account
- Go to a SO
- Click on the stat button 'Timesheets'

Traceback because the field `analytic_account_id` is not on Timesheets.

opw-2124539

closes odoo/odoo#40840

X-original-commit: 3f17dd36
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Excel can store data in multiple tables, each is called a sheet. Odoo
was only importing the first sheet making the process to import a file
containing multiple sheets cumbersome.

It is now possible to select the sheet in the import options. By default
the first sheet is selected.

closes odoo/odoo#40728

Task: 2043768
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

When you create a pos order, it is possible that the request timeout or
the client loose the connection with the server, that will lead to not
have the server_id of the order sent to the server. So when the client
will try to synchronize the order again, it'll not send the server_id to
the server, and the server will create a new order which is a duplicate
of the one created when the client lost the connection.

To avoid this duplication, we are using the pos_reference to find if
there is an existing order like in 12.0 to avoid duplication.

closes odoo/odoo#40837

Task-id: 2127656
X-original-commit: cddf29e7
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Steps to reproduce the bug:

- Let's consider Today = 21/11/2019 and Employee E
- Create a new hr.leave.type LT and set a validity from 01/01/2020 to 31/12/2020
- Set mode = Free Allocation Request and Validation = No Validation
- Try to create leave allocations for LT

Bug:

It was impossible to create a leave allocation for LT because Today < 01/01/2020
So it was impossible to allocate future leave.
We had to wait the 01/01/2020 to make the allocation of LT leaves

opw:2126300

closes odoo/odoo#40815

X-original-commit: 2b1810da
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

closes odoo/odoo#35373

Task: 2129257
Closes: 35373
Signed-off-by: Josse Colpaert <jco@openerp.com>

closes odoo/odoo#40805

X-original-commit: c0f261fd
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

Below points are improved in automated action
- Set no_create on model_id, crud_model_id, partner_ids, and channel_ids
- Set widget many2many tags and change string for trigger_field_ids
- Rename 'Trigger Condition' to 'Trigger'
- Change on_change_fields into a many2many to ir.model.fields
- Set 'Hours' as default of field trg_date_range_time
- Rename label of crud_model_id to 'Target Model'
- Rename label of sms_mass_keep_log to 'Log as Note'
- On creation of template set the default model
- Hide the 'Security' tab
- Set no_create on fields resource_ref and col1
- Make 'value' readonly when col1 is not set
- Rename 'Link using field' to 'Link Field'

Task-2082503

closes odoo/odoo#39622

Closes: #39622
Related: odoo/enterprise#6515
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

- Create a product tracked by lot
- Create a delivery picking

You are allowed to create a new lot for the product although the picking
type doesn't allow it.

This is because of the missing context key `active_picking_id` on which
`_check_create` relies:

https://github.com/odoo/odoo/blob/e5ee5e5b65f85d66c8d59594ead9eece172c4282/addons/stock/models/stock_production_lot.py#L50



opw-2128497

closes odoo/odoo#40813

X-original-commit: 6dd176cc
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Reproduce the issue:
- Install eCommerce app
- Publish a product to your website
- Add the product in your cart
- Unpublish/make unsellable/archive the product

The product is still in the cart and the checkout process can be done.

Cause: There is no check for invalid products before displaying the cart

This commit remove the invalid products while loading the cart.

OPW-2092541

closes odoo/odoo#40241

X-original-commit: ab9290e3
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

After the rainbowMan issue was fixed here: e5bc2e7, steps were consumed
on 'click' events. This caused an issue with the drag and drop event
(which breaks tour, because it is expecting a click event). If the user
dragged an element, thetip was not getting consumed as no click event
was triggered.

closes odoo/odoo#40819

X-original-commit: 3f458fe06e6a629edc72428eab749068c2eba1ba
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Co-authored-by: Aaron Bohy <aab@odoo.com>
Co-authored-by: Priyanka Kakadiya <pka@odoo.com>

A customer reported an issue when he tried to add a link on the
blog covers of his blog. The link is displayed as text and it's added
to all the covers.

![links on all covers](i.imgur.com/fuFu6op.jpg)

According to SBU, the user should not do this.

This commit prevents the user from editing a blog cover.

OPW-2119924

closes odoo/odoo#40816

X-original-commit: 576fe145
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Archived users are inactive, so we shouldn't be able to ping them.

Task-2046885

closes odoo/odoo#40814

X-original-commit: 8169e34a
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>