Skip to content
Snippets Groups Projects
  1. Feb 08, 2019
  2. Feb 01, 2019
    • Romeo Fragomeli's avatar
      [IMP] web: control panel add on_detach_callback · e6e206b1
      Romeo Fragomeli authored
      Adding event listener in on_attach_callback need to be removed
      in on_detach_callback.
      
      Before this commit on_detach_callback was not implemented in control panel.
      After this commit we can use on_detach_callback.
      
      Needed for task ID: 1934261
      
      closes odoo/odoo#30758
      e6e206b1
  3. Feb 08, 2019
    • wan's avatar
      [ADD] account: suspense account management · 969705fa
      wan authored
      Task 1930403
      Purpose:
      A suspense account is an account in the general ledger that temporarily stores any transactions for which there is uncertainty about the account in which they should be recorded. Once the accounting staff investigates and clarifies the purpose of this type of transaction, it shifts the transaction out of the suspense account and into the correct account(s). An entry into a suspense account may be a debit or a credit.
      
      The Chosen Odoo approach (macro) for this case is
      1) from bank statement -> reconciliation widget -> reconciliation model
      2) create move that have a dedicated checkbox
      3) be able to reopen the bank statement line "like if there is no linked account move" and finally reconcile the transaction with the good invoice/bill (we can reprocess account move "to check")
      4) when we reprocess, Instead of creating an account move : Check if there is an "to check" existing linked account move and remove all the account move lines then replace  them by the good ones --> we want to keep the sequence
      
      closes odoo/odoo#30486
      969705fa
    • David Beguin's avatar
      [FIX] website_slides: Fix clean ACLs and refactor access options commit · 723789b6
      David Beguin authored
      Fixes related to commit 748b9072
      
       * fix template still having an unnecessary t-else whereas the t-if has
         been removed;
       * move order by strategy on right class;
       * fix access rights on intermediate model between channels and partners. It
         should be accessible to website publisher as they will have so manage
         channel members;
       * fix some typos;
      
      closes odoo/odoo#30949
      723789b6
    • Aurélien Warnon's avatar
      [REM] website_slides: remove the 'state' field of slide.channel.partner · c4c06750
      Aurélien Warnon authored
      Purpose
      =======
      
      The 'state' field for a member of a channel did not imply anything functionally
      so we decided to remove it. It allows to remove an unnecessary computed fields.
      ACLs are updated accordingly.
      
      If needed, we will soon be able to check partner_ids that have ordered but
      not paid a channel / course product by searching the related 'sale.order' model
      for such products.
      c4c06750
  4. Feb 07, 2019
    • Antoine Guenet's avatar
      [FIX] web_editor: on anchor split, rerange and clean data on getValue · eea58a3c
      Antoine Guenet authored
      Due to a wrong order of operations, after splitting an anchor (press
      ENTER), the range was setting on the first anchor. Now it sets on the
      second one (as the code - but not the tests - suggests was supposed to
      happen). Tests were adapted to reflect that change.
      
      In tests, after splitting the anchor, `Wysiwyg.getValue` didn't always
      properly clean up `data-original-title`. Targetting empty
      `data-original-title` attribute instead of `aria-describedby` attribute
      should fix that issue.
      
      closes odoo/odoo#30923
      eea58a3c
  5. Feb 08, 2019
  6. Feb 07, 2019
    • wan's avatar
      [FIX] account: remove useless TOFIX lines · 6dd25994
      wan authored
      There is nothing preventint to remove this line
      The second FIXME is preserved to keep the tests running, as the account functionality of the function may be removed
      
      closes odoo/odoo#30323
      6dd25994
  7. Feb 08, 2019
    • Juhil Somaiya's avatar
      [IMP] sale, base: partner form view improvement · 5c13831d
      Juhil Somaiya authored
      Improved partner form consistency and clarity via following changes:
      - Renamed string and tooltip from Shipping address to Delivery address
      - Changed description of the customer address
      - Re-organised contact partner form and added image of partner
      - Changed default avatar to a simpler one that is not Stephane Bern
      - Test case improvement
      
      Task ID: 192044
      
      closes odoo/odoo#29917
      5c13831d
  8. Feb 07, 2019
    • Cédric Snauwaert's avatar
      [FIX] base_vat: belgian vat number correct display · e67b2294
      Cédric Snauwaert authored
      Odoo Accept the following mask for vat encoding :
      BE0477472701
      BE.0.477.472.701
      BE.477.472.701
      BE477.472.701
      BE477472701
      
      But, in certain cases we have to add the zero to be compliance (i.e. belgian official reports...). -> http://www.tvaintracommunautaire.eu/belgique.html
      
      This commit make use of the compact method defined in stdnum.be.vat (which is used by vatnumber in order to validate the vat). The compact method return a 10 digits vat number starting with a 0 which is compliant with the official reports.
      
      closes odoo/odoo#28523
      e67b2294
    • Thibault Delavallée's avatar
      [IMP] website_slides: remove duplicated code · 29219b9c
      Thibault Delavallée authored
      Code probably coming form a rebase conflict. Duplicated and therefore removed.
      
      closes odoo/odoo#30921
      29219b9c
    • Raphael Collet's avatar
      [FIX] stock: missing dependency of move_ids_without_package · 4bc02d10
      Raphael Collet authored
      closes odoo/odoo#30910
      4bc02d10
    • Raphael Collet's avatar
    • Robot Odoo's avatar
      [MERGE][REF] website_slides: clean access and add membership on channels · 71bf0c12
      Robot Odoo authored
      Purpose of this merge is to clean access rights on slide models and give
      less access to public / portal / internal users. Website publishers and
      editors have rights to edit slides content and manage channels.
      
      Another purpose is to clean and refactor access options on channels and slides.
      Access to a given slide depends on the current user being a member of the
      slide channel. A channel can be either public (joined easily) or on invitation
      only (manual addition of members).
      
      Slide can be flagged as preview, meaning they are accessible without any
      concern about channel membership. It is used as teasing or free promotion
      of a channel.
      
      Publish flag is orthogonal. Non published slides are not visible to everyone
      except website content editor. It allows to work and improve slides without
      displaying them to members or public people.
      
      Slide upload access is a bit cleaned. A can_publish field is added controlling
      who can publish slides. Currently website publishers are allowed to publish
      content. Not publishers people allowed to upload cannot publish their own
      content. It stays in a submitted non published state.
      
      Base for tests are also added. More of them will be added in future commits.
      
      This merge is related to task ID 1937411 and closes PR #30847. More
      generally this merge is linked to ongoing tasks
      
      * task ID 1902304 (main eLearning task) PR #29876;
      * task ID 1922159 (new user profile and gamification) PR #30514;
      * task ID 1936153 (new homepage for slides) PR #30770;
      * task ID 1937160 (payment flow and integration with ecommerce) PR #30914;
      
      This merge is therefore not functionally complete itself and serves as a
      preparation for other incoming commits. See sub commits for more details
      on what has been done here.
      Unverified
      71bf0c12
    • Thibault Delavallée's avatar
      [IMP] website_slides: add widget to join a channel · 797daba1
      Thibault Delavallée authored
      Purpose is to add a new widget and its route allowing to join a channel.
      As visibility is now mainly based on membership a widget to join channels
      is required.
      
      This commit is linked to task ID 1937411 and PR #30847.
      797daba1
    • Thibault Delavallée's avatar
      [IMP] website_slides: improve upload slide screen · ddccd33b
      Thibault Delavallée authored
      Slide upload access is a bit cleaned. A can_publish field is added controlling
      who can publish slides. Currently website publishers are allowed to publish
      content. Not publishers people allowed to upload cannot publish their own
      content. It stays in a submitted non published state.
      
      This commit is linked to task ID 1937411 and PR #30847.
      ddccd33b
    • Thibault Delavallée's avatar
      [IMP] website_slides: add tests · b91add89
      Thibault Delavallée authored
      Currently website_slides module lacks tests. This commit adds base for tests
      and add some tests related to recently cleaned access rules and rights.
      
      Future commits will gradually add more tests to the module as it evolves
      towards a more broad and up-to-date application.
      
      This commit is linked to task ID 1937411 and PR #30847.
      b91add89
    • Thibault Delavallée's avatar
      [IMP] website_slides: clean ACLs and refactor access options · 748b9072
      Thibault Delavallée authored
      Purpose of this commit is to clean access rights on slide models and give
      less access to public / portal / internal users. Website publishers and
      editors have rights to edit slides content and manage channels.
      
      Another purpose is to clean and refactor access options on channels and slides.
      Access to a given slide depends on the current user being a member of the
      slide channel. A channel can be either public (joined easily) or on invitation
      only (manual addition of members).
      
      Slide can be flagged as preview, meaning they are accessible without any
      concern about channel membership. It is used as teasing or free promotion
      of a channel.
      
      Publish flag is orthogonal. Non published slides are not visible to everyone
      except website content editor. It allows to work and improve slides without
      displaying them to members or public people.
      
      Technically a new model is added to model membership on channels. It is
      a decorated m2m between channels and partners; on this m2m the state of
      membership is added. In a near future additional information will be stored
      on this model, like completion of channel or certification information.
      
      Other technical changes implied by this commit
       * visibility is simplified to either public or invite;
       * can_see and can_see_full are removed, as well as concept of 'partial'
         display of slides;
       * group_ids related to private access is removed;
       * a computed / searchable field is added to be able to efficiently find
         and search active members of a channel;
      
      This commit is linked to task ID 1937411 and PR #30847.
      748b9072
    • Nimesh Jethva's avatar
      [IMP] account: Add chatter on bnk statements form view · e9ac626c
      Nimesh Jethva authored
      This commit is related to task ID : 1871356
      
      odoo/closes #26127
      e9ac626c
    • Robot Odoo's avatar
      [MERGE] gamification: prepare use of gamification in slides and user profile · 91ee6ba5
      Robot Odoo authored
      Purpose of this merge is to prepare addition of gamification in slides /
      eLearning platform. In order to be able to use karma and the badges in other
      modules we move those models in gamification.
      
      A website_profile module is added to hold code, data and all necessary stuff
      to display a user profile, including its gamification-related details. It
      is a bridge between gamification and website. It will soon hold a revamped
      user profile, used in both forum and slides.
      
      More generally this merge is linked to ongoing tasks
       * task ID 1902304 (main eLearning task) PR #29876;
       * task ID 1922159 (new user profile and gamification) PR #30514;
       * task ID 1936153 (new homepage for slides) PR #30770;
       * task ID 1937160 (payment flow and integration with ecommerce) PR #30914;
      
      This merge is therefore not functionally complete itself and serves as a
      preparation for other incoming commits. See sub commits for more details
      on what has been done here.
      
      closes odoo/odoo#30908
      Unverified
      91ee6ba5
    • mgh-odoo's avatar
      [IMP] account, sale: Move terms and conditions to account · ca25a692
      mgh-odoo authored
      Purpose
      =======
      
      Be able to define terms and conditions if sales is not installed.
      
      If sales is not installed, the user cannot define default terms and conditions
      for his customer invoices since the setting in the sales section.
      
      If sales is installed and default terms & conditions are defined, a customer
      invoice created from scratch (not from an SO) will have them.
      
      This is not consistent.
      
      Task: 1917663
      
      closes odoo/odoo#30140
      ca25a692
    • Hetal Dhanak's avatar
      [IMP] calendar: Improve calendar alarm computed name · f711e6d6
      Hetal Dhanak authored
      Improve usability of fields 'reminder_ids' (calendar.appointment.type)
      and 'alarm_ids' (calendar.event)
      
      If the user does not set a meaningful 'name' on a newly created calendar.alarm,
      it is a pain to select the desired record from those fields.
      
      (Also, user should be able to edit existing calendar.alarm)
      
      Related Task ID: 1923205
      
      closes odoo/odoo#30129
      f711e6d6
    • Thibault Delavallée's avatar
      [IMP] website_slides: add dependency on website profile · 43740f94
      Thibault Delavallée authored
      
      Purpose is to prepare the use of gamification tools in slides. In this commit
      we add the dependency on website_profile (gamification front-end) in slides
      and add the slides category on challenges.
      
      Partial commit linked to eLearning project. Main specifications related
      to gamification and user profile can be found on task 1922159 (PR #30514).
      Main specifications related to eLearning can be found on task 1902304
      (PR #29876).
      
      Co-Authored-By: default avatarDavid Beguin <dbe@odoo.com>
      Co-Authored-By: default avatarThibault Delavallee <tde@odoo.com>
      43740f94
    • Thibault Delavallée's avatar
      [ADD] website_profile: new module holding website-related code for gamification · b9856447
      Thibault Delavallée authored
      
      Purpose is to be able to re-use frontend-related model, data and tools
      for gamification. Currently only forum uses gamification. Soon slides module
      will use them and user profile / biography will be expanded. This commit
      prepares those features by already preparing the bridge module and adding
      a publish option on badges.
      
      Partial commit linked to eLearning project. Main specifications related
      to gamification and user profile can be found on task 1922159 (PR #30514).
      Main specifications related to eLearning can be found on task 1902304
      (PR #29876).
      
      Co-Authored-By: default avatarDavid Beguin <dbe@odoo.com>
      Co-Authored-By: default avatarThibault Delavallee <tde@odoo.com>
      b9856447
    • David Beguin's avatar
      [IMP] gamification : add ranks based on karma · 9e082662
      David Beguin authored
      To encourage forum and slides users to be more active ranks are now added.
      They are directly linked to karma. The more the user has karma the more his
      rank will be high.
      
      The default rank is Newbie, with 1 point of karma. Users with 0 karma are
      considered as inactive on forum or slides. When a user reach a new rank
      a mail is sent to him to congratulate him with his new rank.
      
      To add a button in the mail template to allow users to go directly on
      a website section (like forum or slides) simply override
      get_gamification_redirection_data to add the target url.
      
      Partial commit linked to eLearning project. Main specifications related
      to gamification and user profile can be found on task 1922159 (PR #30514).
      Main specifications related to eLearning can be found on task 1902304
      (PR #29876).
      9e082662
    • David Beguin's avatar
      [REF] gamification, website_forum: move karma, badge and badge level to gamification · 3b9dcb6d
      David Beguin authored
      Purpose of this commit is to prepare addition of gamification in slides /
      eLearning platform. In order to be able to use karma and the badges in other
      modules we move those models in gamification.
      
      Partial commit linked to eLearning project. Main specifications related
      to gamification and user profile can be found on task 1922159 (PR #30514).
      Main specifications related to eLearning can be found on task 1902304
      (PR #29876).
      3b9dcb6d
    • XavierDo's avatar
      [FIX] core: remove email escape logic from html_sanitize. · b8f2edd9
      XavierDo authored
      Related to #30326
      
      Before #30326, when calling html_sanitize, some content may be escaped
      when it shouldn't. A simple example was images with cid links containing @.
      (a first fix for another use case was made in 8aff5373)
      
      We suspect that this escaping (added in 71a92f46)
      was made to avoid loosing email with format '<email@domaine>' in html_sanitize
      to escape them if html_sanitize is called on plain text.
      
      Anyway, only html should be passed to html_sanitize, and therefore email of format
      <email@domain> should already be escaped.
      
      PR #30326 fixes the unwanted behaviour in 12.0 and this commit removes
      this logic in master.
      
      closes odoo/odoo#30815
      b8f2edd9
    • shreya thakrar's avatar
      [IMP] base: avoid empty language confusion · c875d025
      shreya thakrar authored
      In User preferences, the empty language was confusing, rename it to 'System
      (English)' instead of blank.
      Rename English language as English (US).
      
      Task ID : 1921583
      
      closes odoo/odoo#30096
      c875d025
    • Jérome Maes's avatar
      [FIX] portal: cast type to consteq signed token · 794ebb0a
      Jérome Maes authored
      To post a comment with a signed token, we compare tokens with the pid.
      The token is signed with the pid, which is an integer. When checking
      access, we compare the token with a pid as char. Obviously, the comparison
      failed, and posting the message is refused, as the 2 'pid' does not
      share the same type.
      This commit cast the recieved 'pid' into an integer before checking
      special access.
      
      closes odoo/odoo#30906
      794ebb0a
    • Hardik Prajapati's avatar
      [ADD] l10n_be: Add Brussels as a province in Belgium · 2a63c2ef
      Hardik Prajapati authored
      Even if Brussels is not a province in Belgium, poeple are confused to not see it in the states of Belgium
      
      TaskID: 1909249
      
      closes odoo/odoo#30888
      2a63c2ef
    • Parth Choksi's avatar
      [IMP] sale, pos_sale: Add industry in sales reporting · aa07f73d
      Parth Choksi authored
      New reading level in the sales reporting : Customer Industry
      
      Task ID: 1922025
      
      closes odoo/odoo#30495
      aa07f73d
Loading